qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] efc6c0: configure: Add a test for the minimum


From: GitHub
Subject: [Qemu-commits] [qemu/qemu] efc6c0: configure: Add a test for the minimum compiler ver...
Date: Fri, 14 Dec 2018 04:59:33 -0800

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: efc6c070acabd92283f8786cc835684d09def12f
      
https://github.com/qemu/qemu/commit/efc6c070acabd92283f8786cc835684d09def12f
  Author: Thomas Huth <address@hidden>
  Date:   2018-12-12 (Wed, 12 Dec 2018)

  Changed paths:
    M configure

  Log Message:
  -----------
  configure: Add a test for the minimum compiler version

So far we only had implicit requirements for the minimum compiler version,
e.g. we require at least GCC 4.1 for the support of atomics. However,
such old compiler versions are not tested anymore by the developers, so
they are not really supported anymore. Since we recently declared explicitly
what platforms we intend to support, we can also get more explicit on the
compiler version now. The supported distributions use the following version
of GCC:

      RHEL-7: 4.8.5
      Debian (Stretch): 6.3.0
      Debian (Jessie): 4.8.4
      OpenBSD (ports): 4.9.4
      FreeBSD (ports): 8.2.0
      OpenSUSE Leap 15: 7.3.1
      Ubuntu (Xenial): 5.3.1
      macOS (Homebrew): 8.2.0

So we can safely assume GCC 4.8 these days. For Clang, the situation is
a little bit more ambiguous, since it is sometimes not available in the
main distros but rather third party repositories. At least Debian Jessie
uses version 3.5, and EPEL7 for RHEL7 uses 3.4, so let's use 3.4 as
minimum Clang version now - we still can adjust this later if necessary.

Unfortunately Apple uses different version numbers for the Clang that is
included in their Xcode suite, so we need to check the version numbers
for Xcode separately. Xcode 5.1 seems to be the first one that has been
shipped with LLVM 3.4, so use this version as the minimum there.

Reviewed-by: Richard Henderson <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>


  Commit: 40f87e2680a3fda6117a08db9106a01345806a66
      
https://github.com/qemu/qemu/commit/40f87e2680a3fda6117a08db9106a01345806a66
  Author: Thomas Huth <address@hidden>
  Date:   2018-12-12 (Wed, 12 Dec 2018)

  Changed paths:
    M configure

  Log Message:
  -----------
  configure: Remove obsolete check for Clang < 3.2

Since we have got a check for Clang >= 3.4 now, we do not need to
check for older Clang versions in the configure test for 128-bit ints
anymore.

Reviewed-by: Richard Henderson <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>


  Commit: d376e9de07e9541a040609d30b73403c33b6afe0
      
https://github.com/qemu/qemu/commit/d376e9de07e9541a040609d30b73403c33b6afe0
  Author: Thomas Huth <address@hidden>
  Date:   2018-12-12 (Wed, 12 Dec 2018)

  Changed paths:
    M Makefile.target
    M configure

  Log Message:
  -----------
  configure: Remove old -fno-gcse workaround for GCC 4.6.x and 4.7.[012]

Now that we require at least GCC 4.8, we don't need this als workaround
for 4.6 and 4.7 anymore.

Reviewed-by: Richard Henderson <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>


  Commit: 6fa2cef205a60b5c5c3b058f53852416b885c455
      
https://github.com/qemu/qemu/commit/6fa2cef205a60b5c5c3b058f53852416b885c455
  Author: Thomas Huth <address@hidden>
  Date:   2018-12-12 (Wed, 12 Dec 2018)

  Changed paths:
    M tcg/tcg.h

  Log Message:
  -----------
  tcg/tcg.h: Remove GCC check for tcg_debug_assert() macro

Both GCC v4.8 and Clang v3.4 (our minimum versions) support
__builtin_unreachable(), so we can remove the version check here now.

Reviewed-by: Richard Henderson <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>


  Commit: 65557f5ed9026f288654bfcfb696b581c1ef49c5
      
https://github.com/qemu/qemu/commit/65557f5ed9026f288654bfcfb696b581c1ef49c5
  Author: Thomas Huth <address@hidden>
  Date:   2018-12-12 (Wed, 12 Dec 2018)

  Changed paths:
    M audio/alsaaudio.c

  Log Message:
  -----------
  audio/alsaaudio: Remove compiler check around pragma

Both GCC v4.8 and Clang v3.4 support the -Waddress option, so we do
not need the compiler version check here anymore.

Reviewed-by: Richard Henderson <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>


  Commit: f773b423cc61f3ca18af5337101c158a52aaae2c
      
https://github.com/qemu/qemu/commit/f773b423cc61f3ca18af5337101c158a52aaae2c
  Author: Thomas Huth <address@hidden>
  Date:   2018-12-12 (Wed, 12 Dec 2018)

  Changed paths:
    M include/qemu/compiler.h
    M include/qemu/host-utils.h

  Log Message:
  -----------
  includes: Replace QEMU_GNUC_PREREQ with "__has_builtin || !defined(__clang__)"

Since we require GCC version 4.8 or newer now, we can be sure that
the builtin functions are always available on GCC. And for Clang,
we can check the availablility with __has_builtin instead.

Reviewed-by: Richard Henderson <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>


  Commit: 78751ea855f89b5a352ccc332162fed3ad4c9496
      
https://github.com/qemu/qemu/commit/78751ea855f89b5a352ccc332162fed3ad4c9496
  Author: Thomas Huth <address@hidden>
  Date:   2018-12-12 (Wed, 12 Dec 2018)

  Changed paths:
    M include/qemu/compiler.h
    M scripts/checkpatch.pl
    M scripts/cocci-macro-file.h

  Log Message:
  -----------
  Remove QEMU_ARTIFICIAL macro

The code that used it has already been removed a while ago with commit
dc41aa7d34989b552ef ("tcg: Remove GET_TCGV_* and MAKE_TCGV_*").

Reviewed-by: Richard Henderson <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>


  Commit: 2b4c1125ac3db2734222ff43c25388a16aca4a99
      
https://github.com/qemu/qemu/commit/2b4c1125ac3db2734222ff43c25388a16aca4a99
  Author: BALATON Zoltan <address@hidden>
  Date:   2018-12-12 (Wed, 12 Dec 2018)

  Changed paths:
    M hw/i2c/bitbang_i2c.h
    M include/hw/i2c/i2c.h
    M include/hw/i2c/ppc4xx_i2c.h

  Log Message:
  -----------
  i2c: Move typedef of bitbang_i2c_interface to i2c.h

Clang 3.4 considers duplicate typedef in ppc4xx_i2c.h and
bitbang_i2c.h an error even if they are identical. Move it to a common
place to allow building with this clang version.

Reported-by: Thomas Huth <address@hidden>
Signed-off-by: BALATON Zoltan <address@hidden>
Acked-by: David Gibson <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>


  Commit: 0f98c9945899c5dfacd5a410ff04178eda605a16
      
https://github.com/qemu/qemu/commit/0f98c9945899c5dfacd5a410ff04178eda605a16
  Author: Peter Maydell <address@hidden>
  Date:   2018-12-14 (Fri, 14 Dec 2018)

  Changed paths:
    M Makefile.target
    M audio/alsaaudio.c
    M configure
    M hw/i2c/bitbang_i2c.h
    M include/hw/i2c/i2c.h
    M include/hw/i2c/ppc4xx_i2c.h
    M include/qemu/compiler.h
    M include/qemu/host-utils.h
    M scripts/checkpatch.pl
    M scripts/cocci-macro-file.h
    M tcg/tcg.h

  Log Message:
  -----------
  Merge remote-tracking branch 
'remotes/huth-gitlab/tags/pull-request-2018-12-12' into staging

- Explicitly check for minimum compiler versions
- Remove obsolete code for old compilers that is now not required anymore
- Fix a duplicated typedef for Clang 3.4

# gpg: Signature made Wed 12 Dec 2018 09:05:50 GMT
# gpg:                using RSA key 2ED9D774FE702DB5
# gpg: Good signature from "Thomas Huth <address@hidden>"
# gpg:                 aka "Thomas Huth <address@hidden>"
# gpg:                 aka "Thomas Huth <address@hidden>"
# gpg:                 aka "Thomas Huth <address@hidden>"
# Primary key fingerprint: 27B8 8847 EEE0 2501 18F3  EAB9 2ED9 D774 FE70 2DB5

* remotes/huth-gitlab/tags/pull-request-2018-12-12:
  i2c: Move typedef of bitbang_i2c_interface to i2c.h
  Remove QEMU_ARTIFICIAL macro
  includes: Replace QEMU_GNUC_PREREQ with "__has_builtin || !defined(__clang__)"
  audio/alsaaudio: Remove compiler check around pragma
  tcg/tcg.h: Remove GCC check for tcg_debug_assert() macro
  configure: Remove old -fno-gcse workaround for GCC 4.6.x and 4.7.[012]
  configure: Remove obsolete check for Clang < 3.2
  configure: Add a test for the minimum compiler version

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/d8d5fefd8657...0f98c9945899
      **NOTE:** This service has been marked for deprecation: 
https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]