[Qemu-commits] [qemu/qemu] 549b50: vfio-helpers: Fix qemu_vfio_open_pci() crash

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 549b50a31d28f2687a47e827a1e17300784a2c44
      
https://github.com/qemu/qemu/commit/549b50a31d28f2687a47e827a1e17300784a2c44
  Author: Markus Armbruster <address@hidden>
  Date:   2018-11-27 (Tue, 27 Nov 2018)

  Changed paths:
    M util/vfio-helpers.c

  Log Message:
  -----------
  vfio-helpers: Fix qemu_vfio_open_pci() crash

qemu_vfio_open_common() initializes s->lock only after passing s to
qemu_vfio_dma_map() via qemu_vfio_init_ramblock().
qemu_vfio_dma_map() tries to lock the uninitialized lock and crashes.

Fix by initializing s->lock first.

RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1645840
Fixes: 418026ca43bc2626db092d7558258f9594366f28
Cc: address@hidden
Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Cornelia Huck <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Message-id: address@hidden
Signed-off-by: Peter Maydell <address@hidden>



      **NOTE:** This service has been marked for deprecation: 
https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.