qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] f898ee: qga-win: fix leaks of build_guest_dis


From: GitHub
Subject: [Qemu-commits] [qemu/qemu] f898ee: qga-win: fix leaks of build_guest_disk_info()
Date: Tue, 13 Nov 2018 05:36:11 -0800

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: f898ee0f9951f2875c6cea299b4a1287e0a90e9f
      
https://github.com/qemu/qemu/commit/f898ee0f9951f2875c6cea299b4a1287e0a90e9f
  Author: Marc-André Lureau <address@hidden>
  Date:   2018-11-09 (Fri, 09 Nov 2018)

  Changed paths:
    M qga/commands-win32.c

  Log Message:
  -----------
  qga-win: fix leaks of build_guest_disk_info()

Introduced in commit b1ba8890e63ce9432c41c5c3fc229f54c87c9c99, vol_h
handle should be closed, and "out" cleanup should be done after
DeviceIoControl() fails.

Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Signed-off-by: Michael Roth <address@hidden>


  Commit: 61baac2fdb7ad3891fb00bbd3c9e8b8ca87f0f62
      
https://github.com/qemu/qemu/commit/61baac2fdb7ad3891fb00bbd3c9e8b8ca87f0f62
  Author: Peter Maydell <address@hidden>
  Date:   2018-11-09 (Fri, 09 Nov 2018)

  Changed paths:
    M qga/guest-agent-core.h

  Log Message:
  -----------
  qga: Add multiple include guard to guest-agent-core.h

The guest-agent-core.h header was missing the usual guards
against multiple inclusion; add them.

(Spotted by lgtm.com's static analyzer.)

Signed-off-by: Peter Maydell <address@hidden>
Reviewed-by: Marc-André Lureau <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Tested-by: Philippe Mathieu-Daudé <address@hidden>
Signed-off-by: Michael Roth <address@hidden>


  Commit: 6ff144698935e8bdbc96d255cf49b1a7d54174ac
      
https://github.com/qemu/qemu/commit/6ff144698935e8bdbc96d255cf49b1a7d54174ac
  Author: Peter Maydell <address@hidden>
  Date:   2018-11-13 (Tue, 13 Nov 2018)

  Changed paths:
    M qga/commands-win32.c
    M qga/guest-agent-core.h

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/mdroth/tags/qga-pull-2018-11-12-tag' 
into staging

qemu-ga patch queue for 3.1.0

* add missing #include guards for guest-agent-core.h
* fix leaks introduced with recent win32 enablement of disk info in
  guest-get-fsinfo

# gpg: Signature made Tue 13 Nov 2018 02:52:12 GMT
# gpg:                using RSA key 3353C9CEF108B584
# gpg: Good signature from "Michael Roth <address@hidden>"
# gpg:                 aka "Michael Roth <address@hidden>"
# gpg:                 aka "Michael Roth <address@hidden>"
# Primary key fingerprint: CEAC C9E1 5534 EBAB B82D  3FA0 3353 C9CE F108 B584

* remotes/mdroth/tags/qga-pull-2018-11-12-tag:
  qga: Add multiple include guard to guest-agent-core.h
  qga-win: fix leaks of build_guest_disk_info()

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/186ac05f749c...6ff144698935
      **NOTE:** This service has been marked for deprecation: 
https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]