[Qemu-commits] [qemu/qemu] a1f3bb: hostmem-file: fixed the memory leak w

qemu-commits
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-commits] [qemu/qemu] a1f3bb: hostmem-file: fixed the memory leak w

From:	GitHub
Subject:	[Qemu-commits] [qemu/qemu] a1f3bb: hostmem-file: fixed the memory leak while get pmem...
Date:	Fri, 26 Oct 2018 12:15:36 -0700
  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: a1f3bb1845e23c38c3bb6ca5e90ac184cfaf1a57
      
https://github.com/qemu/qemu/commit/a1f3bb1845e23c38c3bb6ca5e90ac184cfaf1a57
  Author: Zhang Yi <address@hidden>
  Date:   2018-10-24 (Wed, 24 Oct 2018)

  Changed paths:
    M backends/hostmem-file.c

  Log Message:
  -----------
  hostmem-file: fixed the memory leak while get pmem path.

object_get_canonical_path_component() returns a string which
must be freed using g_free().

Reported-by: Peter Maydell <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Zhang Yi <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Eduardo Habkost <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>


  Commit: bc1fb850a31468ac4976f3895f01a6d981e06d0a
      
https://github.com/qemu/qemu/commit/bc1fb850a31468ac4976f3895f01a6d981e06d0a
  Author: Igor Mammedov <address@hidden>
  Date:   2018-10-24 (Wed, 24 Oct 2018)

  Changed paths:
    M qemu-deprecated.texi
    M tests/cpu-plug-test.c
    M vl.c

  Log Message:
  -----------
  vl.c deprecate incorrect CPUs topology

-smp [cpus],sockets/cores/threads[,maxcpus] should describe topology
so that total number of logical CPUs [sockets * cores * threads]
would be equal to [maxcpus], however historically we didn't have
such check in QEMU and it is possible to start VM with an invalid
topology.
Deprecate invalid options combination so we can make sure that
the topology VM started with is always correct in the future.
Users with an invalid sockets/cores/threads/maxcpus values should
fix their CLI to make sure that
   [sockets * cores * threads] == [maxcpus]

Signed-off-by: Igor Mammedov <address@hidden>
Reviewed-by: Andrew Jones <address@hidden>
Reviewed-by: Eduardo Habkost <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
[ehabkost: squashed unit test fix]
Message-Id: <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>


  Commit: 268430be5e411d34808e824b4714eee30c7d157a
      
https://github.com/qemu/qemu/commit/268430be5e411d34808e824b4714eee30c7d157a
  Author: Igor Mammedov <address@hidden>
  Date:   2018-10-24 (Wed, 24 Oct 2018)

  Changed paths:
    M vl.c

  Log Message:
  -----------
  vl:c: make sure that sockets are calculated correctly in '-smp X' case

commit
  (5cdc9b76e3 vl.c: Remove dead assignment)
removed sockets calculation when 'sockets' weren't provided on CLI
since there wasn't any users for it back then. Exiting checks
are neither reachable
   } else if (sockets * cores * threads < cpus) {
or nor triggerable
   if (sockets * cores * threads > max_cpus)
so we weren't noticing wrong topology since then, since users
recalculate sockets adhoc on their own.

However with deprecation check it becomes noticable, for example
  -smp 2
will start printing warning:
  "warning: Invalid CPU topology deprecated: sockets (1) * cores (1) * threads 
(1) != maxcpus (2)"
calculating sockets if they weren't specified.

Fix it by returning back sockets calculation if it's omitted on CLI.

Signed-off-by: Igor Mammedov <address@hidden>
Reviewed-by: Andrew Jones <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>


  Commit: d33fff2a937ab429343a8bb98caa7b07ae915767
      
https://github.com/qemu/qemu/commit/d33fff2a937ab429343a8bb98caa7b07ae915767
  Author: Philippe Mathieu-Daudé <address@hidden>
  Date:   2018-10-24 (Wed, 24 Oct 2018)

  Changed paths:
    M hw/timer/trace-events

  Log Message:
  -----------
  trace-events: Fix copy/paste typo

Missed while reviewing 5dd85b4b486.

Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Peter Maydell <address@hidden>
Reviewed-by: Cédric Le Goater <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>


  Commit: 252bfbdec04b698cbcdc5779ecb07faa2bc48ae0
      
https://github.com/qemu/qemu/commit/252bfbdec04b698cbcdc5779ecb07faa2bc48ae0
  Author: Philippe Mathieu-Daudé <address@hidden>
  Date:   2018-10-24 (Wed, 24 Oct 2018)

  Changed paths:
    M hw/timer/sun4v-rtc.c
    M hw/timer/trace-events

  Log Message:
  -----------
  hw/timer/sun4v-rtc: Convert from DPRINTF() macro to trace events

Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Artyom Tarasenko <address@hidden>
Reviewed-by: Cédric Le Goater <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>


  Commit: e871972e65edab552cd62a5cdd28cef049cc795b
      
https://github.com/qemu/qemu/commit/e871972e65edab552cd62a5cdd28cef049cc795b
  Author: Philippe Mathieu-Daudé <address@hidden>
  Date:   2018-10-24 (Wed, 24 Oct 2018)

  Changed paths:
    M hw/timer/sun4v-rtc.c

  Log Message:
  -----------
  hw/timer/sun4v-rtc: Use DeviceState::realize rather than SysBusDevice::init

Move from the legacy SysBusDevice::init method to using DeviceState::realize.

Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>
Reviewed-by: Cédric Le Goater <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>


  Commit: a7e1562ca2aaf59f0eac042bee4199386819d996
      
https://github.com/qemu/qemu/commit/a7e1562ca2aaf59f0eac042bee4199386819d996
  Author: Philippe Mathieu-Daudé <address@hidden>
  Date:   2018-10-24 (Wed, 24 Oct 2018)

  Changed paths:
    M hw/ssi/xilinx_spi.c

  Log Message:
  -----------
  hw/ssi/xilinx_spi: Use DeviceState::realize rather than SysBusDevice::init

Move from the legacy SysBusDevice::init method to using DeviceState::realize.

Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>
Reviewed-by: Cédric Le Goater <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>


  Commit: 0e372e5853818e731e6fc6cf26ae62acf2179b35
      
https://github.com/qemu/qemu/commit/0e372e5853818e731e6fc6cf26ae62acf2179b35
  Author: Philippe Mathieu-Daudé <address@hidden>
  Date:   2018-10-24 (Wed, 24 Oct 2018)

  Changed paths:
    M hw/sh4/sh_pci.c

  Log Message:
  -----------
  hw/sh4/sh_pci: Use DeviceState::realize rather than SysBusDevice::init

Move from the legacy SysBusDevice::init method to using DeviceState::realize.

Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Peter Maydell <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>


  Commit: e800894a1cb04c7ba79febfde8bc0fe7c27498df
      
https://github.com/qemu/qemu/commit/e800894a1cb04c7ba79febfde8bc0fe7c27498df
  Author: Philippe Mathieu-Daudé <address@hidden>
  Date:   2018-10-24 (Wed, 24 Oct 2018)

  Changed paths:
    M hw/pci-host/bonito.c

  Log Message:
  -----------
  hw/pci-host/bonito: Use DeviceState::realize rather than SysBusDevice::init

Move from the legacy SysBusDevice::init method to using DeviceState::realize.

Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Peter Maydell <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>


  Commit: 43fd7bbf53b66ce3239c33747832044fe9154f72
      
https://github.com/qemu/qemu/commit/43fd7bbf53b66ce3239c33747832044fe9154f72
  Author: Philippe Mathieu-Daudé <address@hidden>
  Date:   2018-10-24 (Wed, 24 Oct 2018)

  Changed paths:
    M hw/mips/gt64xxx_pci.c

  Log Message:
  -----------
  hw/mips/gt64xxx_pci: Convert gt64120_reset() function into Device reset method

Convert the gt64120_reset() function into a proper Device reset method.

Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Peter Maydell <address@hidden>
Reviewed-by: Cédric Le Goater <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>


  Commit: d126869934314f35b15c5925d3f445357b7f5af0
      
https://github.com/qemu/qemu/commit/d126869934314f35b15c5925d3f445357b7f5af0
  Author: Philippe Mathieu-Daudé <address@hidden>
  Date:   2018-10-24 (Wed, 24 Oct 2018)

  Changed paths:
    M hw/mips/gt64xxx_pci.c

  Log Message:
  -----------
  hw/mips/gt64xxx_pci: Mark as bridge device

The gt64120 is currently listed as uncategorized device.
Mark it as bridge device.

Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Peter Maydell <address@hidden>
Reviewed-by: Cédric Le Goater <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>


  Commit: da0f044258299a0ab8ac4b37cbb59f64d3343079
      
https://github.com/qemu/qemu/commit/da0f044258299a0ab8ac4b37cbb59f64d3343079
  Author: Philippe Mathieu-Daudé <address@hidden>
  Date:   2018-10-24 (Wed, 24 Oct 2018)

  Changed paths:
    M default-configs/sparc64-softmmu.mak
    M hw/sparc64/niagara.c

  Log Message:
  -----------
  hw/sparc64/niagara: Model the I/O Bridge with the 'unimplemented_device'

Since the I/O Bridge device is not implemented,  Use the
TYPE_UNIMPLEMENTED_DEVICE which suits better: if the user
asks for 'unimp' warnings via the -d option then all accesses
will generate logging.

Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Artyom Tarasenko <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>


  Commit: c378adef0e651838d5af1af5f76d54af5493d28a
      
https://github.com/qemu/qemu/commit/c378adef0e651838d5af1af5f76d54af5493d28a
  Author: Philippe Mathieu-Daudé <address@hidden>
  Date:   2018-10-24 (Wed, 24 Oct 2018)

  Changed paths:
    M hw/alpha/typhoon.c

  Log Message:
  -----------
  hw/alpha/typhoon: Remove unuseful code

Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>


  Commit: fbd371a3ab7f38b612d3421849ed16c7d59dce9b
      
https://github.com/qemu/qemu/commit/fbd371a3ab7f38b612d3421849ed16c7d59dce9b
  Author: Philippe Mathieu-Daudé <address@hidden>
  Date:   2018-10-24 (Wed, 24 Oct 2018)

  Changed paths:
    M hw/hppa/dino.c

  Log Message:
  -----------
  hw/hppa/dino: Remove unuseful code

Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>


  Commit: 0f016fbd76c3db0523caaf3fa62844f54ab4cb21
      
https://github.com/qemu/qemu/commit/0f016fbd76c3db0523caaf3fa62844f54ab4cb21
  Author: Philippe Mathieu-Daudé <address@hidden>
  Date:   2018-10-24 (Wed, 24 Oct 2018)

  Changed paths:
    M hw/mips/mips_malta.c

  Log Message:
  -----------
  hw/mips/malta: Remove unuseful code

Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>


  Commit: bfec23a0d1944f465dc8ee640394ae752fc0d4dd
      
https://github.com/qemu/qemu/commit/bfec23a0d1944f465dc8ee640394ae752fc0d4dd
  Author: Li Qiang <address@hidden>
  Date:   2018-10-24 (Wed, 24 Oct 2018)

  Changed paths:
    M hw/core/machine.c

  Log Message:
  -----------
  machine: fix a typo

Cc: address@hidden
Signed-off-by: Li Qiang <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Stefano Garzarella <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>


  Commit: 7c63ba2055a0a27cdd6ae835f5964f7895d18edc
      
https://github.com/qemu/qemu/commit/7c63ba2055a0a27cdd6ae835f5964f7895d18edc
  Author: David Hildenbrand <address@hidden>
  Date:   2018-10-24 (Wed, 24 Oct 2018)

  Changed paths:
    M hw/mem/memory-device.c

  Log Message:
  -----------
  memory-device: fix alignment error message

We're missing "x" after the leading 0.

Reviewed-by: David Gibson <address@hidden>
Reviewed-by: Igor Mammedov <address@hidden>
Signed-off-by: David Hildenbrand <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>


  Commit: ac1b3375880d8ddc9d8d1b648dd83f80f4338e8e
      
https://github.com/qemu/qemu/commit/ac1b3375880d8ddc9d8d1b648dd83f80f4338e8e
  Author: David Hildenbrand <address@hidden>
  Date:   2018-10-24 (Wed, 24 Oct 2018)

  Changed paths:
    M hw/mem/memory-device.c

  Log Message:
  -----------
  memory-device: fix error message when hinted address is too small

The "at" should actually be a "before".
    if (new_addr < address_space_start)
     -> "can't add memory ... before... $address_space_start"

So it looks similar to the other check
    } else if ((new_addr + size) > address_space_end)
     -> "can't add memory ... beyond..."

Reviewed-by: Dr. David Alan Gilbert <address@hidden>
Reviewed-by: Igor Mammedov <address@hidden>
Reviewed-by: David Gibson <address@hidden>
Signed-off-by: David Hildenbrand <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>


  Commit: f99d84b1fc54f2eb7b164e4b8196061c10095522
      
https://github.com/qemu/qemu/commit/f99d84b1fc54f2eb7b164e4b8196061c10095522
  Author: David Hildenbrand <address@hidden>
  Date:   2018-10-24 (Wed, 24 Oct 2018)

  Changed paths:
    M hw/mem/memory-device.c

  Log Message:
  -----------
  memory-device: improve "range conflicts" error message

Handle id==NULL better and indicate that we are dealing with memory
devices.

Signed-off-by: David Hildenbrand <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: David Gibson <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>


  Commit: fd3416f5eb160ed9ed53ddda5203fcaf06eeb647
      
https://github.com/qemu/qemu/commit/fd3416f5eb160ed9ed53ddda5203fcaf06eeb647
  Author: David Hildenbrand <address@hidden>
  Date:   2018-10-24 (Wed, 24 Oct 2018)

  Changed paths:
    M hw/i386/pc.c
    M hw/mem/pc-dimm.c
    M hw/ppc/spapr.c
    M include/hw/mem/pc-dimm.h

  Log Message:
  -----------
  pc-dimm: pass PCDIMMDevice to pc_dimm_.*plug

We're plugging/unplugging a PCDIMMDevice, so directly pass this type
instead of a more generic DeviceState.

Reviewed-by: David Gibson <address@hidden>
Acked-by: David Gibson <address@hidden>
Reviewed-by: Igor Mammedov <address@hidden>
Reviewed-by: Eric Auger <address@hidden>
Signed-off-by: David Hildenbrand <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>


  Commit: 26b1d1fd642994faf06ca480890b76fd6bfde328
      
https://github.com/qemu/qemu/commit/26b1d1fd642994faf06ca480890b76fd6bfde328
  Author: David Hildenbrand <address@hidden>
  Date:   2018-10-24 (Wed, 24 Oct 2018)

  Changed paths:
    M hw/mem/memory-device.c

  Log Message:
  -----------
  memory-device: use memory device terminology in error messages

While we rephrased most error messages, we missed these.

Reviewed-by: Dr. David Alan Gilbert <address@hidden>
Reviewed-by: Igor Mammedov <address@hidden>
Reviewed-by: David Gibson <address@hidden>
Signed-off-by: David Hildenbrand <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>


  Commit: 15cea5ae813f35bf34363511338219102f45ff39
      
https://github.com/qemu/qemu/commit/15cea5ae813f35bf34363511338219102f45ff39
  Author: David Hildenbrand <address@hidden>
  Date:   2018-10-24 (Wed, 24 Oct 2018)

  Changed paths:
    M default-configs/i386-softmmu.mak
    M default-configs/ppc64-softmmu.mak
    M hw/Makefile.objs
    M hw/mem/Makefile.objs
    M qapi/misc.json

  Log Message:
  -----------
  memory-device: introduce separate config option

Some architectures might support memory devices, while they don't
support DIMM/NVDIMM. So let's
- Rename CONFIG_MEM_HOTPLUG to CONFIG_MEM_DEVICE
- Introduce CONFIG_DIMM and use it similarly to CONFIG NVDIMM

CONFIG_DIMM and CONFIG_NVDIMM require CONFIG_MEM_DEVICE.

Reviewed-by: Igor Mammedov <address@hidden>
Reviewed-by: David Gibson <address@hidden>
Acked-by: David Gibson <address@hidden>
Signed-off-by: David Hildenbrand <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>


  Commit: e40c5b6b3f5483bd4e1f493853e6a1f12eba1e93
      
https://github.com/qemu/qemu/commit/e40c5b6b3f5483bd4e1f493853e6a1f12eba1e93
  Author: David Hildenbrand <address@hidden>
  Date:   2018-10-24 (Wed, 24 Oct 2018)

  Changed paths:
    M hw/mem/memory-device.c
    M hw/mem/pc-dimm.c
    M include/hw/mem/memory-device.h

  Log Message:
  -----------
  memory-device: forward errors in get_region_size()/get_plugged_size()

Let's properly forward the errors, so errors from get_region_size() /
get_plugged_size() can be handled.

Users right now call both functions after the device has been realized,
which is will never fail, so it is fine to continue using error_abort.

While at it, remove a leftover error check (suggested by Igor).

Reviewed-by: David Gibson <address@hidden>
Reviewed-by: Igor Mammedov <address@hidden>
Reviewed-by: Eric Auger <address@hidden>
Signed-off-by: David Hildenbrand <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>


  Commit: 5cca020c8835921c5de634a3ff31c3e1cfe5b245
      
https://github.com/qemu/qemu/commit/5cca020c8835921c5de634a3ff31c3e1cfe5b245
  Author: David Hildenbrand <address@hidden>
  Date:   2018-10-24 (Wed, 24 Oct 2018)

  Changed paths:
    M include/hw/mem/memory-device.h

  Log Message:
  -----------
  memory-device: document MemoryDeviceClass

Document the functions. Don't document get_region_size(), as we will be
dropping/replacing that one soon.

Use same documentation style as in include/exec/memory.h, but don't
document the parameters, as they are self-explanatory.

Reviewed-by: David Gibson <address@hidden>
Reviewed-by: Igor Mammedov <address@hidden>
Signed-off-by: David Hildenbrand <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>


  Commit: 946d6154aba9aaa4d19433a6a8bcd3de3b119240
      
https://github.com/qemu/qemu/commit/946d6154aba9aaa4d19433a6a8bcd3de3b119240
  Author: David Hildenbrand <address@hidden>
  Date:   2018-10-24 (Wed, 24 Oct 2018)

  Changed paths:
    M hw/mem/memory-device.c
    M hw/mem/pc-dimm.c
    M hw/ppc/spapr.c
    M include/hw/mem/memory-device.h

  Log Message:
  -----------
  memory-device: add and use memory_device_get_region_size()

We will factor out get_memory_region() from pc-dimm to memory device code
soon. Once that is done, get_region_size() can be implemented
generically and essentially be replaced by
memory_device_get_region_size (and work only on get_memory_region()).

We have some users of get_memory_region() (spapr and pc-dimm code) that are
only interested in the size. So let's rework them to use
memory_device_get_region_size() first, then we can factor out
get_memory_region() and eventually remove get_region_size() without
touching the same code multiple times.

Reviewed-by: David Gibson <address@hidden>
Reviewed-by: Igor Mammedov <address@hidden>
Signed-off-by: David Hildenbrand <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>


  Commit: 3a0a2b0a2ba87ed00b732f061e59f890aaa27c17
      
https://github.com/qemu/qemu/commit/3a0a2b0a2ba87ed00b732f061e59f890aaa27c17
  Author: David Hildenbrand <address@hidden>
  Date:   2018-10-24 (Wed, 24 Oct 2018)

  Changed paths:
    M hw/mem/nvdimm.c
    M hw/mem/pc-dimm.c
    M include/hw/mem/memory-device.h
    M include/hw/mem/pc-dimm.h

  Log Message:
  -----------
  memory-device: factor out get_memory_region() from pc-dimm

The memory region is necessary for plugging/unplugging a memory device.
The region size (via get_region_size()) is no longer sufficient, as
besides the alignment, also the region itself is required in order to
add it to the device memory region of the machine via
- memory_region_add_subregion
- memory_region_del_subregion

So, to factor out plugging/unplugging of memory devices from pc-dimm
code, we have to factor out access to the memory region first.

Reviewed-by: David Gibson <address@hidden>
Reviewed-by: Igor Mammedov <address@hidden>
Signed-off-by: David Hildenbrand <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>


  Commit: af390027475a0ada7a9da71108d5aee6fcc18151
      
https://github.com/qemu/qemu/commit/af390027475a0ada7a9da71108d5aee6fcc18151
  Author: David Hildenbrand <address@hidden>
  Date:   2018-10-24 (Wed, 24 Oct 2018)

  Changed paths:
    M hw/mem/memory-device.c
    M hw/mem/pc-dimm.c
    M include/hw/mem/memory-device.h

  Log Message:
  -----------
  memory-device: drop get_region_size()

There are no remaining users of get_region_size() except
memory_device_get_region_size() itself. We can make
memory_device_get_region_size() work directly on get_memory_region()
instead and drop get_region_size().

In addition, we can now use memory_device_get_region_size() in pc-dimm
code to implement get_plugged_size()"

Reviewed-by: David Gibson <address@hidden>
Reviewed-by: Igor Mammedov <address@hidden>
Signed-off-by: David Hildenbrand <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>


  Commit: c331d3e1362648dadf41c49ae0749c7dfeba4518
      
https://github.com/qemu/qemu/commit/c331d3e1362648dadf41c49ae0749c7dfeba4518
  Author: David Hildenbrand <address@hidden>
  Date:   2018-10-24 (Wed, 24 Oct 2018)

  Changed paths:
    M hw/mem/pc-dimm.c
    M include/hw/mem/memory-device.h

  Log Message:
  -----------
  memory-device: add device class function set_addr()

To be able to factor out address assignment of memory devices, we will
have to read (get_addr()) and write (set_addr()) the address.

We can't use properties for this purpose, as properties are device
specific. E.g. while the address property for a DIMM is called "addr", it
might be called differently (e.g. "memaddr") for other devices.

Especially virtio based memory devices cannot use "addr" as that is already
reserved and used for the address on the bus (for the proxy device).

Also, it might be possible to have memory devices without address
properties (e.g. internal DIMM-like thingies).

In contrast to get_addr(), we expect that set_addr() can fail.

Keep it simple for now for pc-dimm and simply set the static property, that
will fail once realized.

Reviewed-by: David Gibson <address@hidden>
Reviewed-by: Igor Mammedov <address@hidden>
Reviewed-by: Eric Auger <address@hidden>
Signed-off-by: David Hildenbrand <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>


  Commit: 6ef2c0f2c162c3cae30f235c8d27ee7b0c37a1ab
      
https://github.com/qemu/qemu/commit/6ef2c0f2c162c3cae30f235c8d27ee7b0c37a1ab
  Author: David Hildenbrand <address@hidden>
  Date:   2018-10-24 (Wed, 24 Oct 2018)

  Changed paths:
    M hw/mem/memory-device.c
    M hw/mem/pc-dimm.c
    M include/hw/mem/memory-device.h

  Log Message:
  -----------
  memory-device: complete factoring out pre_plug handling

With all required memory device class functions in place, we can factor
out pre_plug handling of memory devices. Take proper care of errors. We
still have to carry along legacy_align required for pc compatibility
handling.

We will factor out tracing of the address separately in a follow-up
patch.

Reviewed-by: David Gibson <address@hidden>
Reviewed-by: Igor Mammedov <address@hidden>
Signed-off-by: David Hildenbrand <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>


  Commit: 55d67a04923488cb27f470b37896dde7a8dc0366
      
https://github.com/qemu/qemu/commit/55d67a04923488cb27f470b37896dde7a8dc0366
  Author: David Hildenbrand <address@hidden>
  Date:   2018-10-24 (Wed, 24 Oct 2018)

  Changed paths:
    M hw/mem/memory-device.c
    M hw/mem/pc-dimm.c
    M include/hw/mem/memory-device.h

  Log Message:
  -----------
  memory-device: complete factoring out plug handling

With the new memory device functions in place, we can factor out
plugging of memory devices completely.

Reviewed-by: David Gibson <address@hidden>
Reviewed-by: Igor Mammedov <address@hidden>
Reviewed-by: Eric Auger <address@hidden>
Signed-off-by: David Hildenbrand <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>


  Commit: 8288590d230c31e891965c30fa579ba3ac0f4c80
      
https://github.com/qemu/qemu/commit/8288590d230c31e891965c30fa579ba3ac0f4c80
  Author: David Hildenbrand <address@hidden>
  Date:   2018-10-24 (Wed, 24 Oct 2018)

  Changed paths:
    M hw/mem/memory-device.c
    M hw/mem/pc-dimm.c
    M include/hw/mem/memory-device.h

  Log Message:
  -----------
  memory-device: complete factoring out unplug handling

With the new memory device functions in place, we can factor out
unplugging of memory devices completely.

Reviewed-by: David Gibson <address@hidden>
Reviewed-by: Igor Mammedov <address@hidden>
Reviewed-by: Eric Auger <address@hidden>
Signed-off-by: David Hildenbrand <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>


  Commit: 005feccf626ad2078e27d831173c88f29832d99e
      
https://github.com/qemu/qemu/commit/005feccf626ad2078e27d831173c88f29832d99e
  Author: David Hildenbrand <address@hidden>
  Date:   2018-10-24 (Wed, 24 Oct 2018)

  Changed paths:
    M hw/mem/memory-device.c
    M hw/mem/pc-dimm.c
    M hw/mem/trace-events

  Log Message:
  -----------
  memory-device: trace when pre_plugging/plugging/unplugging

Let's trace the address and the id of a memory device when
pre_plugging/plugging/unplugging succeeded.

Trace it when pre_plugging as well as when plugging, so we really know
when a specific address is actually used.

Reviewed-by: David Gibson <address@hidden>
Reviewed-by: Igor Mammedov <address@hidden>
Signed-off-by: David Hildenbrand <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>


  Commit: c24828bb95ef8cdf9010e32890620c41e5390f9d
      
https://github.com/qemu/qemu/commit/c24828bb95ef8cdf9010e32890620c41e5390f9d
  Author: Cédric Le Goater <address@hidden>
  Date:   2018-10-24 (Wed, 24 Oct 2018)

  Changed paths:
    M hw/net/etraxfs_eth.c

  Log Message:
  -----------
  net: etraxfs_eth: convert SysBus init method to a realize method

Cc: Edgar E. Iglesias <address@hidden>
Signed-off-by: Cédric Le Goater <address@hidden>
Reviewed-by: Peter Maydell <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>


  Commit: 56dff42a2ca3d26968c6f211c8e978bdbf5006a3
      
https://github.com/qemu/qemu/commit/56dff42a2ca3d26968c6f211c8e978bdbf5006a3
  Author: Cédric Le Goater <address@hidden>
  Date:   2018-10-24 (Wed, 24 Oct 2018)

  Changed paths:
    M hw/net/etraxfs_eth.c

  Log Message:
  -----------
  net: etraxfs_eth: add a reset method

Cc: Edgar E. Iglesias <address@hidden>
Signed-off-by: Cédric Le Goater <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>


  Commit: f71b3367a243058215e3724be8d661c67bf94d8e
      
https://github.com/qemu/qemu/commit/f71b3367a243058215e3724be8d661c67bf94d8e
  Author: Cédric Le Goater <address@hidden>
  Date:   2018-10-24 (Wed, 24 Oct 2018)

  Changed paths:
    M hw/net/lan9118.c

  Log Message:
  -----------
  net: lan9118: convert SysBus init method to a realize method

Signed-off-by: Cédric Le Goater <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>


  Commit: 45099c42b2034507151e0f51d280b0b369ada1b6
      
https://github.com/qemu/qemu/commit/45099c42b2034507151e0f51d280b0b369ada1b6
  Author: Cédric Le Goater <address@hidden>
  Date:   2018-10-24 (Wed, 24 Oct 2018)

  Changed paths:
    M hw/net/lance.c

  Log Message:
  -----------
  net: lance: convert SysBus init method to a realize method

Signed-off-by: Cédric Le Goater <address@hidden>
Reviewed-by: Peter Maydell <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>


  Commit: d85d01601db236a4b0e087e5f0d926c4c787568a
      
https://github.com/qemu/qemu/commit/d85d01601db236a4b0e087e5f0d926c4c787568a
  Author: Cédric Le Goater <address@hidden>
  Date:   2018-10-24 (Wed, 24 Oct 2018)

  Changed paths:
    M hw/net/milkymist-minimac2.c

  Log Message:
  -----------
  net: milkymist_minimac2: convert SysBus init method to a realize method

Cc: Michael Walle <address@hidden>
Signed-off-by: Cédric Le Goater <address@hidden>
Reviewed-by: Peter Maydell <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Message-Id: <address@hidden>
Acked-by: Michael Walle <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>


  Commit: 04cb1572658f46bdccb1549b97a3fccd6787e5da
      
https://github.com/qemu/qemu/commit/04cb1572658f46bdccb1549b97a3fccd6787e5da
  Author: Cédric Le Goater <address@hidden>
  Date:   2018-10-24 (Wed, 24 Oct 2018)

  Changed paths:
    M hw/net/mipsnet.c

  Log Message:
  -----------
  net: mipsnet: convert SysBus init method to a realize method

Cc: Aleksandar Markovic <address@hidden>
Signed-off-by: Cédric Le Goater <address@hidden>
Reviewed-by: Peter Maydell <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>


  Commit: 842fac8e20f986183c90b604ef412ef8cd17a2d2
      
https://github.com/qemu/qemu/commit/842fac8e20f986183c90b604ef412ef8cd17a2d2
  Author: Cédric Le Goater <address@hidden>
  Date:   2018-10-24 (Wed, 24 Oct 2018)

  Changed paths:
    M hw/net/opencores_eth.c

  Log Message:
  -----------
  net: opencores_eth: convert SysBus init method to a realize method

Cc: Max Filippov <address@hidden>
Signed-off-by: Cédric Le Goater <address@hidden>
Reviewed-by: Peter Maydell <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Message-Id: <address@hidden>
Acked-by: Max Filippov <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>


  Commit: f5ac82ce6c88f4ffe1171df32e1aa188784ba841
      
https://github.com/qemu/qemu/commit/f5ac82ce6c88f4ffe1171df32e1aa188784ba841
  Author: Cédric Le Goater <address@hidden>
  Date:   2018-10-24 (Wed, 24 Oct 2018)

  Changed paths:
    M hw/net/smc91c111.c

  Log Message:
  -----------
  net: smc91c111: convert SysBus init method to a realize method

Signed-off-by: Cédric Le Goater <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>


  Commit: bb4d585027157f8251da0cfdf584479f85f50bce
      
https://github.com/qemu/qemu/commit/bb4d585027157f8251da0cfdf584479f85f50bce
  Author: Cédric Le Goater <address@hidden>
  Date:   2018-10-24 (Wed, 24 Oct 2018)

  Changed paths:
    M hw/net/stellaris_enet.c

  Log Message:
  -----------
  net: stellaris_enet: convert SysBus init method to a realize method

Cc: Peter Maydell <address@hidden>
Cc: address@hidden
Signed-off-by: Cédric Le Goater <address@hidden>
Reviewed-by: Peter Maydell <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>


  Commit: b11ff5ecf6961a637d17242eb3201d68cb94b282
      
https://github.com/qemu/qemu/commit/b11ff5ecf6961a637d17242eb3201d68cb94b282
  Author: Cédric Le Goater <address@hidden>
  Date:   2018-10-24 (Wed, 24 Oct 2018)

  Changed paths:
    M hw/net/stellaris_enet.c

  Log Message:
  -----------
  net: stellaris_enet: add a reset method

Cc: Peter Maydell <address@hidden>
Cc: address@hidden
Signed-off-by: Cédric Le Goater <address@hidden>
Reviewed-by: Peter Maydell <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>


  Commit: 8fa922c241e63f018f5b55c03ac494ae3d5fe594
      
https://github.com/qemu/qemu/commit/8fa922c241e63f018f5b55c03ac494ae3d5fe594
  Author: Cédric Le Goater <address@hidden>
  Date:   2018-10-24 (Wed, 24 Oct 2018)

  Changed paths:
    M hw/net/xgmac.c

  Log Message:
  -----------
  net: xgmac: convert SysBus init method to a realize method

Cc: Peter Maydell <address@hidden>
Cc: address@hidden
Cc: Rob Herring <address@hidden>
Signed-off-by: Cédric Le Goater <address@hidden>
Reviewed-by: Peter Maydell <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>


  Commit: 6e6ffc9ffa88eb6af6f39931f6b495805b150c95
      
https://github.com/qemu/qemu/commit/6e6ffc9ffa88eb6af6f39931f6b495805b150c95
  Author: Peter Maydell <address@hidden>
  Date:   2018-10-25 (Thu, 25 Oct 2018)

  Changed paths:
    M backends/hostmem-file.c
    M default-configs/i386-softmmu.mak
    M default-configs/ppc64-softmmu.mak
    M default-configs/sparc64-softmmu.mak
    M hw/Makefile.objs
    M hw/alpha/typhoon.c
    M hw/core/machine.c
    M hw/hppa/dino.c
    M hw/i386/pc.c
    M hw/mem/Makefile.objs
    M hw/mem/memory-device.c
    M hw/mem/nvdimm.c
    M hw/mem/pc-dimm.c
    M hw/mem/trace-events
    M hw/mips/gt64xxx_pci.c
    M hw/mips/mips_malta.c
    M hw/net/etraxfs_eth.c
    M hw/net/lan9118.c
    M hw/net/lance.c
    M hw/net/milkymist-minimac2.c
    M hw/net/mipsnet.c
    M hw/net/opencores_eth.c
    M hw/net/smc91c111.c
    M hw/net/stellaris_enet.c
    M hw/net/xgmac.c
    M hw/pci-host/bonito.c
    M hw/ppc/spapr.c
    M hw/sh4/sh_pci.c
    M hw/sparc64/niagara.c
    M hw/ssi/xilinx_spi.c
    M hw/timer/sun4v-rtc.c
    M hw/timer/trace-events
    M include/hw/mem/memory-device.h
    M include/hw/mem/pc-dimm.h
    M qapi/misc.json
    M qemu-deprecated.texi
    M tests/cpu-plug-test.c
    M vl.c

  Log Message:
  -----------
  Merge remote-tracking branch 
'remotes/ehabkost/tags/machine-next-pull-request' into staging

Machine queue, 2018-10-25

* sysbus init/realize cleanups
  (Cédric Le Goater, Philippe Mathieu-Daudé)
* memory-device refactoring (David Hildenbrand)
* -smp: deprecate incorrect CPUs topology (Igor Mammedov)
* -numa parsing cleanups (Markus Armbruster)
* Fix hostmem-file memory leak (Zhang Yi)
* Typo fix (Li Qiang)

# gpg: Signature made Thu 25 Oct 2018 14:31:46 BST
# gpg:                using RSA key 2807936F984DC5A6
# gpg: Good signature from "Eduardo Habkost <address@hidden>"
# Primary key fingerprint: 5A32 2FD5 ABC4 D3DB ACCF  D1AA 2807 936F 984D C5A6

* remotes/ehabkost/tags/machine-next-pull-request: (43 commits)
  net: xgmac: convert SysBus init method to a realize method
  net: stellaris_enet: add a reset method
  net: stellaris_enet: convert SysBus init method to a realize method
  net: smc91c111: convert SysBus init method to a realize method
  net: opencores_eth: convert SysBus init method to a realize method
  net: mipsnet: convert SysBus init method to a realize method
  net: milkymist_minimac2: convert SysBus init method to a realize method
  net: lance: convert SysBus init method to a realize method
  net: lan9118: convert SysBus init method to a realize method
  net: etraxfs_eth: add a reset method
  net: etraxfs_eth: convert SysBus init method to a realize method
  memory-device: trace when pre_plugging/plugging/unplugging
  memory-device: complete factoring out unplug handling
  memory-device: complete factoring out plug handling
  memory-device: complete factoring out pre_plug handling
  memory-device: add device class function set_addr()
  memory-device: drop get_region_size()
  memory-device: factor out get_memory_region() from pc-dimm
  memory-device: add and use memory_device_get_region_size()
  memory-device: document MemoryDeviceClass
  ...

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/808ebd66e467...6e6ffc9ffa88
      **NOTE:** This service has been marked for deprecation: 
https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.
[Prev in Thread]
Current Thread
[Next in Thread]
[Qemu-commits] [qemu/qemu] a1f3bb: hostmem-file: fixed the memory leak while get pmem..., GitHub <=
Prev by Date: [Qemu-commits] [qemu/qemu] 85ba72: RISC-V: Allow setting and clearing multiple irqs
Next by Date: [Qemu-commits] [qemu/qemu] ba1e81: target/mips: Add nanoMIPS CRC32 instruction pool
Previous by thread: [Qemu-commits] [qemu/qemu] 85ba72: RISC-V: Allow setting and clearing multiple irqs
Next by thread: [Qemu-commits] [qemu/qemu] ba1e81: target/mips: Add nanoMIPS CRC32 instruction pool
Index(es):
- Date
- Thread