[Qemu-commits] [qemu/qemu] a9e081: crypto: expand algorithm coverage for cipher bench...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: a9e08155bd4ae096688a8ff19669023ab0fbc170
      
https://github.com/qemu/qemu/commit/a9e08155bd4ae096688a8ff19669023ab0fbc170
  Author: Daniel P. Berrangé <address@hidden>
  Date:   2018-10-24 (Wed, 24 Oct 2018)

  Changed paths:
    M tests/benchmark-crypto-cipher.c

  Log Message:
  -----------
  crypto: expand algorithm coverage for cipher benchmark

Add testing coverage for AES with XTS, ECB and CTR modes

Reviewed-by: Marc-André Lureau <address@hidden>
Reviewed-by: Alberto Garcia <address@hidden>
Signed-off-by: Daniel P. Berrangé <address@hidden>


  Commit: 299ec87838babdf38be618cf2d81aef2500758bd
      
https://github.com/qemu/qemu/commit/299ec87838babdf38be618cf2d81aef2500758bd
  Author: Daniel P. Berrangé <address@hidden>
  Date:   2018-10-24 (Wed, 24 Oct 2018)

  Changed paths:
    M crypto/xts.c

  Log Message:
  -----------
  crypto: remove code duplication in tweak encrypt/decrypt

The tweak encrypt/decrypt functions are identical except for the
comments, so can be merged. Profiling data shows that the compiler is
in fact already merging the two merges in the object files.

Reviewed-by: Marc-André Lureau <address@hidden>
Reviewed-by: Alberto Garcia <address@hidden>
Signed-off-by: Daniel P. Berrangé <address@hidden>


  Commit: cc36930e4077eb3dbee6cd30d2d826ec62b3490a
      
https://github.com/qemu/qemu/commit/cc36930e4077eb3dbee6cd30d2d826ec62b3490a
  Author: Daniel P. Berrangé <address@hidden>
  Date:   2018-10-24 (Wed, 24 Oct 2018)

  Changed paths:
    M crypto/xts.c

  Log Message:
  -----------
  crypto: introduce a xts_uint128 data type

The new type is designed to allow use of 64-bit arithmetic instead
of operating 1-byte at a time. The following patches will use this to
improve performance.

Reviewed-by: Alberto Garcia <address@hidden>
Signed-off-by: Daniel P. Berrangé <address@hidden>


  Commit: db217c69f0849add67cfa2cd6601c329398be12c
      
https://github.com/qemu/qemu/commit/db217c69f0849add67cfa2cd6601c329398be12c
  Author: Daniel P. Berrangé <address@hidden>
  Date:   2018-10-24 (Wed, 24 Oct 2018)

  Changed paths:
    M crypto/xts.c

  Log Message:
  -----------
  crypto: convert xts_tweak_encdec to use xts_uint128 type

Using 64-bit arithmetic increases the performance for xts-aes-128
when built with gcrypt:

  Encrypt: 272 MB/s -> 355 MB/s
  Decrypt: 275 MB/s -> 362 MB/s

Reviewed-by: Alberto Garcia <address@hidden>
Signed-off-by: Daniel P. Berrangé <address@hidden>


  Commit: 7dac0dd67426753646df0c23c819609b9e704f59
      
https://github.com/qemu/qemu/commit/7dac0dd67426753646df0c23c819609b9e704f59
  Author: Daniel P. Berrangé <address@hidden>
  Date:   2018-10-24 (Wed, 24 Oct 2018)

  Changed paths:
    M crypto/xts.c

  Log Message:
  -----------
  crypto: convert xts_mult_x to use xts_uint128 type

Using 64-bit arithmetic increases the performance for xts-aes-128
when built with gcrypt:

  Encrypt: 355 MB/s -> 545 MB/s
  Decrypt: 362 MB/s -> 568 MB/s

Reviewed-by: Alberto Garcia <address@hidden>
Signed-off-by: Daniel P. Berrangé <address@hidden>


  Commit: aa895bd439341a8f218d8f1a3d21359ba058c13f
      
https://github.com/qemu/qemu/commit/aa895bd439341a8f218d8f1a3d21359ba058c13f
  Author: Daniel P. Berrangé <address@hidden>
  Date:   2018-10-24 (Wed, 24 Oct 2018)

  Changed paths:
    M crypto/xts.c

  Log Message:
  -----------
  crypto: annotate xts_tweak_encdec as inlineable

Encouraging the compiler to inline xts_tweak_encdec increases the
performance for xts-aes-128 when built with gcrypt:

  Encrypt: 545 MB/s -> 580 MB/s
  Decrypt: 568 MB/s -> 602 MB/s

Reviewed-by: Alberto Garcia <address@hidden>
Signed-off-by: Daniel P. Berrangé <address@hidden>


  Commit: a61f682fde664467c4b4dd498ea84338598c8cbd
      
https://github.com/qemu/qemu/commit/a61f682fde664467c4b4dd498ea84338598c8cbd
  Author: Daniel P. Berrangé <address@hidden>
  Date:   2018-10-24 (Wed, 24 Oct 2018)

  Changed paths:
    M tests/test-crypto-xts.c

  Log Message:
  -----------
  crypto: refactor XTS cipher mode test suite

The current XTS test overloads two different tests in a single function
making the code a little hard to follow. Split it into distinct test
cases.

Reviewed-by: Alberto Garcia <address@hidden>
Signed-off-by: Daniel P. Berrangé <address@hidden>


  Commit: 1e0fa32c6c952d2ce9c19d35717c609804dd55d5
      
https://github.com/qemu/qemu/commit/1e0fa32c6c952d2ce9c19d35717c609804dd55d5
  Author: Daniel P. Berrangé <address@hidden>
  Date:   2018-10-24 (Wed, 24 Oct 2018)

  Changed paths:
    M tests/test-crypto-xts.c

  Log Message:
  -----------
  crypto: add testing for unaligned buffers with XTS cipher mode

Validate that the XTS cipher mode will correctly operate with plain
text, cipher text and IV buffers that are not 64-bit aligned.

Reviewed-by: Alberto Garcia <address@hidden>
Signed-off-by: Daniel P. Berrangé <address@hidden>


  Commit: a4d710251fa5aa9ec26de4626f11c78500195d12
      
https://github.com/qemu/qemu/commit/a4d710251fa5aa9ec26de4626f11c78500195d12
  Author: Peter Maydell <address@hidden>
  Date:   2018-10-24 (Wed, 24 Oct 2018)

  Changed paths:
    M crypto/xts.c
    M tests/benchmark-crypto-cipher.c
    M tests/test-crypto-xts.c

  Log Message:
  -----------
  Merge remote-tracking branch 
'remotes/berrange/tags/qcrypto-next-pull-request' into staging

Improve performance of XTS cipher mode impl

The XTS cipher mode performance is approximately doubled and test
coverage is improved.

# gpg: Signature made Wed 24 Oct 2018 19:05:08 BST
# gpg:                using RSA key BE86EBB415104FDF
# gpg: Good signature from "Daniel P. Berrange <address@hidden>"
# gpg:                 aka "Daniel P. Berrange <address@hidden>"
# Primary key fingerprint: DAF3 A6FD B26B 6291 2D0E  8E3F BE86 EBB4 1510 4FDF

* remotes/berrange/tags/qcrypto-next-pull-request:
  crypto: add testing for unaligned buffers with XTS cipher mode
  crypto: refactor XTS cipher mode test suite
  crypto: annotate xts_tweak_encdec as inlineable
  crypto: convert xts_mult_x to use xts_uint128 type
  crypto: convert xts_tweak_encdec to use xts_uint128 type
  crypto: introduce a xts_uint128 data type
  crypto: remove code duplication in tweak encrypt/decrypt
  crypto: expand algorithm coverage for cipher benchmark

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/c96292036a17...a4d710251fa5
      **NOTE:** This service has been marked for deprecation: 
https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.