qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] a95db5: qdev-monitor: print help to stdout


From: GitHub
Subject: [Qemu-commits] [qemu/qemu] a95db5: qdev-monitor: print help to stdout
Date: Mon, 08 Oct 2018 03:09:42 -0700

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: a95db58f210ddf5ed61f25cfcb89063cda86ea3c
      
https://github.com/qemu/qemu/commit/a95db58f210ddf5ed61f25cfcb89063cda86ea3c
  Author: Marc-André Lureau <address@hidden>
  Date:   2018-10-05 (Fri, 05 Oct 2018)

  Changed paths:
    M include/monitor/monitor.h
    M monitor.c
    M qdev-monitor.c

  Log Message:
  -----------
  qdev-monitor: print help to stdout

qdev_device_help() is used from command line "-device help", or from
HMP "device_add". If used from command line, print help to stdout
(it is only printed on explicit demand).

Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Eric Blake <address@hidden>


  Commit: 85e33a2818f46ee023c8729252c797f125744d20
      
https://github.com/qemu/qemu/commit/85e33a2818f46ee023c8729252c797f125744d20
  Author: Marc-André Lureau <address@hidden>
  Date:   2018-10-05 (Fri, 05 Oct 2018)

  Changed paths:
    M include/qemu/cutils.h
    M util/cutils.c

  Log Message:
  -----------
  cutils: add qemu_pstrcmp0()

A char** variant of g_strcmp0().

Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>


  Commit: e05979d0d7362d25275adcc73ad082bf66b9b018
      
https://github.com/qemu/qemu/commit/e05979d0d7362d25275adcc73ad082bf66b9b018
  Author: Marc-André Lureau <address@hidden>
  Date:   2018-10-05 (Fri, 05 Oct 2018)

  Changed paths:
    M util/qemu-option.c

  Log Message:
  -----------
  qemu-option: add help fallback to print the list of options

QDev options accept 'help' (or '?', but that's problematic with shell
globbing) in the list of parameters, which is handy to list the
available options.

Unfortunately, this isn't built in QemuOpts. qemu_opts_parse_noisily()
seems to be the common path for command line options, so place a
fallback to print help, listing the available options.

This is quite handy, for example with qemu "-spice help".

Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Eric Blake <address@hidden>


  Commit: 9cbef9d68ee1d8d04342e40d1126ab7d27f93554
      
https://github.com/qemu/qemu/commit/9cbef9d68ee1d8d04342e40d1126ab7d27f93554
  Author: Marc-André Lureau <address@hidden>
  Date:   2018-10-05 (Fri, 05 Oct 2018)

  Changed paths:
    M util/qemu-option.c

  Log Message:
  -----------
  qemu-option: improve qemu_opts_print_help() output

Modify qemu_opts_print_help():
- to print expected argument type
- skip description if not available
- sort lines
- prefix with the list name (like qdev, to avoid confusion)
- drop 16-chars alignment, use a '-' as seperator for option name and
  description

For ex, "-spice help" output is changed from:

port             No description available
tls-port         No description available
addr             No description available
[...]
gl               No description available
rendernode       No description available

to:

spice.addr=str
spice.agent-mouse=bool (on/off)
spice.disable-agent-file-xfer=bool (on/off)
[...]
spice.x509-key-password=str
spice.zlib-glz-wan-compression=str

"qemu-img create -f qcow2 -o help", changed from:

size             Virtual disk size
compat           Compatibility level (0.10 or 1.1)
backing_file     File name of a base image
[...]
lazy_refcounts   Postpone refcount updates
refcount_bits    Width of a reference count entry in bits

to:

backing_file=str - File name of a base image
backing_fmt=str - Image format of the base image
cluster_size=size - qcow2 cluster size
[...]
refcount_bits=num - Width of a reference count entry in bits
size=size - Virtual disk size

Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Eric Blake <address@hidden>


  Commit: 684546d8e9b5adefa5b499d4371b83f9163593b6
      
https://github.com/qemu/qemu/commit/684546d8e9b5adefa5b499d4371b83f9163593b6
  Author: Marc-André Lureau <address@hidden>
  Date:   2018-10-05 (Fri, 05 Oct 2018)

  Changed paths:
    M qom/object.c

  Log Message:
  -----------
  qom/object: fix iterating properties over a class

object_class_property_iter_init() starts from the given class, so the
next class should continue with the parent class.

Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Paolo Bonzini <address@hidden>


  Commit: 7439a036d58f0def85751d6d4d3232461a35ebee
      
https://github.com/qemu/qemu/commit/7439a036d58f0def85751d6d4d3232461a35ebee
  Author: Marc-André Lureau <address@hidden>
  Date:   2018-10-05 (Fri, 05 Oct 2018)

  Changed paths:
    M qom/object.c

  Log Message:
  -----------
  qom/object: register 'type' property as class property

Let's save a few byte in each object instance.

Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Paolo Bonzini <address@hidden>


  Commit: 9633017998c965e106f9ff4585ec09294c924c8e
      
https://github.com/qemu/qemu/commit/9633017998c965e106f9ff4585ec09294c924c8e
  Author: Marc-André Lureau <address@hidden>
  Date:   2018-10-05 (Fri, 05 Oct 2018)

  Changed paths:
    M tests/check-qom-proplist.c

  Log Message:
  -----------
  tests/qom-proplist: check duplicate "bv" property registration failed

"bv" is already a class property.

Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Paolo Bonzini <address@hidden>


  Commit: 94ef3b309273c37717fad34acd8c8b58a21861a0
      
https://github.com/qemu/qemu/commit/94ef3b309273c37717fad34acd8c8b58a21861a0
  Author: Marc-André Lureau <address@hidden>
  Date:   2018-10-05 (Fri, 05 Oct 2018)

  Changed paths:
    M tests/check-qom-proplist.c

  Log Message:
  -----------
  tests/qom-proplist: check properties are not listed multiple times

And factor out a common function used by the follow class properties
iterator test.

Fix uninitialized "seentype" variable.

Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Paolo Bonzini <address@hidden>


  Commit: e569ba9232ce91bc4ffaa566b2ac44e49d8f5ba2
      
https://github.com/qemu/qemu/commit/e569ba9232ce91bc4ffaa566b2ac44e49d8f5ba2
  Author: Marc-André Lureau <address@hidden>
  Date:   2018-10-05 (Fri, 05 Oct 2018)

  Changed paths:
    M tests/check-qom-proplist.c

  Log Message:
  -----------
  tests/qom-proplist: check class properties iterator

This test failed before "fix iterating properties over a class".

Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Paolo Bonzini <address@hidden>


  Commit: bb15cbc0538f4a81810761c58d9b4acf0917b60d
      
https://github.com/qemu/qemu/commit/bb15cbc0538f4a81810761c58d9b4acf0917b60d
  Author: Marc-André Lureau <address@hidden>
  Date:   2018-10-05 (Fri, 05 Oct 2018)

  Changed paths:
    M vl.c

  Log Message:
  -----------
  vl: handle -object help

List the user creatable objects.

Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Paolo Bonzini <address@hidden>


  Commit: 033bfc5e0e450c5f6566cb9dab7e4095d06199c8
      
https://github.com/qemu/qemu/commit/033bfc5e0e450c5f6566cb9dab7e4095d06199c8
  Author: Marc-André Lureau <address@hidden>
  Date:   2018-10-05 (Fri, 05 Oct 2018)

  Changed paths:
    M backends/hostmem-memfd.c
    M backends/hostmem.c

  Log Message:
  -----------
  hostmem: add some properties description

Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Paolo Bonzini <address@hidden>


  Commit: 1195fa2b08d98ab503155c5cee8831d1ef91aac5
      
https://github.com/qemu/qemu/commit/1195fa2b08d98ab503155c5cee8831d1ef91aac5
  Author: Marc-André Lureau <address@hidden>
  Date:   2018-10-05 (Fri, 05 Oct 2018)

  Changed paths:
    M qom/object_interfaces.c
    M vl.c

  Log Message:
  -----------
  vl: list user creatable properties when 'help' is argument

Iterate over the writable class properties, sort and print them out
with the description if available.

Ex: qemu -object memory-backend-file,help
memory-backend-file.align=int
memory-backend-file.discard-data=bool
memory-backend-file.dump=bool - Set to 'off' to exclude from core dump
memory-backend-file.host-nodes=int - Binds memory to the list of NUMA host nodes
memory-backend-file.mem-path=string
memory-backend-file.merge=bool - Mark memory as mergeable
memory-backend-file.pmem=bool
memory-backend-file.policy=HostMemPolicy - Set the NUMA policy
memory-backend-file.prealloc=bool - Preallocate memory
memory-backend-file.share=bool - Mark the memory as private to QEMU or shared
memory-backend-file.size=int - Size of the memory region (ex: 500M)

Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Paolo Bonzini <address@hidden>


  Commit: df51a005192ee40b469c9714d451bf49b6eb7fa7
      
https://github.com/qemu/qemu/commit/df51a005192ee40b469c9714d451bf49b6eb7fa7
  Author: Peter Maydell <address@hidden>
  Date:   2018-10-08 (Mon, 08 Oct 2018)

  Changed paths:
    M backends/hostmem-memfd.c
    M backends/hostmem.c
    M include/monitor/monitor.h
    M include/qemu/cutils.h
    M monitor.c
    M qdev-monitor.c
    M qom/object.c
    M qom/object_interfaces.c
    M tests/check-qom-proplist.c
    M util/cutils.c
    M util/qemu-option.c
    M vl.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/elmarco/tags/option-pull-request' into 
staging

CLI help improvements

PULLv2:
 - fix uninitialized "seentype" variable in qom-test

# gpg: Signature made Fri 05 Oct 2018 13:28:21 BST
# gpg:                using RSA key DAE8E10975969CE5
# gpg: Good signature from "Marc-André Lureau <address@hidden>"
# gpg:                 aka "Marc-André Lureau <address@hidden>"
# Primary key fingerprint: 87A9 BD93 3F87 C606 D276  F62D DAE8 E109 7596 9CE5

* remotes/elmarco/tags/option-pull-request:
  vl: list user creatable properties when 'help' is argument
  hostmem: add some properties description
  vl: handle -object help
  tests/qom-proplist: check class properties iterator
  tests/qom-proplist: check properties are not listed multiple times
  tests/qom-proplist: check duplicate "bv" property registration failed
  qom/object: register 'type' property as class property
  qom/object: fix iterating properties over a class
  qemu-option: improve qemu_opts_print_help() output
  qemu-option: add help fallback to print the list of options
  cutils: add qemu_pstrcmp0()
  qdev-monitor: print help to stdout

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/e2e3436add53...df51a005192e
      **NOTE:** This service has been marked for deprecation: 
https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]