qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 6624c3: sdl2: show console #0 unconditionally


From: GitHub
Subject: [Qemu-commits] [qemu/qemu] 6624c3: sdl2: show console #0 unconditionally
Date: Mon, 01 Oct 2018 08:36:23 -0700

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 6624c38d11d0bdb45579c3cc8c7499af79b20564
      
https://github.com/qemu/qemu/commit/6624c38d11d0bdb45579c3cc8c7499af79b20564
  Author: Gerd Hoffmann <address@hidden>
  Date:   2018-10-01 (Mon, 01 Oct 2018)

  Changed paths:
    M ui/sdl2.c

  Log Message:
  -----------
  sdl2: show console #0 unconditionally

Otherwise sdl2 will show no window in case no graphical
display device is present.

Reproducer: qemu -nodefaults -display sdl -serial vc

Signed-off-by: Gerd Hoffmann <address@hidden>
Message-id: address@hidden


  Commit: b5dc0d7d565048fcf2767060261d8385805aced1
      
https://github.com/qemu/qemu/commit/b5dc0d7d565048fcf2767060261d8385805aced1
  Author: Marc-André Lureau <address@hidden>
  Date:   2018-10-01 (Mon, 01 Oct 2018)

  Changed paths:
    M ui/vnc.c

  Log Message:
  -----------
  vnc: call sasl_server_init() only when required

VNC server is calling sasl_server_init() during startup of QEMU, even
if SASL auth has not been enabled.

This may create undesirable warnings like "Could not find keytab file:
/etc/qemu/krb5.tab" when the user didn't configure SASL on host and
started VNC server.

Instead, only initialize SASL when needed. Note that HMP/QMP "change
vnc" calls vnc_display_open() again, which will initialize SASL if
needed.

Fix assignment in if condition, while touching this code.

Related to:
https://bugzilla.redhat.com/show_bug.cgi?id=1609327

Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Daniel P. Berrangé <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: e8b1386ea1719525a1a92df03377764703fe8c64
      
https://github.com/qemu/qemu/commit/e8b1386ea1719525a1a92df03377764703fe8c64
  Author: Gerd Hoffmann <address@hidden>
  Date:   2018-10-01 (Mon, 01 Oct 2018)

  Changed paths:
    M qapi/ui.json
    M ui/gtk.c

  Log Message:
  -----------
  gtk: add zoom-to-fit to gtk options.

This allows to set the option on the command line, i.e. "-display
gtk,zoom-to-fit={on,off}", overriding the default chosen by qemu.

Signed-off-by: Gerd Hoffmann <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Message-id: address@hidden


  Commit: a2ef4d9e95400cd387ab4ae19a317741e458fb07
      
https://github.com/qemu/qemu/commit/a2ef4d9e95400cd387ab4ae19a317741e458fb07
  Author: Peter Maydell <address@hidden>
  Date:   2018-10-01 (Mon, 01 Oct 2018)

  Changed paths:
    M qapi/ui.json
    M ui/gtk.c
    M ui/sdl2.c
    M ui/vnc.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/kraxel/tags/ui-20181001-pull-request' 
into staging

ui: some small fixes/improvements.

# gpg: Signature made Mon 01 Oct 2018 11:42:16 BST
# gpg:                using RSA key 4CB6D8EED3E87138
# gpg: Good signature from "Gerd Hoffmann (work) <address@hidden>"
# gpg:                 aka "Gerd Hoffmann <address@hidden>"
# gpg:                 aka "Gerd Hoffmann (private) <address@hidden>"
# Primary key fingerprint: A032 8CFF B93A 17A7 9901  FE7D 4CB6 D8EE D3E8 7138

* remotes/kraxel/tags/ui-20181001-pull-request:
  gtk: add zoom-to-fit to gtk options.
  vnc: call sasl_server_init() only when required
  sdl2: show console #0 unconditionally

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/24c3833717d2...a2ef4d9e9540
      **NOTE:** This service has been marked for deprecation: 
https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]