[Qemu-commits] [qemu/qemu] 44dd41: usb-mtp: fix error conditions for write operation

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 44dd4196806ef015e7df3c671ca986b0b5ca0f73
      
https://github.com/qemu/qemu/commit/44dd4196806ef015e7df3c671ca986b0b5ca0f73
  Author: Bandan <address@hidden>
  Date:   2018-10-01 (Mon, 01 Oct 2018)

  Changed paths:
    M hw/usb/dev-mtp.c

  Log Message:
  -----------
  usb-mtp: fix error conditions for write operation

Return STORE_FULL if we can't write all the bytes but
return incomplete transfer if data received is less then
what was specified in the metadata. Also, use d->offset
as the file size which is valid for all file sizes.

Signed-off-by: Bandan <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 1ee53067f849506042193a9fd57f857583536eca
      
https://github.com/qemu/qemu/commit/1ee53067f849506042193a9fd57f857583536eca
  Author: Bandan <address@hidden>
  Date:   2018-10-01 (Mon, 01 Oct 2018)

  Changed paths:
    M qemu-doc.texi
    M scripts/device-crash-test

  Log Message:
  -----------
  doc: replace x-root with rootdir for usb-mtp

Signed-off-by: Bandan <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: f7c36a754c0a597e6c397e6e21e03798fc2eee69
      
https://github.com/qemu/qemu/commit/f7c36a754c0a597e6c397e6e21e03798fc2eee69
  Author: Bandan Das <address@hidden>
  Date:   2018-10-01 (Mon, 01 Oct 2018)

  Changed paths:
    M hw/usb/dev-mtp.c

  Log Message:
  -----------
  usb-mtp: reset ObjectInfo dataset size on cleanup

Stale values in this field may result in qemu
expecting more data on the next operation

Signed-off-by: Bandan Das <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 3e9191acb797e4298adb853bf6c75cd31af47ef9
      
https://github.com/qemu/qemu/commit/3e9191acb797e4298adb853bf6c75cd31af47ef9
  Author: Gerd Hoffmann <address@hidden>
  Date:   2018-10-01 (Mon, 01 Oct 2018)

  Changed paths:
    M hw/usb/dev-hub.c

  Log Message:
  -----------
  usb-hub: clear suspend on detach

Signed-off-by: Gerd Hoffmann <address@hidden>
Message-id: address@hidden


  Commit: a60f39a4681b369bdcc78a9d1a1067d4a6bb8736
      
https://github.com/qemu/qemu/commit/a60f39a4681b369bdcc78a9d1a1067d4a6bb8736
  Author: Miguel GAIO <address@hidden>
  Date:   2018-10-01 (Mon, 01 Oct 2018)

  Changed paths:
    M hw/usb/hcd-ohci.c

  Log Message:
  -----------
  ohci: set effectively usb frame rate to 1kHz

USB frame rate is slightly lower than 1kHz: ie. ~950Hz.
Thus usb-audio device is not able to perform a simple audio playback
without underruns on audio backend.
eg. "-device pci-ohci,id=ohci -device usb-audio,bus=ohci.0" vs PulseAudio
backend. more than 50 underruns are observed per second.

Update ohci_sof_time computation, using QEMU_CLOCK_VIRTUAL in
ohci_usb_start(), and increment by usb_frame_time in ohci_sof()
makes USB frame rate close to 1kHz.
This way, no audio underrun are observed during audio playback.

Signed-off-by: Miguel GAIO <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 24c3833717d2528b98833bb5ebf4397a5512043f
      
https://github.com/qemu/qemu/commit/24c3833717d2528b98833bb5ebf4397a5512043f
  Author: Peter Maydell <address@hidden>
  Date:   2018-10-01 (Mon, 01 Oct 2018)

  Changed paths:
    M hw/usb/dev-hub.c
    M hw/usb/dev-mtp.c
    M hw/usb/hcd-ohci.c
    M qemu-doc.texi
    M scripts/device-crash-test

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/kraxel/tags/usb-20181001-pull-request' 
into staging

usb: fixes for mtp, hub and ohci.

# gpg: Signature made Mon 01 Oct 2018 10:28:36 BST
# gpg:                using RSA key 4CB6D8EED3E87138
# gpg: Good signature from "Gerd Hoffmann (work) <address@hidden>"
# gpg:                 aka "Gerd Hoffmann <address@hidden>"
# gpg:                 aka "Gerd Hoffmann (private) <address@hidden>"
# Primary key fingerprint: A032 8CFF B93A 17A7 9901  FE7D 4CB6 D8EE D3E8 7138

* remotes/kraxel/tags/usb-20181001-pull-request:
  ohci: set effectively usb frame rate to 1kHz
  usb-hub: clear suspend on detach
  usb-mtp: reset ObjectInfo dataset size on cleanup
  doc: replace x-root with rootdir for usb-mtp
  usb-mtp: fix error conditions for write operation

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/cc28dce2eccd...24c3833717d2
      **NOTE:** This service has been marked for deprecation: 
https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.