qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 681a1e: Makefile: Add missing dependency for


From: GitHub
Subject: [Qemu-commits] [qemu/qemu] 681a1e: Makefile: Add missing dependency for qemu-deprecat...
Date: Thu, 27 Sep 2018 01:48:41 -0700

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 681a1eafe27d7520818e3827ef87e093fb2387e0
      
https://github.com/qemu/qemu/commit/681a1eafe27d7520818e3827ef87e093fb2387e0
  Author: Thomas Huth <address@hidden>
  Date:   2018-09-25 (Tue, 25 Sep 2018)

  Changed paths:
    M Makefile

  Log Message:
  -----------
  Makefile: Add missing dependency for qemu-deprecated.texi

Make sure that the docs get correctly regenerated when the
file qemu-deprecated.texi has been changed.

Fixes: 44c67847e32c91a6071fb0440c357b9489f08bc6
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>
(cherry picked from commit f99ce85279178385f204a52236f855c879c29cdc)


  Commit: 101625a4d4ac7e96227a156bc5f6d21a9cc383cd
      
https://github.com/qemu/qemu/commit/101625a4d4ac7e96227a156bc5f6d21a9cc383cd
  Author: Thomas Huth <address@hidden>
  Date:   2018-09-25 (Tue, 25 Sep 2018)

  Changed paths:
    M net/net.c
    M qemu-deprecated.texi

  Log Message:
  -----------
  net: Deprecate the "name" parameter of -net

In early times, network backends were specified by a "vlan" and "name"
tuple. With the introduction of netdevs, the "name" was replaced by an
"id" (which is supposed to be unique), but the "name" parameter stayed
as an alias which could be used instead of "id". Unfortunately, we miss
the duplication check for "name":

 $ qemu-system-x86_64 -net user,name=n1 -net user,name=n1

... starts without an error, while "id" correctly complains:

 $ qemu-system-x86_64 -net user,id=n1 -net user,id=n1
 qemu-system-x86_64: -net user,id=n1: Duplicate ID 'n1' for net

Instead of trying to fix the code for the legacy "name" parameter, let's
rather get rid of this old interface and deprecate the "name" parameter
now - this will also be less confusing for the users in the long run.

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>


  Commit: 68cb29ea6585c6fb87ee598583c561cde246873b
      
https://github.com/qemu/qemu/commit/68cb29ea6585c6fb87ee598583c561cde246873b
  Author: Thomas Huth <address@hidden>
  Date:   2018-09-25 (Tue, 25 Sep 2018)

  Changed paths:
    M net/slirp.c
    M qemu-deprecated.texi

  Log Message:
  -----------
  net/slirp: Deprecate the [hub_id name] parameter tuple

The "name" in the [hub_id name] parameter tuple is the same as a
"netdev_id" (which should be unique), so specifying the hub_id here
is just redundant (it was likely just necessary in the past when
the network subsystem was still using "vlans" only and when it did
not use unique "id"s yet).

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>


  Commit: 91c082ad86e96ee342faaa024d46fd3e6242a98e
      
https://github.com/qemu/qemu/commit/91c082ad86e96ee342faaa024d46fd3e6242a98e
  Author: Thomas Huth <address@hidden>
  Date:   2018-09-25 (Tue, 25 Sep 2018)

  Changed paths:
    M hw/core/machine.c
    M qemu-deprecated.texi

  Log Message:
  -----------
  hw/core/machine: Officially deprecate the enforce-config-section parameter

Commit 16f7244842b5135543ef068a1adafd94c6965953 added this parameter
to the documentation, including a note that it is deprecated. But it
has never been added to the "Deprecated features" appendix, which is
our official way to deprecate legacy parameters. So let's do this now.

Reviewed-by: Peter Xu <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>


  Commit: 1e7ec6cf067025552bb10def7c49f4527d2f035f
      
https://github.com/qemu/qemu/commit/1e7ec6cf067025552bb10def7c49f4527d2f035f
  Author: Dima Stepanov <address@hidden>
  Date:   2018-09-25 (Tue, 25 Sep 2018)

  Changed paths:
    M util/memfd.c

  Log Message:
  -----------
  memfd: fix possible usage of the uninitialized file descriptor

The qemu_memfd_alloc_check() routine allocates the fd variable on stack.
This variable is initialized inside the qemu_memfd_alloc() function.
There are several cases when *fd will be left unintialized which can
lead to the unexpected close() in the qemu_memfd_free() call.

Set file descriptor to -1 before calling the qemu_memfd_alloc routine.

Signed-off-by: Dima Stepanov <address@hidden>
Reviewed-by: Marc-André Lureau <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>


  Commit: 55d38d10b84a256ca80484eb5114a4824608b85e
      
https://github.com/qemu/qemu/commit/55d38d10b84a256ca80484eb5114a4824608b85e
  Author: Thomas Huth <address@hidden>
  Date:   2018-09-25 (Tue, 25 Sep 2018)

  Changed paths:
    M block/blkreplay.c
    M pc-bios/hppa-firmware.img
    M pc-bios/palcode-clipper
    M pc-bios/u-boot-sam460-20100605.bin
    M pc-bios/u-boot.e500
    M replay/replay-char.c

  Log Message:
  -----------
  trivial: Make bios files and source files non-executable

These files can not be executed on the host, so they should not be
marked as executable.

Reviewed-by: David Hildenbrand <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>


  Commit: 963e64a486512914231a99716c8775c71e438e0c
      
https://github.com/qemu/qemu/commit/963e64a486512914231a99716c8775c71e438e0c
  Author: Stefan Weil <address@hidden>
  Date:   2018-09-25 (Tue, 25 Sep 2018)

  Changed paths:
    M docs/COLO-FT.txt
    M docs/interop/vhost-user.txt
    M docs/replay.txt

  Log Message:
  -----------
  docs: Fix some typos (most found by codespell)

Signed-off-by: Stefan Weil <address@hidden>
Reviewed-by: Peter Maydell <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>


  Commit: 6871a0d01f16871c67ea46d4264472cce345bb63
      
https://github.com/qemu/qemu/commit/6871a0d01f16871c67ea46d4264472cce345bb63
  Author: Li Qiang <address@hidden>
  Date:   2018-09-25 (Tue, 25 Sep 2018)

  Changed paths:
    M hw/core/qdev.c

  Log Message:
  -----------
  qdev: fix a typo in comment

Found by reading code.

Signed-off-by: Li Qiang <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>


  Commit: 6038f98904942a84d4a9cb03a2d84a5c1948343b
      
https://github.com/qemu/qemu/commit/6038f98904942a84d4a9cb03a2d84a5c1948343b
  Author: Thomas Huth <address@hidden>
  Date:   2018-09-25 (Tue, 25 Sep 2018)

  Changed paths:
    M include/hw/qdev-core.h

  Log Message:
  -----------
  hw/qdev-core: Fix description of instance_init

The part of the documentation of DeviceClass that talks about instance_init
is partly wrong: instance_init() functions must not abort or exit, since
the function is also called during introspection of the device already.
So if a device calls exit() during its instance_init() function, QEMU
terminates unexpectedly if somebody tries to just have a look at the
interfaces from the device with "device_add xyz,help" or with the
"device-list-properties" QOM command. This should never happen.

Reviewed-by: Andreas Färber <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>


  Commit: 2fc3ee6e3fadf1d578de7effb13d4200cc2b13a7
      
https://github.com/qemu/qemu/commit/2fc3ee6e3fadf1d578de7effb13d4200cc2b13a7
  Author: Thomas Huth <address@hidden>
  Date:   2018-09-25 (Tue, 25 Sep 2018)

  Changed paths:
    M tests/migration-test.c

  Log Message:
  -----------
  tests/migration: Speed up the test on ppc64

The SLOF boot process is always quite slow ... but we can speed it up
a little bit by specifying "-nodefaults" and by using the "nvramrc"
variable instead of "boot-command" (since "nvramrc" is evaluated earlier
in the SLOF boot process than "boot-command").

Reviewed-by: Dr. David Alan Gilbert <address@hidden>
Reviewed-by: Laurent Vivier <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>


  Commit: 72f911d47115041a38912b72ad9258157c6b9a2d
      
https://github.com/qemu/qemu/commit/72f911d47115041a38912b72ad9258157c6b9a2d
  Author: Thomas Huth <address@hidden>
  Date:   2018-09-25 (Tue, 25 Sep 2018)

  Changed paths:
    M tests/Makefile.include

  Log Message:
  -----------
  Revert "check: Move wdt_ib700 test to common"

This reverts commit ee1f6c812b3240420dff07a3860060b7d4abfe09.

The patch did not work as expected: The wdt_ib700 test is currently
not run at all anymore.

Signed-off-by: Thomas Huth <address@hidden>


  Commit: c9324bf5cff8f7889aecbb50bade42db5cea636b
      
https://github.com/qemu/qemu/commit/c9324bf5cff8f7889aecbb50bade42db5cea636b
  Author: Thomas Huth <address@hidden>
  Date:   2018-09-25 (Tue, 25 Sep 2018)

  Changed paths:
    M tests/Makefile.include

  Log Message:
  -----------
  Revert "check: Move endianess test to common"

This reverts commit 669cc7100065c690cb7b4f3da5cfc471d1ed4740.

The patch did not work as expected: The endianess test is currently
not run at all anymore.

Signed-off-by: Thomas Huth <address@hidden>


  Commit: deead96db50524cd5e90a515d151cc58abf5c109
      
https://github.com/qemu/qemu/commit/deead96db50524cd5e90a515d151cc58abf5c109
  Author: Thomas Huth <address@hidden>
  Date:   2018-09-25 (Tue, 25 Sep 2018)

  Changed paths:
    M tests/Makefile.include

  Log Message:
  -----------
  Revert "check: Move VMXNET3 test to common"

This reverts commit 7a066770f53c198014add869696427f81d67e9c2.

The patch did not work as expected: The vmxnet3 test is currently
not run at all anymore.

Signed-off-by: Thomas Huth <address@hidden>


  Commit: 866ba8385466a1a74ea4729e2a247c4c75584166
      
https://github.com/qemu/qemu/commit/866ba8385466a1a74ea4729e2a247c4c75584166
  Author: Peter Maydell <address@hidden>
  Date:   2018-09-25 (Tue, 25 Sep 2018)

  Changed paths:
    M Makefile
    M block/blkreplay.c
    M docs/COLO-FT.txt
    M docs/interop/vhost-user.txt
    M docs/replay.txt
    M hw/core/machine.c
    M hw/core/qdev.c
    M include/hw/qdev-core.h
    M net/net.c
    M net/slirp.c
    M pc-bios/hppa-firmware.img
    M pc-bios/palcode-clipper
    M pc-bios/u-boot-sam460-20100605.bin
    M pc-bios/u-boot.e500
    M qemu-deprecated.texi
    M replay/replay-char.c
    M tests/Makefile.include
    M tests/migration-test.c
    M util/memfd.c

  Log Message:
  -----------
  Merge remote-tracking branch 
'remotes/huth-gitlab/tags/pull-request-2018-09-25' into staging

- Deprecate the usage of a network backend via "name" instead of "id"
- Deprecate the "enforce-config-section" machine parameter
- Re-enable the wdt_ib700, endianness and vmxnet3 qtests
- Some trivial fixes and doc update patches that crossed my way

# gpg: Signature made Tue 25 Sep 2018 16:58:42 BST
# gpg:                using RSA key 2ED9D774FE702DB5
# gpg: Good signature from "Thomas Huth <address@hidden>"
# gpg:                 aka "Thomas Huth <address@hidden>"
# gpg:                 aka "Thomas Huth <address@hidden>"
# gpg:                 aka "Thomas Huth <address@hidden>"
# Primary key fingerprint: 27B8 8847 EEE0 2501 18F3  EAB9 2ED9 D774 FE70 2DB5

* remotes/huth-gitlab/tags/pull-request-2018-09-25:
  Revert "check: Move VMXNET3 test to common"
  Revert "check: Move endianess test to common"
  Revert "check: Move wdt_ib700 test to common"
  tests/migration: Speed up the test on ppc64
  hw/qdev-core: Fix description of instance_init
  qdev: fix a typo in comment
  docs: Fix some typos (most found by codespell)
  trivial: Make bios files and source files non-executable
  memfd: fix possible usage of the uninitialized file descriptor
  hw/core/machine: Officially deprecate the enforce-config-section parameter
  net/slirp: Deprecate the [hub_id name] parameter tuple
  net: Deprecate the "name" parameter of -net
  Makefile: Add missing dependency for qemu-deprecated.texi

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/c5e4e49258e9...866ba8385466
      **NOTE:** This service has been marked for deprecation: 
https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]