[Qemu-commits] [qemu/qemu] 3d7a1c: monitor: simplify monitor_qmp_setup_handlers_bh

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 3d7a1c44e2b23079485c0cd21ca2db04f886ec13
      
https://github.com/qemu/qemu/commit/3d7a1c44e2b23079485c0cd21ca2db04f886ec13
  Author: Peter Xu <address@hidden>
  Date:   2018-08-28 (Tue, 28 Aug 2018)

  Changed paths:
    M monitor.c

  Log Message:
  -----------
  monitor: simplify monitor_qmp_setup_handlers_bh

When we reach monitor_qmp_setup_handlers_bh() we must be using the
IOThread then, so no need to check against it any more.  Instead, we
assert.

Reviewed-by: Markus Armbruster <address@hidden>
Signed-off-by: Peter Xu <address@hidden>
Message-Id: <address@hidden>
[Insufficiently useful comment dropped]
Signed-off-by: Markus Armbruster <address@hidden>


  Commit: 8af6bb14a3a8bb40b0b3bf0171c018cd39026cb8
      
https://github.com/qemu/qemu/commit/8af6bb14a3a8bb40b0b3bf0171c018cd39026cb8
  Author: Marc-André Lureau <address@hidden>
  Date:   2018-08-28 (Tue, 28 Aug 2018)

  Changed paths:
    M monitor.c

  Log Message:
  -----------
  monitor: accept input on resume

A chardev may stop trying to write if the associated can_read()
callback returned 0. This happens when the monitor is suspended.
The frontend is supposed to call qemu_chr_fe_accept_input() when it is
ready to accept data again.

An issue was observed with a spice port: pending commands may be
delayed, as the chardev is not flushed. Most chardev don't use the
accept_input() callback, and instead check regularly if they can
write. The ones that do use it are braille, mux, msmouse,
spice (abstract), spicevmc, spiceport, wctablet.

Signed-off-by: Marc-André Lureau <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>


  Commit: 6cd112e26664994cb5eff207e765c9c3e55f73ea
      
https://github.com/qemu/qemu/commit/6cd112e26664994cb5eff207e765c9c3e55f73ea
  Author: Marc-André Lureau <address@hidden>
  Date:   2018-08-30 (Thu, 30 Aug 2018)

  Changed paths:
    M monitor.c

  Log Message:
  -----------
  monitor: consitify qmp_send_response() QDict argument

Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>


  Commit: 2aa788f5cb9e7fa24bed9091e7eae801f5c3ab04
      
https://github.com/qemu/qemu/commit/2aa788f5cb9e7fa24bed9091e7eae801f5c3ab04
  Author: Marc-André Lureau <address@hidden>
  Date:   2018-08-30 (Thu, 30 Aug 2018)

  Changed paths:
    M include/qapi/qmp/dispatch.h
    M qapi/qmp-dispatch.c

  Log Message:
  -----------
  qmp: constify qmp_is_oob()

Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>


  Commit: 27656018d8683d02175fa5b7911353645d64cd9d
      
https://github.com/qemu/qemu/commit/27656018d8683d02175fa5b7911353645d64cd9d
  Author: Marc-André Lureau <address@hidden>
  Date:   2018-08-30 (Thu, 30 Aug 2018)

  Changed paths:
    M monitor.c

  Log Message:
  -----------
  Revert "qmp: isolate responses into io thread"

This reverts commit abe3cd0ff7f774966da6842620806ab7576fe4f3.

There is no need to add an additional queue to send the reply to the
IOThread, because QMP response is thread safe, and chardev write path
is thread safe. It will schedule the watcher in the associated
IOThread.

Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>


  Commit: 176160ce78b58f29d765ddace885e88a732df34a
      
https://github.com/qemu/qemu/commit/176160ce78b58f29d765ddace885e88a732df34a
  Author: Marc-André Lureau <address@hidden>
  Date:   2018-08-30 (Thu, 30 Aug 2018)

  Changed paths:
    M monitor.c

  Log Message:
  -----------
  monitor: no need to save need_resume

There is no need for per-command need_resume granularity, it should
resume after running an non-oob command on oob-disabled monitor.

Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>


  Commit: efd1d5229fbf09f2ef535df024ccaa620a013f86
      
https://github.com/qemu/qemu/commit/efd1d5229fbf09f2ef535df024ccaa620a013f86
  Author: Peter Maydell <address@hidden>
  Date:   2018-09-24 (Mon, 24 Sep 2018)

  Changed paths:
    M include/qapi/qmp/dispatch.h
    M monitor.c
    M qapi/qmp-dispatch.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/armbru/tags/pull-monitor-2018-09-01' 
into staging

Monitor patches for 2018-09-01

# gpg: Signature made Sat 01 Sep 2018 12:06:52 BST
# gpg:                using RSA key 3870B400EB918653
# gpg: Good signature from "Markus Armbruster <address@hidden>"
# gpg:                 aka "Markus Armbruster <address@hidden>"
# Primary key fingerprint: 354B C8B3 D7EB 2A6B 6867  4E5F 3870 B400 EB91 8653

* remotes/armbru/tags/pull-monitor-2018-09-01:
  monitor: no need to save need_resume
  Revert "qmp: isolate responses into io thread"
  qmp: constify qmp_is_oob()
  monitor: consitify qmp_send_response() QDict argument
  monitor: accept input on resume
  monitor: simplify monitor_qmp_setup_handlers_bh

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/d6f71af65410...efd1d5229fbf
      **NOTE:** This service has been marked for deprecation: 
https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.