qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 2313e4: ui/sdl2: Remove the obsolete SDL_INIT


From: GitHub
Subject: [Qemu-commits] [qemu/qemu] 2313e4: ui/sdl2: Remove the obsolete SDL_INIT_NOPARACHUTE ...
Date: Mon, 27 Aug 2018 06:55:28 -0700

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 2313e482e12288202762495050040952b6e07431
      
https://github.com/qemu/qemu/commit/2313e482e12288202762495050040952b6e07431
  Author: Thomas Huth <address@hidden>
  Date:   2018-08-24 (Fri, 24 Aug 2018)

  Changed paths:
    M ui/sdl2.c

  Log Message:
  -----------
  ui/sdl2: Remove the obsolete SDL_INIT_NOPARACHUTE flag

SDL_INIT_NOPARACHUTE is not used in SDL2 anymore, and the define is just
a dummy (see https://wiki.libsdl.org/MigrationGuide#Some_general_truths
for example). So we can remove it and get rid of the "flags" variable
nowadays.

Signed-off-by: Thomas Huth <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 0ae0b069aa8f23a138cc6d2d83edaa5c22f948a5
      
https://github.com/qemu/qemu/commit/0ae0b069aa8f23a138cc6d2d83edaa5c22f948a5
  Author: Peter Wu <address@hidden>
  Date:   2018-08-24 (Fri, 24 Aug 2018)

  Changed paths:
    M ui/vnc-jobs.c

  Log Message:
  -----------
  vnc: fix memleak of the "vnc-worker-output" name

Fixes repeated memory leaks of 18 bytes when using VNC:

    Direct leak of 831024 byte(s) in 46168 object(s) allocated from:
  ...
  #4 0x7f6d2f919bdd in g_strdup_vprintf glib/gstrfuncs.c:514
  #5 0x56085cdcf660 in buffer_init util/buffer.c:59
  #6 0x56085ca6a7ec in vnc_async_encoding_start ui/vnc-jobs.c:177
  #7 0x56085ca6b815 in vnc_worker_thread_loop ui/vnc-jobs.c:240

Fixes: 543b95801f98 ("vnc: attach names to buffers")
Cc: Gerd Hoffmann <address@hidden>
CC: address@hidden
Signed-off-by: Peter Wu <address@hidden>
Reviewed-by: Marc-André Lureau <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: c809d1d2f4e3d40d4767871d3cf9cd78391e5a4f
      
https://github.com/qemu/qemu/commit/c809d1d2f4e3d40d4767871d3cf9cd78391e5a4f
  Author: Marc-André Lureau <address@hidden>
  Date:   2018-08-24 (Fri, 24 Aug 2018)

  Changed paths:
    M qemu-keymap.c
    M ui/console.c

  Log Message:
  -----------
  ui: use enum to string helpers

Minor code simplification.

Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 77f60fb436ca773ce6f57d37c022ad792445e644
      
https://github.com/qemu/qemu/commit/77f60fb436ca773ce6f57d37c022ad792445e644
  Author: Tao Wu <address@hidden>
  Date:   2018-08-24 (Fri, 24 Aug 2018)

  Changed paths:
    M ui/sdl2-gl.c

  Log Message:
  -----------
  sdl2: redraw correctly when scanout_mode enabled.

When scanout_mode enabled, surface is out of sync with actual screen.
In such case, we just call sdl2_gl_scanout_flush to do redraw. This
fixes bug reported in
https://lists.freedesktop.org/archives/virglrenderer-devel/2018-July/001330.html

Signed-off-by: Tao Wu <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 756b9da71958ea0c8b465e8c7f124c1365010922
      
https://github.com/qemu/qemu/commit/756b9da71958ea0c8b465e8c7f124c1365010922
  Author: Daniel P. Berrangé <address@hidden>
  Date:   2018-08-24 (Fri, 24 Aug 2018)

  Changed paths:
    M qemu-doc.texi

  Log Message:
  -----------
  doc: switch to modern syntax for VNC TLS setup

The use of 'tls', 'x509' and 'x509verify' properties is the deprecated
backcompat syntax, replaced by use of TLS creds objects.

Signed-off-by: Daniel P. Berrangé <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: ec86faa934cb31d97f738134547137f16d17c0d0
      
https://github.com/qemu/qemu/commit/ec86faa934cb31d97f738134547137f16d17c0d0
  Author: Daniel P. Berrangé <address@hidden>
  Date:   2018-08-24 (Fri, 24 Aug 2018)

  Changed paths:
    M qemu-deprecated.texi
    M qemu-options.hx
    M ui/vnc.c

  Log Message:
  -----------
  vnc: remove support for deprecated tls, x509, x509verify options

The 'tls-creds' option accepts the name of a TLS credentials
object. This replaced the usage of 'tls', 'x509' and 'x509verify'
options in 2.5.0. These deprecated options were grandfathered in
when the deprecation policy was introduded in 2.10.0, so can now
finally be removed.

Signed-off-by: Daniel P. Berrangé <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 2480f41e685690511f8f15bbeabb6cdc0b2ddaf0
      
https://github.com/qemu/qemu/commit/2480f41e685690511f8f15bbeabb6cdc0b2ddaf0
  Author: Paolo Bonzini <address@hidden>
  Date:   2018-08-24 (Fri, 24 Aug 2018)

  Changed paths:
    M ui/spice-display.c

  Log Message:
  -----------
  spice-display: access ptr_x/ptr_y under Mutex

The OpenGL-enabled SPICE code was not accessing the cursor position
under the SimpleSpiceDisplay lock.  Fix this.

Signed-off-by: Paolo Bonzini <address@hidden>
Reviewed-by: Marc-André Lureau <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 006bf4641b553565990a6b18e0cff36972a36773
      
https://github.com/qemu/qemu/commit/006bf4641b553565990a6b18e0cff36972a36773
  Author: Paolo Bonzini <address@hidden>
  Date:   2018-08-24 (Fri, 24 Aug 2018)

  Changed paths:
    M ui/spice-display.c

  Log Message:
  -----------
  spice-display: fix qemu_spice_cursor_refresh_bh locking

spice-display should not call the ui/console.c functions dpy_cursor_define
and dpy_moues_set with the SimpleSpiceDisplay lock taken.  That will cause
a deadlock, because the DisplayChangeListener callbacks will take the lock
again.  It is also in general a bad idea to invoke generic callbacks with a
lock taken, because it can cause AB-BA deadlocks in the long run.  The only
thing that requires care is that the cursor may disappear as soon as the
mutex is released, so you need an extra cursor_get/cursor_put pair.

Signed-off-by: Paolo Bonzini <address@hidden>
Reviewed-by: Marc-André Lureau <address@hidden>
Message-id: address@hidden

[ kraxel: fix dpy_cursor_define() call ]

Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 6fb34ffcaae0823304b2e9dd96ea67e59d11b780
      
https://github.com/qemu/qemu/commit/6fb34ffcaae0823304b2e9dd96ea67e59d11b780
  Author: Thomas Huth <address@hidden>
  Date:   2018-08-24 (Fri, 24 Aug 2018)

  Changed paths:
    M ui/sdl2.c

  Log Message:
  -----------
  ui/sdl2: Fix broken -full-screen CLI option

We've got to set the gui_fullscreen variable before creating the
SDL2 window, otherwise the initial window will not be created in
fullscreen mode.

Buglink: https://bugs.launchpad.net/bugs/1780812
Signed-off-by: Thomas Huth <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 949ed4c227395473cdd3748cc62f4e96bfc9c142
      
https://github.com/qemu/qemu/commit/949ed4c227395473cdd3748cc62f4e96bfc9c142
  Author: Philippe Mathieu-Daudé <address@hidden>
  Date:   2018-08-24 (Fri, 24 Aug 2018)

  Changed paths:
    M ui/vnc-enc-tight.c
    M ui/vnc.c

  Log Message:
  -----------
  ui/vnc: Remove useless parenthesis around DIV_ROUND_UP macro

Patch created mechanically by rerunning:

  $  spatch --sp-file scripts/coccinelle/round.cocci \
      --macro-file scripts/cocci-macro-file.h \
      --dir . --in-place

Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 242d01336d6e706a26f5370464902a3f8ceba222
      
https://github.com/qemu/qemu/commit/242d01336d6e706a26f5370464902a3f8ceba222
  Author: Marc-André Lureau <address@hidden>
  Date:   2018-08-24 (Fri, 24 Aug 2018)

  Changed paths:
    M include/ui/console.h
    M ui/spice-display.c

  Log Message:
  -----------
  dmabuf: add y0_top, pass it to spice

Some scanouts during boot are top-down without it.

y0_top is set from VHOST_USER_GPU_DMABUF_SCANOUT code path in the last
patch of this series.

In current QEMU code base, only vfio/display uses dmabuf API. But the
VFIO query interface doesn't provide or need that detail so far.

Signed-off-by: Marc-André Lureau <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: b1d380372f31672da9318431e84e79bccd8ef3bf
      
https://github.com/qemu/qemu/commit/b1d380372f31672da9318431e84e79bccd8ef3bf
  Author: Marc-André Lureau <address@hidden>
  Date:   2018-08-27 (Mon, 27 Aug 2018)

  Changed paths:
    M MAINTAINERS
    A include/qemu/drm.h
    M ui/egl-helpers.c
    M util/Makefile.objs
    A util/drm.c

  Log Message:
  -----------
  util: promote qemu_egl_rendernode_open() to libqemuutil

vhost-user-gpu will share the same code to open a DRM node.

Signed-off-by: Marc-André Lureau <address@hidden>
Message-Id: <address@hidden>

[ kraxel: buildfix: util/drm.o must be CONFIG_OPENGL not CONFIG_LINUX ]

Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 025573be71dab8d7885b787a6ca52d6d9bbfd75c
      
https://github.com/qemu/qemu/commit/025573be71dab8d7885b787a6ca52d6d9bbfd75c
  Author: Peter Maydell <address@hidden>
  Date:   2018-08-27 (Mon, 27 Aug 2018)

  Changed paths:
    M MAINTAINERS
    A include/qemu/drm.h
    M include/ui/console.h
    M qemu-deprecated.texi
    M qemu-doc.texi
    M qemu-keymap.c
    M qemu-options.hx
    M ui/console.c
    M ui/egl-helpers.c
    M ui/sdl2-gl.c
    M ui/sdl2.c
    M ui/spice-display.c
    M ui/vnc-enc-tight.c
    M ui/vnc-jobs.c
    M ui/vnc.c
    M util/Makefile.objs
    A util/drm.c

  Log Message:
  -----------
  Merge remote-tracking branch 
'remotes/kraxel/tags/ui-20180827-v4-pull-request' into staging

ui: misc fixes which piled up during 3.0 release freeze

# gpg: Signature made Mon 27 Aug 2018 09:53:07 BST
# gpg:                using RSA key 4CB6D8EED3E87138
# gpg: Good signature from "Gerd Hoffmann (work) <address@hidden>"
# gpg:                 aka "Gerd Hoffmann <address@hidden>"
# gpg:                 aka "Gerd Hoffmann (private) <address@hidden>"
# Primary key fingerprint: A032 8CFF B93A 17A7 9901  FE7D 4CB6 D8EE D3E8 7138

* remotes/kraxel/tags/ui-20180827-v4-pull-request:
  util: promote qemu_egl_rendernode_open() to libqemuutil
  dmabuf: add y0_top, pass it to spice
  ui/vnc: Remove useless parenthesis around DIV_ROUND_UP macro
  ui/sdl2: Fix broken -full-screen CLI option
  spice-display: fix qemu_spice_cursor_refresh_bh locking
  spice-display: access ptr_x/ptr_y under Mutex
  vnc: remove support for deprecated tls, x509, x509verify options
  doc: switch to modern syntax for VNC TLS setup
  sdl2: redraw correctly when scanout_mode enabled.
  ui: use enum to string helpers
  vnc: fix memleak of the "vnc-worker-output" name
  ui/sdl2: Remove the obsolete SDL_INIT_NOPARACHUTE flag

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/235c82acca04...025573be71da
      **NOTE:** This service has been marked for deprecation: 
https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]