[Qemu-commits] [qemu/qemu] 8a85e5: linux-user: Remove DEBUG

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 8a85e5dd3b3e11a6f92f70a7ec4fb7c871885206
      
https://github.com/qemu/qemu/commit/8a85e5dd3b3e11a6f92f70a7ec4fb7c871885206
  Author: Richard Henderson <address@hidden>
  Date:   2018-08-21 (Tue, 21 Aug 2018)

  Changed paths:
    M linux-user/syscall.c

  Log Message:
  -----------
  linux-user: Remove DEBUG

This is redundant with both -strace and actual tracing.

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Laurent Vivier <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>


  Commit: dc1ce18b2bfcd4a759a4cb8c0fc513be887a679b
      
https://github.com/qemu/qemu/commit/dc1ce18b2bfcd4a759a4cb8c0fc513be887a679b
  Author: Richard Henderson <address@hidden>
  Date:   2018-08-21 (Tue, 21 Aug 2018)

  Changed paths:
    M linux-user/syscall.c

  Log Message:
  -----------
  linux-user: Split out do_syscall1

There was supposed to be a single point of return for do_syscall
so that tracing works properly.  However, there are a few bugs
in that area.  It is significantly simpler to simply split out
an inner function to enforce this.

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Laurent Vivier <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>


  Commit: 72eb7ea8f9e97313555b4bc2aa638330c725679a
      
https://github.com/qemu/qemu/commit/72eb7ea8f9e97313555b4bc2aa638330c725679a
  Author: Richard Henderson <address@hidden>
  Date:   2018-08-21 (Tue, 21 Aug 2018)

  Changed paths:
    M linux-user/syscall.c

  Log Message:
  -----------
  linux-user: Relax single exit from "break"

Transform outermost "break" to "return ret".  If the immediately
preceeding statement was an assignment to ret, return the value
directly.

Reviewed-by: Laurent Vivier <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>


  Commit: 2852aafd9d05d97accd7a1d4df8ff25d9ac4cbfc
      
https://github.com/qemu/qemu/commit/2852aafd9d05d97accd7a1d4df8ff25d9ac4cbfc
  Author: Richard Henderson <address@hidden>
  Date:   2018-08-21 (Tue, 21 Aug 2018)

  Changed paths:
    M linux-user/syscall.c

  Log Message:
  -----------
  linux-user: Propagate goto efault to return

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Laurent Vivier <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>


  Commit: 10f45d98f28cb28a00fc646e6ad415d2a62487f9
      
https://github.com/qemu/qemu/commit/10f45d98f28cb28a00fc646e6ad415d2a62487f9
  Author: Richard Henderson <address@hidden>
  Date:   2018-08-21 (Tue, 21 Aug 2018)

  Changed paths:
    M linux-user/syscall.c

  Log Message:
  -----------
  linux-user: Propagate goto unimplemented_nowarn to return

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Laurent Vivier <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>


  Commit: 1a7b2b13c907392078115401f5f2a2a3ce1ce7cb
      
https://github.com/qemu/qemu/commit/1a7b2b13c907392078115401f5f2a2a3ce1ce7cb
  Author: Richard Henderson <address@hidden>
  Date:   2018-08-21 (Tue, 21 Aug 2018)

  Changed paths:
    M linux-user/syscall.c

  Log Message:
  -----------
  linux-user: Propagate goto unimplemented to default

There is no point in listing a syscall if you want the same effect as
not listing it.  In one less trivial case, the goto was demonstrably
not reachable.

Reviewed-by: Peter Maydell <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
Reviewed-by: Laurent Vivier <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>


  Commit: 259841c153698325e12f0186f349e1366616434e
      
https://github.com/qemu/qemu/commit/259841c153698325e12f0186f349e1366616434e
  Author: Richard Henderson <address@hidden>
  Date:   2018-08-21 (Tue, 21 Aug 2018)

  Changed paths:
    M linux-user/syscall.c

  Log Message:
  -----------
  linux-user: Propagate goto fail to return

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Laurent Vivier <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>


  Commit: 3392fbee4e435658733bbe9aab23392660558b59
      
https://github.com/qemu/qemu/commit/3392fbee4e435658733bbe9aab23392660558b59
  Author: Peter Maydell <address@hidden>
  Date:   2018-08-23 (Thu, 23 Aug 2018)

  Changed paths:
    M linux-user/syscall.c

  Log Message:
  -----------
  Merge remote-tracking branch 
'remotes/vivier2/tags/linux-user-for-3.1-pull-request' into staging

This pull-request includes pre-requisite patches for the
"split do_syscall()" series. As they are clean-up, we can already
merge them.

# gpg: Signature made Wed 22 Aug 2018 02:12:08 BST
# gpg:                using RSA key F30C38BD3F2FBE3C
# gpg: Good signature from "Laurent Vivier <address@hidden>"
# gpg:                 aka "Laurent Vivier <address@hidden>"
# gpg:                 aka "Laurent Vivier (Red Hat) <address@hidden>"
# Primary key fingerprint: CD2F 75DD C8E3 A4DC 2E4F  5173 F30C 38BD 3F2F BE3C

* remotes/vivier2/tags/linux-user-for-3.1-pull-request:
  linux-user: Propagate goto fail to return
  linux-user: Propagate goto unimplemented to default
  linux-user: Propagate goto unimplemented_nowarn to return
  linux-user: Propagate goto efault to return
  linux-user: Relax single exit from "break"
  linux-user: Split out do_syscall1
  linux-user: Remove DEBUG

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/78ee443e5290...3392fbee4e43
      **NOTE:** This service has been marked for deprecation: 
https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.