[Qemu-commits] [qemu/qemu] 95c94f: docs/usb2.txt: ehci has six ports

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 95c94f8968325390d63b3c407584e91e6d7fb010
      
https://github.com/qemu/qemu/commit/95c94f8968325390d63b3c407584e91e6d7fb010
  Author: npes87184 <address@hidden>
  Date:   2018-08-21 (Tue, 21 Aug 2018)

  Changed paths:
    M docs/usb2.txt

  Log Message:
  -----------
  docs/usb2.txt: ehci has six ports

In commit 5cc194caeb019cf1dae7f74ccbdf0401a56c2ac6,
the number of ehci ports is corrected to six. Fix docs
related to it.

Signed-off-by: npes87184 <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 7c48b95df47458d10726d6dca0c4c33eb5eace40
      
https://github.com/qemu/qemu/commit/7c48b95df47458d10726d6dca0c4c33eb5eace40
  Author: Sebastian Bauer <address@hidden>
  Date:   2018-08-21 (Tue, 21 Aug 2018)

  Changed paths:
    M hw/usb/hcd-ohci.c

  Log Message:
  -----------
  ohci: Clear the interrupt counter for erroneous transfers

This is mandated by the ohci specification. It tells at 6.4.4 on page 104
that for transfer descriptors that are retired with an error the done
queue interrupt counter is cleared as if the interrupt delay field of the
descriptions were zero.

Before this change, error conditions were handled similarly to the
successful condition which is especially troublesome for control transfers.
Some drivers (e.g., the AmigaOS-one) as well as the example code in the
spec, set the setup stage with an interrupt delay of seven (which means no
interrupt). This is fine under normal conditions, because one usually
doesn't want to be notified about the completion of this stage. However, if
an error occurs in this stage, these drivers will not get notified with the
current implementation. The fix addresses this by following the spec more
closely. Also, otherwise, the ability to set interrupt delay to seven would
be useless.

Note that Linux drivers that I looked at don't seem to be affected as they
set six as the interrupt delay presumably for the reason that they won't
get notified otherwise.

Signed-off-by: Sebastian Bauer <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 47bff13cea8dd3e6ae869c3203723d93bd734637
      
https://github.com/qemu/qemu/commit/47bff13cea8dd3e6ae869c3203723d93bd734637
  Author: Bandan Das <address@hidden>
  Date:   2018-08-21 (Tue, 21 Aug 2018)

  Changed paths:
    M hw/usb/dev-mtp.c

  Log Message:
  -----------
  dev-mtp: add support for canceling transaction

The initiator can choose to cancel an ongoing request which
is specified by bRequest=0x64. If such a request arrives,
free up any pending state

Signed-off-by: Bandan Das <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 406f35d7fcf5f029780d2e0cc9fa0cc37856d57c
      
https://github.com/qemu/qemu/commit/406f35d7fcf5f029780d2e0cc9fa0cc37856d57c
  Author: Bandan Das <address@hidden>
  Date:   2018-08-21 (Tue, 21 Aug 2018)

  Changed paths:
    M hw/usb/dev-mtp.c

  Log Message:
  -----------
  dev-mtp: fix buffer allocation for writing file contents

usb_mtp_realloc() was being incorrectly used when allocating
buffer for incoming data. Set d->length only after resizing
the buffer.

Signed-off-by: Bandan Das <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: d33e3e4bf8df7a7f1bd538bc19d17c8c21f14df2
      
https://github.com/qemu/qemu/commit/d33e3e4bf8df7a7f1bd538bc19d17c8c21f14df2
  Author: Bandan Das <address@hidden>
  Date:   2018-08-21 (Tue, 21 Aug 2018)

  Changed paths:
    M hw/usb/dev-mtp.c

  Log Message:
  -----------
  dev-mtp: retry write for incomplete transfers

For large buffers, write may not copy the full buffer. For example,
on Linux, write imposes a limit of 0x7ffff000. Note that this does
not fix >4G transfers but ~>2G files will transfer successfully.

Signed-off-by: Bandan Das <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 3e096650a64daaac261c289b569362b06995e379
      
https://github.com/qemu/qemu/commit/3e096650a64daaac261c289b569362b06995e379
  Author: Bandan Das <address@hidden>
  Date:   2018-08-21 (Tue, 21 Aug 2018)

  Changed paths:
    M hw/usb/dev-mtp.c

  Log Message:
  -----------
  dev-mtp: Add support for > 4GB file transfers

To support larger file transfers, rely on a short packet
to detect end of the data phase and rewrite d->length to
the size received

Signed-off-by: Bandan Das <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 15aa757d0523b9d6fb26ea1e5c967ba0619dce0a
      
https://github.com/qemu/qemu/commit/15aa757d0523b9d6fb26ea1e5c967ba0619dce0a
  Author: Bandan Das <address@hidden>
  Date:   2018-08-21 (Tue, 21 Aug 2018)

  Changed paths:
    M hw/usb/dev-mtp.c

  Log Message:
  -----------
  dev-mtp: rename x-root to rootdir

x-root was renamed as such owing to the experimental nature of the
property; the underlying filesystem semantics were undecided

Signed-off-by: Bandan Das <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 78ee443e52907ec540e3e40edbf8456a3b0ec14b
      
https://github.com/qemu/qemu/commit/78ee443e52907ec540e3e40edbf8456a3b0ec14b
  Author: Peter Maydell <address@hidden>
  Date:   2018-08-21 (Tue, 21 Aug 2018)

  Changed paths:
    M docs/usb2.txt
    M hw/usb/dev-mtp.c
    M hw/usb/hcd-ohci.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/kraxel/tags/usb-20180821-pull-request' 
into staging

usb: mtp write support, bugfixes.

# gpg: Signature made Tue 21 Aug 2018 10:11:36 BST
# gpg:                using RSA key 4CB6D8EED3E87138
# gpg: Good signature from "Gerd Hoffmann (work) <address@hidden>"
# gpg:                 aka "Gerd Hoffmann <address@hidden>"
# gpg:                 aka "Gerd Hoffmann (private) <address@hidden>"
# Primary key fingerprint: A032 8CFF B93A 17A7 9901  FE7D 4CB6 D8EE D3E8 7138

* remotes/kraxel/tags/usb-20180821-pull-request:
  dev-mtp: rename x-root to rootdir
  dev-mtp: Add support for > 4GB file transfers
  dev-mtp: retry write for incomplete transfers
  dev-mtp: fix buffer allocation for writing file contents
  dev-mtp: add support for canceling transaction
  ohci: Clear the interrupt counter for erroneous transfers
  docs/usb2.txt: ehci has six ports

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/13b7b188501d...78ee443e5290
      **NOTE:** This service has been marked for deprecation: 
https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.