qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 3aeaac: machine: Fix coding style at machine_


From: GitHub
Subject: [Qemu-commits] [qemu/qemu] 3aeaac: machine: Fix coding style at machine_run_board_ini...
Date: Mon, 20 Aug 2018 02:26:16 -0700

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 3aeaac8fa2d008a1f55b040fde6d4ec06f2f5146
      
https://github.com/qemu/qemu/commit/3aeaac8fa2d008a1f55b040fde6d4ec06f2f5146
  Author: Dou Liyang <address@hidden>
  Date:   2018-08-16 (Thu, 16 Aug 2018)

  Changed paths:
    M hw/core/machine.c

  Log Message:
  -----------
  machine: Fix coding style at machine_run_board_init()

Commit 7747abf11487 ("hw/machine: Remove the Zero check of
nb_numa_nodes for numa_complete_configuration()") removed the
curly brackets.  Re-add them.

Signed-off-by: Dou Liyang <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Igor Mammedov <address@hidden>
[ehabkost: rewrote commit message]
Signed-off-by: Eduardo Habkost <address@hidden>


  Commit: be64d7776bcc48a542acf1f74765a3930692cef4
      
https://github.com/qemu/qemu/commit/be64d7776bcc48a542acf1f74765a3930692cef4
  Author: Mark Cave-Ayland <address@hidden>
  Date:   2018-08-16 (Thu, 16 Aug 2018)

  Changed paths:
    M hw/core/sysbus.c

  Log Message:
  -----------
  sysbus: always allow explicit_ofw_unit_address() to override address 
generation

Some SysBusDevices either use sysbus_init_mmio() without
sysbus_mmio_map() or the first MMIO memory region doesn't represent the
bus address, causing a firmware device path with an invalid address to
be generated.

SysBusDeviceClass does provide a virtual explicit_ofw_unit_address()
method that can be used to override this process, but it was originally intended
only as as a fallback option meaning that any existing MMIO memory regions still
take priority whilst determining the firmware device address.

There is currently only one user of explicit_ofw_unit_address() and that
is the PCI expander bridge (PXB) device which has no MMIO/PIO resources
defined. This enables us to allow explicit_ofw_unit_address() to take
priority without affecting backwards compatibility, allowing the address
to be customised as required.

Signed-off-by: Mark Cave-Ayland <address@hidden>
Reviewed-by: Laszlo Ersek <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>
Reviewed-by: Eduardo Habkost <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>


  Commit: 907aac2f6af6ef775367c368b87cc1720e39d407
      
https://github.com/qemu/qemu/commit/907aac2f6af6ef775367c368b87cc1720e39d407
  Author: Mark Cave-Ayland <address@hidden>
  Date:   2018-08-16 (Thu, 16 Aug 2018)

  Changed paths:
    M bootdevice.c
    M hw/nvram/fw_cfg.c
    M hw/ppc/spapr.c
    M include/hw/boards.h
    M include/sysemu/sysemu.h

  Log Message:
  -----------
  fw_cfg: ignore suffixes in the bootdevice list dependent on machine class

For the older machines (such as Mac and SPARC) the DT nodes representing
bootdevices for disk nodes are irregular for mainly historical reasons.

Since the majority of bootdevice nodes for these machines either do not have a
separate disk node or require different (custom) names then it is much easier
for processing to just disable all suffixes for a particular machine.

Introduce a new ignore_boot_device_suffixes MachineClass property to control
bootdevice suffix generation, defaulting to false in order to preserve
compatibility.

Suggested-by: Eduardo Habkost <address@hidden>
Signed-off-by: Mark Cave-Ayland <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Laszlo Ersek <address@hidden>
Acked-by: David Gibson <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>


  Commit: adaec191bfb31e12d40af8ab1b869f5b40d61ee9
      
https://github.com/qemu/qemu/commit/adaec191bfb31e12d40af8ab1b869f5b40d61ee9
  Author: Peter Maydell <address@hidden>
  Date:   2018-08-20 (Mon, 20 Aug 2018)

  Changed paths:
    M bootdevice.c
    M hw/core/machine.c
    M hw/core/sysbus.c
    M hw/nvram/fw_cfg.c
    M hw/ppc/spapr.c
    M include/hw/boards.h
    M include/sysemu/sysemu.h

  Log Message:
  -----------
  Merge remote-tracking branch 
'remotes/ehabkost/tags/machine-next-pull-request' into staging

Machine queue, 2018-08-17

* Allow machine classes to specify if boot device suffixes should
  be ignored by get_boot_devices_list()
* Tiny coding style fixup

# gpg: Signature made Fri 17 Aug 2018 19:29:22 BST
# gpg:                using RSA key 2807936F984DC5A6
# gpg: Good signature from "Eduardo Habkost <address@hidden>"
# Primary key fingerprint: 5A32 2FD5 ABC4 D3DB ACCF  D1AA 2807 936F 984D C5A6

* remotes/ehabkost/tags/machine-next-pull-request:
  fw_cfg: ignore suffixes in the bootdevice list dependent on machine class
  sysbus: always allow explicit_ofw_unit_address() to override address 
generation
  machine: Fix coding style at machine_run_board_init()

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/a544c9110d39...adaec191bfb3
      **NOTE:** This service has been marked for deprecation: 
https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]