qemu-commits
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 317c52: monitor: report entirety of hmp comma

From: GitHub
Subject: [Qemu-commits] [qemu/qemu] 317c52: monitor: report entirety of hmp command on error
Date: Fri, 22 Jun 2018 06:16:55 -0700 
  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 317c52cc6aa0d7b47fa156eb84857a339d0b4406
      
https://github.com/qemu/qemu/commit/317c52cc6aa0d7b47fa156eb84857a339d0b4406
  Author: Collin Walling <address@hidden>
  Date:   2018-06-21 (Thu, 21 Jun 2018)

  Changed paths:
    M monitor.c

  Log Message:
  -----------
  monitor: report entirety of hmp command on error

When a user incorrectly provides an hmp command, an error response will be
printed that prompts the user to try "help <command name>". However, when
the command contains multiple parts e.g. "info uuid xyz", only the last
whitespace delimited string will be reported (in this example "info" will
be dropped and the message will read "Try "help uuid" for more information",
which is incorrect).

Let's correct this by capturing the entirety of the command from the command
line -- excluding any extraneous characters.

Reported-by: Mikhail Fokin <address@hidden>
Signed-off-by: Collin Walling <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Signed-off-by: Dr. David Alan Gilbert <address@hidden>


  Commit: 65fa57b09bec6f638c77bdf031698189a1ad050c
      
https://github.com/qemu/qemu/commit/65fa57b09bec6f638c77bdf031698189a1ad050c
  Author: Suraj Jitindar Singh <address@hidden>
  Date:   2018-06-21 (Thu, 21 Jun 2018)

  Changed paths:
    M hmp-commands.hx

  Log Message:
  -----------
  hmp-commands: use long for begin and length in dump-guest-memory

The dump-guest-memory command is used to dump an area of guest memory
to a file, the piece of memory is specified by a begin address and
a length. These parameters are specified as ints and thus have a maximum
value of 4GB. This means you can't dump the guest memory past the first
4GB and instead get:
(qemu) dump-guest-memory tmp 0x100000000 0x100000000
'dump-guest-memory' has failed: integer is for 32-bit values
Try "help dump-guest-memory" for more information

This limitation is imposed in monitor_parse_arguments() since they are
both ints. hmp_dump_guest_memory() uses 64 bit quantities to store both
the begin and length values. Thus specify begin and length as long so
that the entire guest memory space can be dumped.

Signed-off-by: Suraj Jitindar Singh <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
Signed-off-by: Dr. David Alan Gilbert <address@hidden>


  Commit: c3120f715db9dc351bde89b8a9d992cfeccb4680
      
https://github.com/qemu/qemu/commit/c3120f715db9dc351bde89b8a9d992cfeccb4680
  Author: Dr. David Alan Gilbert <address@hidden>
  Date:   2018-06-21 (Thu, 21 Jun 2018)

  Changed paths:
    M monitor.c

  Log Message:
  -----------
  hmp: Add flag for preconfig commands

Add a flag to command definitions to allow them to be used in preconfig
and check it.
If users try to use commands that aren't available, tell them to use
the exit_preconfig comand we're adding in a few patches.

Signed-off-by: Dr. David Alan Gilbert <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Reviewed-by: Igor Mammedov <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Dr. David Alan Gilbert <address@hidden>


  Commit: 31785f1b030b62ec84e1c852eaeeabbae1232345
      
https://github.com/qemu/qemu/commit/31785f1b030b62ec84e1c852eaeeabbae1232345
  Author: Dr. David Alan Gilbert <address@hidden>
  Date:   2018-06-21 (Thu, 21 Jun 2018)

  Changed paths:
    M hmp-commands.hx
    M monitor.c

  Log Message:
  -----------
  hmp: Allow help on preconfig commands

Allow the 'help' command in preconfig state but
make it only list the preconfig commands.

Signed-off-by: Dr. David Alan Gilbert <address@hidden>
Reviewed-by: Peter Xu <address@hidden>
Reviewed-by: Igor Mammedov <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Dr. David Alan Gilbert <address@hidden>


  Commit: 6d9f7839b7e6c364536d22beb2ca1277772813a6
      
https://github.com/qemu/qemu/commit/6d9f7839b7e6c364536d22beb2ca1277772813a6
  Author: Dr. David Alan Gilbert <address@hidden>
  Date:   2018-06-21 (Thu, 21 Jun 2018)

  Changed paths:
    M monitor.c

  Log Message:
  -----------
  hmp: Restrict auto-complete in preconfig

Don't show the commands that aren't available.

Signed-off-by: Dr. David Alan Gilbert <address@hidden>
Reviewed-by: Peter Xu <address@hidden>
Reviewed-by: Igor Mammedov <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Dr. David Alan Gilbert <address@hidden>


  Commit: a87706c83a0101d59eb8dafe998152bbd66aeec8
      
https://github.com/qemu/qemu/commit/a87706c83a0101d59eb8dafe998152bbd66aeec8
  Author: Igor Mammedov <address@hidden>
  Date:   2018-06-21 (Thu, 21 Jun 2018)

  Changed paths:
    M qapi/char.json
    M qapi/misc.json

  Log Message:
  -----------
  qmp: Enable a few commands in preconfig state

Commands query-chardev, query-version, query-name, query-uuid,
query-iothreads, query-memdev are informational and do not depend on
the machine being initialized.  Make them available in preconfig
runstate to make the latter a little bit more useful.
The generic qom commands don't depend on the machine being initialized
either; so enabled qom-list, qom-get, qom-set, qom-list-types,
qom-list-properties.

Signed-off-by: Igor Mammedov <address@hidden>
Signed-off-by: Dr. David Alan Gilbert <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Dr. David Alan Gilbert <address@hidden>


  Commit: 8c7c7ecbb1e5e9325b736906a4368b76a68d0eae
      
https://github.com/qemu/qemu/commit/8c7c7ecbb1e5e9325b736906a4368b76a68d0eae
  Author: Dr. David Alan Gilbert <address@hidden>
  Date:   2018-06-21 (Thu, 21 Jun 2018)

  Changed paths:
    M hmp-commands-info.hx
    M hmp-commands.hx

  Log Message:
  -----------
  hmp: Add commands for preconfig

Allow a bunch of the info commands to be used in preconfig.

version, chardev, name, uuid,memdev, iothreads
  Were enabled in QMP in the previous patch from Igor

status, hotpluggable_cpus
  Was enabled in the original allow-preconfig series

history
  is HMP specific

qom-tree
  Don't have a QMP equivalent

Also enable the qom commands qom-list and qom-set.

Signed-off-by: Dr. David Alan Gilbert <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Igor Mammedov <address@hidden>
Signed-off-by: Dr. David Alan Gilbert <address@hidden>
  Dropped info numa as per Igor's 2018-06-21 review


  Commit: 8e8581e6b1b77e878520a2334f8e74b1001f1578
      
https://github.com/qemu/qemu/commit/8e8581e6b1b77e878520a2334f8e74b1001f1578
  Author: Dr. David Alan Gilbert <address@hidden>
  Date:   2018-06-21 (Thu, 21 Jun 2018)

  Changed paths:
    M hmp-commands.hx
    M hmp.c
    M hmp.h

  Log Message:
  -----------
  hmp: add exit_preconfig

Add the exit_preconfig command to return to normality.

Signed-off-by: Dr. David Alan Gilbert <address@hidden>
Reviewed-by: Peter Xu <address@hidden>
Reviewed-by: Igor Mammedov <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Dr. David Alan Gilbert <address@hidden>


  Commit: 13163a93b729b9ec4b49501d03d3f50af4b05758
      
https://github.com/qemu/qemu/commit/13163a93b729b9ec4b49501d03d3f50af4b05758
  Author: Dr. David Alan Gilbert <address@hidden>
  Date:   2018-06-21 (Thu, 21 Jun 2018)

  Changed paths:
    M monitor.c

  Log Message:
  -----------
  hmp: Allow HMP in preconfig state again

Now we can cope with preconfig in HMP, reenable by reverting
commit 71dc578e116599ea73c8a2a4e693134702ec0e83.

Signed-off-by: Dr. David Alan Gilbert <address@hidden>
Reviewed-by: Peter Xu <address@hidden>
Reviewed-by: Igor Mammedov <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Dr. David Alan Gilbert <address@hidden>


  Commit: c74b91ac1c23e58e513203f112ab9b446e02b56c
      
https://github.com/qemu/qemu/commit/c74b91ac1c23e58e513203f112ab9b446e02b56c
  Author: Peter Maydell <address@hidden>
  Date:   2018-06-22 (Fri, 22 Jun 2018)

  Changed paths:
    M hmp-commands-info.hx
    M hmp-commands.hx
    M hmp.c
    M hmp.h
    M monitor.c
    M qapi/char.json
    M qapi/misc.json

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/dgilbert/tags/pull-hmp-20180621' into 
staging

HMP pull 2018-06-21

Minor fixes and reenable preconfig

# gpg: Signature made Thu 21 Jun 2018 17:43:09 BST
# gpg:                using RSA key 0516331EBC5BFDE7
# gpg: Good signature from "Dr. David Alan Gilbert (RH2) <address@hidden>"
# Primary key fingerprint: 45F5 C71B 4A0C B7FB 977A  9FA9 0516 331E BC5B FDE7

* remotes/dgilbert/tags/pull-hmp-20180621:
  hmp: Allow HMP in preconfig state again
  hmp: add exit_preconfig
  hmp: Add commands for preconfig
  qmp: Enable a few commands in preconfig state
  hmp: Restrict auto-complete in preconfig
  hmp: Allow help on preconfig commands
  hmp: Add flag for preconfig commands
  hmp-commands: use long for begin and length in dump-guest-memory
  monitor: report entirety of hmp command on error

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/de44c044420d...c74b91ac1c23
      **NOTE:** This service been marked for deprecation: 
https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.
reply via email to
[Prev in Thread] Current Thread [Next in Thread]