[Qemu-commits] [qemu/qemu] ab41fc: block: remove bdrv_dirty_bitmap_make_anon

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: ab41fc4853cc0cf01ed4903ffe7c36e3768b538f
      
https://github.com/qemu/qemu/commit/ab41fc4853cc0cf01ed4903ffe7c36e3768b538f
  Author: Paolo Bonzini <address@hidden>
  Date:   2018-06-11 (Mon, 11 Jun 2018)

  Changed paths:
    M block/dirty-bitmap.c
    M blockdev.c
    M include/block/dirty-bitmap.h

  Log Message:
  -----------
  block: remove bdrv_dirty_bitmap_make_anon

All this function is doing will be repeated by
bdrv_do_release_matching_dirty_bitmap_locked, except
resetting bm->persistent.  But even that does not matter
because the bitmap will be freed.

Signed-off-by: Paolo Bonzini <address@hidden>
Reviewed-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Message-id: address@hidden
Signed-off-by: John Snow <address@hidden>


  Commit: b133c27f5dc59969574b0715e5837d32c99caa86
      
https://github.com/qemu/qemu/commit/b133c27f5dc59969574b0715e5837d32c99caa86
  Author: Paolo Bonzini <address@hidden>
  Date:   2018-06-11 (Mon, 11 Jun 2018)

  Changed paths:
    M block/dirty-bitmap.c

  Log Message:
  -----------
  block: simplify code around releasing bitmaps

QLIST_REMOVE does not require walking the list, and once the "bitmap"
argument is removed from bdrv_do_release_matching_dirty_bitmap_locked
the code simplifies a lot and it is worth inlining everything in the
callers of bdrv_do_release_matching_dirty_bitmap.

Signed-off-by: Paolo Bonzini <address@hidden>
Reviewed-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Reviewed-by: John Snow <address@hidden>
Message-id: address@hidden
Signed-off-by: John Snow <address@hidden>


  Commit: 8b1402ce80d74dc02802f101a0f6c340462380d1
      
https://github.com/qemu/qemu/commit/8b1402ce80d74dc02802f101a0f6c340462380d1
  Author: Vladimir Sementsov-Ogievskiy <address@hidden>
  Date:   2018-06-11 (Mon, 11 Jun 2018)

  Changed paths:
    M block/dirty-bitmap.c

  Log Message:
  -----------
  block/dirty-bitmap: add lock to bdrv_enable/disable_dirty_bitmap

Add locks and remove comments about BQL accordingly to
dirty_bitmap_mutex definition in block_int.h.

Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Signed-off-by: John Snow <address@hidden>
Reviewed-by: Jeff Cody <address@hidden>
Message-id: address@hidden
Signed-off-by: John Snow <address@hidden>


  Commit: 5c5d2e50e5ac85234d793f0127a20ea3424a1229
      
https://github.com/qemu/qemu/commit/5c5d2e50e5ac85234d793f0127a20ea3424a1229
  Author: Vladimir Sementsov-Ogievskiy <address@hidden>
  Date:   2018-06-11 (Mon, 11 Jun 2018)

  Changed paths:
    M blockdev.c
    M qapi/block-core.json

  Log Message:
  -----------
  qapi: add x-block-dirty-bitmap-enable/disable

Expose the ability to turn bitmaps "on" or "off". This is experimental
and principally for the sake of the Libvirt Checkpoints API, and it may
or may not be committed for 3.0.

Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Signed-off-by: John Snow <address@hidden>
Reviewed-by: Jeff Cody <address@hidden>
Message-id: address@hidden
Signed-off-by: John Snow <address@hidden>


  Commit: c6490447402f574bbe45f45c318e0bdd19121baf
      
https://github.com/qemu/qemu/commit/c6490447402f574bbe45f45c318e0bdd19121baf
  Author: Vladimir Sementsov-Ogievskiy <address@hidden>
  Date:   2018-06-11 (Mon, 11 Jun 2018)

  Changed paths:
    M blockdev.c
    M qapi/transaction.json

  Log Message:
  -----------
  qmp: transaction support for x-block-dirty-bitmap-enable/disable

Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Signed-off-by: John Snow <address@hidden>
Reviewed-by: Jeff Cody <address@hidden>
Message-id: address@hidden
[Added x- prefix. --js]
Signed-off-by: John Snow <address@hidden>


  Commit: b598e531f1123d2fb72615f1161c66093be751ea
      
https://github.com/qemu/qemu/commit/b598e531f1123d2fb72615f1161c66093be751ea
  Author: Vladimir Sementsov-Ogievskiy <address@hidden>
  Date:   2018-06-11 (Mon, 11 Jun 2018)

  Changed paths:
    M block/dirty-bitmap.c
    M blockdev.c
    M include/block/dirty-bitmap.h
    M qapi/block-core.json

  Log Message:
  -----------
  qapi: add x-block-dirty-bitmap-merge

Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Signed-off-by: John Snow <address@hidden>
Reviewed-by: Jeff Cody <address@hidden>
Message-id: address@hidden
Signed-off-by: John Snow <address@hidden>


  Commit: a6e2ca5f6521553681ae136578ec1cb67e1a7973
      
https://github.com/qemu/qemu/commit/a6e2ca5f6521553681ae136578ec1cb67e1a7973
  Author: Vladimir Sementsov-Ogievskiy <address@hidden>
  Date:   2018-06-11 (Mon, 11 Jun 2018)

  Changed paths:
    M blockdev.c
    M qapi/block-core.json

  Log Message:
  -----------
  qapi: add disabled parameter to block-dirty-bitmap-add

This is needed, for example, to create a new bitmap and merge several
disabled bitmaps into a new one. Without this flag we will have to
put block-dirty-bitmap-add and block-dirty-bitmap-disable into one
transaction.

Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Signed-off-by: John Snow <address@hidden>
Reviewed-by: Jeff Cody <address@hidden>
Message-id: address@hidden
Signed-off-by: John Snow <address@hidden>


  Commit: 98d11a6e72c4c4524f9623a165d081da65936269
      
https://github.com/qemu/qemu/commit/98d11a6e72c4c4524f9623a165d081da65936269
  Author: Peter Maydell <address@hidden>
  Date:   2018-06-12 (Tue, 12 Jun 2018)

  Changed paths:
    M block/dirty-bitmap.c
    M blockdev.c
    M include/block/dirty-bitmap.h
    M qapi/block-core.json
    M qapi/transaction.json

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/jnsnow/tags/bitmaps-pull-request' into 
staging

bitmaps pull request

# gpg: Signature made Mon 11 Jun 2018 20:33:09 BST
# gpg:                using RSA key 7DEF8106AAFC390E
# gpg: Good signature from "John Snow (John Huston) <address@hidden>"
# Primary key fingerprint: FAEB 9711 A12C F475 812F  18F2 88A9 064D 1835 61EB
#      Subkey fingerprint: F9B7 ABDB BCAC DF95 BE76  CBD0 7DEF 8106 AAFC 390E

* remotes/jnsnow/tags/bitmaps-pull-request:
  qapi: add disabled parameter to block-dirty-bitmap-add
  qapi: add x-block-dirty-bitmap-merge
  qmp: transaction support for x-block-dirty-bitmap-enable/disable
  qapi: add x-block-dirty-bitmap-enable/disable
  block/dirty-bitmap: add lock to bdrv_enable/disable_dirty_bitmap
  block: simplify code around releasing bitmaps
  block: remove bdrv_dirty_bitmap_make_anon

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/59f3a1c6ac72...98d11a6e72c4
      **NOTE:** This service been marked for deprecation: 
https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.