[Qemu-commits] [qemu/qemu] 03b036: sheepdog: cleanup repeated expression

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 03b036cc0ca3362ff1aacd70315f5e53f4234f5c
      
https://github.com/qemu/qemu/commit/03b036cc0ca3362ff1aacd70315f5e53f4234f5c
  Author: Paolo Bonzini <address@hidden>
  Date:   2018-06-05 (Tue, 05 Jun 2018)

  Changed paths:
    M block/sheepdog.c

  Log Message:
  -----------
  sheepdog: cleanup repeated expression

The expression "SD_INODE_SIZE - sizeof(inode.data_vdi_id)" already has a macro
defined for the same value (though with a nicer definition using offsetof).
Replace it.

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Fam Zheng <address@hidden>
Reviewed-by: Jeff Cody <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Jeff Cody <address@hidden>


  Commit: 68acc99f143b60ec4faa2903065b187d4d3c4bf3
      
https://github.com/qemu/qemu/commit/68acc99f143b60ec4faa2903065b187d4d3c4bf3
  Author: Paolo Bonzini <address@hidden>
  Date:   2018-06-05 (Tue, 05 Jun 2018)

  Changed paths:
    M block/sheepdog.c

  Log Message:
  -----------
  sheepdog: remove huge BSS object

block/sheepdog.o has a 4M static variable that is 90% of QEMU's whole .bss
section.  Replace it with a heap-allocated block, and make it smaller too
since only the inode header is actually being used.

bss size goes down from 4464280 to 269976.

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Jeff Cody <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Jeff Cody <address@hidden>


  Commit: 1d889f2a8baaa265939b339d2f52ec57f5b8a09c
      
https://github.com/qemu/qemu/commit/1d889f2a8baaa265939b339d2f52ec57f5b8a09c
  Author: Peter Maydell <address@hidden>
  Date:   2018-06-05 (Tue, 05 Jun 2018)

  Changed paths:
    M block/sheepdog.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/cody/tags/block-pull-request' into 
staging

# gpg: Signature made Tue 05 Jun 2018 15:17:18 BST
# gpg:                using RSA key BDBE7B27C0DE3057
# gpg: Good signature from "Jeffrey Cody <address@hidden>"
# gpg:                 aka "Jeffrey Cody <address@hidden>"
# gpg:                 aka "Jeffrey Cody <address@hidden>"
# Primary key fingerprint: 9957 4B4D 3474 90E7 9D98  D624 BDBE 7B27 C0DE 3057

* remotes/cody/tags/block-pull-request:
  sheepdog: remove huge BSS object
  sheepdog: cleanup repeated expression

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/41feb5b955f0...1d889f2a8baa
      **NOTE:** This service been marked for deprecation: 
https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.