qemu-commits
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 871f95: syscall: replace strcpy() by g_strlcp

From: GitHub
Subject: [Qemu-commits] [qemu/qemu] 871f95: syscall: replace strcpy() by g_strlcpy()
Date: Tue, 05 Jun 2018 03:42:51 -0700 
  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 871f95c6171d5301d14dbc73997aa8fbd8e9e7ef
      
https://github.com/qemu/qemu/commit/871f95c6171d5301d14dbc73997aa8fbd8e9e7ef
  Author: Philippe Mathieu-Daudé <address@hidden>
  Date:   2018-06-04 (Mon, 04 Jun 2018)

  Changed paths:
    M linux-user/syscall.c

  Log Message:
  -----------
  syscall: replace strcpy() by g_strlcpy()

linux-user/syscall.c:9860:17: warning: Call to function 'strcpy' is insecure as 
it does not provide bounding of the memory buffer. Replace unbounded copy 
functions with analogous functions that support length arguments such as 
'strlcpy'. CWE-119
          strcpy (buf->machine, cpu_to_uname_machine(cpu_env));
          ^~~~~~

Reported-by: Clang Static Analyzer
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Laurent Vivier <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>


  Commit: b8e13ba94e39aae79be5724b2a382091e4c91c83
      
https://github.com/qemu/qemu/commit/b8e13ba94e39aae79be5724b2a382091e4c91c83
  Author: Laurent Vivier <address@hidden>
  Date:   2018-06-04 (Mon, 04 Jun 2018)

  Changed paths:
    M target/sparc/helper.c

  Log Message:
  -----------
  linux-user: SPARC "rd %tick" can be used by user application

we have the same problem decribed in 7d6b1daedd
("linux-user, ppc: mftbl can be used by user application")
for ppc in the case of sparc.

When we use an application trying to resolve a name, it hangs in

    0x00000000ff5dd40c:  rd  %tick, %o5
    0x00000000ff5dd410:  srlx  %o5, 0x20, %o4
    0x00000000ff5dd414:  btst  %o5, %g4
    0x00000000ff5dd418:  be  %icc, 0xff5dd40c

because %tick is staying at 0.

As QEMU_CLOCK_VIRTUAL is not available in linux-user mode,
simply use cpu_get_host_ticks() instead.

Signed-off-by: Laurent Vivier <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Message-Id: <address@hidden>


  Commit: 5de7706e2c713e7fe2cf6ea039b042f1e7c53fa0
      
https://github.com/qemu/qemu/commit/5de7706e2c713e7fe2cf6ea039b042f1e7c53fa0
  Author: Laurent Vivier <address@hidden>
  Date:   2018-06-04 (Mon, 04 Jun 2018)

  Changed paths:
    A linux-user/aarch64/target_fcntl.h
    A linux-user/alpha/target_fcntl.h
    A linux-user/arm/target_fcntl.h
    A linux-user/cris/target_fcntl.h
    A linux-user/generic/fcntl.h
    A linux-user/hppa/target_fcntl.h
    A linux-user/i386/target_fcntl.h
    A linux-user/m68k/target_fcntl.h
    A linux-user/microblaze/target_fcntl.h
    A linux-user/mips/target_fcntl.h
    A linux-user/mips64/target_fcntl.h
    A linux-user/nios2/target_fcntl.h
    A linux-user/openrisc/target_fcntl.h
    A linux-user/ppc/target_fcntl.h
    A linux-user/riscv/target_fcntl.h
    A linux-user/s390x/target_fcntl.h
    A linux-user/sh4/target_fcntl.h
    A linux-user/sparc/target_fcntl.h
    A linux-user/sparc64/target_fcntl.h
    M linux-user/syscall_defs.h
    A linux-user/tilegx/target_fcntl.h
    A linux-user/x86_64/target_fcntl.h
    A linux-user/xtensa/target_fcntl.h

  Log Message:
  -----------
  linux-user: move generic fcntl definitions to generic/fcntl.h

add a per target target_fcntl.h and include the generic one from them

No code change.

Signed-off-by: Laurent Vivier <address@hidden>
Message-Id: <address@hidden>


  Commit: 40460c16eed61a4206e7033d8a98506c4cf3df5d
      
https://github.com/qemu/qemu/commit/40460c16eed61a4206e7033d8a98506c4cf3df5d
  Author: Laurent Vivier <address@hidden>
  Date:   2018-06-04 (Mon, 04 Jun 2018)

  Changed paths:
    M linux-user/alpha/target_fcntl.h
    M linux-user/syscall_defs.h

  Log Message:
  -----------
  linux-user: move alpha fcntl definitions to alpha/target_fcntl.h

No code change.

Signed-off-by: Laurent Vivier <address@hidden>
Acked-by: Richard Henderson <address@hidden>
Message-Id: <address@hidden>


  Commit: 8b08c98e4704df3bee99da3989dce4be2c36f873
      
https://github.com/qemu/qemu/commit/8b08c98e4704df3bee99da3989dce4be2c36f873
  Author: Laurent Vivier <address@hidden>
  Date:   2018-06-04 (Mon, 04 Jun 2018)

  Changed paths:
    M linux-user/hppa/target_fcntl.h
    M linux-user/syscall_defs.h

  Log Message:
  -----------
  linux-user: move hppa fcntl definitions to hppa/target_fcntl.h

No code change.

Signed-off-by: Laurent Vivier <address@hidden>
Acked-by: Richard Henderson <address@hidden>
Message-Id: <address@hidden>


  Commit: 050a1ba69a61f0d4ef79a6b252ffe449b7ca37e7
      
https://github.com/qemu/qemu/commit/050a1ba69a61f0d4ef79a6b252ffe449b7ca37e7
  Author: Laurent Vivier <address@hidden>
  Date:   2018-06-04 (Mon, 04 Jun 2018)

  Changed paths:
    M linux-user/aarch64/target_fcntl.h
    M linux-user/arm/target_fcntl.h
    M linux-user/m68k/target_fcntl.h
    M linux-user/syscall_defs.h

  Log Message:
  -----------
  linux-user: move arm/aarch64/m68k fcntl definitions to 
[arm|aarch64|m68k]/target_fcntl.h

No code change.

Signed-off-by: Laurent Vivier <address@hidden>
Acked-by: Richard Henderson <address@hidden>
Message-Id: <address@hidden>


  Commit: b9acdef7861b63b17335112133995db3667aa9de
      
https://github.com/qemu/qemu/commit/b9acdef7861b63b17335112133995db3667aa9de
  Author: Laurent Vivier <address@hidden>
  Date:   2018-06-04 (Mon, 04 Jun 2018)

  Changed paths:
    M linux-user/mips/target_fcntl.h
    M linux-user/syscall_defs.h

  Log Message:
  -----------
  linux-user: move mips/mips64 fcntl definitions to mips/target_fcntl.h

No code change.

Signed-off-by: Laurent Vivier <address@hidden>
Message-Id: <address@hidden>


  Commit: 3e6800ba3c79faa725160464a869a2a73491d573
      
https://github.com/qemu/qemu/commit/3e6800ba3c79faa725160464a869a2a73491d573
  Author: Laurent Vivier <address@hidden>
  Date:   2018-06-04 (Mon, 04 Jun 2018)

  Changed paths:
    M linux-user/ppc/target_fcntl.h
    M linux-user/syscall_defs.h

  Log Message:
  -----------
  linux-user: move ppc fcntl definitions to ppc/target_fcntl.h

No code change.

Signed-off-by: Laurent Vivier <address@hidden>
Message-Id: <address@hidden>


  Commit: 995d2004b739a2a8ff60f9a0dda8c53bbdcceccf
      
https://github.com/qemu/qemu/commit/995d2004b739a2a8ff60f9a0dda8c53bbdcceccf
  Author: Laurent Vivier <address@hidden>
  Date:   2018-06-04 (Mon, 04 Jun 2018)

  Changed paths:
    M linux-user/sparc/target_fcntl.h
    M linux-user/syscall_defs.h

  Log Message:
  -----------
  linux-user: move sparc/sparc64 fcntl definitions to sparc/target_fcntl.h

No code change.

Signed-off-by: Laurent Vivier <address@hidden>
Message-Id: <address@hidden>


  Commit: 9850f9f63acb44724138a2b89b07ea4f6b3d2ba0
      
https://github.com/qemu/qemu/commit/9850f9f63acb44724138a2b89b07ea4f6b3d2ba0
  Author: Laurent Vivier <address@hidden>
  Date:   2018-06-04 (Mon, 04 Jun 2018)

  Changed paths:
    M linux-user/aarch64/signal.c
    M linux-user/aarch64/target_cpu.h
    M linux-user/aarch64/target_signal.h
    M linux-user/alpha/signal.c
    M linux-user/alpha/target_cpu.h
    M linux-user/alpha/target_signal.h
    M linux-user/arm/signal.c
    M linux-user/arm/target_cpu.h
    M linux-user/arm/target_signal.h
    M linux-user/cris/signal.c
    M linux-user/cris/target_cpu.h
    M linux-user/cris/target_signal.h
    M linux-user/hppa/signal.c
    M linux-user/hppa/target_cpu.h
    M linux-user/hppa/target_signal.h
    M linux-user/i386/signal.c
    M linux-user/i386/target_cpu.h
    M linux-user/i386/target_signal.h
    M linux-user/m68k/signal.c
    M linux-user/m68k/target_cpu.h
    M linux-user/m68k/target_signal.h
    M linux-user/microblaze/signal.c
    M linux-user/microblaze/target_cpu.h
    M linux-user/microblaze/target_signal.h
    M linux-user/mips/signal.c
    M linux-user/mips/target_cpu.h
    M linux-user/mips/target_signal.h
    M linux-user/mips64/target_signal.h
    M linux-user/nios2/signal.c
    M linux-user/nios2/target_cpu.h
    M linux-user/nios2/target_signal.h
    M linux-user/openrisc/signal.c
    M linux-user/openrisc/target_cpu.h
    M linux-user/openrisc/target_signal.h
    M linux-user/ppc/signal.c
    M linux-user/ppc/target_cpu.h
    M linux-user/ppc/target_signal.h
    M linux-user/qemu.h
    M linux-user/riscv/signal.c
    M linux-user/riscv/target_cpu.h
    M linux-user/riscv/target_signal.h
    M linux-user/s390x/signal.c
    M linux-user/s390x/target_cpu.h
    M linux-user/s390x/target_signal.h
    M linux-user/sh4/signal.c
    M linux-user/sh4/target_cpu.h
    M linux-user/sh4/target_signal.h
    M linux-user/signal.c
    M linux-user/sparc/signal.c
    M linux-user/sparc/target_cpu.h
    M linux-user/sparc/target_signal.h
    M linux-user/sparc64/target_signal.h
    M linux-user/syscall_defs.h
    M linux-user/tilegx/signal.c
    M linux-user/tilegx/target_cpu.h
    M linux-user/tilegx/target_signal.h
    M linux-user/x86_64/target_signal.h
    M linux-user/xtensa/signal.c
    M linux-user/xtensa/target_cpu.h
    M linux-user/xtensa/target_signal.h

  Log Message:
  -----------
  linux-user: move get_sp_from_cpustate() to target_cpu.h

Remove useless includes
Fix HPPA include guard.

Signed-off-by: Laurent Vivier <address@hidden>
Acked-by: Richard Henderson <address@hidden>
Message-Id: <address@hidden>


  Commit: e5171a9eb9a580b874a7e69aebaf7bf2a89818c2
      
https://github.com/qemu/qemu/commit/e5171a9eb9a580b874a7e69aebaf7bf2a89818c2
  Author: Laurent Vivier <address@hidden>
  Date:   2018-06-04 (Mon, 04 Jun 2018)

  Changed paths:
    M linux-user/aarch64/target_signal.h
    M linux-user/arm/target_signal.h
    M linux-user/cris/target_signal.h
    A linux-user/generic/signal.h
    M linux-user/i386/target_signal.h
    M linux-user/m68k/target_signal.h
    M linux-user/microblaze/target_signal.h
    M linux-user/nios2/target_signal.h
    M linux-user/openrisc/target_signal.h
    M linux-user/ppc/target_signal.h
    M linux-user/riscv/target_signal.h
    M linux-user/s390x/target_signal.h
    M linux-user/sh4/target_signal.h
    M linux-user/syscall_defs.h
    M linux-user/tilegx/target_signal.h
    M linux-user/x86_64/target_signal.h
    M linux-user/xtensa/target_signal.h

  Log Message:
  -----------
  linux-user: move generic signal definitions to generic/signal.h

No code change.

Signed-off-by: Laurent Vivier <address@hidden>
Message-Id: <address@hidden>


  Commit: 1bdefb5ac73a8a5f7cc4858627424ea88d6db6de
      
https://github.com/qemu/qemu/commit/1bdefb5ac73a8a5f7cc4858627424ea88d6db6de
  Author: Laurent Vivier <address@hidden>
  Date:   2018-06-04 (Mon, 04 Jun 2018)

  Changed paths:
    M linux-user/sparc/target_signal.h
    M linux-user/sparc64/signal.c
    M linux-user/sparc64/target_signal.h
    M linux-user/syscall_defs.h

  Log Message:
  -----------
  linux-user: move sparc signal definitions to sparc/target_signal.h

Remove sparc64/target_signal.h, use sparc/target_signal.h instead.

Signed-off-by: Laurent Vivier <address@hidden>
Message-Id: <address@hidden>


  Commit: f70c731347406cbd2bc79ab466415e21061fef96
      
https://github.com/qemu/qemu/commit/f70c731347406cbd2bc79ab466415e21061fef96
  Author: Laurent Vivier <address@hidden>
  Date:   2018-06-04 (Mon, 04 Jun 2018)

  Changed paths:
    M linux-user/mips/target_signal.h
    M linux-user/mips64/target_signal.h
    M linux-user/syscall_defs.h

  Log Message:
  -----------
  linux-user: move mips signal definitions to mips/target_signal.h

No code change.

Signed-off-by: Laurent Vivier <address@hidden>
Message-Id: <address@hidden>


  Commit: 5795083b1616545910d9508b663008beb016fd6a
      
https://github.com/qemu/qemu/commit/5795083b1616545910d9508b663008beb016fd6a
  Author: Laurent Vivier <address@hidden>
  Date:   2018-06-04 (Mon, 04 Jun 2018)

  Changed paths:
    M linux-user/openrisc/target_signal.h
    M linux-user/syscall_defs.h

  Log Message:
  -----------
  linux-user: move openrisc signal definitions to openrisc/target_signal.h

No code change.

Signed-off-by: Laurent Vivier <address@hidden>
Message-Id: <address@hidden>


  Commit: 3e511153a810c779c85b2ae8058fb3d41188b6d9
      
https://github.com/qemu/qemu/commit/3e511153a810c779c85b2ae8058fb3d41188b6d9
  Author: Laurent Vivier <address@hidden>
  Date:   2018-06-04 (Mon, 04 Jun 2018)

  Changed paths:
    M linux-user/alpha/target_signal.h
    M linux-user/syscall_defs.h

  Log Message:
  -----------
  linux-user: move alpha signal definitions to alpha/target_signal.h

No code change.

Signed-off-by: Laurent Vivier <address@hidden>
Message-Id: <address@hidden>


  Commit: db30b1aa8cab867d9790ba3ec593fc8a1784e48f
      
https://github.com/qemu/qemu/commit/db30b1aa8cab867d9790ba3ec593fc8a1784e48f
  Author: Laurent Vivier <address@hidden>
  Date:   2018-06-04 (Mon, 04 Jun 2018)

  Changed paths:
    M linux-user/hppa/target_signal.h
    M linux-user/syscall_defs.h

  Log Message:
  -----------
  linux-user: move hppa signal definitions to hppa/target_signal.h

No code change.

Signed-off-by: Laurent Vivier <address@hidden>
Message-Id: <address@hidden>


  Commit: 7ea65371ee6ba714c5b369b38dd608b128dab57c
      
https://github.com/qemu/qemu/commit/7ea65371ee6ba714c5b369b38dd608b128dab57c
  Author: Laurent Vivier <address@hidden>
  Date:   2018-06-04 (Mon, 04 Jun 2018)

  Changed paths:
    M linux-user/syscall_defs.h

  Log Message:
  -----------
  linux-user: remove useless #if

Remove a "#if defined(XX) || defined(YY) || ..." with all available
targets

Signed-off-by: Laurent Vivier <address@hidden>
Message-Id: <address@hidden>


  Commit: 41feb5b955f0d7c9d071b2c5adbc404ae2895c7a
      
https://github.com/qemu/qemu/commit/41feb5b955f0d7c9d071b2c5adbc404ae2895c7a
  Author: Peter Maydell <address@hidden>
  Date:   2018-06-05 (Tue, 05 Jun 2018)

  Changed paths:
    M linux-user/aarch64/signal.c
    M linux-user/aarch64/target_cpu.h
    A linux-user/aarch64/target_fcntl.h
    M linux-user/aarch64/target_signal.h
    M linux-user/alpha/signal.c
    M linux-user/alpha/target_cpu.h
    A linux-user/alpha/target_fcntl.h
    M linux-user/alpha/target_signal.h
    M linux-user/arm/signal.c
    M linux-user/arm/target_cpu.h
    A linux-user/arm/target_fcntl.h
    M linux-user/arm/target_signal.h
    M linux-user/cris/signal.c
    M linux-user/cris/target_cpu.h
    A linux-user/cris/target_fcntl.h
    M linux-user/cris/target_signal.h
    A linux-user/generic/fcntl.h
    A linux-user/generic/signal.h
    M linux-user/hppa/signal.c
    M linux-user/hppa/target_cpu.h
    A linux-user/hppa/target_fcntl.h
    M linux-user/hppa/target_signal.h
    M linux-user/i386/signal.c
    M linux-user/i386/target_cpu.h
    A linux-user/i386/target_fcntl.h
    M linux-user/i386/target_signal.h
    M linux-user/m68k/signal.c
    M linux-user/m68k/target_cpu.h
    A linux-user/m68k/target_fcntl.h
    M linux-user/m68k/target_signal.h
    M linux-user/microblaze/signal.c
    M linux-user/microblaze/target_cpu.h
    A linux-user/microblaze/target_fcntl.h
    M linux-user/microblaze/target_signal.h
    M linux-user/mips/signal.c
    M linux-user/mips/target_cpu.h
    A linux-user/mips/target_fcntl.h
    M linux-user/mips/target_signal.h
    A linux-user/mips64/target_fcntl.h
    M linux-user/mips64/target_signal.h
    M linux-user/nios2/signal.c
    M linux-user/nios2/target_cpu.h
    A linux-user/nios2/target_fcntl.h
    M linux-user/nios2/target_signal.h
    M linux-user/openrisc/signal.c
    M linux-user/openrisc/target_cpu.h
    A linux-user/openrisc/target_fcntl.h
    M linux-user/openrisc/target_signal.h
    M linux-user/ppc/signal.c
    M linux-user/ppc/target_cpu.h
    A linux-user/ppc/target_fcntl.h
    M linux-user/ppc/target_signal.h
    M linux-user/qemu.h
    M linux-user/riscv/signal.c
    M linux-user/riscv/target_cpu.h
    A linux-user/riscv/target_fcntl.h
    M linux-user/riscv/target_signal.h
    M linux-user/s390x/signal.c
    M linux-user/s390x/target_cpu.h
    A linux-user/s390x/target_fcntl.h
    M linux-user/s390x/target_signal.h
    M linux-user/sh4/signal.c
    M linux-user/sh4/target_cpu.h
    A linux-user/sh4/target_fcntl.h
    M linux-user/sh4/target_signal.h
    M linux-user/signal.c
    M linux-user/sparc/signal.c
    M linux-user/sparc/target_cpu.h
    A linux-user/sparc/target_fcntl.h
    M linux-user/sparc/target_signal.h
    M linux-user/sparc64/signal.c
    A linux-user/sparc64/target_fcntl.h
    M linux-user/sparc64/target_signal.h
    M linux-user/syscall.c
    M linux-user/syscall_defs.h
    M linux-user/tilegx/signal.c
    M linux-user/tilegx/target_cpu.h
    A linux-user/tilegx/target_fcntl.h
    M linux-user/tilegx/target_signal.h
    A linux-user/x86_64/target_fcntl.h
    M linux-user/x86_64/target_signal.h
    M linux-user/xtensa/signal.c
    M linux-user/xtensa/target_cpu.h
    A linux-user/xtensa/target_fcntl.h
    M linux-user/xtensa/target_signal.h
    M target/sparc/helper.c

  Log Message:
  -----------
  Merge remote-tracking branch 
'remotes/vivier2/tags/linux-user-for-3.0-pull-request' into staging

move more data to arch specific files
fix SPARC %tick
replace strcpy() by g_strlcpy() in syscall.c

# gpg: Signature made Mon 04 Jun 2018 16:19:44 BST
# gpg:                using RSA key F30C38BD3F2FBE3C
# gpg: Good signature from "Laurent Vivier <address@hidden>"
# gpg:                 aka "Laurent Vivier <address@hidden>"
# gpg:                 aka "Laurent Vivier (Red Hat) <address@hidden>"
# Primary key fingerprint: CD2F 75DD C8E3 A4DC 2E4F  5173 F30C 38BD 3F2F BE3C

* remotes/vivier2/tags/linux-user-for-3.0-pull-request:
  linux-user: remove useless #if
  linux-user: move hppa signal definitions to hppa/target_signal.h
  linux-user: move alpha signal definitions to alpha/target_signal.h
  linux-user: move openrisc signal definitions to openrisc/target_signal.h
  linux-user: move mips signal definitions to mips/target_signal.h
  linux-user: move sparc signal definitions to sparc/target_signal.h
  linux-user: move generic signal definitions to generic/signal.h
  linux-user: move get_sp_from_cpustate() to target_cpu.h
  linux-user: move sparc/sparc64 fcntl definitions to sparc/target_fcntl.h
  linux-user: move ppc fcntl definitions to ppc/target_fcntl.h
  linux-user: move mips/mips64 fcntl definitions to mips/target_fcntl.h
  linux-user: move arm/aarch64/m68k fcntl definitions to 
[arm|aarch64|m68k]/target_fcntl.h
  linux-user: move hppa fcntl definitions to hppa/target_fcntl.h
  linux-user: move alpha fcntl definitions to alpha/target_fcntl.h
  linux-user: move generic fcntl definitions to generic/fcntl.h
  linux-user: SPARC "rd %tick" can be used by user application
  syscall: replace strcpy() by g_strlcpy()

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/0d514fa23402...41feb5b955f0
      **NOTE:** This service been marked for deprecation: 
https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.
reply via email to
[Prev in Thread] Current Thread [Next in Thread]