qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] f88e5c: sdl2: move opts assignment into loop


From: GitHub
Subject: [Qemu-commits] [qemu/qemu] f88e5c: sdl2: move opts assignment into loop
Date: Tue, 15 May 2018 04:49:36 -0700

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: f88e5c5744c7969ba0ccb7f9a3b85cdcac3aacf1
      
https://github.com/qemu/qemu/commit/f88e5c5744c7969ba0ccb7f9a3b85cdcac3aacf1
  Author: Gerd Hoffmann <address@hidden>
  Date:   2018-05-15 (Tue, 15 May 2018)

  Changed paths:
    M ui/sdl2.c

  Log Message:
  -----------
  sdl2: move opts assignment into loop

So the opts pointer is set for all sdl2_consoles.

Fixes: 844fd50dbbcfc9e401895274bf4fb8da8e8d3f64
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 1d18774579759a8b5046119266626e9fdf9f7c0b
      
https://github.com/qemu/qemu/commit/1d18774579759a8b5046119266626e9fdf9f7c0b
  Author: Peter Wu <address@hidden>
  Date:   2018-05-15 (Tue, 15 May 2018)

  Changed paths:
    M ui/gtk.c

  Log Message:
  -----------
  gtk: make it possible to hide the menu bar

Saves some space and disables the F10 button as side-effect.

Fixes: https://bugs.launchpad.net/qemu/+bug/1726910
Signed-off-by: Peter Wu <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 4f4cb8282df82d43ba6b3c9045a3ac6fc4c4ef09
      
https://github.com/qemu/qemu/commit/4f4cb8282df82d43ba6b3c9045a3ac6fc4c4ef09
  Author: Tomeu Vizoso <address@hidden>
  Date:   2018-05-15 (Tue, 15 May 2018)

  Changed paths:
    M ui/gtk.c

  Log Message:
  -----------
  ui/gtk: Only try to initialize EGL/X11 if GtkGlArea failed

The commit referenced below changed the logic by causing the gtk-egl
backend to be initialized regardless of whether GtkGlArea initialization
succeeded. This causes eglInitialize to crash in Wayland systems without
XWayland.

This patch restores the previous logic.

Fixes: 4c70280592f5 ("ui/gtk: use GtkGlArea on wayland only")
Signed-off-by: Tomeu Vizoso <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: f31f9c1080d8907c95f1501c6abab038eceb5490
      
https://github.com/qemu/qemu/commit/f31f9c1080d8907c95f1501c6abab038eceb5490
  Author: Gerd Hoffmann <address@hidden>
  Date:   2018-05-15 (Tue, 15 May 2018)

  Changed paths:
    M ui/vnc-jobs.c
    M ui/vnc.c
    M ui/vnc.h

  Log Message:
  -----------
  vnc: add magic cookie to VncState

Set magic cookie on initialization.  Clear on cleanup.  Sprinkle a bunch
of assert()s checking the cookie, to verify the pointer is valid.

Signed-off-by: Gerd Hoffmann <address@hidden>
Message-id: address@hidden


  Commit: 776d1344bd0566f412d5bc063e753a6b98530bcf
      
https://github.com/qemu/qemu/commit/776d1344bd0566f412d5bc063e753a6b98530bcf
  Author: Gerd Hoffmann <address@hidden>
  Date:   2018-05-15 (Tue, 15 May 2018)

  Changed paths:
    M vl.c

  Log Message:
  -----------
  ui: add qapi parser for -display

Add parse_display_qapi() function which parses the -display command line
using a qapi visitor for DisplayOptions.  Wire up as default catch in
parse_display().

Improves the error message for unknown display types.

Also enables json as -display argument, i.e. -display "{ 'type': 'gtk' }"

Signed-off-by: Gerd Hoffmann <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Message-id: address@hidden


  Commit: 2c9498c3e44cd5574df3baaebfb9d5a095252205
      
https://github.com/qemu/qemu/commit/2c9498c3e44cd5574df3baaebfb9d5a095252205
  Author: Gerd Hoffmann <address@hidden>
  Date:   2018-05-15 (Tue, 15 May 2018)

  Changed paths:
    M vl.c

  Log Message:
  -----------
  ui: switch trivial displays to qapi parser

Drop the option-less display types (egl-headless, curses, none) from
parse_display(), so they'll be handled by parse_display_qapi().

Signed-off-by: Gerd Hoffmann <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Message-id: address@hidden


  Commit: 002b2902f39fd9c2b01881e1ca07db80266dc5bf
      
https://github.com/qemu/qemu/commit/002b2902f39fd9c2b01881e1ca07db80266dc5bf
  Author: Gerd Hoffmann <address@hidden>
  Date:   2018-05-15 (Tue, 15 May 2018)

  Changed paths:
    M ui/gtk.c
    M vl.c

  Log Message:
  -----------
  ui: switch gtk display to qapi parser

Drop the gtk option parser from parse_display(), so parse_display_qapi()
will handle it instead.

With this change the parser will accept gl=core and gl=es too, gtk
must catch the unsupported gles variant now.

Signed-off-by: Gerd Hoffmann <address@hidden>
Message-id: address@hidden


  Commit: 7a61f4385991a7b47d71c8d657dea1e34a792baf
      
https://github.com/qemu/qemu/commit/7a61f4385991a7b47d71c8d657dea1e34a792baf
  Author: Gerd Hoffmann <address@hidden>
  Date:   2018-05-15 (Tue, 15 May 2018)

  Changed paths:
    M vl.c

  Log Message:
  -----------
  ui: document non-qapi parser cases.

Add comments to the cases not (yet) switched
over to parse_display_qapi().

Signed-off-by: Gerd Hoffmann <address@hidden>
Message-id: address@hidden


  Commit: cd6cd8fa0da7839b11ca7e5d7d45b73810394395
      
https://github.com/qemu/qemu/commit/cd6cd8fa0da7839b11ca7e5d7d45b73810394395
  Author: Gerd Hoffmann <address@hidden>
  Date:   2018-05-15 (Tue, 15 May 2018)

  Changed paths:
    M ui/console.c

  Log Message:
  -----------
  console: use linked list for QemuConsoles

Signed-off-by: Gerd Hoffmann <address@hidden>
Message-id: address@hidden


  Commit: 677b490501823c1cb6946d8bb9e7907c12cd0c71
      
https://github.com/qemu/qemu/commit/677b490501823c1cb6946d8bb9e7907c12cd0c71
  Author: Peter Wu <address@hidden>
  Date:   2018-05-15 (Tue, 15 May 2018)

  Changed paths:
    M ui/gtk.c

  Log Message:
  -----------
  gtk: disable the F10 menubar key

The F10 key is used in various applications, disable it unconditionally
(do not limit it to grab mode). Note that this property is deprecated
and might be removed in the future (GTK+ commit b082fb598d).

Fixes: https://bugs.launchpad.net/qemu/+bug/1726910
Signed-off-by: Peter Wu <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: c13547feeec97fb31a2283cd129549b3e8c78054
      
https://github.com/qemu/qemu/commit/c13547feeec97fb31a2283cd129549b3e8c78054
  Author: Peter Maydell <address@hidden>
  Date:   2018-05-15 (Tue, 15 May 2018)

  Changed paths:
    M ui/console.c
    M ui/gtk.c
    M ui/sdl2.c
    M ui/vnc-jobs.c
    M ui/vnc.c
    M ui/vnc.h
    M vl.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/kraxel/tags/ui-20180515-pull-request' 
into staging

ui: qapi parser for -display cmd line.
gtk: multiple fixes.
sdl: opts bugfix.
vnc: magic cookie.

# gpg: Signature made Tue 15 May 2018 10:18:51 BST
# gpg:                using RSA key 4CB6D8EED3E87138
# gpg: Good signature from "Gerd Hoffmann (work) <address@hidden>"
# gpg:                 aka "Gerd Hoffmann <address@hidden>"
# gpg:                 aka "Gerd Hoffmann (private) <address@hidden>"
# Primary key fingerprint: A032 8CFF B93A 17A7 9901  FE7D 4CB6 D8EE D3E8 7138

* remotes/kraxel/tags/ui-20180515-pull-request:
  gtk: disable the F10 menubar key
  console: use linked list for QemuConsoles
  ui: document non-qapi parser cases.
  ui: switch gtk display to qapi parser
  ui: switch trivial displays to qapi parser
  ui: add qapi parser for -display
  vnc: add magic cookie to VncState
  ui/gtk: Only try to initialize EGL/X11 if GtkGlArea failed
  gtk: make it possible to hide the menu bar
  sdl2: move opts assignment into loop

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/46cc2fc4f591...c13547feeec9
      **NOTE:** This service been marked for deprecation: 
https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]