[Qemu-commits] [qemu/qemu] 9d9461: net: Fix memory leak in net_param_nic()

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 9d94619189d899b2b40e9dfaa0ede64c8b81e5ab
      
https://github.com/qemu/qemu/commit/9d94619189d899b2b40e9dfaa0ede64c8b81e5ab
  Author: Thomas Huth <address@hidden>
  Date:   2018-05-14 (Mon, 14 May 2018)

  Changed paths:
    M net/net.c

  Log Message:
  -----------
  net: Fix memory leak in net_param_nic()

The early exits in case of errors leak the memory allocated for nd_id.
Fix it by using a "goto out" to the cleanup at the end of the function
instead.

Reviewed-by: Peter Maydell <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>
Signed-off-by: Jason Wang <address@hidden>


  Commit: af1a5c3eb41521b4f090ad6125cd981b72b99ab9
      
https://github.com/qemu/qemu/commit/af1a5c3eb41521b4f090ad6125cd981b72b99ab9
  Author: Thomas Huth <address@hidden>
  Date:   2018-05-14 (Mon, 14 May 2018)

  Changed paths:
    M docs/qdev-device-use.txt
    M hw/core/qdev-properties-system.c
    M include/hw/qdev-properties.h
    M include/net/net.h
    M net/net.c
    M qapi/net.json
    M qemu-doc.texi
    M qemu-options.hx

  Log Message:
  -----------
  net: Remove the deprecated "vlan" parameter

It's been marked as deprecated since QEMU v2.9.0, so that should have
been enough time for everybody to either just drop unnecessary "vlan=0"
parameters, to switch to the modern -device + -netdev syntax for connecting
guest NICs with host network backends, or to switch to the "hubport" netdev
in case hubs are really wanted instead.

Buglink: https://bugs.launchpad.net/qemu/+bug/658904
Signed-off-by: Thomas Huth <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Signed-off-by: Jason Wang <address@hidden>


  Commit: 442da403ead80525761898ab0d8036a9cd3c6829
      
https://github.com/qemu/qemu/commit/442da403ead80525761898ab0d8036a9cd3c6829
  Author: Thomas Huth <address@hidden>
  Date:   2018-05-14 (Mon, 14 May 2018)

  Changed paths:
    M net/hub.c
    M net/slirp.c
    M net/tap.c

  Log Message:
  -----------
  net: Get rid of 'vlan' terminology and use 'hub' instead in the source files

'vlan' is very confusing since it does not mean something like IEEE
802.1Q, but rather emulated hubs, so let's switch to that terminology
instead.

Buglink: https://bugs.launchpad.net/qemu/+bug/658904
Reviewed-by: Stefan Hajnoczi <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>
Signed-off-by: Jason Wang <address@hidden>


  Commit: 0e0266c2e475b82b39a757c875fa03e64272fbe7
      
https://github.com/qemu/qemu/commit/0e0266c2e475b82b39a757c875fa03e64272fbe7
  Author: Thomas Huth <address@hidden>
  Date:   2018-05-14 (Mon, 14 May 2018)

  Changed paths:
    M qemu-doc.texi

  Log Message:
  -----------
  net: Get rid of 'vlan' terminology and use 'hub' instead in the doc files

'vlan' is very confusing since it does not mean something like IEEE
802.1Q, but rather emulated hubs, so let's switch to that terminology
instead. While we're at it, move the subsection about hub a little bit
downward in the documentation (it's not as important anymore as it was
before the invention of the -netdev parameter), and extend it a little
bit.

Buglink: https://bugs.launchpad.net/qemu/+bug/658904
Reviewed-by: Stefan Hajnoczi <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>
Signed-off-by: Jason Wang <address@hidden>


  Commit: 7a9180b77eca258ab418ec00ab397392e70e55d9
      
https://github.com/qemu/qemu/commit/7a9180b77eca258ab418ec00ab397392e70e55d9
  Author: Peter Maydell <address@hidden>
  Date:   2018-05-14 (Mon, 14 May 2018)

  Changed paths:
    M docs/qdev-device-use.txt
    M hw/core/qdev-properties-system.c
    M include/hw/qdev-properties.h
    M include/net/net.h
    M net/hub.c
    M net/net.c
    M net/slirp.c
    M net/tap.c
    M qapi/net.json
    M qemu-doc.texi
    M qemu-options.hx

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/jasowang/tags/net-pull-request' into 
staging

# gpg: Signature made Mon 14 May 2018 08:51:53 BST
# gpg:                using RSA key EF04965B398D6211
# gpg: Good signature from "Jason Wang (Jason Wang on RedHat) <address@hidden>"
# gpg: WARNING: This key is not certified with sufficiently trusted signatures!
# gpg:          It is not certain that the signature belongs to the owner.
# Primary key fingerprint: 215D 46F4 8246 689E C77F  3562 EF04 965B 398D 6211

* remotes/jasowang/tags/net-pull-request:
  net: Get rid of 'vlan' terminology and use 'hub' instead in the doc files
  net: Get rid of 'vlan' terminology and use 'hub' instead in the source files
  net: Remove the deprecated "vlan" parameter
  net: Fix memory leak in net_param_nic()

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/bbd87423ea0c...7a9180b77eca
      **NOTE:** This service been marked for deprecation: 
https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.