qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 335722: target/riscv: avoid integer overflow


From: GitHub
Subject: [Qemu-commits] [qemu/qemu] 335722: target/riscv: avoid integer overflow in next_page ...
Date: Fri, 11 May 2018 09:30:34 -0700

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 33572269a54ba6339ce00537abfa434e4ffc95c2
      
https://github.com/qemu/qemu/commit/33572269a54ba6339ce00537abfa434e4ffc95c2
  Author: Emilio G. Cota <address@hidden>
  Date:   2018-05-09 (Wed, 09 May 2018)

  Changed paths:
    M target/riscv/translate.c

  Log Message:
  -----------
  target/riscv: avoid integer overflow in next_page PC check

If the PC is in the last page of the address space, next_page_start
overflows to 0. Fix it.

Reported-by: Richard Henderson <address@hidden>
Suggested-by: Richard Henderson <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Reviewed-by: Michael Clark <address@hidden>
Acked-by: Bastian Koppelmann <address@hidden>
Cc: Michael Clark <address@hidden>
Cc: Palmer Dabbelt <address@hidden>
Cc: Sagar Karandikar <address@hidden>
Cc: Bastian Koppelmann <address@hidden>
Signed-off-by: Emilio G. Cota <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>


  Commit: 3ac5e413c00511d10d69b8b55fc06cc0c54bd45f
      
https://github.com/qemu/qemu/commit/3ac5e413c00511d10d69b8b55fc06cc0c54bd45f
  Author: Emilio G. Cota <address@hidden>
  Date:   2018-05-09 (Wed, 09 May 2018)

  Changed paths:
    M target/cris/translate.c

  Log Message:
  -----------
  target/cris: avoid integer overflow in next_page PC check

If the PC is in the last page of the address space, next_page_start
overflows to 0. Fix it.

Reviewed-by: Richard Henderson <address@hidden>
Cc: "Edgar E. Iglesias" <address@hidden>
Signed-off-by: Emilio G. Cota <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>


  Commit: 4302303d3c1f6f40b92791702f74d783a51ae60c
      
https://github.com/qemu/qemu/commit/4302303d3c1f6f40b92791702f74d783a51ae60c
  Author: Emilio G. Cota <address@hidden>
  Date:   2018-05-09 (Wed, 09 May 2018)

  Changed paths:
    M target/lm32/translate.c

  Log Message:
  -----------
  target/lm32: avoid integer overflow in next_page PC check

If the PC is in the last page of the address space, next_page_start
overflows to 0. Fix it.

Reviewed-by: Richard Henderson <address@hidden>
Acked-by: Michael Walle <address@hidden>
Cc: Michael Walle <address@hidden>
Signed-off-by: Emilio G. Cota <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>


  Commit: 4e8b44b6c2350e02ca8e410d40022122b4038bd5
      
https://github.com/qemu/qemu/commit/4e8b44b6c2350e02ca8e410d40022122b4038bd5
  Author: Emilio G. Cota <address@hidden>
  Date:   2018-05-09 (Wed, 09 May 2018)

  Changed paths:
    M target/xtensa/translate.c

  Log Message:
  -----------
  target/xtensa: avoid integer overflow in next_page PC check

If the PC is in the last page of the address space, next_page_start
overflows to 0. Fix it.

Reviewed-by: Richard Henderson <address@hidden>
Acked-by: Max Filippov <address@hidden>
Cc: Max Filippov <address@hidden>
Signed-off-by: Emilio G. Cota <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>


  Commit: 818c187781a0e9dcfd0cbaffd90c9485f2edcccd
      
https://github.com/qemu/qemu/commit/818c187781a0e9dcfd0cbaffd90c9485f2edcccd
  Author: Emilio G. Cota <address@hidden>
  Date:   2018-05-09 (Wed, 09 May 2018)

  Changed paths:
    M target/unicore32/translate.c

  Log Message:
  -----------
  target/unicore32: avoid integer overflow in next_page PC check

If the PC is in the last page of the address space, next_page_start
overflows to 0. Fix it.

Reviewed-by: Richard Henderson <address@hidden>
Cc: Guan Xuetao <address@hidden>
Signed-off-by: Emilio G. Cota <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>


  Commit: 5c433a7aac1a34c199ed5a7a07f4f71349562a8f
      
https://github.com/qemu/qemu/commit/5c433a7aac1a34c199ed5a7a07f4f71349562a8f
  Author: Emilio G. Cota <address@hidden>
  Date:   2018-05-09 (Wed, 09 May 2018)

  Changed paths:
    M target/tilegx/translate.c

  Log Message:
  -----------
  target/tilegx: avoid integer overflow in next_page PC check

If the PC is in the last page of the address space, next_page_start
overflows to 0. Fix it.

Reviewed-by: Richard Henderson <address@hidden>
Signed-off-by: Emilio G. Cota <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>


  Commit: 56371527f3f8d33be651046700d72489f4df505f
      
https://github.com/qemu/qemu/commit/56371527f3f8d33be651046700d72489f4df505f
  Author: Emilio G. Cota <address@hidden>
  Date:   2018-05-09 (Wed, 09 May 2018)

  Changed paths:
    M target/microblaze/translate.c

  Log Message:
  -----------
  target/microblaze: avoid integer overflow in next_page PC check

If the PC is in the last page of the address space, next_page_start
overflows to 0. Fix it.

Reviewed-by: Richard Henderson <address@hidden>
Cc: "Edgar E. Iglesias" <address@hidden>
Signed-off-by: Emilio G. Cota <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>


  Commit: bfe7ad5be77a6a8925a7ab1628452c8942222102
      
https://github.com/qemu/qemu/commit/bfe7ad5be77a6a8925a7ab1628452c8942222102
  Author: Emilio G. Cota <address@hidden>
  Date:   2018-05-09 (Wed, 09 May 2018)

  Changed paths:
    M target/arm/translate.c
    M target/arm/translate.h

  Log Message:
  -----------
  target/arm: avoid integer overflow in next_page PC check

If the PC is in the last page of the address space, next_page_start
overflows to 0. Fix it.

Reviewed-by: Richard Henderson <address@hidden>
Cc: Peter Maydell <address@hidden>
Signed-off-by: Emilio G. Cota <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>


  Commit: 071bd2b628cedbb640be8ca6c25d1949b2e6fe4a
      
https://github.com/qemu/qemu/commit/071bd2b628cedbb640be8ca6c25d1949b2e6fe4a
  Author: Emilio G. Cota <address@hidden>
  Date:   2018-05-09 (Wed, 09 May 2018)

  Changed paths:
    M target/s390x/translate.c

  Log Message:
  -----------
  target/s390x: avoid integer overflow in next_page PC check

If the PC is in the last page of the address space, next_page_start
overflows to 0. Fix it.

Reviewed-by: Richard Henderson <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>
Reviewed-by: David Hildenbrand <address@hidden>
Acked-by: Cornelia Huck <address@hidden>
Cc: Cornelia Huck <address@hidden>
Cc: Alexander Graf <address@hidden>
Cc: David Hildenbrand <address@hidden>
Cc: address@hidden
Signed-off-by: Emilio G. Cota <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>


  Commit: 6cd79443d33e6ba6b4c5b787eb713ca1cec56328
      
https://github.com/qemu/qemu/commit/6cd79443d33e6ba6b4c5b787eb713ca1cec56328
  Author: Emilio G. Cota <address@hidden>
  Date:   2018-05-09 (Wed, 09 May 2018)

  Changed paths:
    M target/mips/translate.c

  Log Message:
  -----------
  target/mips: avoid integer overflow in next_page PC check

If the PC is in the last page of the address space, next_page_start
overflows to 0. Fix it.

Reviewed-by: Richard Henderson <address@hidden>
Cc: Aurelien Jarno <address@hidden>
Cc: Yongbok Kim <address@hidden>
Signed-off-by: Emilio G. Cota <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>


  Commit: b542683d77b4f56cef0221b267c341616d87bce9
      
https://github.com/qemu/qemu/commit/b542683d77b4f56cef0221b267c341616d87bce9
  Author: Emilio G. Cota <address@hidden>
  Date:   2018-05-09 (Wed, 09 May 2018)

  Changed paths:
    M accel/tcg/translator.c
    M include/exec/translator.h
    M target/alpha/translate.c
    M target/arm/translate-a64.c
    M target/arm/translate.c
    M target/hppa/translate.c
    M target/i386/translate.c
    M target/ppc/translate.c

  Log Message:
  -----------
  translator: merge max_insns into DisasContextBase

While at it, use int for both num_insns and max_insns to make
sure we have same-type comparisons.

Reviewed-by: Richard Henderson <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Michael Clark <address@hidden>
Signed-off-by: Emilio G. Cota <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>


  Commit: fd1b3d38649470191ffbe67429a0c4b1a95116a0
      
https://github.com/qemu/qemu/commit/fd1b3d38649470191ffbe67429a0c4b1a95116a0
  Author: Emilio G. Cota <address@hidden>
  Date:   2018-05-09 (Wed, 09 May 2018)

  Changed paths:
    M target/sh4/translate.c

  Log Message:
  -----------
  target/sh4: convert to TranslatorOps

This was fairly straightforward since it had already been converted
to DisasContextBase; just had to add TARGET_TOO_MANY to the switch
in tb_stop.

Reviewed-by: Richard Henderson <address@hidden>
Cc: Aurelien Jarno <address@hidden>
Signed-off-by: Emilio G. Cota <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>


  Commit: c5e6ccdf6c8d32d3a45d9dca4d6847dcff741882
      
https://github.com/qemu/qemu/commit/c5e6ccdf6c8d32d3a45d9dca4d6847dcff741882
  Author: Emilio G. Cota <address@hidden>
  Date:   2018-05-09 (Wed, 09 May 2018)

  Changed paths:
    M target/sparc/translate.c

  Log Message:
  -----------
  target/sparc: convert to DisasJumpType

Reviewed-by: Richard Henderson <address@hidden>
Cc: Mark Cave-Ayland <address@hidden>
Cc: Artyom Tarasenko <address@hidden>
Signed-off-by: Emilio G. Cota <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>


  Commit: af00be490b30d7f576d12ac7b2bc5406ca6fda3f
      
https://github.com/qemu/qemu/commit/af00be490b30d7f576d12ac7b2bc5406ca6fda3f
  Author: Emilio G. Cota <address@hidden>
  Date:   2018-05-09 (Wed, 09 May 2018)

  Changed paths:
    M target/sparc/translate.c

  Log Message:
  -----------
  target/sparc: convert to DisasContextBase

Notes:

- pc and npc are left unmodified, since they can point to out-of-TB
  jump targets.

- Got rid of last_pc in gen_intermediate_code(), using base.pc_next
  instead. Only update pc_next (1) on a breakpoint (so that tb->size
  includes the insn), and (2) after reading the current instruction
  from memory. This allows us to use base.pc_next in the BP check,
  which is what the translator loop does.

Reviewed-by: Richard Henderson <address@hidden>
Cc: Mark Cave-Ayland <address@hidden>
Cc: Artyom Tarasenko <address@hidden>
Signed-off-by: Emilio G. Cota <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>


  Commit: 6e61bc941025345ab01c48d116bef60bb8990406
      
https://github.com/qemu/qemu/commit/6e61bc941025345ab01c48d116bef60bb8990406
  Author: Emilio G. Cota <address@hidden>
  Date:   2018-05-09 (Wed, 09 May 2018)

  Changed paths:
    M target/sparc/translate.c

  Log Message:
  -----------
  target/sparc: convert to TranslatorOps

Notes:

- Moved the cross-page check from the end of translate_insn to
  init_disas_context.

Reviewed-by: Richard Henderson <address@hidden>
Tested-by: Mark Cave-Ayland <address@hidden>
Cc: Mark Cave-Ayland <address@hidden>
Cc: Artyom Tarasenko <address@hidden>
Signed-off-by: Emilio G. Cota <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>


  Commit: cd314a7d0190a03122ca0606ecf71b4b873a22c6
      
https://github.com/qemu/qemu/commit/cd314a7d0190a03122ca0606ecf71b4b873a22c6
  Author: Emilio G. Cota <address@hidden>
  Date:   2018-05-09 (Wed, 09 May 2018)

  Changed paths:
    M target/mips/translate.c

  Log Message:
  -----------
  target/mips: use lookup_and_goto_ptr on BS_STOP

The TB after BS_STOP is not fixed (e.g. helper_mtc0_hwrena
changes hflags, which ends up changing the TB flags via
cpu_get_tb_cpu_state). This requires a full lookup (i.e.
with flags) via lookup_and_goto_ptr instead of gen_goto_tb,
since the latter only looks at the PC for in-page goto's. Fix it.

Reported-by: Richard Henderson <address@hidden>
Suggested-by: Richard Henderson <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Signed-off-by: Emilio G. Cota <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>


  Commit: b28425babc2ad4b90cd87d07a1809d3322b9c065
      
https://github.com/qemu/qemu/commit/b28425babc2ad4b90cd87d07a1809d3322b9c065
  Author: Emilio G. Cota <address@hidden>
  Date:   2018-05-09 (Wed, 09 May 2018)

  Changed paths:
    M target/mips/translate.c

  Log Message:
  -----------
  target/mips: convert to DisasJumpType

Notes:

- BS_EXCP in generate_exception_err and after hen_helper_wait
  becomes DISAS_NORETURN, because we do not return after
  raising an exception.

- Some uses of BS_EXCP are misleading in that they're used
  only as a "not BS_STOP" exit condition, i.e. they have nothing
  to do with an actual exception. For those cases, define
  and use DISAS_EXIT, which is clearer. With this and the
  above change, BS_EXCP goes away completely.

- fix a comment typo (s/intetrupt/interrupt/).

Suggested-by: Richard Henderson <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Cc: Aurelien Jarno <address@hidden>
Cc: Yongbok Kim <address@hidden>
Signed-off-by: Emilio G. Cota <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>


  Commit: eeb3bba8477cebc46c482ef37d565d54e771c2d3
      
https://github.com/qemu/qemu/commit/eeb3bba8477cebc46c482ef37d565d54e771c2d3
  Author: Emilio G. Cota <address@hidden>
  Date:   2018-05-09 (Wed, 09 May 2018)

  Changed paths:
    M target/mips/translate.c

  Log Message:
  -----------
  target/mips: convert to DisasContextBase

Reviewed-by: Richard Henderson <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Cc: Aurelien Jarno <address@hidden>
Cc: Yongbok Kim <address@hidden>
Signed-off-by: Emilio G. Cota <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>


  Commit: 12be92588cf26a192f1b62846906983fc1e102a7
      
https://github.com/qemu/qemu/commit/12be92588cf26a192f1b62846906983fc1e102a7
  Author: Emilio G. Cota <address@hidden>
  Date:   2018-05-09 (Wed, 09 May 2018)

  Changed paths:
    M target/mips/translate.c

  Log Message:
  -----------
  target/mips: use *ctx for DisasContext

No changes to the logic here; this is just to make the diff
that follows easier to read.

While at it, remove the unnecessary 'struct' in
'struct TranslationBlock'.

Note that checkpatch complains with a false positive:
  ERROR: space prohibited after that '&' (ctx:WxW)
  #75: FILE: target/mips/translate.c:20220:
  +    ctx->kscrexist = (env->CP0_Config4 >> CP0C4_KScrExist) & 0xff;
                                                        ^
Reviewed-by: Richard Henderson <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Cc: Aurelien Jarno <address@hidden>
Cc: Yongbok Kim <address@hidden>
Signed-off-by: Emilio G. Cota <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>


  Commit: 18f440edfb974feaff8490d4861844b5a2b7a3b5
      
https://github.com/qemu/qemu/commit/18f440edfb974feaff8490d4861844b5a2b7a3b5
  Author: Emilio G. Cota <address@hidden>
  Date:   2018-05-09 (Wed, 09 May 2018)

  Changed paths:
    M target/mips/translate.c

  Log Message:
  -----------
  target/mips: convert to TranslatorOps

Notes:

- DISAS_TOO_MANY replaces the former "break" in the translation loop.
  However, care must be taken not to overwrite a previous condition
  in is_jmp; that's why in translate_insn we first check is_jmp and
  return if it's != DISAS_NEXT.

- Added an assert in translate_insn, before exiting due to an exception,
  to make sure that is_jmp is set to DISAS_NORETURN (the exception
  generation function always sets it.)

- Added an assert for the default case in is_jmp's switch.

Reviewed-by: Richard Henderson <address@hidden>
Cc: Aurelien Jarno <address@hidden>
Cc: Yongbok Kim <address@hidden>
Signed-off-by: Emilio G. Cota <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>


  Commit: 21a8eced9bc61633dc37c8f15739c3e04bc3d70f
      
https://github.com/qemu/qemu/commit/21a8eced9bc61633dc37c8f15739c3e04bc3d70f
  Author: Emilio G. Cota <address@hidden>
  Date:   2018-05-09 (Wed, 09 May 2018)

  Changed paths:
    M target/s390x/translate.c

  Log Message:
  -----------
  target/s390x: convert to DisasJumpType

The only non-trivial modification is the use of DISAS_TOO_MANY
in the same way is used by the generic translation loop.

Acked-by: Cornelia Huck <address@hidden>
Reviewed-by: David Hildenbrand <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Cc: David Hildenbrand <address@hidden>
Cc: Cornelia Huck <address@hidden>
Cc: Alexander Graf <address@hidden>
Cc: address@hidden
Signed-off-by: Emilio G. Cota <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>


  Commit: eccf741ab8ee9f2011bdc6d6e47917fab6bebb94
      
https://github.com/qemu/qemu/commit/eccf741ab8ee9f2011bdc6d6e47917fab6bebb94
  Author: Emilio G. Cota <address@hidden>
  Date:   2018-05-09 (Wed, 09 May 2018)

  Changed paths:
    M target/s390x/translate.c

  Log Message:
  -----------
  target/s390x: convert to DisasContextBase

Notes:

- Did not convert {num,max}_insns and is_jmp, since the corresponding
  code will go away in the next patch.

- Avoided a checkpatch error in use_exit_tb.

- As suggested by David, (1) Drop ctx.pc and use
  ctx.base.pc_next instead, and (2) Rename ctx.next_pc to
  ctx.pc_tmp and add a comment about it.

Acked-by: Cornelia Huck <address@hidden>
Suggested-by: David Hildenbrand <address@hidden>
Reviewed-by:  David Hildenbrand <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Cc: David Hildenbrand <address@hidden>
Cc: Cornelia Huck <address@hidden>
Cc: Alexander Graf <address@hidden>
Cc: address@hidden
Signed-off-by: Emilio G. Cota <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>


  Commit: c88691aaddf364f25ea5bc7c99671d1903960466
      
https://github.com/qemu/qemu/commit/c88691aaddf364f25ea5bc7c99671d1903960466
  Author: Emilio G. Cota <address@hidden>
  Date:   2018-05-09 (Wed, 09 May 2018)

  Changed paths:
    M target/s390x/translate.c

  Log Message:
  -----------
  target/s390x: convert to TranslatorOps

Note: I looked into dropping dc->do_debug. However, I don't see
an easy way to do it given that TOO_MANY is also valid
when we just translate more than max_insns. Thus, the check
for do_debug in "case DISAS_PC_CC_UPDATED" would still need
additional state to know whether or not we came from
breakpoint_check.

Acked-by: Cornelia Huck <address@hidden>
Reviewed-by: David Hildenbrand <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Tested-by:   David Hildenbrand <address@hidden>
Cc: David Hildenbrand <address@hidden>
Cc: Cornelia Huck <address@hidden>
Cc: Alexander Graf <address@hidden>
Cc: address@hidden
Signed-off-by: Emilio G. Cota <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>


  Commit: 1ffa4bced09840ffbb0802260492d3a22c5701d3
      
https://github.com/qemu/qemu/commit/1ffa4bced09840ffbb0802260492d3a22c5701d3
  Author: Emilio G. Cota <address@hidden>
  Date:   2018-05-09 (Wed, 09 May 2018)

  Changed paths:
    M target/openrisc/translate.c

  Log Message:
  -----------
  target/openrisc: convert to DisasContextBase

While at it, set is_jmp to DISAS_NORETURN when generating
an exception.

Reviewed-by: Richard Henderson <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Cc: Stafford Horne <address@hidden>
Signed-off-by: Emilio G. Cota <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>


  Commit: a4fd3ec3c7299f6a0f99e89aeb8a52c6538ca27b
      
https://github.com/qemu/qemu/commit/a4fd3ec3c7299f6a0f99e89aeb8a52c6538ca27b
  Author: Emilio G. Cota <address@hidden>
  Date:   2018-05-09 (Wed, 09 May 2018)

  Changed paths:
    M target/openrisc/translate.c

  Log Message:
  -----------
  target/openrisc: convert to TranslatorOps

Notes:

- Changed the num_insns test in insn_start to check for
  dc->base.num_insns > 1, since when tb_start is first
  called in a TB, base.num_insns is already set to 1.

- Removed DISAS_NEXT from the switch in tb_stop; use
  DISAS_TOO_MANY instead.

- Added an assert_not_reached on tb_stop for DISAS_NEXT
  and the default case.

- Merged the two separate log_target_disas calls into the
  disas_log op.

Reviewed-by: Richard Henderson <address@hidden>
Cc: Stafford Horne <address@hidden>
Signed-off-by: Emilio G. Cota <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>


  Commit: b2e32021e73349db1b2925e994b7bc4d238f5315
      
https://github.com/qemu/qemu/commit/b2e32021e73349db1b2925e994b7bc4d238f5315
  Author: Emilio G. Cota <address@hidden>
  Date:   2018-05-09 (Wed, 09 May 2018)

  Changed paths:
    M target/riscv/translate.c

  Log Message:
  -----------
  target/riscv: convert to DisasJumpType

Reviewed-by: Bastian Koppelmann <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Cc: Michael Clark <address@hidden>
Cc: Palmer Dabbelt <address@hidden>
Cc: Sagar Karandikar <address@hidden>
Cc: Bastian Koppelmann <address@hidden>
Signed-off-by: Emilio G. Cota <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>


  Commit: 0114db1c827919f22bfd86006e787fafb9d6256b
      
https://github.com/qemu/qemu/commit/0114db1c827919f22bfd86006e787fafb9d6256b
  Author: Emilio G. Cota <address@hidden>
  Date:   2018-05-09 (Wed, 09 May 2018)

  Changed paths:
    M target/riscv/translate.c

  Log Message:
  -----------
  target/riscv: convert to DisasContextBase

Notes:

- Did not convert {num,max}_insns, since the corresponding code
  will go away in the next patch.

- ctx->pc becomes ctx->base.pc_next, and ctx->next_pc becomes
  ctx->pc_succ_insn.

While at it, convert the remaining tb->cflags readers to tb_cflags().

Reviewed-by: Richard Henderson <address@hidden>
Cc: Michael Clark <address@hidden>
Cc: Palmer Dabbelt <address@hidden>
Cc: Sagar Karandikar <address@hidden>
Cc: Bastian Koppelmann <address@hidden>
Signed-off-by: Emilio G. Cota <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>


  Commit: 5b4f1d2db9fb0e24549054ee58c7a7d8f84ddd6e
      
https://github.com/qemu/qemu/commit/5b4f1d2db9fb0e24549054ee58c7a7d8f84ddd6e
  Author: Emilio G. Cota <address@hidden>
  Date:   2018-05-09 (Wed, 09 May 2018)

  Changed paths:
    M target/riscv/translate.c

  Log Message:
  -----------
  target/riscv: convert to TranslatorOps

Reviewed-by: Richard Henderson <address@hidden>
Reviewed-by: Michael Clark <address@hidden>
Cc: Palmer Dabbelt <address@hidden>
Cc: Sagar Karandikar <address@hidden>
Cc: Bastian Koppelmann <address@hidden>
Signed-off-by: Emilio G. Cota <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>


  Commit: c74e62ee3e2dc2955e07d004c71badecb68a84eb
      
https://github.com/qemu/qemu/commit/c74e62ee3e2dc2955e07d004c71badecb68a84eb
  Author: Peter Maydell <address@hidden>
  Date:   2018-05-11 (Fri, 11 May 2018)

  Changed paths:
    M accel/tcg/translator.c
    M include/exec/translator.h
    M target/alpha/translate.c
    M target/arm/translate-a64.c
    M target/arm/translate.c
    M target/arm/translate.h
    M target/cris/translate.c
    M target/hppa/translate.c
    M target/i386/translate.c
    M target/lm32/translate.c
    M target/microblaze/translate.c
    M target/mips/translate.c
    M target/openrisc/translate.c
    M target/ppc/translate.c
    M target/riscv/translate.c
    M target/s390x/translate.c
    M target/sh4/translate.c
    M target/sparc/translate.c
    M target/tilegx/translate.c
    M target/unicore32/translate.c
    M target/xtensa/translate.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/rth/tags/cota-target-pull-request' into 
staging

* Fix all next_page checks for overflow.
* Convert six targets to the translator loop.

# gpg: Signature made Wed 09 May 2018 18:20:43 BST
# gpg:                using RSA key 64DF38E8AF7E215F
# gpg: Good signature from "Richard Henderson <address@hidden>"
# Primary key fingerprint: 7A48 1E78 868B 4DB6 A85A  05C0 64DF 38E8 AF7E 215F

* remotes/rth/tags/cota-target-pull-request: (28 commits)
  target/riscv: convert to TranslatorOps
  target/riscv: convert to DisasContextBase
  target/riscv: convert to DisasJumpType
  target/openrisc: convert to TranslatorOps
  target/openrisc: convert to DisasContextBase
  target/s390x: convert to TranslatorOps
  target/s390x: convert to DisasContextBase
  target/s390x: convert to DisasJumpType
  target/mips: convert to TranslatorOps
  target/mips: use *ctx for DisasContext
  target/mips: convert to DisasContextBase
  target/mips: convert to DisasJumpType
  target/mips: use lookup_and_goto_ptr on BS_STOP
  target/sparc: convert to TranslatorOps
  target/sparc: convert to DisasContextBase
  target/sparc: convert to DisasJumpType
  target/sh4: convert to TranslatorOps
  translator: merge max_insns into DisasContextBase
  target/mips: avoid integer overflow in next_page PC check
  target/s390x: avoid integer overflow in next_page PC check
  ...

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/6d7cde809d91...c74e62ee3e2d
      **NOTE:** This service been marked for deprecation: 
https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]