[Qemu-commits] [qemu/qemu] 24e8d1: usb-mtp: Add some NULL checks for issues pointed o...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 24e8d1faea1e4a2dc59841e048390645d7804cb5
      
https://github.com/qemu/qemu/commit/24e8d1faea1e4a2dc59841e048390645d7804cb5
  Author: Bandan Das <address@hidden>
  Date:   2018-05-07 (Mon, 07 May 2018)

  Changed paths:
    M hw/usb/dev-mtp.c

  Log Message:
  -----------
  usb-mtp: Add some NULL checks for issues pointed out by coverity

CID 1390578: In usb_mtp_write_metadata, parent can never be NULL but
just in case, add an assert
CID 1390592: Check for o->format only if o !=NULL
CID 1390604: Check s->data_out != NULL in usb_mtp_handle_data

Signed-off-by: Bandan Das <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 2392ae6bbb0a940a4fd6df29e704b09cadc14790
      
https://github.com/qemu/qemu/commit/2392ae6bbb0a940a4fd6df29e704b09cadc14790
  Author: Bandan Das <address@hidden>
  Date:   2018-05-07 (Mon, 07 May 2018)

  Changed paths:
    M hw/usb/dev-mtp.c

  Log Message:
  -----------
  usb-mtp: Unconditionally check for the readonly bit

Currently, it's only being checked if desc is NULL and
so write support breaks upon specifying desc

Signed-off-by: Bandan Das <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 3280ea8edede3814553aa19fa27a58daedd48ad9
      
https://github.com/qemu/qemu/commit/3280ea8edede3814553aa19fa27a58daedd48ad9
  Author: Gerd Hoffmann <address@hidden>
  Date:   2018-05-07 (Mon, 07 May 2018)

  Changed paths:
    M hw/usb/host-libusb.c

  Log Message:
  -----------
  usb-host: skip open on pending postload bh

usb-host emulates a device unplug after live migration, because the
device state is unknown and unplug/replug makes sure the guest
re-initializes the device into a working state.  This can't be done in
post-load though, so post-load just schedules a bottom half which
executes after vmload is complete.

It can happen that the device autoscan timer hits the race window
between scheduling and running the bottom half, which in turn can
triggers an assert().

Fix that issue by just ignoring the usb_host_open() call in case the
bottom half didn't execute yet.

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1572851
Signed-off-by: Gerd Hoffmann <address@hidden>
Message-id: address@hidden


  Commit: 302a84e878e89e11531eb4dff51156e3bee39c49
      
https://github.com/qemu/qemu/commit/302a84e878e89e11531eb4dff51156e3bee39c49
  Author: Peter Maydell <address@hidden>
  Date:   2018-05-08 (Tue, 08 May 2018)

  Changed paths:
    M hw/usb/dev-mtp.c
    M hw/usb/host-libusb.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/kraxel/tags/usb-20180507-pull-request' 
into staging

usb: fixes for mtp and host.

# gpg: Signature made Mon 07 May 2018 10:44:26 BST
# gpg:                using RSA key 4CB6D8EED3E87138
# gpg: Good signature from "Gerd Hoffmann (work) <address@hidden>"
# gpg:                 aka "Gerd Hoffmann <address@hidden>"
# gpg:                 aka "Gerd Hoffmann (private) <address@hidden>"
# Primary key fingerprint: A032 8CFF B93A 17A7 9901  FE7D 4CB6 D8EE D3E8 7138

* remotes/kraxel/tags/usb-20180507-pull-request:
  usb-host: skip open on pending postload bh
  usb-mtp: Unconditionally check for the readonly bit
  usb-mtp: Add some NULL checks for issues pointed out by coverity

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/2fb513d3b1e3...302a84e878e8
      **NOTE:** This service been marked for deprecation: 
https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.