qemu-commits
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 1bad49: hw/rdma: Fix possible munmap call on

From: GitHub
Subject: [Qemu-commits] [qemu/qemu] 1bad49: hw/rdma: Fix possible munmap call on a NULL pointe...
Date: Fri, 04 May 2018 01:24:28 -0700 
  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 1bad4957c8c4d5367961cb3d5287b2f25a1d6847
      
https://github.com/qemu/qemu/commit/1bad4957c8c4d5367961cb3d5287b2f25a1d6847
  Author: Marcel Apfelbaum <address@hidden>
  Date:   2018-05-03 (Thu, 03 May 2018)

  Changed paths:
    M hw/rdma/vmw/pvrdma_cmd.c

  Log Message:
  -----------
  hw/rdma: Fix possible munmap call on a NULL pointer

Coverity CID 1390620: we call munmap() on a NULL pointer.

Reported-by: Peter Maydell <address@hidden>
Signed-off-by: Marcel Apfelbaum <address@hidden>
Reviewed-by: Yuval Shaia <address@hidden>
Message-Id: <address@hidden>


  Commit: b0197cf80a903aa1e401cc7ebdf8be8bc307297b
      
https://github.com/qemu/qemu/commit/b0197cf80a903aa1e401cc7ebdf8be8bc307297b
  Author: Marcel Apfelbaum <address@hidden>
  Date:   2018-05-03 (Thu, 03 May 2018)

  Changed paths:
    M hw/rdma/vmw/pvrdma_qp_ops.c

  Log Message:
  -----------
  hw/rdma: Fix possible usage of a NULL pointer

Coverity CID 1390586; The cq handle is provided by the guest
and cannot be trusted to be previuosly allocated.
Fix it by exiting the completion flow.

Reported-by: Peter Maydell <address@hidden>
Signed-off-by: Marcel Apfelbaum <address@hidden>
Reviewed-by: Yuval Shaia <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>


  Commit: b9e34872b95af26076e2b456fd1c3e9dd65f3b19
      
https://github.com/qemu/qemu/commit/b9e34872b95af26076e2b456fd1c3e9dd65f3b19
  Author: Yuval Shaia <address@hidden>
  Date:   2018-05-03 (Thu, 03 May 2018)

  Changed paths:
    M hw/rdma/rdma_rm_defs.h
    M hw/rdma/vmw/pvrdma_main.c

  Log Message:
  -----------
  hw/rdma: Delete port's pkey table

Support for PKEY is not yet implemented. Removing the unneeded table
until a support will be added.

Signed-off-by: Yuval Shaia <address@hidden>
Reviewed-by: Marcel Apfelbaum <address@hidden>
Message-Id: <address@hidden>


  Commit: c387e8a4ecee76479f4b83b58e2e8ab854ef74ee
      
https://github.com/qemu/qemu/commit/c387e8a4ecee76479f4b83b58e2e8ab854ef74ee
  Author: Yuval Shaia <address@hidden>
  Date:   2018-05-03 (Thu, 03 May 2018)

  Changed paths:
    M hw/rdma/rdma_rm_defs.h
    M hw/rdma/vmw/pvrdma_cmd.c

  Log Message:
  -----------
  hw/rdma: Fix possible out of bounds access to GID table

Array size is MAX_PORT_GIDS, let's make sure the given index is in
range.

While there limit device table size to 1.

Reported-by: Peter Maydell <address@hidden>
Signed-off-by: Yuval Shaia <address@hidden>
Reviewed-by: Marcel Apfelbaum <address@hidden>
Message-Id: <address@hidden>


  Commit: 350929172b0205dccf19c29b93ac41a406ef740d
      
https://github.com/qemu/qemu/commit/350929172b0205dccf19c29b93ac41a406ef740d
  Author: Yuval Shaia <address@hidden>
  Date:   2018-05-03 (Thu, 03 May 2018)

  Changed paths:
    M hw/rdma/vmw/pvrdma.h
    M hw/rdma/vmw/pvrdma_main.c

  Log Message:
  -----------
  hw/rdma: Fix possible out of bounds access to regs array

Coverity (CID1390589, CID1390608).
Array size is RDMA_BAR1_REGS_SIZE, let's make sure the given address is
in range.

While there also:
1. Adjust the size of this bar to reasonable size
2. Report the size of the array with sizeof(array)

Reported-by: Peter Maydell <address@hidden>
Signed-off-by: Yuval Shaia <address@hidden>
Reviewed-by: Marcel Apfelbaum <address@hidden>
Message-Id: <address@hidden>


  Commit: 6c080b9ea6efbc277cfa7afc7d4f9d8cc3a9020b
      
https://github.com/qemu/qemu/commit/6c080b9ea6efbc277cfa7afc7d4f9d8cc3a9020b
  Author: Yuval Shaia <address@hidden>
  Date:   2018-05-03 (Thu, 03 May 2018)

  Changed paths:
    M hw/rdma/rdma_rm.c
    M hw/rdma/rdma_rm_defs.h

  Log Message:
  -----------
  hw/rdma: Delete duplicate definition of MAX_RM_TBL_NAME

By a mistake this constant was defined twice - remove the duplication.

Signed-off-by: Yuval Shaia <address@hidden>
Reviewed-by: Marcel Apfelbaum <address@hidden>
Message-Id: <address@hidden>


  Commit: d18a530d8589257cd81960284df8730ef869cabe
      
https://github.com/qemu/qemu/commit/d18a530d8589257cd81960284df8730ef869cabe
  Author: Marcel Apfelbaum <address@hidden>
  Date:   2018-05-03 (Thu, 03 May 2018)

  Changed paths:
    M hw/rdma/rdma_backend.c

  Log Message:
  -----------
  hw/rdma: Fix possible out of bounds access to port GID index

Make sure the backend GID index is less then port's
gid table length.

Signed-off-by: Marcel Apfelbaum <address@hidden>
Reviewed-by: Yuval Shaia <address@hidden>
Message-Id: <address@hidden>


  Commit: fe355cbda28b5e3dfc6a70b902343b84c466aa17
      
https://github.com/qemu/qemu/commit/fe355cbda28b5e3dfc6a70b902343b84c466aa17
  Author: Marcel Apfelbaum <address@hidden>
  Date:   2018-05-03 (Thu, 03 May 2018)

  Changed paths:
    M MAINTAINERS

  Log Message:
  -----------
  MAINTAINERS: update Marcel Apfelbaum email

Use my gmail account for maintainer tasks.

Signed-off-by: Marcel Apfelbaum <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Yuval Shaia <address@hidden>


  Commit: e2f557f9889fea29fbb7bafae7719e38821df8fb
      
https://github.com/qemu/qemu/commit/e2f557f9889fea29fbb7bafae7719e38821df8fb
  Author: Peter Maydell <address@hidden>
  Date:   2018-05-03 (Thu, 03 May 2018)

  Changed paths:
    M MAINTAINERS
    M hw/rdma/rdma_backend.c
    M hw/rdma/rdma_rm.c
    M hw/rdma/rdma_rm_defs.h
    M hw/rdma/vmw/pvrdma.h
    M hw/rdma/vmw/pvrdma_cmd.c
    M hw/rdma/vmw/pvrdma_main.c
    M hw/rdma/vmw/pvrdma_qp_ops.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/marcel/tags/rdma-pull-request' into 
staging

* fix PVRDMA coverity errors
* update MAINTAINERS file

# gpg: Signature made Thu 03 May 2018 18:53:00 BST
# gpg:                using RSA key 36D4C0F0CF2FE46D
# gpg: Good signature from "Marcel Apfelbaum <address@hidden>"
# gpg: WARNING: This key is not certified with sufficiently trusted signatures!
# gpg:          It is not certain that the signature belongs to the owner.
# Primary key fingerprint: B1C6 3A57 F92E 08F2 640F  31F5 36D4 C0F0 CF2F E46D

* remotes/marcel/tags/rdma-pull-request:
  MAINTAINERS: update Marcel Apfelbaum email
  hw/rdma: Fix possible out of bounds access to port GID index
  hw/rdma: Delete duplicate definition of MAX_RM_TBL_NAME
  hw/rdma: Fix possible out of bounds access to regs array
  hw/rdma: Fix possible out of bounds access to GID table
  hw/rdma: Delete port's pkey table
  hw/rdma: Fix possible usage of a NULL pointer
  hw/rdma: Fix possible munmap call on a NULL pointer

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/59255887e6ca...e2f557f9889f
      **NOTE:** This service been marked for deprecation: 
https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.
reply via email to
[Prev in Thread] Current Thread [Next in Thread]