[Qemu-commits] [qemu/qemu] d9b06d: hw/s390x: fix memory leak in s390_init_ipl_dev()

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: d9b06db813270d9deacd9e8f2ae3fd0d88f03f2a
      
https://github.com/qemu/qemu/commit/d9b06db813270d9deacd9e8f2ae3fd0d88f03f2a
  Author: Greg Kurz <address@hidden>
  Date:   2018-04-03 (Tue, 03 Apr 2018)

  Changed paths:
    M hw/s390x/s390-virtio-ccw.c

  Log Message:
  -----------
  hw/s390x: fix memory leak in s390_init_ipl_dev()

The string returned by object_property_get_str() is dynamically allocated.

Fixes: 3c4e9baacf4d9
Signed-off-by: Greg Kurz <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Cornelia Huck <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>
Signed-off-by: Cornelia Huck <address@hidden>


  Commit: 23bf419c1c48e71c08737045f7d9c9b5e05ac4a7
      
https://github.com/qemu/qemu/commit/23bf419c1c48e71c08737045f7d9c9b5e05ac4a7
  Author: Thomas Huth <address@hidden>
  Date:   2018-04-03 (Tue, 03 Apr 2018)

  Changed paths:
    M pc-bios/s390-ccw/virtio.c

  Log Message:
  -----------
  pc-bios/s390-ccw: Increase virtio timeout to 30 seconds

The current timeout is set to only three seconds - and considering that
vring_wait_reply() or rather get_second() is not doing any rounding,
the real timeout is likely rather 2 seconds in most cases. When the
host is really badly loaded, it's possible that we hit this timeout by
mistake; it's even more likely if we run the guest in TCG mode instead
of KVM.

So let's increase the timeout to 30 seconds instead to ease this situation
(30 seconds is also the timeout that is used by the Linux SCSI subsystem
for example, so this seems to be a sane value for block IO timeout).

Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1549079
Signed-off-by: Thomas Huth <address@hidden>
Message-Id: <address@hidden>
Acked-by: Christian Borntraeger <address@hidden>
[CH: tweaked commit message]
Signed-off-by: Cornelia Huck <address@hidden>


  Commit: d3b6e3bb6dc582099b8572c439fa651b3672de89
      
https://github.com/qemu/qemu/commit/d3b6e3bb6dc582099b8572c439fa651b3672de89
  Author: Cornelia Huck <address@hidden>
  Date:   2018-04-03 (Tue, 03 Apr 2018)

  Changed paths:
    M pc-bios/s390-ccw.img

  Log Message:
  -----------
  pc-bios/s390-ccw: update image

Contains the following commits:
- pc-bios/s390-ccw: Move string arrays from bootmap header to .c file
- pc-bios/s390-ccw: Increase virtio timeout to 30 seconds

Signed-off-by: Cornelia Huck <address@hidden>


  Commit: f7481f651ccf7bf0fe3547b16820c9d18da8f584
      
https://github.com/qemu/qemu/commit/f7481f651ccf7bf0fe3547b16820c9d18da8f584
  Author: Peter Maydell <address@hidden>
  Date:   2018-04-03 (Tue, 03 Apr 2018)

  Changed paths:
    M hw/s390x/s390-virtio-ccw.c
    M pc-bios/s390-ccw.img
    M pc-bios/s390-ccw/virtio.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20180403' into staging

- fix a memory leak in the ipl code introduced with this release
- increase timeout in the bios to avoid hangs during migration (and
  rebuild bios to activate the change)

# gpg: Signature made Tue 03 Apr 2018 09:28:30 BST
# gpg:                using RSA key DECF6B93C6F02FAF
# gpg: Good signature from "Cornelia Huck <address@hidden>"
# gpg:                 aka "Cornelia Huck <address@hidden>"
# gpg:                 aka "Cornelia Huck <address@hidden>"
# gpg:                 aka "Cornelia Huck <address@hidden>"
# gpg:                 aka "Cornelia Huck <address@hidden>"
# Primary key fingerprint: C3D0 D66D C362 4FF6 A8C0  18CE DECF 6B93 C6F0 2FAF

* remotes/cohuck/tags/s390x-20180403:
  pc-bios/s390-ccw: update image
  pc-bios/s390-ccw: Increase virtio timeout to 30 seconds
  hw/s390x: fix memory leak in s390_init_ipl_dev()

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/9abfc88af3ff...f7481f651ccf