[Qemu-commits] [qemu/qemu] 36b4cf: scripts/get_maintainer.pl: Print proper error mess...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 36b4cf19348c98fa070dbb99e4bb2eb190ff4cef
      
https://github.com/qemu/qemu/commit/36b4cf19348c98fa070dbb99e4bb2eb190ff4cef
  Author: Ian Jackson <address@hidden>
  Date:   2018-03-26 (Mon, 26 Mar 2018)

  Changed paths:
    M scripts/get_maintainer.pl

  Log Message:
  -----------
  scripts/get_maintainer.pl: Print proper error message for missing $file

If you pass scripts/get_maintainer.pl the name of a FIFO or other
exciting object (/dev/stdin, for example), it would falsely print
"file not found".  Instead: stat the object rather than using -f so
that we do not mind if the object is not a file; and print the errno
value in the error message.

Signed-off-by: Ian Jackson <address@hidden>
CC: Thomas Huth <address@hidden>
CC: Paolo Bonzini <address@hidden>
CC: Stefano Stabellini <address@hidden>
CC: Anthony PERARD <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
Signed-off-by: Ian Jackson <address@hidden>


  Commit: 3907e6318eae2668712bba04edc10e3648292508
      
https://github.com/qemu/qemu/commit/3907e6318eae2668712bba04edc10e3648292508
  Author: Justin Terry (VM) <address@hidden>
  Date:   2018-03-26 (Mon, 26 Mar 2018)

  Changed paths:
    M configure
    M target/i386/whpx-all.c

  Log Message:
  -----------
  WHPX fix WHvGetCapability out WrittenSizeInBytes

This fixes a breaking change to WHvGetCapability to include the 'out'
WrittenSizeInBytes introduced in Windows Insider SDK 17110.

This specifies on return the safe length to read into the WHV_CAPABILITY
structure passed to the call.

Signed-off-by: Justin Terry (VM) <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>


  Commit: 60168541dab015f71b1a2f5e70df3c0fe44d91c4
      
https://github.com/qemu/qemu/commit/60168541dab015f71b1a2f5e70df3c0fe44d91c4
  Author: Justin Terry (VM) <address@hidden>
  Date:   2018-03-26 (Mon, 26 Mar 2018)

  Changed paths:
    M target/i386/whpx-all.c

  Log Message:
  -----------
  WHPX fix WHvSetPartitionProperty in PropertyCode

This fixes a breaking change to WHvSetPartitionProperty to pass the 'in'
PropertyCode on function invocation introduced in Windows Insider SDK 17110.
Usage of this indicates the PropertyCode of the opaque PropertyBuffer passed in
on function invocation.

Also fixes the removal of the PropertyCode parameter from the
WHV_PARTITION_PROPERTY struct as it is now passed to the function directly.

Signed-off-by: Justin Terry (VM) <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>


  Commit: 4e286099fee107d801f190145de54e47cc5bb3d2
      
https://github.com/qemu/qemu/commit/4e286099fee107d801f190145de54e47cc5bb3d2
  Author: Justin Terry (VM) <address@hidden>
  Date:   2018-03-26 (Mon, 26 Mar 2018)

  Changed paths:
    M target/i386/whpx-all.c

  Log Message:
  -----------
  WHPX improve vcpu_post_run perf

This removes the additional call to WHvGetVirtualProcessorRegisters in
whpx_vcpu_post_run now that the WHV_VP_EXIT_CONTEXT is returned in all
WHV_RUN_VP_EXIT_CONTEXT structures.

Signed-off-by: Justin Terry (VM) <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>


  Commit: 089eac81e1d34d202471c0a023284f47f4c5f00e
      
https://github.com/qemu/qemu/commit/089eac81e1d34d202471c0a023284f47f4c5f00e
  Author: Thomas Huth <address@hidden>
  Date:   2018-03-26 (Mon, 26 Mar 2018)

  Changed paths:
    M hw/net/can/can_sja1000.c

  Log Message:
  -----------
  hw/net/can: Fix segfaults when using the devices without bus

The CAN devices can currently be used to crash QEMU, e.g.:

$ x86_64-softmmu/qemu-system-x86_64 -device kvaser_pci
Segmentation fault (core dumped)

So we've got to add a proper check here that the corresponding
bus is available.

Signed-off-by: Thomas Huth <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>


  Commit: b3da551389c86ce214d5418c174134c3e1c838ab
      
https://github.com/qemu/qemu/commit/b3da551389c86ce214d5418c174134c3e1c838ab
  Author: Alexey Kardashevskiy <address@hidden>
  Date:   2018-03-26 (Mon, 26 Mar 2018)

  Changed paths:
    M hw/block/fdc.c

  Log Message:
  -----------
  fdc: Exit if ISA controller does not support DMA

A "powernv" machine type defines an ISA bus but it does not add any DMA
controller to it so it is possible to hit assert(fdctrl->dma) by
adding "-machine powernv -device isa-fdc".

This replaces assert() with an error message.

Signed-off-by: Alexey Kardashevskiy <address@hidden>
[thuth: Slightly adjusted error message and updated scripts/device-crash-test]
Signed-off-by: Thomas Huth <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>


  Commit: c9073238fcb647644b329705ad54734ad1f0b1a3
      
https://github.com/qemu/qemu/commit/c9073238fcb647644b329705ad54734ad1f0b1a3
  Author: Thomas Huth <address@hidden>
  Date:   2018-03-26 (Mon, 26 Mar 2018)

  Changed paths:
    M hw/audio/cs4231a.c
    M hw/audio/gus.c
    M hw/audio/sb16.c
    M scripts/device-crash-test

  Log Message:
  -----------
  hw/audio: Fix crashes when devices are used on ISA bus without DMA

The cs4231a, gus and sb16 sound cards crash QEMU when the user tries
to instantiate them on a machine with DMA-less ISA bus (for example
with "qemu-system-mips64el -M mips -device sb16"). Add proper checks
to the realize functions to avoid the crashes.

Signed-off-by: Thomas Huth <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>


  Commit: 6ff8d9b03af289153cb88c9ef84ae9a76b888d88
      
https://github.com/qemu/qemu/commit/6ff8d9b03af289153cb88c9ef84ae9a76b888d88
  Author: Thomas Huth <address@hidden>
  Date:   2018-03-26 (Mon, 26 Mar 2018)

  Changed paths:
    M scripts/device-crash-test

  Log Message:
  -----------
  scripts/device-crash-test: Remove fixed isapc-with-iommu entry

Fixed in a0c167a18470831e359f0538c3cf67907808f13e ("x86_iommu: check
if machine has PCI bus").

Signed-off-by: Thomas Huth <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>


  Commit: 642e065a15de6c22d9830372f7ae5164505f21c7
      
https://github.com/qemu/qemu/commit/642e065a15de6c22d9830372f7ae5164505f21c7
  Author: Marc-André Lureau <address@hidden>
  Date:   2018-03-26 (Mon, 26 Mar 2018)

  Changed paths:
    M tests/vhost-user-test.c

  Log Message:
  -----------
  vhost-user-test: do not hang if chardev creation failed

Before the chardev name fix, the following error may happen: "attempt
to add duplicate property 'chr-test' to object (type 'container')",
due to races.

Sadly, error_vprintf() uses g_test_message(), so you have to use
read the cryptic --debug-log to see it. Later, it would make sense to
use g_critical() instead, and catch errors with
g_test_expect_message() (in glib 2.34).

Signed-off-by: Marc-André Lureau <address@hidden>
Message-Id: <address@hidden>
Acked-by: Maxime Coquelin <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>


  Commit: 8e029fd64ea09cea4cd5cfd7c4c04714571cbae6
      
https://github.com/qemu/qemu/commit/8e029fd64ea09cea4cd5cfd7c4c04714571cbae6
  Author: Marc-André Lureau <address@hidden>
  Date:   2018-03-26 (Mon, 26 Mar 2018)

  Changed paths:
    M tests/vhost-user-test.c

  Log Message:
  -----------
  vhost-user-test: add back memfd check

This revert commit fb68096da3d35e64c88cd610c1fa42766c58e92a, and
modify test_read_guest_mem() to use different chardev names, when
using memfd (_test_server_free(), where the chardev is removed, runs
in idle).

Signed-off-by: Marc-André Lureau <address@hidden>
Message-Id: <address@hidden>
Acked-by: Maxime Coquelin <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>


  Commit: 87f963be66a32453e001d1052b000f1653605caa
      
https://github.com/qemu/qemu/commit/87f963be66a32453e001d1052b000f1653605caa
  Author: Richard Henderson <address@hidden>
  Date:   2018-03-26 (Mon, 26 Mar 2018)

  Changed paths:
    M accel/tcg/translate-all.c

  Log Message:
  -----------
  tcg: Really fix cpu_io_recompile

We have confused the number of instructions that have been
executed in the TB with the number of instructions needed
to repeat the I/O instruction.

We have used cpu_restore_state_from_tb, which means that
the guest pc is pointing to the I/O instruction.  The only
time the answer to the later question is not 1 is when
MIPS or SH4 need to re-execute the branch for the delay
slot as well.

We must rely on cpu->cflags_next_tb to generate the next TB,
as otherwise we have a race condition with other guest cpus
within the TB cache.

Fixes: 0790f86861079b1932679d0f011e431aaf4ee9e2
Signed-off-by: Richard Henderson <address@hidden>
Message-Id: <address@hidden>
Tested-by: Pavel Dovgalyuk <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>


  Commit: ff82fab792cba01f29a700e4c4ac660753961fbb
      
https://github.com/qemu/qemu/commit/ff82fab792cba01f29a700e4c4ac660753961fbb
  Author: Paolo Bonzini <address@hidden>
  Date:   2018-03-26 (Mon, 26 Mar 2018)

  Changed paths:
    M chardev/char-socket.c

  Log Message:
  -----------
  chardev-socket: remove useless if

This trips Coverity, which believes the subsequent qio_channel_create_watch
can dereference a NULL pointer.  In reality, tcp_chr_connect's callers
all have s->ioc properly initialized, since they are all rooted at
tcp_chr_new_client.

Reviewed-by: Marc-André Lureau <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>


  Commit: 09c2c6ffda7f8f7c64869bc465c2d1715769ebae
      
https://github.com/qemu/qemu/commit/09c2c6ffda7f8f7c64869bc465c2d1715769ebae
  Author: Paolo Bonzini <address@hidden>
  Date:   2018-03-26 (Mon, 26 Mar 2018)

  Changed paths:
    M hw/scsi/scsi-disk.c
    M hw/scsi/scsi-generic.c

  Log Message:
  -----------
  scsi: turn "is this a SCSI device?" into a conditional hint

If the user does not have permissions to send ioctls to the device (due to
SELinux or cgroups, for example), the output can look like

qemu-kvm: -device scsi-block,drive=disk: cannot get SG_IO version number:
  Operation not permitted.  Is this a SCSI device?

but this is confusing because the ioctl was blocked _before_ the device
even received the SG_GET_VERSION_NUM ioctl.  Therefore, for EPERM errors
the suggestion should be eliminated.  To make that simpler, change the
code to use error_append_hint.

Reported-by: Ala Hino <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>


  Commit: 90c558beca0c0ef26db1ed77d1eb8f24a5ea02a1
      
https://github.com/qemu/qemu/commit/90c558beca0c0ef26db1ed77d1eb8f24a5ea02a1
  Author: Peter Xu <address@hidden>
  Date:   2018-03-26 (Mon, 26 Mar 2018)

  Changed paths:
    M iothread.c
    M util/aio-win32.c

  Log Message:
  -----------
  iothread: fix breakage on windows

OOB can enable iothread for parsing even on Windows.  We need some tunes
to enable that on Windows otherwise it'll break Windows users.  This
patch fixes the breakage on Windows with qemu-system-ppc.exe.

Reported-by: Howard Spoelstra <address@hidden>
Tested-by: Howard Spoelstra <address@hidden>
Suggested-by: Paolo Bonzini <address@hidden>
Signed-off-by: Peter Xu <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>


  Commit: 12051d82f004024d5d0202279be898c7b38cea56
      
https://github.com/qemu/qemu/commit/12051d82f004024d5d0202279be898c7b38cea56
  Author: Peter Maydell <address@hidden>
  Date:   2018-03-26 (Mon, 26 Mar 2018)

  Changed paths:
    M chardev/char-fe.c

  Log Message:
  -----------
  chardev/char-fe: Allow NULL chardev in qemu_chr_fe_init()

All the functions in char-fe.c handle the CharBackend
having a NULL Chardev pointer, which means that the
backend exists but is not connected to anything. The
exception is qemu_chr_fe_init(), which will crash if
passed a NULL Chardev pointer argument. This can happen
for various boards if they're started with 'nodefaults':
 arm-softmmu/qemu-system-arm -S -nodefaults -M cubieboard
 riscv32-softmmu/qemu-system-riscv32 -nodefaults -M sifive_e

Make qemu_chr_fe_init() accept a NULL chardev. This allows
UART models to handle NULL chardev properties without
generally needing to special case them or to manually
create a NullChardev.

Reported-by: Thomas Huth <address@hidden>
Signed-off-by: Peter Maydell <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>


  Commit: f8e1a989644f22ba2f7afb0e13b6ce2309ea9503
      
https://github.com/qemu/qemu/commit/f8e1a989644f22ba2f7afb0e13b6ce2309ea9503
  Author: Michal Privoznik <address@hidden>
  Date:   2018-03-26 (Mon, 26 Mar 2018)

  Changed paths:
    M scsi/qemu-pr-helper.c

  Log Message:
  -----------
  qemu-pr-helper: Actually allow users to specify pidfile

Due to wrong specification of arguments to getopt_long() any
attempt to set pidfile resulted in:

1) the default to be leaked
2) the @pidfile variable to be set to NULL (because optarg is
NULL without this patch).

Signed-off-by: Michal Privoznik <address@hidden>
Message-Id: <address@hidden>
Cc: address@hidden
Reviewed-by: Eric Blake <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>


  Commit: 7b93d78a04aa242d377ae213b79db6c319c71847
      
https://github.com/qemu/qemu/commit/7b93d78a04aa242d377ae213b79db6c319c71847
  Author: Peter Maydell <address@hidden>
  Date:   2018-03-26 (Mon, 26 Mar 2018)

  Changed paths:
    M accel/tcg/translate-all.c
    M chardev/char-fe.c
    M chardev/char-socket.c
    M configure
    M hw/audio/cs4231a.c
    M hw/audio/gus.c
    M hw/audio/sb16.c
    M hw/block/fdc.c
    M hw/net/can/can_sja1000.c
    M hw/scsi/scsi-disk.c
    M hw/scsi/scsi-generic.c
    M iothread.c
    M scripts/device-crash-test
    M scripts/get_maintainer.pl
    M scsi/qemu-pr-helper.c
    M target/i386/whpx-all.c
    M tests/vhost-user-test.c
    M util/aio-win32.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging

Miscellaenous bugfixes, including crash fixes from Alexey, Peter M. and
Thomas.

# gpg: Signature made Mon 26 Mar 2018 13:37:38 BST
# gpg:                using RSA key BFFBD25F78C7AE83
# gpg: Good signature from "Paolo Bonzini <address@hidden>"
# gpg:                 aka "Paolo Bonzini <address@hidden>"
# Primary key fingerprint: 46F5 9FBD 57D6 12E7 BFD4  E2F7 7E15 100C CD36 69B1
#      Subkey fingerprint: F133 3857 4B66 2389 866C  7682 BFFB D25F 78C7 AE83

* remotes/bonzini/tags/for-upstream:
  qemu-pr-helper: Actually allow users to specify pidfile
  chardev/char-fe: Allow NULL chardev in qemu_chr_fe_init()
  iothread: fix breakage on windows
  scsi: turn "is this a SCSI device?" into a conditional hint
  chardev-socket: remove useless if
  tcg: Really fix cpu_io_recompile
  vhost-user-test: add back memfd check
  vhost-user-test: do not hang if chardev creation failed
  scripts/device-crash-test: Remove fixed isapc-with-iommu entry
  hw/audio: Fix crashes when devices are used on ISA bus without DMA
  fdc: Exit if ISA controller does not support DMA
  hw/net/can: Fix segfaults when using the devices without bus
  WHPX improve vcpu_post_run perf
  WHPX fix WHvSetPartitionProperty in PropertyCode
  WHPX fix WHvGetCapability out WrittenSizeInBytes
  scripts/get_maintainer.pl: Print proper error message for missing $file

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/2ffd221d07a6...7b93d78a04aa