qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 4fd78a: Revert "tests: qmp-test: add oob test


From: GitHub
Subject: [Qemu-commits] [qemu/qemu] 4fd78a: Revert "tests: qmp-test: add oob test"
Date: Sat, 24 Mar 2018 09:33:41 -0700

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 4fd78ad7934bbd002da8ea420ce16f73ad23f417
      
https://github.com/qemu/qemu/commit/4fd78ad7934bbd002da8ea420ce16f73ad23f417
  Author: Peter Xu <address@hidden>
  Date:   2018-03-23 (Fri, 23 Mar 2018)

  Changed paths:
    M tests/qmp-test.c

  Log Message:
  -----------
  Revert "tests: qmp-test: add oob test"

This reverts commit d003f7a8f9cafe50119975844fa01afc2baf41fb.

Enabling OOB caused several iotests failures; due to the imminent
2.12 release, the safest action is to disable OOB, but first we
have to revert tests that rely on OOB.

Signed-off-by: Peter Xu <address@hidden>
Message-Id: <address@hidden>
Tested-by: Christian Borntraeger <address@hidden>
[eblake: reorder commits, enhance commit message]
Signed-off-by: Eric Blake <address@hidden>


  Commit: cc797607c03722871a030f8a64d800a8df93b5b2
      
https://github.com/qemu/qemu/commit/cc797607c03722871a030f8a64d800a8df93b5b2
  Author: Peter Xu <address@hidden>
  Date:   2018-03-23 (Fri, 23 Mar 2018)

  Changed paths:
    M tests/qmp-test.c

  Log Message:
  -----------
  Revert "tests: qmp-test: verify command batching"

This reverts commit 91ad45061af0fe44ac5dadb5bedaf4d7a08077c8.

Enabling OOB caused several iotests failures; due to the imminent
2.12 release, the safest action is to disable OOB, but first we
have to revert tests that rely on OOB.

Signed-off-by: Peter Xu <address@hidden>
Message-Id: <address@hidden>
Tested-by: Christian Borntraeger <address@hidden>
[eblake: reorder commits, enhance commit message]
Signed-off-by: Eric Blake <address@hidden>


  Commit: a4f90923b520f1dc0a768634877eb412e5052c26
      
https://github.com/qemu/qemu/commit/a4f90923b520f1dc0a768634877eb412e5052c26
  Author: Peter Xu <address@hidden>
  Date:   2018-03-23 (Fri, 23 Mar 2018)

  Changed paths:
    M monitor.c
    M tests/qmp-test.c

  Log Message:
  -----------
  Revert "monitor: enable IO thread for (qmp & !mux) typed"

This reverts commit 3fd2457d18edf5736f713dfe1ada9c87a9badab1.

Enabling OOB caused several iotests failures; due to the imminent
2.12 release, the safest action is to disable OOB for now.  If
other patches fix the issues that iotests exposed, it may be turned
back on in time for the release, otherwise it will be 2.13 material;
either way, the framework changes not reverted now do not hurt if
they remain as part of the 2.12 release.

Additionally, revert the tests in the patch 02130314d8 ("qmp: introduce
QMPCapability", 2018-03-19), as both parts must be reverted at once
to keep 'make check' passing.

Signed-off-by: Peter Xu <address@hidden>
Message-Id: <address@hidden>
Tested-by: Christian Borntraeger <address@hidden>
[eblake: reorder/squash commits, enhance commit message]
Signed-off-by: Eric Blake <address@hidden>


  Commit: 39615354fc07af34e04ab5efb5b6d478b0d24e32
      
https://github.com/qemu/qemu/commit/39615354fc07af34e04ab5efb5b6d478b0d24e32
  Author: Eric Blake <address@hidden>
  Date:   2018-03-23 (Fri, 23 Mar 2018)

  Changed paths:
    M tests/Makefile.include

  Log Message:
  -----------
  qapi: Force UTF8 encoding when parsing qapi files

Commit d4e5ec877 already fixed things to work around Python 3's
lame bug of having LC_ALL=C not be 8-bit clean, when parsing the
main QMP qapi files; but failed to do likewise in the tests
directory.  As a result, running 'LC_ALL=C make check' fails on
escape-too-big and unicode-str when using python 3 with a nasty
stack trace instead of the intended graceful error message that
QAPI doesn't yet support 8-bit data (the two tests contain
Unicode é, when parsed in UTF-8; they represent something
different when parsed in a proper single-byte C locale, but that
doesn't matter to the error message printed out, provided that
brain-dead Python hasn't first choked on the input instead of
being 8-bit clean).

Ideally, we'd teach the qapi generator scripts to automatically
slurp things in using UTF-8 regardless of locale, and to honor
content that is not limited to 7 bit data rather than gracefully
erroring out; but until then, since our graceful error depends
on python parsing 8-bit data (even if nothing we generate uses
8-bit data), our quick fix is to use the right locale when
running these tests.

Reported-by: Peter Maydell <address@hidden>
Signed-off-by: Eric Blake <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Daniel P. Berrangé <address@hidden>


  Commit: 66793daa03f38af64cbed3a54c1059d03d48aea7
      
https://github.com/qemu/qemu/commit/66793daa03f38af64cbed3a54c1059d03d48aea7
  Author: Peter Maydell <address@hidden>
  Date:   2018-03-23 (Fri, 23 Mar 2018)

  Changed paths:
    M monitor.c
    M tests/Makefile.include
    M tests/qmp-test.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/ericb/tags/pull-qapi-2018-03-23' into 
staging

qapi patches for 2018-03-12, 2.12-rc1

- Peter Xu: 0/4 Turn OOB off for 2.12-rc1, revert OOB tests
- Eric Blake: qapi: Force UTF8 encoding when parsing qapi files

# gpg: Signature made Fri 23 Mar 2018 17:35:49 GMT
# gpg:                using RSA key A7A16B4A2527436A
# gpg: Good signature from "Eric Blake <address@hidden>"
# gpg:                 aka "Eric Blake (Free Software Programmer) 
<address@hidden>"
# gpg:                 aka "[jpeg image of size 6874]"
# Primary key fingerprint: 71C2 CC22 B1C4 6029 27D2  F3AA A7A1 6B4A 2527 436A

* remotes/ericb/tags/pull-qapi-2018-03-23:
  qapi: Force UTF8 encoding when parsing qapi files
  Revert "monitor: enable IO thread for (qmp & !mux) typed"
  Revert "tests: qmp-test: verify command batching"
  Revert "tests: qmp-test: add oob test"

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/4c2c1015905f...66793daa03f3

reply via email to

[Prev in Thread] Current Thread [Next in Thread]