[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-commits] [qemu/qemu] 32cd65: HMP: Initialize err before using
From: |
GitHub |
Subject: |
[Qemu-commits] [qemu/qemu] 32cd65: HMP: Initialize err before using |
Date: |
Tue, 20 Mar 2018 12:02:50 -0700 |
Branch: refs/heads/master
Home: https://github.com/qemu/qemu
Commit: 32cd6550f7a6c8a621798c8b249eae2597db04ea
https://github.com/qemu/qemu/commit/32cd6550f7a6c8a621798c8b249eae2597db04ea
Author: zhangjixiang <address@hidden>
Date: 2018-03-20 (Tue, 20 Mar 2018)
Changed paths:
M hmp.c
Log Message:
-----------
HMP: Initialize err before using
When bdrv_snapshot_delete return fail, the errp will not be
assigned a valid value in error_propagate as errp didn't be
initialized in hmp_delvm, then error_reportf_err will use an
uninitialized value(call by hmp_delvm), and qemu crash.
Signed-off-by: zhangjixiang <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
Signed-off-by: Dr. David Alan Gilbert <address@hidden>
Commit: 95372184b7acdfd82ee748b6f0c6df1d839982ba
https://github.com/qemu/qemu/commit/95372184b7acdfd82ee748b6f0c6df1d839982ba
Author: Marc-André Lureau <address@hidden>
Date: 2018-03-20 (Tue, 20 Mar 2018)
Changed paths:
M target/i386/monitor.c
Log Message:
-----------
hmp: free sev info
Found thanks to ASAN:
Direct leak of 16 byte(s) in 1 object(s) allocated from:
#0 0x7efe20417a38 in __interceptor_calloc (/lib64/libasan.so.4+0xdea38)
#1 0x7efe1f7b2f75 in g_malloc0 ../glib/gmem.c:124
#2 0x7efe1f7b3249 in g_malloc0_n ../glib/gmem.c:355
#3 0x558272879162 in sev_get_info
/home/elmarco/src/qemu/target/i386/sev.c:414
#4 0x55827285113b in hmp_info_sev
/home/elmarco/src/qemu/target/i386/monitor.c:684
#5 0x5582724043b8 in handle_hmp_command
/home/elmarco/src/qemu/monitor.c:3333
Fixes: 63036314
Signed-off-by: Marc-André Lureau <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Signed-off-by: Dr. David Alan Gilbert <address@hidden>
Commit: a9b47e53e88f3816e041e00c08714e451251e498
https://github.com/qemu/qemu/commit/a9b47e53e88f3816e041e00c08714e451251e498
Author: Peter Maydell <address@hidden>
Date: 2018-03-20 (Tue, 20 Mar 2018)
Changed paths:
M hmp.c
M target/i386/monitor.c
Log Message:
-----------
Merge remote-tracking branch 'remotes/dgilbert/tags/pull-hmp-20180320' into
staging
HMP fixes for 2.12
# gpg: Signature made Tue 20 Mar 2018 12:39:24 GMT
# gpg: using RSA key 0516331EBC5BFDE7
# gpg: Good signature from "Dr. David Alan Gilbert (RH2) <address@hidden>"
# Primary key fingerprint: 45F5 C71B 4A0C B7FB 977A 9FA9 0516 331E BC5B FDE7
* remotes/dgilbert/tags/pull-hmp-20180320:
hmp: free sev info
HMP: Initialize err before using
Signed-off-by: Peter Maydell <address@hidden>
Compare: https://github.com/qemu/qemu/compare/ed627b2ad374...a9b47e53e88f
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Qemu-commits] [qemu/qemu] 32cd65: HMP: Initialize err before using,
GitHub <=