[Qemu-commits] [qemu/qemu] 2a8fcd: multiboot: bss_end_addr can be zero

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 2a8fcd119eb7c6bb3837fc3669eb1b2dfb31daf8
      
https://github.com/qemu/qemu/commit/2a8fcd119eb7c6bb3837fc3669eb1b2dfb31daf8
  Author: Jack Schwartz <address@hidden>
  Date:   2018-03-07 (Wed, 07 Mar 2018)

  Changed paths:
    M hw/i386/multiboot.c

  Log Message:
  -----------
  multiboot: bss_end_addr can be zero

The multiboot spec (https://www.gnu.org/software/grub/manual/multiboot/),
section 3.1.3, allows for bss_end_addr to be zero.

A zero bss_end_addr signifies there is no .bss section.

Suggested-by: Daniel Kiper <address@hidden>
Signed-off-by: Jack Schwartz <address@hidden>
Reviewed-by: Daniel Kiper <address@hidden>
Reviewed-by: Prasad J Pandit <address@hidden>
Signed-off-by: Kevin Wolf <address@hidden>


  Commit: 7a2e43cc96fd017883973caf9ee076ae23a3bebd
      
https://github.com/qemu/qemu/commit/7a2e43cc96fd017883973caf9ee076ae23a3bebd
  Author: Jack Schwartz <address@hidden>
  Date:   2018-03-07 (Wed, 07 Mar 2018)

  Changed paths:
    M hw/i386/multiboot.c

  Log Message:
  -----------
  multiboot: Remove unused variables from multiboot.c

Remove unused variables: mh_mode_type, mh_width, mh_height, mh_depth

Signed-off-by: Jack Schwartz <address@hidden>
Reviewed-by: Daniel Kiper <address@hidden>
Reviewed-by: Prasad J Pandit <address@hidden>
Signed-off-by: Kevin Wolf <address@hidden>


  Commit: ce5eb6dc4dc5652f7e360a1db817f1d5dafab90f
      
https://github.com/qemu/qemu/commit/ce5eb6dc4dc5652f7e360a1db817f1d5dafab90f
  Author: Jack Schwartz <address@hidden>
  Date:   2018-03-07 (Wed, 07 Mar 2018)

  Changed paths:
    M hw/i386/multiboot.c

  Log Message:
  -----------
  multiboot: Use header names when displaying fields

Refer to field names when displaying fields in printf and debug statements.

Signed-off-by: Jack Schwartz <address@hidden>
Reviewed-by: Daniel Kiper <address@hidden>
Signed-off-by: Kevin Wolf <address@hidden>


  Commit: 4b9006a41ea8818f2385ae5228e07f211bb4a33d
      
https://github.com/qemu/qemu/commit/4b9006a41ea8818f2385ae5228e07f211bb4a33d
  Author: Jack Schwartz <address@hidden>
  Date:   2018-03-07 (Wed, 07 Mar 2018)

  Changed paths:
    M hw/i386/multiboot.c

  Log Message:
  -----------
  multiboot: fprintf(stderr...) -> error_report()

Change all fprintf(stderr...) calls in hw/i386/multiboot.c to call
error_report() instead, including the mb_debug macro.  Remove the "\n"
from strings passed to all modified calls, since error_report() appends
one.

Signed-off-by: Jack Schwartz <address@hidden>
Reviewed-by: Daniel Kiper <address@hidden>
Signed-off-by: Kevin Wolf <address@hidden>


  Commit: 854a4436dd313eaeb51c275d00526d60437915d2
      
https://github.com/qemu/qemu/commit/854a4436dd313eaeb51c275d00526d60437915d2
  Author: Peter Maydell <address@hidden>
  Date:   2018-03-08 (Thu, 08 Mar 2018)

  Changed paths:
    M hw/i386/multiboot.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging

Multiboot patches

# gpg: Signature made Wed 07 Mar 2018 11:15:17 GMT
# gpg:                using RSA key 7F09B272C88F2FD6
# gpg: Good signature from "Kevin Wolf <address@hidden>"
# Primary key fingerprint: DC3D EB15 9A9A F95D 3D74  56FE 7F09 B272 C88F 2FD6

* remotes/kevin/tags/for-upstream:
  multiboot: fprintf(stderr...) -> error_report()
  multiboot: Use header names when displaying fields
  multiboot: Remove unused variables from multiboot.c
  multiboot: bss_end_addr can be zero

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/f32408f3b472...854a4436dd31