[Qemu-commits] [qemu/qemu] be95ad: util/uri.c: Coding style check, Only whitespace in...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: be95adaf2b65d359be324c61dd62cf7b1be34659
      
https://github.com/qemu/qemu/commit/be95adaf2b65d359be324c61dd62cf7b1be34659
  Author: Su Hang <address@hidden>
  Date:   2018-03-05 (Mon, 05 Mar 2018)

  Changed paths:
    M util/uri.c

  Log Message:
  -----------
  util/uri.c: Coding style check, Only whitespace involved

Using `clang-format -i util/uri.c` first, then change back few code
manually, to make sure only whitespace involved.

Signed-off-by: Su Hang <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>
Message-id: address@hidden
Signed-off-by: Stefan Hajnoczi <address@hidden>


  Commit: 42fa27253cfa8b9ad7d41ce63a733a4c623ffc74
      
https://github.com/qemu/qemu/commit/42fa27253cfa8b9ad7d41ce63a733a4c623ffc74
  Author: Su Hang <address@hidden>
  Date:   2018-03-05 (Mon, 05 Mar 2018)

  Changed paths:
    M util/uri.c

  Log Message:
  -----------
  util/uri.c: remove brackets that wrap `return` statement's content.

only remove brackets that wrap `return` statements' content.

use `perl -pi -e "s/return \((.*?)\);/return \1;/g" util/uri.c`
to remove pattern like this: "return (1);"

Signed-off-by: Su Hang <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>
Message-id: address@hidden
Signed-off-by: Stefan Hajnoczi <address@hidden>


  Commit: a1515161b563acd0986867fc37084c1cf952ba35
      
https://github.com/qemu/qemu/commit/a1515161b563acd0986867fc37084c1cf952ba35
  Author: Su Hang <address@hidden>
  Date:   2018-03-05 (Mon, 05 Mar 2018)

  Changed paths:
    M util/uri.c

  Log Message:
  -----------
  util/uri.c: wrap single statement blocks with braces {}

For this patch, using curly braces to wrap `if` `while` `else` statements,
which only hold single statement. For example:
'''
if (cond)
    statement;
'''
to
'''
if (cond) {
    statement;
}
'''

And using tricks that compare the disassemblies before and after
code changes, to make sure code logic isn't changed:
'''
git checkout master
make util/uri.o
strip util/uri.o
objdump -Drx util/uri.o > /tmp/uri-master.txt
git checkout cleanupbranch
make util/uri.o
strip util/uri.o
objdump -Drx util/uri.o > /tmp/uri-cleanup.txt

Signed-off-by: Stefan Hajnoczi <address@hidden>


  Commit: bb37a2c0b51f74e7bd9a1f87ca4ec1648e1f9398
      
https://github.com/qemu/qemu/commit/bb37a2c0b51f74e7bd9a1f87ca4ec1648e1f9398
  Author: Thomas Huth <address@hidden>
  Date:   2018-03-05 (Mon, 05 Mar 2018)

  Changed paths:
    M tests/libqos/virtio-pci.c

  Log Message:
  -----------
  tests/libqos: Check for valid dev pointer when looking for PCI devices

dev could be NULL if the PCI device can not be found due to some
reasons, so we must not dereference the pointer in this case.

Signed-off-by: Thomas Huth <address@hidden>
Message-id: address@hidden
Signed-off-by: Stefan Hajnoczi <address@hidden>


  Commit: 08bb160e02bb24e831f581f846d5f3ed2f2ce2c1
      
https://github.com/qemu/qemu/commit/08bb160e02bb24e831f581f846d5f3ed2f2ce2c1
  Author: Fam Zheng <address@hidden>
  Date:   2018-03-05 (Mon, 05 Mar 2018)

  Changed paths:
    A .gitpublish

  Log Message:
  -----------
  Add a git-publish configuration file

git-publish [1] is a convenient tool to send patches and has been
popular among QEMU developers.  Recently it has been made available in
Fedora/Debian official repo.

One nice feature of the tool is a per-project configuration with
profiles, especially in which the cccmd option is a handy method to
create the Cc list.

[1]: https://github.com/stefanha/git-publish

Signed-off-by: Fam Zheng <address@hidden>
Message-id: address@hidden
Signed-off-by: Stefan Hajnoczi <address@hidden>


  Commit: 23500c6a9409efc80d696aede0629bfbe7556a90
      
https://github.com/qemu/qemu/commit/23500c6a9409efc80d696aede0629bfbe7556a90
  Author: Fam Zheng <address@hidden>
  Date:   2018-03-05 (Mon, 05 Mar 2018)

  Changed paths:
    M README

  Log Message:
  -----------
  README: Document 'git-publish' workflow

Signed-off-by: Fam Zheng <address@hidden>
Message-id: address@hidden
Signed-off-by: Stefan Hajnoczi <address@hidden>


  Commit: f2bb2d14c2958f3f5aef456bd2cdb1ff99f4a562
      
https://github.com/qemu/qemu/commit/f2bb2d14c2958f3f5aef456bd2cdb1ff99f4a562
  Author: Peter Maydell <address@hidden>
  Date:   2018-03-05 (Mon, 05 Mar 2018)

  Changed paths:
    A .gitpublish
    M README
    M tests/libqos/virtio-pci.c
    M util/uri.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into 
staging

Pull request

Mostly patches that are only indirectly related to the block layer, but I've
reviewed them and there is no maintainer.

# gpg: Signature made Mon 05 Mar 2018 09:39:50 GMT
# gpg:                using RSA key 9CA4ABB381AB73C8
# gpg: Good signature from "Stefan Hajnoczi <address@hidden>"
# gpg:                 aka "Stefan Hajnoczi <address@hidden>"
# Primary key fingerprint: 8695 A8BF D3F9 7CDA AC35  775A 9CA4 ABB3 81AB 73C8

* remotes/stefanha/tags/block-pull-request:
  README: Document 'git-publish' workflow
  Add a git-publish configuration file
  tests/libqos: Check for valid dev pointer when looking for PCI devices
  util/uri.c: wrap single statement blocks with braces {}
  util/uri.c: remove brackets that wrap `return` statement's content.
  util/uri.c: Coding style check, Only whitespace involved

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/4ee02f53be79...f2bb2d14c295