qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 6f49ec: dump-guest-memory.py: fix python 2 su


From: GitHub
Subject: [Qemu-commits] [qemu/qemu] 6f49ec: dump-guest-memory.py: fix python 2 support
Date: Mon, 22 Jan 2018 04:22:40 -0800

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 6f49ec4034e55dfb675a56a62c9579384f7fb8cc
      
https://github.com/qemu/qemu/commit/6f49ec4034e55dfb675a56a62c9579384f7fb8cc
  Author: Marc-André Lureau <address@hidden>
  Date:   2018-01-20 (Sat, 20 Jan 2018)

  Changed paths:
    M scripts/dump-guest-memory.py

  Log Message:
  -----------
  dump-guest-memory.py: fix python 2 support

Python GDB support may use Python 2 or 3.

Inferior.read_memory() may return a 'buffer' with Python 2 or a
'memoryview' with Python 3 (see also
https://sourceware.org/gdb/onlinedocs/gdb/Inferiors-In-Python.html)

The elf.add_vmcoreinfo_note() method expects a "bytes" object. Wrap
the returned memory with bytes(), which works with both 'memoryview'
and 'buffer'.

Fixes a regression introduced with commit
d23bfa91b7789534d16ede6cb7d925bfac3f3c4c ("add vmcoreinfo").

Suggested-by: Peter Maydell <address@hidden>
Signed-off-by: Marc-André Lureau <address@hidden>
Acked-by: Laszlo Ersek <address@hidden>
Reviewed-by: Eric Blake <address@hidden>


  Commit: 6df555170437e28fe89aa11f3b0613026c41d1f9
      
https://github.com/qemu/qemu/commit/6df555170437e28fe89aa11f3b0613026c41d1f9
  Author: Peter Maydell <address@hidden>
  Date:   2018-01-22 (Mon, 22 Jan 2018)

  Changed paths:
    M scripts/dump-guest-memory.py

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/elmarco/tags/dump-pull-request' into 
staging

# gpg: Signature made Sat 20 Jan 2018 20:03:47 GMT
# gpg:                using RSA key 0xDAE8E10975969CE5
# gpg: Good signature from "Marc-André Lureau <address@hidden>"
# gpg:                 aka "Marc-André Lureau <address@hidden>"
# Primary key fingerprint: 87A9 BD93 3F87 C606 D276  F62D DAE8 E109 7596 9CE5

* remotes/elmarco/tags/dump-pull-request:
  dump-guest-memory.py: fix python 2 support

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/f7c6b96c3e63...6df555170437

reply via email to

[Prev in Thread] Current Thread [Next in Thread]