qemu-commits
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] bd3be4: virtio-9p: move unrealize/realize aft

From: GitHub
Subject: [Qemu-commits] [qemu/qemu] bd3be4: virtio-9p: move unrealize/realize after virtio_9p_...
Date: Tue, 09 Jan 2018 01:46:55 -0800 
  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: bd3be4dbbf0491d6db8bf326706747b4629ace4b
      
https://github.com/qemu/qemu/commit/bd3be4dbbf0491d6db8bf326706747b4629ace4b
  Author: Greg Kurz <address@hidden>
  Date:   2018-01-08 (Mon, 08 Jan 2018)

  Changed paths:
    M hw/9pfs/virtio-9p-device.c

  Log Message:
  -----------
  virtio-9p: move unrealize/realize after virtio_9p_transport definition

And drop the now useless forward declaration of virtio_9p_transport.

Signed-off-by: Greg Kurz <address@hidden>


  Commit: 01847522bc1165438d933092d9482dd917342662
      
https://github.com/qemu/qemu/commit/01847522bc1165438d933092d9482dd917342662
  Author: Greg Kurz <address@hidden>
  Date:   2018-01-08 (Mon, 08 Jan 2018)

  Changed paths:
    M fsdev/file-op-9p.h
    M hw/9pfs/9p-xattr.h

  Log Message:
  -----------
  9pfs: fix XattrOperations typedef

To comply with the QEMU coding style.

Signed-off-by: Greg Kurz <address@hidden>


  Commit: 1a8d0bb31a02f492cb8c77b3022e652bc288da7c
      
https://github.com/qemu/qemu/commit/1a8d0bb31a02f492cb8c77b3022e652bc288da7c
  Author: Greg Kurz <address@hidden>
  Date:   2018-01-08 (Mon, 08 Jan 2018)

  Changed paths:
    M fsdev/file-op-9p.h

  Log Message:
  -----------
  fsdev: fix some type definitions

To comply with the QEMU coding style.

Signed-off-by: Greg Kurz <address@hidden>


  Commit: 8e71b96c62d4d3b5e757ca84ba12424ce10ea7d3
      
https://github.com/qemu/qemu/commit/8e71b96c62d4d3b5e757ca84ba12424ce10ea7d3
  Author: Greg Kurz <address@hidden>
  Date:   2018-01-08 (Mon, 08 Jan 2018)

  Changed paths:
    M hw/9pfs/9p.c
    M hw/9pfs/9p.h
    M hw/9pfs/virtio-9p-device.c
    M hw/9pfs/xen-9p-backend.c

  Log Message:
  -----------
  9pfs: fix some type definitions

To comply with the QEMU coding style.

Signed-off-by: Greg Kurz <address@hidden>


  Commit: c4ce2c0ff3e54639bb9c130fd9ade8d3503b661d
      
https://github.com/qemu/qemu/commit/c4ce2c0ff3e54639bb9c130fd9ade8d3503b661d
  Author: Greg Kurz <address@hidden>
  Date:   2018-01-08 (Mon, 08 Jan 2018)

  Changed paths:
    M hw/9pfs/9p-handle.c

  Log Message:
  -----------
  9pfs: handle: fix type definition

To comply with the QEMU coding style.

Signed-off-by: Greg Kurz <address@hidden>


  Commit: 7bd41d3db6b16775f5e17151fd380b976fed2d2f
      
https://github.com/qemu/qemu/commit/7bd41d3db6b16775f5e17151fd380b976fed2d2f
  Author: Greg Kurz <address@hidden>
  Date:   2018-01-08 (Mon, 08 Jan 2018)

  Changed paths:
    M hw/9pfs/9p-handle.c
    M hw/9pfs/9p-local.c
    M hw/9pfs/9p-proxy.c

  Log Message:
  -----------
  9pfs: fix type in *_parse_opts declarations

To comply with the QEMU coding style.

Signed-off-by: Greg Kurz <address@hidden>
Reviewed-by: Eric Blake <address@hidden>


  Commit: d1471233bb07611458b701e670e5e2ba0ac12e7c
      
https://github.com/qemu/qemu/commit/d1471233bb07611458b701e670e5e2ba0ac12e7c
  Author: Greg Kurz <address@hidden>
  Date:   2018-01-08 (Mon, 08 Jan 2018)

  Changed paths:
    M hw/9pfs/9p.c

  Log Message:
  -----------
  9pfs: fix error path in pdu_submit()

If we receive an unsupported request id, we first decide to
return -ENOTSUPP to the client, but since the request id
causes is_read_only_op() to return false, we change the
error to be -EROFS if the fsdev is read-only. This doesn't
make sense since we don't know what the client asked for.

This patch ensures that -EROFS can only be returned if the
request id is supported.

Signed-off-by: Greg Kurz <address@hidden>
Reviewed-by: Eric Blake <address@hidden>


  Commit: 75673590942fd74c9befa31ef09f4b0f8f1c7eb2
      
https://github.com/qemu/qemu/commit/75673590942fd74c9befa31ef09f4b0f8f1c7eb2
  Author: Greg Kurz <address@hidden>
  Date:   2018-01-08 (Mon, 08 Jan 2018)

  Changed paths:
    M hw/9pfs/9p.c
    M hw/9pfs/9p.h

  Log Message:
  -----------
  9pfs: make pdu_marshal() and pdu_unmarshal() static functions

They're only used by the 9p core code.

Signed-off-by: Greg Kurz <address@hidden>
Reviewed-by: Eric Blake <address@hidden>


  Commit: 65b70fc7dee3ec24afd606946ee7e093105c4875
      
https://github.com/qemu/qemu/commit/65b70fc7dee3ec24afd606946ee7e093105c4875
  Author: Greg Kurz <address@hidden>
  Date:   2018-01-08 (Mon, 08 Jan 2018)

  Changed paths:
    M tests/virtio-9p-test.c

  Log Message:
  -----------
  tests: virtio-9p: fix ISR dependence

Like other virtio tests, use the used ring APIs instead of assuming ISR
being set means the request has completed.

Signed-off-by: Greg Kurz <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>


  Commit: d8803b1ad06734d36878645328011dc86108af9f
      
https://github.com/qemu/qemu/commit/d8803b1ad06734d36878645328011dc86108af9f
  Author: Greg Kurz <address@hidden>
  Date:   2018-01-08 (Mon, 08 Jan 2018)

  Changed paths:
    M tests/virtio-9p-test.c

  Log Message:
  -----------
  tests: virtio-9p: set DRIVER_OK before using the device

Signed-off-by: Greg Kurz <address@hidden>


  Commit: 91cda4e8f372602795e3a2f4bd2e3adaf9f82255
      
https://github.com/qemu/qemu/commit/91cda4e8f372602795e3a2f4bd2e3adaf9f82255
  Author: Greg Kurz <address@hidden>
  Date:   2018-01-08 (Mon, 08 Jan 2018)

  Changed paths:
    M fsdev/file-op-9p.h
    M fsdev/qemu-fsdev.c
    M hw/9pfs/9p-handle.c
    M hw/9pfs/9p-local.c
    M hw/9pfs/9p-proxy.c

  Log Message:
  -----------
  fsdev: improve error handling of backend opts parsing

This patch changes some error messages in the backend opts parsing
code and convert backends to propagate QEMU Error objects instead
of calling error_report().

Signed-off-by: Greg Kurz <address@hidden>


  Commit: 65603a801e14a89701b359cd12d7c5b1764e6de1
      
https://github.com/qemu/qemu/commit/65603a801e14a89701b359cd12d7c5b1764e6de1
  Author: Greg Kurz <address@hidden>
  Date:   2018-01-08 (Mon, 08 Jan 2018)

  Changed paths:
    M fsdev/file-op-9p.h
    M hw/9pfs/9p-handle.c
    M hw/9pfs/9p-local.c
    M hw/9pfs/9p-proxy.c
    M hw/9pfs/9p-synth.c
    M hw/9pfs/9p.c

  Log Message:
  -----------
  fsdev: improve error handling of backend init

This patch changes some error messages in the backend init code and
convert backends to propagate QEMU Error objects instead of calling
error_report().

One notable improvement is that the local backend now provides a more
detailed error report when it fails to open the shared directory.

Signed-off-by: Greg Kurz <address@hidden>


  Commit: db3b3c7281ca82e2647e072a1f97db111313dd73
      
https://github.com/qemu/qemu/commit/db3b3c7281ca82e2647e072a1f97db111313dd73
  Author: Greg Kurz <address@hidden>
  Date:   2018-01-08 (Mon, 08 Jan 2018)

  Changed paths:
    M hw/9pfs/9p-handle.c
    M qemu-doc.texi

  Log Message:
  -----------
  9pfs: deprecate handle backend

This backend raise some concerns:

- doesn't support symlinks
- fails +100 tests in the PJD POSIX file system test suite [1]
- requires the QEMU process to run with the CAP_DAC_READ_SEARCH
  capability, which isn't recommended for security reasons

This backend should not be used and wil be removed. The 'local'
backend is the recommended alternative.

[1] https://www.tuxera.com/community/posix-test-suite/

Signed-off-by: Greg Kurz <address@hidden>
Reviewed-by: Daniel P. Berrange <address@hidden>
Reviewed-by: Aneesh Kumar K.V <address@hidden>


  Commit: ffcfb446db1776198a3fe02b75bfecfa1d0b7ab3
      
https://github.com/qemu/qemu/commit/ffcfb446db1776198a3fe02b75bfecfa1d0b7ab3
  Author: Greg Kurz <address@hidden>
  Date:   2018-01-08 (Mon, 08 Jan 2018)

  Changed paths:
    M MAINTAINERS

  Log Message:
  -----------
  MAINTAINERS: Drop Aneesh as 9pfs maintainer

Aneesh has been working on other topics for some time now. Let's reflect
that in the MAINTAINERS file, so that people stop Cc'ing him.

Signed-off-by: Greg Kurz <address@hidden>
Acked-by: Aneesh Kumar K.V <address@hidden>


  Commit: ee98a6b089d363ddcd006d3d179afad220b09cac
      
https://github.com/qemu/qemu/commit/ee98a6b089d363ddcd006d3d179afad220b09cac
  Author: Peter Maydell <address@hidden>
  Date:   2018-01-08 (Mon, 08 Jan 2018)

  Changed paths:
    M MAINTAINERS
    M fsdev/file-op-9p.h
    M fsdev/qemu-fsdev.c
    M hw/9pfs/9p-handle.c
    M hw/9pfs/9p-local.c
    M hw/9pfs/9p-proxy.c
    M hw/9pfs/9p-synth.c
    M hw/9pfs/9p-xattr.h
    M hw/9pfs/9p.c
    M hw/9pfs/9p.h
    M hw/9pfs/virtio-9p-device.c
    M hw/9pfs/xen-9p-backend.c
    M qemu-doc.texi
    M tests/virtio-9p-test.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/gkurz/tags/for-upstream' into staging

- Aneesh no longer listed in MAINTAINERS,
- deprecation of the handle backend,
- improved error reporting, especially when the local backend fails to
  open the VirtFS root,
- virtio-9p-test to behave more like a real virtio guest driver: set
  DRIVER_OK when ready to use the device and process the used ring
  for completed requests,
- cosmetic fixes (mostly coding style related).

# gpg: Signature made Mon 08 Jan 2018 10:19:18 GMT
# gpg:                using RSA key 0x71D4D5E5822F73D6
# gpg: Good signature from "Greg Kurz <address@hidden>"
# gpg:                 aka "Gregory Kurz <address@hidden>"
# gpg:                 aka "[jpeg image of size 3330]"
# Primary key fingerprint: B482 8BAF 9431 40CE F2A3  4910 71D4 D5E5 822F 73D6

* remotes/gkurz/tags/for-upstream:
  MAINTAINERS: Drop Aneesh as 9pfs maintainer
  9pfs: deprecate handle backend
  fsdev: improve error handling of backend init
  fsdev: improve error handling of backend opts parsing
  tests: virtio-9p: set DRIVER_OK before using the device
  tests: virtio-9p: fix ISR dependence
  9pfs: make pdu_marshal() and pdu_unmarshal() static functions
  9pfs: fix error path in pdu_submit()
  9pfs: fix type in *_parse_opts declarations
  9pfs: handle: fix type definition
  9pfs: fix some type definitions
  fsdev: fix some type definitions
  9pfs: fix XattrOperations typedef
  virtio-9p: move unrealize/realize after virtio_9p_transport definition

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/232e5537e476...ee98a6b089d3
reply via email to
[Prev in Thread] Current Thread [Next in Thread]