[Qemu-commits] [qemu/qemu] 341e0b: throttle-groups: forget timer and schedule next TG...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 341e0b5658681f46680024cdbfc998717d85cc35
      
https://github.com/qemu/qemu/commit/341e0b5658681f46680024cdbfc998717d85cc35
  Author: Stefan Hajnoczi <address@hidden>
  Date:   2017-11-16 (Thu, 16 Nov 2017)

  Changed paths:
    M block/throttle-groups.c

  Log Message:
  -----------
  throttle-groups: forget timer and schedule next TGM on detach

tg->any_timer_armed[] must be cleared when detaching pending timers from
the AioContext.  Failure to do so leads to hung I/O because it looks
like there are still timers pending when in fact they have been removed.

Other ThrottleGroupMembers might have requests pending too so it's
necessary to schedule the next TGM so it can set a timer.

This patch fixes hung I/O when QEMU is launched with drives that are in
the same throttling group:

  (guest)$ dd if=/dev/zero of=/dev/vdb oflag=direct bs=512 &
  (guest)$ dd if=/dev/zero of=/dev/vdc oflag=direct bs=512 &
  (qemu) stop
  (qemu) cont
  ...I/O is stuck...

Signed-off-by: Stefan Hajnoczi <address@hidden>
Message-id: address@hidden
Signed-off-by: Stefan Hajnoczi <address@hidden>


  Commit: afdad8b6840d3ea4bc8b7cd0f1b9f25801748c50
      
https://github.com/qemu/qemu/commit/afdad8b6840d3ea4bc8b7cd0f1b9f25801748c50
  Author: Peter Maydell <address@hidden>
  Date:   2017-11-16 (Thu, 16 Nov 2017)

  Changed paths:
    M block/throttle-groups.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into 
staging

# gpg: Signature made Thu 16 Nov 2017 16:36:02 GMT
# gpg:                using RSA key 0x9CA4ABB381AB73C8
# gpg: Good signature from "Stefan Hajnoczi <address@hidden>"
# gpg:                 aka "Stefan Hajnoczi <address@hidden>"
# Primary key fingerprint: 8695 A8BF D3F9 7CDA AC35  775A 9CA4 ABB3 81AB 73C8

* remotes/stefanha/tags/block-pull-request:
  throttle-groups: forget timer and schedule next TGM on detach

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/62955e101e4b...afdad8b6840d