[Qemu-commits] [qemu/qemu] 5b38ee: tcg: Allow constant pool entries in the prologue

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 5b38ee31616d1532c3c3a6dc644a9160d608ed2f
      
https://github.com/qemu/qemu/commit/5b38ee31616d1532c3c3a6dc644a9160d608ed2f
  Author: Richard Henderson <address@hidden>
  Date:   2017-11-03 (Fri, 03 Nov 2017)

  Changed paths:
    M tcg/tcg.c

  Log Message:
  -----------
  tcg: Allow constant pool entries in the prologue

Both ARMv6 and AArch64 currently may drop complex guest_base values
into the constant pool.  But generic code wasn't expecting that, and
the pool is not emitted.  Correct that.

Tested-by: Emilio G. Cota <address@hidden>
Tested-by: Laurent Desnogues <address@hidden>
Reported-by: Laurent Desnogues <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>


  Commit: ba2c747992f8c315c2fbddba196ce9137430d61d
      
https://github.com/qemu/qemu/commit/ba2c747992f8c315c2fbddba196ce9137430d61d
  Author: Richard Henderson <address@hidden>
  Date:   2017-11-03 (Fri, 03 Nov 2017)

  Changed paths:
    M tcg/s390/tcg-target.inc.c

  Log Message:
  -----------
  tcg/s390x: Use constant pool for prologue

Rather than have separate code only used for guest_base,
rely on a recent change to handle constant pool entries.

Cc: address@hidden
Signed-off-by: Richard Henderson <address@hidden>


  Commit: 426eeecdf5d9cf1695a53c08f46394f8e5351750
      
https://github.com/qemu/qemu/commit/426eeecdf5d9cf1695a53c08f46394f8e5351750
  Author: Peter Maydell <address@hidden>
  Date:   2017-11-03 (Fri, 03 Nov 2017)

  Changed paths:
    M accel/tcg/cpu-exec.c

  Log Message:
  -----------
  cpu-exec: Exit exclusive region on longjmp from step_atomic

Commit ac03ee5331612e44be narrowed the scope of the exclusive
region so it only covers when we're executing the TB, not when
we're generating it. However it missed that there is more than
one execution path out of cpu_tb_exec -- if the atomic insn
causes an exception then the code will longjmp out, skipping
the code to end the exclusive region. This causes QEMU to hang
the next time the CPU calls start_exclusive(), waiting for
itself to exit the region.

Move the "end the region" code out to the end of the
function so that it is run for both normal exit and also
for exit-via-longjmp. We have to use a volatile bool flag
to decide whether we need to end the region, because we
can longjump out of the codegen as well as the execution.

(For some reason this only reproduces for me with a clang
optimized build, not a gcc debug build.)

Reviewed-by: Emilio G. Cota <address@hidden>
Reviewed-by: Alex Bennée <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Fixes: ac03ee5331612e44beb393df2b578c951d27dc0d
Signed-off-by: Peter Maydell <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>


  Commit: 9c4da1fa2b667aa50c0db9557fa04593bef54a76
      
https://github.com/qemu/qemu/commit/9c4da1fa2b667aa50c0db9557fa04593bef54a76
  Author: Peter Maydell <address@hidden>
  Date:   2017-11-03 (Fri, 03 Nov 2017)

  Changed paths:
    M accel/tcg/cpu-exec.c
    M tcg/s390/tcg-target.inc.c
    M tcg/tcg.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20171103' into staging

Queued tcg patches

# gpg: Signature made Fri 03 Nov 2017 08:37:58 GMT
# gpg:                using RSA key 0x64DF38E8AF7E215F
# gpg: Good signature from "Richard Henderson <address@hidden>"
# Primary key fingerprint: 7A48 1E78 868B 4DB6 A85A  05C0 64DF 38E8 AF7E 215F

* remotes/rth/tags/pull-tcg-20171103:
  cpu-exec: Exit exclusive region on longjmp from step_atomic
  tcg/s390x: Use constant pool for prologue
  tcg: Allow constant pool entries in the prologue

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/094611b426b3...9c4da1fa2b66