[Qemu-commits] [qemu/qemu] 4d80d2: qga-win: don't hang if vss hold writes timeout

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 4d80d20fe12248956c07587376f5b5a741f74aa2
      
https://github.com/qemu/qemu/commit/4d80d20fe12248956c07587376f5b5a741f74aa2
  Author: Chen Hanxiao <address@hidden>
  Date:   2017-10-25 (Wed, 25 Oct 2017)

  Changed paths:
    M qga/vss-win32/requester.cpp

  Log Message:
  -----------
  qga-win: don't hang if vss hold writes timeout

When VM is in a heavy IO, if the command "guest-fsfreeze-freeze"
is executed, VSS may timeout when trying to hold writes.

Inside guest, Event ID 12298(VSS_ERROR_HOLD_WRITES_TIMEOUT)
is logged in the Event Viewer.

At that time, if we call AbortBackup, qga may hang forever.

This patch will solve this issue.

Cc: Michael Roth <address@hidden>
Cc: Tomoki Sekiyama <address@hidden>

Signed-off-by: Chen Hanxiao <address@hidden>
Signed-off-by: Michael Roth <address@hidden>


  Commit: 105fad6bb226ac3404874fe3fd7013ad6f86fc86
      
https://github.com/qemu/qemu/commit/105fad6bb226ac3404874fe3fd7013ad6f86fc86
  Author: Bishara AbuHattoum <address@hidden>
  Date:   2017-10-25 (Wed, 25 Oct 2017)

  Changed paths:
    M configure
    M qga/commands-win32.c

  Log Message:
  -----------
  qga-win: Updating guest_set_time action

  At the moment, Windows libraries don't provide a way to access
  RTC, so, a workaround is to use the Windows w32tm command to
  resync the time.
  Related bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1183874

Signed-off-by: Bishara AbuHattoum <address@hidden>
Reviewed-by: Sameeh Jubran <address@hidden>
Signed-off-by: Michael Roth <address@hidden>


  Commit: 53f9fcb263e40ff82b9fcbce8b8cba0f3649ac9b
      
https://github.com/qemu/qemu/commit/53f9fcb263e40ff82b9fcbce8b8cba0f3649ac9b
  Author: ZhiPeng Lu <address@hidden>
  Date:   2017-10-25 (Wed, 25 Oct 2017)

  Changed paths:
    M qga/commands-posix.c
    M qga/commands-win32.c
    M qga/qapi-schema.json

  Log Message:
  -----------
  qga: add network stats to guest-network-get-interfaces

we can get the network interface statistics inside a virtual machine by
guest-network-get-interfaces command. it is very useful for us tomonitor
and analyze network traffic.

Signed-off-by: ZhiPeng Lu <address@hidden>
* don't rely on sizeof(wchar[]) for wchar[] indexing
* avoid camelCase variable names
* fix up getline() usage
* condensed commit subject line
Signed-off-by: Michael Roth <address@hidden>


  Commit: 8cedc80555e5a395a4fda7130b0115015e775c48
      
https://github.com/qemu/qemu/commit/8cedc80555e5a395a4fda7130b0115015e775c48
  Author: Michael Roth <address@hidden>
  Date:   2017-10-26 (Thu, 26 Oct 2017)

  Changed paths:
    M qga/vss-win32/install.cpp

  Log Message:
  -----------
  qga-win: fix error-handling in getNameByStringSID()

In one case we misconstrue a BOOL return as an HRESULT, and in the
other case we don't check the BOOL return from LookupAccountSidW()
before extracting the HRESULT from GetLastError(). Both can lead to
getNameByStringSID() misreporting an error.

Reported-by: Chen Hanxiao <address@hidden>
Suggested-by: Tomáš Golembiovský <address@hidden>
Signed-off-by: Michael Roth <address@hidden>


  Commit: 953e35f69c302522c280e8d4e05995afc31da051
      
https://github.com/qemu/qemu/commit/953e35f69c302522c280e8d4e05995afc31da051
  Author: Peter Maydell <address@hidden>
  Date:   2017-10-28 (Sat, 28 Oct 2017)

  Changed paths:
    M configure
    M qga/commands-posix.c
    M qga/commands-win32.c
    M qga/qapi-schema.json
    M qga/vss-win32/install.cpp
    M qga/vss-win32/requester.cpp

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/mdroth/tags/qga-pull-2017-10-26-tag' 
into staging

qemu-ga patch queue for 2.11

* support for network interface stats
* w32: improvements for guest-set-time
* w32: fix a hang with guest-fsfreeze-freeze when timeout occurs
  during heavy I/O
* w32: fix faulty error-handling in VSS/fsfreeze COM registration

# gpg: Signature made Fri 27 Oct 2017 02:11:53 BST
# gpg:                using RSA key 0x3353C9CEF108B584
# gpg: Good signature from "Michael Roth <address@hidden>"
# gpg:                 aka "Michael Roth <address@hidden>"
# gpg:                 aka "Michael Roth <address@hidden>"
# Primary key fingerprint: CEAC C9E1 5534 EBAB B82D  3FA0 3353 C9CE F108 B584

* remotes/mdroth/tags/qga-pull-2017-10-26-tag:
  qga-win: fix error-handling in getNameByStringSID()
  qga: add network stats to guest-network-get-interfaces
  qga-win: Updating guest_set_time action
  qga-win: don't hang if vss hold writes timeout

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/a93ece47fd9e...953e35f69c30