[Qemu-commits] [qemu/qemu] 5e7577: migration: Fix migrate_test_apply for multifd para...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 5e7577a101d8db8015c7dbc3ab977a41d5b3afdc
      
https://github.com/qemu/qemu/commit/5e7577a101d8db8015c7dbc3ab977a41d5b3afdc
  Author: Juan Quintela <address@hidden>
  Date:   2017-10-23 (Mon, 23 Oct 2017)

  Changed paths:
    M migration/migration.c

  Log Message:
  -----------
  migration: Fix migrate_test_apply for multifd parameters

They were missing when introduced on the tree

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Peter Xu <address@hidden>


  Commit: ceaaecb49ff99b871aac64329c1a0708abc696a4
      
https://github.com/qemu/qemu/commit/ceaaecb49ff99b871aac64329c1a0708abc696a4
  Author: Juan Quintela <address@hidden>
  Date:   2017-10-23 (Mon, 23 Oct 2017)

  Changed paths:
    M migration/page_cache.c

  Log Message:
  -----------
  migratiom: Remove max_item_age parameter

It was not used at all since commit:

27af7d6ea5015e5ef1f7985eab94a8a218267a2b

which replaced its use by the dirty sync count.

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Peter Xu <address@hidden>


  Commit: 9ca3f963949c88ac58f81de5e1e391bfcd7dbaa3
      
https://github.com/qemu/qemu/commit/9ca3f963949c88ac58f81de5e1e391bfcd7dbaa3
  Author: Juan Quintela <address@hidden>
  Date:   2017-10-23 (Mon, 23 Oct 2017)

  Changed paths:
    M migration/page_cache.c
    M migration/page_cache.h

  Log Message:
  -----------
  migration: Make cache size elements use the right types

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>


  Commit: 8acabf69ea36a5d8c09b4015b350afb3fc3bd12f
      
https://github.com/qemu/qemu/commit/8acabf69ea36a5d8c09b4015b350afb3fc3bd12f
  Author: Juan Quintela <address@hidden>
  Date:   2017-10-23 (Mon, 23 Oct 2017)

  Changed paths:
    M migration/migration.c
    M migration/ram.c
    M migration/ram.h

  Log Message:
  -----------
  migration: Move xbzrle cache resize error handling to xbzrle_cache_resize

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Peter Xu <address@hidden>


  Commit: 80f8dfde97e89739d7b9edcf0afceaed3f7f2aad
      
https://github.com/qemu/qemu/commit/80f8dfde97e89739d7b9edcf0afceaed3f7f2aad
  Author: Juan Quintela <address@hidden>
  Date:   2017-10-23 (Mon, 23 Oct 2017)

  Changed paths:
    M migration/page_cache.c
    M migration/page_cache.h
    M migration/ram.c

  Log Message:
  -----------
  migration: Make cache_init() take an error parameter

Once there, take a total size instead of the size of the pages.  We
move the check that the new_size is bigger than one page from
xbzrle_cache_resize().

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Peter Xu <address@hidden>

--

Fix typo spotted by Peter Xu


  Commit: 93fbd0314ec060ffaf90169a06d5737fa97ffb25
      
https://github.com/qemu/qemu/commit/93fbd0314ec060ffaf90169a06d5737fa97ffb25
  Author: Dr. David Alan Gilbert <address@hidden>
  Date:   2017-10-23 (Mon, 23 Oct 2017)

  Changed paths:
    M migration/migration.c
    M migration/migration.h
    M qapi/migration.json

  Log Message:
  -----------
  migration: Add 'pause-before-switchover' capability

When 'pause-before-switchover' is enabled, the outgoing migration
will pause before invalidating the block devices and serializing
the device state.
At this point the management layer gets the chance to clean up any
device jobs or other device users before the migration completes.

Signed-off-by: Dr. David Alan Gilbert <address@hidden>
Reviewed-by: Peter Xu <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>
Signed-off-by: Juan Quintela <address@hidden>


  Commit: 31e060774cf5c3b9945f6f16d6c18d6eae18e4d9
      
https://github.com/qemu/qemu/commit/31e060774cf5c3b9945f6f16d6c18d6eae18e4d9
  Author: Dr. David Alan Gilbert <address@hidden>
  Date:   2017-10-23 (Mon, 23 Oct 2017)

  Changed paths:
    M migration/migration.c
    M qapi/migration.json

  Log Message:
  -----------
  migration: Add 'pre-switchover' and 'device' statuses

Add two statuses for use when the 'pause-before-switchover'
capability is enabled.

'pre-switchover' is the state that we wait in for management
to allow us to continue.
'device' is the state we enter while serialising the devices
after management gives us the OK.

Signed-off-by: Dr. David Alan Gilbert <address@hidden>
Reviewed-by: Peter Xu <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>
Signed-off-by: Juan Quintela <address@hidden>


  Commit: e91d8951d59d483f085f7650381b8e55a1a55e4c
      
https://github.com/qemu/qemu/commit/e91d8951d59d483f085f7650381b8e55a1a55e4c
  Author: Dr. David Alan Gilbert <address@hidden>
  Date:   2017-10-23 (Mon, 23 Oct 2017)

  Changed paths:
    M migration/migration.c
    M migration/migration.h

  Log Message:
  -----------
  migration: Wait for semaphore before completing migration

Wait for a semaphore before completing the migration,
if the previously added capability was enabled.

Signed-off-by: Dr. David Alan Gilbert <address@hidden>
Reviewed-by: Peter Xu <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>
Signed-off-by: Juan Quintela <address@hidden>


  Commit: 89cfc02cb6e3fdaf8ae246493ea51e75be2818c1
      
https://github.com/qemu/qemu/commit/89cfc02cb6e3fdaf8ae246493ea51e75be2818c1
  Author: Dr. David Alan Gilbert <address@hidden>
  Date:   2017-10-23 (Mon, 23 Oct 2017)

  Changed paths:
    M migration/migration.c
    M qapi/migration.json

  Log Message:
  -----------
  migration: migrate-continue

A new qmp command allows the caller to continue from a given
paused state.

Signed-off-by: Dr. David Alan Gilbert <address@hidden>
Reviewed-by: Peter Xu <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>
Signed-off-by: Juan Quintela <address@hidden>


  Commit: 94ae12cba4f18253e3cf5f9a70335e22870053b4
      
https://github.com/qemu/qemu/commit/94ae12cba4f18253e3cf5f9a70335e22870053b4
  Author: Dr. David Alan Gilbert <address@hidden>
  Date:   2017-10-23 (Mon, 23 Oct 2017)

  Changed paths:
    M hmp-commands.hx
    M hmp.c
    M hmp.h

  Log Message:
  -----------
  migrate: HMP migate_continue

HMP equivalent to the just added migrate-continue
Unpause a migrate paused at a given state.

Signed-off-by: Dr. David Alan Gilbert <address@hidden>
Reviewed-by: Peter Xu <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>
Signed-off-by: Juan Quintela <address@hidden>


  Commit: a7b36b486dd58d8f44f788a2a2efa6a4fa3b1223
      
https://github.com/qemu/qemu/commit/a7b36b486dd58d8f44f788a2a2efa6a4fa3b1223
  Author: Dr. David Alan Gilbert <address@hidden>
  Date:   2017-10-23 (Mon, 23 Oct 2017)

  Changed paths:
    M migration/migration.c

  Log Message:
  -----------
  migration: allow cancel to unpause

If a migration_cancel is issued during the new paused state,
kick the pause_sem to get to unpause so it can cancel.

Signed-off-by: Dr. David Alan Gilbert <address@hidden>
Reviewed-by: Peter Xu <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>
Signed-off-by: Juan Quintela <address@hidden>


  Commit: 0331c8cabf6168aa263aa0b25f5e135b328606ac
      
https://github.com/qemu/qemu/commit/0331c8cabf6168aa263aa0b25f5e135b328606ac
  Author: Dr. David Alan Gilbert <address@hidden>
  Date:   2017-10-23 (Mon, 23 Oct 2017)

  Changed paths:
    M migration/migration.c

  Log Message:
  -----------
  migration: pause-before-switchover for postcopy

Add pause-before-switchover support for postcopy.
After starting postcopy it will transition
    active->pre-switchover->postcopy_active

Signed-off-by: Dr. David Alan Gilbert <address@hidden>
Reviewed-by: Peter Xu <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>
Signed-off-by: Juan Quintela <address@hidden>


  Commit: 7d00ee6ad6c2dbeeb68e8d5343ec77bc5873d8f8
      
https://github.com/qemu/qemu/commit/7d00ee6ad6c2dbeeb68e8d5343ec77bc5873d8f8
  Author: Peter Xu <address@hidden>
  Date:   2017-10-23 (Mon, 23 Oct 2017)

  Changed paths:
    M migration/ram.c

  Log Message:
  -----------
  migration: provide ram_state_init()

The old ram_state_init() is not really initializing the RAMState only,
but including lots of other stuff that is RAM-related.  Renaming it to
ram_init_all().  Instead, provide a real ram_state_init().

Signed-off-by: Peter Xu <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>
Signed-off-by: Juan Quintela <address@hidden>


  Commit: 7d7c96be7b25f285b3759ec0545bbe82dd0d8076
      
https://github.com/qemu/qemu/commit/7d7c96be7b25f285b3759ec0545bbe82dd0d8076
  Author: Peter Xu <address@hidden>
  Date:   2017-10-23 (Mon, 23 Oct 2017)

  Changed paths:
    M migration/ram.c

  Log Message:
  -----------
  migration: provide ram_state_cleanup

There are two Mutexes that are created but not yet destroyed for
RAMState.  Fix that.

Since we are at it, provide helper function to clean up RAMState.

Signed-off-by: Peter Xu <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>
Signed-off-by: Juan Quintela <address@hidden>


  Commit: 84593a0807004d852132eaa56edf24d55793d480
      
https://github.com/qemu/qemu/commit/84593a0807004d852132eaa56edf24d55793d480
  Author: Peter Xu <address@hidden>
  Date:   2017-10-23 (Mon, 23 Oct 2017)

  Changed paths:
    M migration/ram.c

  Log Message:
  -----------
  migration: clean up xbzrle cache init/destroy

Let's further simplify ram_init_all() and ram_save_cleanup() by abstract
all the XBZRLE related codes into their own functions.

When allocating xbzrle cache, we are always very careful on -ENOMEM;
which makes sense.  Replacing the last g_malloc0() with g_try_malloc0(),
then refactor the logic a bit.

This patch should be fixing some memory leaks when some memory
allocation failed for XBZRLE in the past.

Signed-off-by: Peter Xu <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>
Signed-off-by: Juan Quintela <address@hidden>


  Commit: d6eff5d75d6b8d2fb18dca4ebd9f02a16d8e7f3b
      
https://github.com/qemu/qemu/commit/d6eff5d75d6b8d2fb18dca4ebd9f02a16d8e7f3b
  Author: Peter Xu <address@hidden>
  Date:   2017-10-23 (Mon, 23 Oct 2017)

  Changed paths:
    M migration/ram.c

  Log Message:
  -----------
  migration: new ram_init_bitmaps()

Rearrange the bitmap initialization and the first sync.  Since at it,
make sure the locks are taken/released in correct order (I moved RCU
unlock upper - though it may not affect much).

Signed-off-by: Peter Xu <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>
Signed-off-by: Juan Quintela <address@hidden>


  Commit: 8be4620be237356e22905d9aa2356ced492970c8
      
https://github.com/qemu/qemu/commit/8be4620be237356e22905d9aa2356ced492970c8
  Author: Alexey Perevalov <address@hidden>
  Date:   2017-10-23 (Mon, 23 Oct 2017)

  Changed paths:
    M migration/postcopy-ram.c
    M migration/postcopy-ram.h
    M migration/ram.c

  Log Message:
  -----------
  migration: postcopy_place_page factoring out

Need to mark copied pages as closer as possible to the place where it
tracks down. That will be necessary in futher patch.

Reviewed-by: Dr. David Alan Gilbert <address@hidden>
Reviewed-by: Peter Xu <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>
Signed-off-by: Alexey Perevalov <address@hidden>
Signed-off-by: Juan Quintela <address@hidden>


  Commit: 727b9d7e4926755e14d9ac2b09777c51cccb9b80
      
https://github.com/qemu/qemu/commit/727b9d7e4926755e14d9ac2b09777c51cccb9b80
  Author: Alexey Perevalov <address@hidden>
  Date:   2017-10-23 (Mon, 23 Oct 2017)

  Changed paths:
    M migration/postcopy-ram.c

  Log Message:
  -----------
  migration: introduce qemu_ufd_copy_ioctl helper

Just for placing auxilary operations inside helper,
auxilary operations like: track received pages,
notify about copying operation in futher patches.

Reviewed-by: Juan Quintela <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
Reviewed-by: Peter Xu <address@hidden>
Signed-off-by: Alexey Perevalov <address@hidden>
Signed-off-by: Juan Quintela <address@hidden>


  Commit: f9494614898f46e59bc2243de6fb11ebbfc9cda6
      
https://github.com/qemu/qemu/commit/f9494614898f46e59bc2243de6fb11ebbfc9cda6
  Author: Alexey Perevalov <address@hidden>
  Date:   2017-10-23 (Mon, 23 Oct 2017)

  Changed paths:
    M include/exec/ram_addr.h
    M migration/postcopy-ram.c
    M migration/ram.c
    M migration/ram.h

  Log Message:
  -----------
  migration: add bitmap for received page

This patch adds ability to track down already received
pages, it's necessary for calculation vCPU block time in
postcopy migration feature, and for recovery after
postcopy migration failure.

Also it's necessary to solve shared memory issue in
postcopy livemigration. Information about received pages
will be transferred to the software virtual bridge
(e.g. OVS-VSWITCHD), to avoid fallocate (unmap) for
already received pages. fallocate syscall is required for
remmaped shared memory, due to remmaping itself blocks
ioctl(UFFDIO_COPY, ioctl in this case will end with EEXIT
error (struct page is exists after remmap).

Bitmap is placed into RAMBlock as another postcopy/precopy
related bitmaps.

Reviewed-by: Peter Xu <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
Signed-off-by: Peter Xu <address@hidden>
Signed-off-by: Alexey Perevalov <address@hidden>
Signed-off-by: Juan Quintela <address@hidden>


  Commit: 40a5532f820e26f98d081a49aff9283cd63bd5fa
      
https://github.com/qemu/qemu/commit/40a5532f820e26f98d081a49aff9283cd63bd5fa
  Author: Juan Quintela <address@hidden>
  Date:   2017-10-23 (Mon, 23 Oct 2017)

  Changed paths:
    M qapi/migration.json

  Log Message:
  -----------
  qapi: Fix grammar in x-multifd-page-count descriptions

Reported-by: Eric Blake <address@hidden>
Signed-off-by: Juan Quintela <address@hidden>


  Commit: 87db1a7d89677e3dbc8b3763e417b9376009bdbb
      
https://github.com/qemu/qemu/commit/87db1a7d89677e3dbc8b3763e417b9376009bdbb
  Author: Juan Quintela <address@hidden>
  Date:   2017-10-23 (Mon, 23 Oct 2017)

  Changed paths:
    M migration/migration.c
    M migration/migration.h
    M migration/tls.c

  Log Message:
  -----------
  migration: Improve migration thread error handling

We now report errors also when we finish migration, not only on info
migrate.  We plan to use this error from several places, and we want
the first error to happen to win, so we add an mutex to order it.

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>


  Commit: 4e1b31dba8f66e337fbaf0166b7b8c440be78529
      
https://github.com/qemu/qemu/commit/4e1b31dba8f66e337fbaf0166b7b8c440be78529
  Author: Peter Maydell <address@hidden>
  Date:   2017-10-25 (Wed, 25 Oct 2017)

  Changed paths:
    M hmp-commands.hx
    M hmp.c
    M hmp.h
    M include/exec/ram_addr.h
    M migration/migration.c
    M migration/migration.h
    M migration/page_cache.c
    M migration/page_cache.h
    M migration/postcopy-ram.c
    M migration/postcopy-ram.h
    M migration/ram.c
    M migration/ram.h
    M migration/tls.c
    M qapi/migration.json

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/juanquintela/tags/migration/20171023' 
into staging

migration/next for 20171023

# gpg: Signature made Mon 23 Oct 2017 17:05:14 BST
# gpg:                using RSA key 0xF487EF185872D723
# gpg: Good signature from "Juan Quintela <address@hidden>"
# gpg:                 aka "Juan Quintela <address@hidden>"
# Primary key fingerprint: 1899 FF8E DEBF 58CC EE03  4B82 F487 EF18 5872 D723

* remotes/juanquintela/tags/migration/20171023: (21 commits)
  migration: Improve migration thread error handling
  qapi: Fix grammar in x-multifd-page-count descriptions
  migration: add bitmap for received page
  migration: introduce qemu_ufd_copy_ioctl helper
  migration: postcopy_place_page factoring out
  migration: new ram_init_bitmaps()
  migration: clean up xbzrle cache init/destroy
  migration: provide ram_state_cleanup
  migration: provide ram_state_init()
  migration: pause-before-switchover for postcopy
  migration: allow cancel to unpause
  migrate: HMP migate_continue
  migration: migrate-continue
  migration: Wait for semaphore before completing migration
  migration: Add 'pre-switchover' and 'device' statuses
  migration: Add 'pause-before-switchover' capability
  migration: Make cache_init() take an error parameter
  migration: Move xbzrle cache resize error handling to xbzrle_cache_resize
  migration: Make cache size elements use the right types
  migratiom: Remove max_item_age parameter
  ...

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/328f6f79e991...4e1b31dba8f6