[Qemu-commits] [qemu/qemu] 45876e: hw/m68k: Replace fprintf(stderr, "*\n" with error_...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 45876e913e169bf156a3fc36f21eb0adf6ec3671
      
https://github.com/qemu/qemu/commit/45876e913e169bf156a3fc36f21eb0adf6ec3671
  Author: Alistair Francis <address@hidden>
  Date:   2017-10-16 (Mon, 16 Oct 2017)

  Changed paths:
    M hw/m68k/an5206.c
    M hw/m68k/mcf5206.c
    M hw/m68k/mcf5208.c

  Log Message:
  -----------
  hw/m68k: Replace fprintf(stderr, "*\n" with error_report()

Replace a large number of the fprintf(stderr, "*\n" calls with
error_report(). The functions were renamed with these commands and then
compiler issues where manually fixed.

find ./* -type f -exec sed -i \
    'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr, 
"\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \
    {} +
find ./* -type f -exec sed -i \
    'N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr, 
"\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \
    {} +
find ./* -type f -exec sed -i \
    'N;N;N;N;N;N;N;N;N; {s|fprintf(stderr, 
"\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \
    {} +
find ./* -type f -exec sed -i \
    'N;N;N;N;N;N;N;N; {s|fprintf(stderr, 
"\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \
    {} +
find ./* -type f -exec sed -i \
    'N;N;N;N;N;N;N; {s|fprintf(stderr, 
"\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \
    {} +
find ./* -type f -exec sed -i \
    'N;N;N;N;N;N; {s|fprintf(stderr, 
"\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \
    {} +
find ./* -type f -exec sed -i \
    'N;N;N;N;N; {s|fprintf(stderr, 
"\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \
    {} +
find ./* -type f -exec sed -i \
    'N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' 
\
    {} +
find ./* -type f -exec sed -i \
    'N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \
    {} +
find ./* -type f -exec sed -i \
    'N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \
    {} +
find ./* -type f -exec sed -i \
    'N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \
    {} +

Some lines where then manually tweaked to pass checkpatch.

Signed-off-by: Alistair Francis <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>
[thuth: Remove "qemu:" prefix from strings]
Signed-off-by: Thomas Huth <address@hidden>


  Commit: d3c9218840c070f1c81ac20bc02fb6aafc6e3803
      
https://github.com/qemu/qemu/commit/d3c9218840c070f1c81ac20bc02fb6aafc6e3803
  Author: Marc-André Lureau <address@hidden>
  Date:   2017-10-16 (Mon, 16 Oct 2017)

  Changed paths:
    M hw/m68k/mcf5206.c
    M hw/m68k/mcf5208.c

  Log Message:
  -----------
  M68K: use g_new() family of functions

Signed-off-by: Marc-André Lureau <address@hidden>
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
[PMD: squashed commits]
Reviewed-by: Thomas Huth <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>


  Commit: 790bbb9768e6a21920e76989f931db80ca67dc10
      
https://github.com/qemu/qemu/commit/790bbb9768e6a21920e76989f931db80ca67dc10
  Author: Marc-André Lureau <address@hidden>
  Date:   2017-10-16 (Mon, 16 Oct 2017)

  Changed paths:
    M tests/ahci-test.c
    M tests/fw_cfg-test.c
    M tests/libqos/ahci.c
    M tests/libqos/libqos.c
    M tests/libqos/malloc.c
    M tests/libqtest.c
    M tests/pc-cpu-test.c

  Log Message:
  -----------
  tests: use g_new() family of functions

Signed-off-by: Marc-André Lureau <address@hidden>
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
[PMD: split of some files in other commits of the same series, add libqtest.c]
Acked-by: John Snow <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>


  Commit: b95b5a0a52b323533a7b5b2a0deedc7e9c6befd9
      
https://github.com/qemu/qemu/commit/b95b5a0a52b323533a7b5b2a0deedc7e9c6befd9
  Author: Thomas Huth <address@hidden>
  Date:   2017-10-16 (Mon, 16 Oct 2017)

  Changed paths:
    M tests/prom-env-test.c

  Log Message:
  -----------
  tests/prom-env: Bump the timeout, and test pseries only in slow mode

If QEMU has been compiled with the flags --enable-tcg-interpreter and
--enable-debug, the guest is running incredibly slow. The prom-env
test is approximately 10 times slower than normal in this case, and
it takes up to 500 seconds until the test with the pseries machine
finishs. While we should still look for ways to speed up the test
on the pseries machine here, let's bump the timeout to 600 seconds to
allow the test to pass with this unusal configuration already now.
Also move the pseries test into the "slow" category - since it is
really a very slow test.

Reviewed-by: Stefan Weil <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>


  Commit: 03bf6b5c08c792f5c2b55d6038e9a6acbf43d9c3
      
https://github.com/qemu/qemu/commit/03bf6b5c08c792f5c2b55d6038e9a6acbf43d9c3
  Author: Thomas Huth <address@hidden>
  Date:   2017-10-16 (Mon, 16 Oct 2017)

  Changed paths:
    M default-configs/i386-softmmu.mak
    M default-configs/pci.mak
    M default-configs/x86_64-softmmu.mak

  Log Message:
  -----------
  default-configs: Enable CONFIG_VMXNET3_PCI only on x86

The device can not be instantiated on many non-x86 and just prints
some error messages, e.g.:

$ qemu-system-ppc64 -device vmxnet3 -M g3beige
[vmxnet3][WR][vmxnet3_init_msix]: Failed to initialize MSI-X, error -95
[vmxnet3][WR][vmxnet3_pci_realize]: Failed to initialize MSI-X, configuration 
is inconsistent.

Since vmxnet3 is a para-virtualized device that is only useful on x86,
it should also only be enabled on the x86 targets.

Reviewed-by: Dmitry Fleytman <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>


  Commit: e24cdd07216890d24468cdcbdd5a3e60b3e9f23b
      
https://github.com/qemu/qemu/commit/e24cdd07216890d24468cdcbdd5a3e60b3e9f23b
  Author: Peter Maydell <address@hidden>
  Date:   2017-10-16 (Mon, 16 Oct 2017)

  Changed paths:
    M default-configs/i386-softmmu.mak
    M default-configs/pci.mak
    M default-configs/x86_64-softmmu.mak
    M hw/m68k/an5206.c
    M hw/m68k/mcf5206.c
    M hw/m68k/mcf5208.c
    M tests/ahci-test.c
    M tests/fw_cfg-test.c
    M tests/libqos/ahci.c
    M tests/libqos/libqos.c
    M tests/libqos/malloc.c
    M tests/libqtest.c
    M tests/pc-cpu-test.c
    M tests/prom-env-test.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/huth/tags/pull-request-2017-10-16' into 
staging

Some m68k, qtest and config improvements

# gpg: Signature made Mon 16 Oct 2017 13:38:03 BST
# gpg:                using RSA key 0x2ED9D774FE702DB5
# gpg: Good signature from "Thomas Huth <address@hidden>"
# gpg:                 aka "Thomas Huth <address@hidden>"
# gpg:                 aka "Thomas Huth <address@hidden>"
# gpg:                 aka "Thomas Huth <address@hidden>"
# Primary key fingerprint: 27B8 8847 EEE0 2501 18F3  EAB9 2ED9 D774 FE70 2DB5

* remotes/huth/tags/pull-request-2017-10-16:
  default-configs: Enable CONFIG_VMXNET3_PCI only on x86
  tests/prom-env: Bump the timeout, and test pseries only in slow mode
  tests: use g_new() family of functions
  M68K: use g_new() family of functions
  hw/m68k: Replace fprintf(stderr, "*\n" with error_report()

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/c5bbcaa4b7c0...e24cdd072168