qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 43851b: iotests: Set up Python logging


From: GitHub
Subject: [Qemu-commits] [qemu/qemu] 43851b: iotests: Set up Python logging
Date: Thu, 12 Oct 2017 03:04:47 -0700

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 43851b5bd48d952561610d0d6d6c314c97eff543
      
https://github.com/qemu/qemu/commit/43851b5bd48d952561610d0d6d6c314c97eff543
  Author: Eduardo Habkost <address@hidden>
  Date:   2017-10-11 (Wed, 11 Oct 2017)

  Changed paths:
    M tests/qemu-iotests/iotests.py

  Log Message:
  -----------
  iotests: Set up Python logging

Set up Python logging module instead of relying on
QEMUMachine._debug to enable debugging messages.

Cc: Kevin Wolf <address@hidden>
Cc: Max Reitz <address@hidden>
Cc: address@hidden
Signed-off-by: Eduardo Habkost <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Daniel P. Berrange <address@hidden>
Reviewed-by: Lukáš Doktor <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>


  Commit: fb3b4e6d88120da41ae553853b281214f7aac7cf
      
https://github.com/qemu/qemu/commit/fb3b4e6d88120da41ae553853b281214f7aac7cf
  Author: Eduardo Habkost <address@hidden>
  Date:   2017-10-11 (Wed, 11 Oct 2017)

  Changed paths:
    M tests/vm/basevm.py

  Log Message:
  -----------
  basevm: Call logging.basicConfig()

Just setting level=DEBUG when debug is enabled is not enough: we
need to set up a log handler if we want debug messages generated
using logging.getLogger(...).debug() to be printed.

This was not a problem before because logging.debug() calls
logging.basicConfig() implicitly, but it's safer to not rely on
that.

Cc: "Alex Bennée" <address@hidden>
Cc: Fam Zheng <address@hidden>
Cc: "Philippe Mathieu-Daudé" <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Daniel P. Berrange <address@hidden>
Reviewed-by: Fam Zheng <address@hidden>
Reviewed-by: Lukáš Doktor <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>


  Commit: 8af09b8001301e6bb085a23fc029da94e0725c1c
      
https://github.com/qemu/qemu/commit/8af09b8001301e6bb085a23fc029da94e0725c1c
  Author: Eduardo Habkost <address@hidden>
  Date:   2017-10-11 (Wed, 11 Oct 2017)

  Changed paths:
    M tests/migration/guestperf/shell.py

  Log Message:
  -----------
  guestperf: Configure logging on all shell frontends

The logging module will eventually replace the 'debug' parameter
in QEMUMachine and QEMUMonitorProtocol.

Cc: Daniel P. Berrange <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Lukáš Doktor <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>


  Commit: 091776545f759f379fa9ae5b67ce5b2a6153a010
      
https://github.com/qemu/qemu/commit/091776545f759f379fa9ae5b67ce5b2a6153a010
  Author: Eduardo Habkost <address@hidden>
  Date:   2017-10-11 (Wed, 11 Oct 2017)

  Changed paths:
    M scripts/qemu.py
    M scripts/qmp/qmp.py

  Log Message:
  -----------
  scripts: Remove debug parameter from QEMUMonitorProtocol

Use logging module for the QMP debug messages.  The only scripts
that set debug=True are iotests.py and guestperf/engine.py, and
they already call logging.basicConfig() to set up logging.

Scripts that don't configure logging are safe as long as they
don't need debugging output, because debug messages don't trigger
the "No handlers could be found for logger" message from the
Python logging module.

Scripts that already configure logging but don't use debug=True
(e.g. scripts/vm/basevm.py) will get QMP debugging enabled for
free.

Cc: "Alex Bennée" <address@hidden>
Cc: Fam Zheng <address@hidden>
Cc: "Philippe Mathieu-Daudé" <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Lukáš Doktor <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>


  Commit: 1a6d3757107181dc0b9baf3dd8ff40fb2a242b66
      
https://github.com/qemu/qemu/commit/1a6d3757107181dc0b9baf3dd8ff40fb2a242b66
  Author: Eduardo Habkost <address@hidden>
  Date:   2017-10-11 (Wed, 11 Oct 2017)

  Changed paths:
    M scripts/qemu.py
    M tests/migration/guestperf/engine.py
    M tests/qemu-iotests/iotests.py

  Log Message:
  -----------
  scripts: Remove debug parameter from QEMUMachine

All scripts that use the QEMUMachine and QEMUQtestMachine classes
(device-crash-test, tests/migration/*, iotests.py, basevm.py)
already configure logging.

The basicConfig() call inside QEMUMachine.__init__() is being
kept just to make sure a script would still work if it didn't
configure logging.

Signed-off-by: Eduardo Habkost <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Lukáš Doktor <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>


  Commit: a0b261db8c030813e30a39eae47359ac2a37f7e2
      
https://github.com/qemu/qemu/commit/a0b261db8c030813e30a39eae47359ac2a37f7e2
  Author: Peter Maydell <address@hidden>
  Date:   2017-10-12 (Thu, 12 Oct 2017)

  Changed paths:
    M scripts/qemu.py
    M scripts/qmp/qmp.py
    M tests/migration/guestperf/engine.py
    M tests/migration/guestperf/shell.py
    M tests/qemu-iotests/iotests.py
    M tests/vm/basevm.py

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/ehabkost/tags/python-next-pull-request' 
into staging

Python queue, 2017-10-11

# gpg: Signature made Wed 11 Oct 2017 19:49:40 BST
# gpg:                using RSA key 0x2807936F984DC5A6
# gpg: Good signature from "Eduardo Habkost <address@hidden>"
# Primary key fingerprint: 5A32 2FD5 ABC4 D3DB ACCF  D1AA 2807 936F 984D C5A6

* remotes/ehabkost/tags/python-next-pull-request:
  scripts: Remove debug parameter from QEMUMachine
  scripts: Remove debug parameter from QEMUMonitorProtocol
  guestperf: Configure logging on all shell frontends
  basevm: Call logging.basicConfig()
  iotests: Set up Python logging

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/bac960832015...a0b261db8c03

reply via email to

[Prev in Thread] Current Thread [Next in Thread]