[Qemu-commits] [qemu/qemu] be2960: cpu: don't allow negative core id

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: be2960baae07e5257cde8c814cbd91647e235147
      
https://github.com/qemu/qemu/commit/be2960baae07e5257cde8c814cbd91647e235147
  Author: Laurent Vivier <address@hidden>
  Date:   2017-08-02 (Wed, 02 Aug 2017)

  Changed paths:
    M hw/cpu/core.c

  Log Message:
  -----------
  cpu: don't allow negative core id

With pseries machine type a negative core-id is not managed properly:
-1 gives an inaccurate error message ("core -1 already populated"),
-2 crashes QEMU (core dump)

As it seems a negative value is invalid for any architecture,
instead of checking this in spapr_core_pre_plug() I think it's better
to check this in the generic part, core_prop_set_core_id()

Signed-off-by: Laurent Vivier <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Greg Kurz <address@hidden>
Reviewed-by: David Gibson <address@hidden>
Reviewed-by: Eduardo Habkost <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>


  Commit: ac44ed2afb7c60255e989b163301479f5b4ecd04
      
https://github.com/qemu/qemu/commit/ac44ed2afb7c60255e989b163301479f5b4ecd04
  Author: Peter Maydell <address@hidden>
  Date:   2017-08-04 (Fri, 04 Aug 2017)

  Changed paths:
    M hw/cpu/core.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/ehabkost/tags/machine-pull-request' 
into staging

cpu: crash fix (don't allow negative core id)

# gpg: Signature made Thu 03 Aug 2017 18:57:41 BST
# gpg:                using RSA key 0x2807936F984DC5A6
# gpg: Good signature from "Eduardo Habkost <address@hidden>"
# Primary key fingerprint: 5A32 2FD5 ABC4 D3DB ACCF  D1AA 2807 936F 984D C5A6

* remotes/ehabkost/tags/machine-pull-request:
  cpu: don't allow negative core id

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/c233a35d3d91...ac44ed2afb7c