[Qemu-commits] [qemu/qemu] ab7a75: configure: Rename CONFIG_IVSHMEM to CONFIG_IVSHMEM...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: ab7a75b553de295bd308884122101d9afed1d147
      
https://github.com/qemu/qemu/commit/ab7a75b553de295bd308884122101d9afed1d147
  Author: Peter Maydell <address@hidden>
  Date:   2017-07-20 (Thu, 20 Jul 2017)

  Changed paths:
    M default-configs/pci.mak
    M hw/misc/Makefile.objs

  Log Message:
  -----------
  configure: Rename CONFIG_IVSHMEM to CONFIG_IVSHMEM_DEVICE

The current CONFIG_IVSHMEM is confusing, because it looks like it's a
flag for "do we have ivshmem support?", but actually it's a flag for
"is the ivshmem PCI device being compiled?" (and implicitly "do we
have ivshmem support?" is tested with CONFIG_EVENTFD).

Rename it to CONFIG_IVSHMEM_DEVICE to clear this confusion up;
shortly we will add a new CONFIG_IVSHMEM which really does indicate
whether the host can support ivshmem.

Signed-off-by: Peter Maydell <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Message-id: address@hidden


  Commit: e0580342b3bd200a5f1d449129d11b1d2f5a24c0
      
https://github.com/qemu/qemu/commit/e0580342b3bd200a5f1d449129d11b1d2f5a24c0
  Author: Kamil Rytarowski <address@hidden>
  Date:   2017-07-20 (Thu, 20 Jul 2017)

  Changed paths:
    M configure
    M default-configs/pci.mak
    M tests/Makefile.include

  Log Message:
  -----------
  configure: Use an explicit CONFIG_IVSHMEM rather than CONFIG_EVENTFD

Rather than relying on everywhere that cares about whether the host
supports ivshmem using CONFIG_EVENTFD, make configure set an explicit
CONFIG_IVSHMEM.

Signed-off-by: Kamil Rytarowski <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Signed-off-by: Peter Maydell <address@hidden>
Message-id: address@hidden
[PMM: split out from another patch, add commit message]
Signed-off-by: Peter Maydell <address@hidden>


  Commit: b1449edb799909f531b806538c48dc86d701c4b2
      
https://github.com/qemu/qemu/commit/b1449edb799909f531b806538c48dc86d701c4b2
  Author: Kamil Rytarowski <address@hidden>
  Date:   2017-07-20 (Thu, 20 Jul 2017)

  Changed paths:
    M Makefile
    M Makefile.objs
    M configure

  Log Message:
  -----------
  configure: Don't build ivshmem tools unless CONFIG_IVSHMEM is set

Don't try to build the ivshmem-server and ivshmem-client tools unless
CONFIG_IVSHMEM is set.

This fixes in passing a build bug on NetBSD, which fails to build the
ivshmem tools because they use shm_open() and on NetBSD that requires
linking against -lrt.

Signed-off-by: Kamil Rytarowski <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Signed-off-by: Peter Maydell <address@hidden>
Message-id: address@hidden
[PMM: moved some code into earlier patches; minor bugfixes;
 added commit message]
Signed-off-by: Peter Maydell <address@hidden>


  Commit: 64f871e3c92ecd3c72a37b48bcf12812f0057734
      
https://github.com/qemu/qemu/commit/64f871e3c92ecd3c72a37b48bcf12812f0057734
  Author: Peter Maydell <address@hidden>
  Date:   2017-07-20 (Thu, 20 Jul 2017)

  Changed paths:
    M tests/Makefile.include

  Log Message:
  -----------
  tests: Handle $RANDOM not being supported by the shell

In various places in our test makefiles and scripts we use the
shell $RANDOM to create a random number. This is a bash
specific extension, and doesn't work on other shells.
With dash the shell doesn't complain, it just effectively
always evaluates $RANDOM to 0:
  echo $((RANDOM + 32768))     => 32768

However, on NetBSD the shell will complain:
  "-sh: arith: syntax error: "RANDOM + 32768"

which means that "make check" fails.

Switch to using "${RANDOM:-0}" instead of $RANDOM,
which will portably either give us a random number or zero.
This means that on non-bash shells we don't get such
good test coverage via the MALLOC_PERTURB_ setting, but
we were already in that situation for non-bash shells.

Our only other uses of $RANDOM (in tests/qemu-iotests/check
and tests/qemu-iotests/162) are in shell scripts which use
a #!/bin/bash line so they are always run under bash.

Suggested-by: Eric Blake <address@hidden>
Signed-off-by: Peter Maydell <address@hidden>
Reviewed-by: Kamil Rytarowski <address@hidden>
Reviewed-by: Fam Zheng <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Message-id: address@hidden


Compare: https://github.com/qemu/qemu/compare/8dbcd0e5e7cd...64f871e3c92e