qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 009f38: qga-win: fix installation on localize


From: GitHub
Subject: [Qemu-commits] [qemu/qemu] 009f38: qga-win: fix installation on localized windows
Date: Tue, 18 Jul 2017 07:22:42 -0700

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 009f38d9858d4338ccaaef787a5d54fd1c4c9198
      
https://github.com/qemu/qemu/commit/009f38d9858d4338ccaaef787a5d54fd1c4c9198
  Author: Daniel Rempel <address@hidden>
  Date:   2017-07-17 (Mon, 17 Jul 2017)

  Changed paths:
    M qga/vss-win32/install.cpp

  Log Message:
  -----------
  qga-win: fix installation on localized windows

Bug: https://bugzilla.redhat.com/show_bug.cgi?id=1357789
Replace hardcoded user and group names ("Administrators", "SYSTEM") with the 
ones acquired from system. Windows uses localized strings for these names and 
it may cause the installation to fail.
Windows has Well-known SIDs for "Administrators" group and "SYSTEM" user so 
they were used to identify required users and groups.
Well-known SIDs: 
https://support.microsoft.com/en-us/help/243330/well-known-security-identifiers-in-windows-operating-systems

Signed-off-by: Daniel Rempel <address@hidden>
Signed-off-by: Sameeh Jubran <address@hidden>
Reviewed-by: Sameeh Jubran <address@hidden>
Signed-off-by: Michael Roth <address@hidden>


  Commit: f2dce827f55a9b76ca7b2fc60b976b4760fc9eb1
      
https://github.com/qemu/qemu/commit/f2dce827f55a9b76ca7b2fc60b976b4760fc9eb1
  Author: Thomas Lamprecht <address@hidden>
  Date:   2017-07-17 (Mon, 17 Jul 2017)

  Changed paths:
    M qga/installer/qemu-ga.wxs

  Log Message:
  -----------
  qemu-ga: add missing libpcre to MSI build

glib depends on libpcre which was not shipped with the MSI, thus
starting of the qemu-ga.exe failed with the respective error message.

Tell WIXL to ship this library with the MSI to avoid this problem.

Signed-off-by: Thomas Lamprecht <address@hidden>
CC: Stefan Weil <address@hidden>
CC: Michael Roth <address@hidden>
Reviewed-by: Marc-André Lureau <address@hidden>
Signed-off-by: Michael Roth <address@hidden>


  Commit: e674605f9821a275e3ed87ce9accc835d565b753
      
https://github.com/qemu/qemu/commit/e674605f9821a275e3ed87ce9accc835d565b753
  Author: Tomáš Golembiovský <address@hidden>
  Date:   2017-07-17 (Mon, 17 Jul 2017)

  Changed paths:
    M configure
    M qga/commands-posix.c

  Log Message:
  -----------
  qemu-ga: check if utmpx.h is available on the system

Commit 161a56a9065 added command guest-get-users and requires the
utmpx.h (defined by POSIX) to work. It is however not always available
(e.g. on OpenBSD) therefor a check for its existence is necessary.

Signed-off-by: Tomáš Golembiovský <address@hidden>
Signed-off-by: Michael Roth <address@hidden>


  Commit: f8837b3765f507409a2dd1946db60144fe7fb71e
      
https://github.com/qemu/qemu/commit/f8837b3765f507409a2dd1946db60144fe7fb71e
  Author: Peng Hao <address@hidden>
  Date:   2017-07-17 (Mon, 17 Jul 2017)

  Changed paths:
    M qga/main.c

  Log Message:
  -----------
  qga-win32: remove a redundancy code

In the first line of run_agent,it has set ga_state = s,don't need
set ga_state = s again behind.

Signed-off-by: Peng Hao <address@hidden>
Signed-off-by: Michael Roth <address@hidden>


  Commit: cbcd9ba1b76425915c58c67153432ff1d743aefd
      
https://github.com/qemu/qemu/commit/cbcd9ba1b76425915c58c67153432ff1d743aefd
  Author: Marc-André Lureau <address@hidden>
  Date:   2017-07-17 (Mon, 17 Jul 2017)

  Changed paths:
    M qga/main.c

  Log Message:
  -----------
  qga: report error on keyfile dump error

Signed-off-by: Marc-André Lureau <address@hidden>
Cc:address@hidden
Signed-off-by: Michael Roth <address@hidden>


  Commit: 9848f79740dc3bd2e0515470d24b8bec53904473
      
https://github.com/qemu/qemu/commit/9848f79740dc3bd2e0515470d24b8bec53904473
  Author: Tomáš Golembiovský <address@hidden>
  Date:   2017-07-18 (Tue, 18 Jul 2017)

  Changed paths:
    M qga/commands-posix.c
    M qga/commands-win32.c
    M qga/qapi-schema.json

  Log Message:
  -----------
  qemu-ga: add guest-get-osinfo command

Add a new 'guest-get-osinfo' command for reporting basic information of
the guest operating system. This includes machine architecture,
version and release of the kernel and several fields from os-release
file if it is present (as defined in [1]).

[1] https://www.freedesktop.org/software/systemd/man/os-release.html

Signed-off-by: Vinzenz Feenstra <address@hidden>
Signed-off-by: Tomáš Golembiovský <address@hidden>
* moved declarations to beginning of functions
* dropped unecessary initialization of struct utsname
Signed-off-by: Michael Roth <address@hidden>


  Commit: c28afa76c0e2829d1ebe5ad33062d1697bf2710b
      
https://github.com/qemu/qemu/commit/c28afa76c0e2829d1ebe5ad33062d1697bf2710b
  Author: Tomáš Golembiovský <address@hidden>
  Date:   2017-07-18 (Tue, 18 Jul 2017)

  Changed paths:
    M tests/test-qga.c

  Log Message:
  -----------
  test-qga: pass environemnt to qemu-ga

Modify fixture_setup() to pass environemnt variables to spawned qemu-ga
instance.

Signed-off-by: Tomáš Golembiovský <address@hidden>
Reviewed-by: Marc-André Lureau <address@hidden>
Signed-off-by: Michael Roth <address@hidden>


  Commit: 339ca68bef9f30dd18e84b7d92398327e3f819a3
      
https://github.com/qemu/qemu/commit/339ca68bef9f30dd18e84b7d92398327e3f819a3
  Author: Tomáš Golembiovský <address@hidden>
  Date:   2017-07-18 (Tue, 18 Jul 2017)

  Changed paths:
    M qga/commands-posix.c
    A tests/data/test-qga-os-release
    M tests/test-qga.c

  Log Message:
  -----------
  test-qga: add test for guest-get-osinfo

Add test for guest-get-osinfo command.

Qemu-ga was modified to accept QGA_OS_RELEASE environment variable. If
the variable is defined it is interpreted as path to the os-release file
and it is parsed instead of the default paths.

Signed-off-by: Tomáš Golembiovský <address@hidden>
Reviewed-by: Marc-André Lureau <address@hidden>
* move declarations to beginning of functions
Signed-off-by: Michael Roth <address@hidden>


  Commit: e9277a19a1a50ab5662c16795531bac332f142f9
      
https://github.com/qemu/qemu/commit/e9277a19a1a50ab5662c16795531bac332f142f9
  Author: Peter Maydell <address@hidden>
  Date:   2017-07-18 (Tue, 18 Jul 2017)

  Changed paths:
    M configure
    M qga/commands-posix.c
    M qga/commands-win32.c
    M qga/installer/qemu-ga.wxs
    M qga/main.c
    M qga/qapi-schema.json
    M qga/vss-win32/install.cpp
    A tests/data/test-qga-os-release
    M tests/test-qga.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/mdroth/tags/qga-pull-2017-07-17-v2-tag' 
into staging

qemu-ga patch queue

* new command: qemu-get-osinfo
* build fix for OpenBSD
* better error-reporting for failure on keyfile dump
* remove redundant initialization of qa_state global
* include libpcre in w32 package
* w32 localization fixes for service installation/registration

v2:
* fix build issue with older GCCs introduced with guest_get_osinfo
* relocated some declarations in guest_get_osinfo

# gpg: Signature made Tue 18 Jul 2017 11:52:45 BST
# gpg:                using RSA key 0x3353C9CEF108B584
# gpg: Good signature from "Michael Roth <address@hidden>"
# gpg:                 aka "Michael Roth <address@hidden>"
# gpg:                 aka "Michael Roth <address@hidden>"
# Primary key fingerprint: CEAC C9E1 5534 EBAB B82D  3FA0 3353 C9CE F108 B584

* remotes/mdroth/tags/qga-pull-2017-07-17-v2-tag:
  test-qga: add test for guest-get-osinfo
  test-qga: pass environemnt to qemu-ga
  qemu-ga: add guest-get-osinfo command
  qga: report error on keyfile dump error
  qga-win32: remove a redundancy code
  qemu-ga: check if utmpx.h is available on the system
  qemu-ga: add missing libpcre to MSI build
  qga-win: fix installation on localized windows

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/718d7f4f9cf7...e9277a19a1a5

reply via email to

[Prev in Thread] Current Thread [Next in Thread]