[Qemu-commits] [qemu/qemu] 187f47: qobject: Catch another straggler for use of qdict_...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 187f47e947d1e0f4547e58b7cc4fad4d5542b185
      
https://github.com/qemu/qemu/commit/187f47e947d1e0f4547e58b7cc4fad4d5542b185
  Author: Eric Blake <address@hidden>
  Date:   2017-07-12 (Wed, 12 Jul 2017)

  Changed paths:
    M qemu-img.c

  Log Message:
  -----------
  qobject: Catch another straggler for use of qdict_put_str()

Dan's addition of key-secret improvements in commit 29cf9336 was
developed prior to the addition of QDict scalar insertion macros,
but merged after the general cleanup in commit 46f5ac20.
Patch created mechanically by rerunning:
  spatch --sp-file scripts/coccinelle/qobject.cocci \
   --macro-file scripts/cocci-macro-file.h --dir . --in-place

Signed-off-by: Eric Blake <address@hidden>
Reviewed-by: Alberto Garcia <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Max Reitz <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>


  Commit: 8a4613a0ab4b6e9271e64aaa88f588ed1b749eb4
      
https://github.com/qemu/qemu/commit/8a4613a0ab4b6e9271e64aaa88f588ed1b749eb4
  Author: Eric Blake <address@hidden>
  Date:   2017-07-12 (Wed, 12 Jul 2017)

  Changed paths:
    M monitor.c
    M scripts/coccinelle/qobject.cocci

  Log Message:
  -----------
  qobject: Update coccinelle script to catch Q{INC, DEC}REF

The recent commit b097efc0 used qobject_decref(QOBJECT(E)), even
though we already have QDECREF(E) for that purpose.  We can update
our coccinelle script to catch any future relapses; with that in
place, the rest of the patch is generated with:
 spatch --sp-file scripts/coccinelle/qobject.cocci \
  --macro-file scripts/cocci-macro-file.h --dir . --in-place

Signed-off-by: Eric Blake <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>


  Commit: 086ee7a6200fa5ad795b12110b5b3d5a93dcac3e
      
https://github.com/qemu/qemu/commit/086ee7a6200fa5ad795b12110b5b3d5a93dcac3e
  Author: Marc-André Lureau <address@hidden>
  Date:   2017-07-12 (Wed, 12 Jul 2017)

  Changed paths:
    M scripts/qapi-commands.py
    M scripts/qapi-event.py
    M scripts/qapi.py

  Log Message:
  -----------
  scripts: use build_ prefix for string not piped through cgen()

The gen_ prefix is awkward.  Generated C should go through cgen()
exactly once (see commit 1f9a7a1).  The common way to get this wrong is
passing a foo=gen_foo() keyword argument to mcgen().  I'd like us to
adopt a naming convention where gen_ means "something that's been piped
through cgen(), and thus must not be passed to cgen() or mcgen()".
Requires renaming gen_params(), gen_marshal_proto() and
gen_event_send_proto().

Suggested-by: Markus Armbruster <address@hidden>
Signed-off-by: Marc-André Lureau <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>


  Commit: 49bcce4b9c11759678fd223aefb48691c4959d4f
      
https://github.com/qemu/qemu/commit/49bcce4b9c11759678fd223aefb48691c4959d4f
  Author: Peter Maydell <address@hidden>
  Date:   2017-07-13 (Thu, 13 Jul 2017)

  Changed paths:
    M monitor.c
    M qemu-img.c
    M scripts/coccinelle/qobject.cocci
    M scripts/qapi-commands.py
    M scripts/qapi-event.py
    M scripts/qapi.py

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2017-07-12' into 
staging

QAPI patches for 2017-07-12

# gpg: Signature made Wed 12 Jul 2017 17:07:20 BST
# gpg:                using RSA key 0x3870B400EB918653
# gpg: Good signature from "Markus Armbruster <address@hidden>"
# gpg:                 aka "Markus Armbruster <address@hidden>"
# Primary key fingerprint: 354B C8B3 D7EB 2A6B 6867  4E5F 3870 B400 EB91 8653

* remotes/armbru/tags/pull-qapi-2017-07-12:
  scripts: use build_ prefix for string not piped through cgen()
  qobject: Update coccinelle script to catch Q{INC, DEC}REF
  qobject: Catch another straggler for use of qdict_put_str()

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/aa5a704756fe...49bcce4b9c11