[Qemu-commits] [qemu/qemu] d3b787: keymaps: add tracing

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: d3b787fa7ddea1c66ee59eb332d1523c67db8cf6
      
https://github.com/qemu/qemu/commit/d3b787fa7ddea1c66ee59eb332d1523c67db8cf6
  Author: Gerd Hoffmann <address@hidden>
  Date:   2017-06-23 (Fri, 23 Jun 2017)

  Changed paths:
    M ui/keymaps.c
    M ui/trace-events

  Log Message:
  -----------
  keymaps: add tracing

Drop commented debug logging, add trace points instead.

Also cleanup parser code a bit, the key name is copied into a new
variable instead of patching the input line, that way we can log
the unmodified line.

Signed-off-by: Gerd Hoffmann <address@hidden>
Message-id: address@hidden


  Commit: 77b0359bf414ad666d1714dc9888f1017c08e283
      
https://github.com/qemu/qemu/commit/77b0359bf414ad666d1714dc9888f1017c08e283
  Author: Alexander Graf <address@hidden>
  Date:   2017-06-23 (Fri, 23 Jun 2017)

  Changed paths:
    M ui/input.c

  Log Message:
  -----------
  input: Decrement queue count on kbd delay

Delays in the input layer are special cased input events. Every input
event is accounted for in a global intput queue count. The special cased
delays however did not get removed from the queue, leading to queue overruns
and thus silent key drops after typing quite a few characters.

Signed-off-by: Alexander Graf <address@hidden>
Message-id: address@hidden
Fixes: be1a7176 ("input: add support for kbd delays")
Cc: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 51dbea77a29ea46173373a6dad4ebd95d4661f42
      
https://github.com/qemu/qemu/commit/51dbea77a29ea46173373a6dad4ebd95d4661f42
  Author: Alexander Graf <address@hidden>
  Date:   2017-06-23 (Fri, 23 Jun 2017)

  Changed paths:
    M hw/input/hid.c

  Log Message:
  -----------
  hid: Reset kbd modifiers on reset

When resetting the keyboard, we need to reset not just the pending keystrokes,
but also any pending modifiers. Otherwise there's a race when we're getting
reset while running an escape sequence (modifier 0x100).

Cc: address@hidden
Signed-off-by: Alexander Graf <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 85970a627f308483053f18a342037245d0fee469
      
https://github.com/qemu/qemu/commit/85970a627f308483053f18a342037245d0fee469
  Author: Gerd Hoffmann <address@hidden>
  Date:   2017-06-23 (Fri, 23 Jun 2017)

  Changed paths:
    M ui/sdl2.c

  Log Message:
  -----------
  sdl2: add assert to make coverity happy

There is a loop a few lines up counting consoles and setting
sdl2_num_outputs accordingly, so con ptr can't be NULL there.

Signed-off-by: Gerd Hoffmann <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 8498bb8d2e19f5c280aaac6be772fad5980e7519
      
https://github.com/qemu/qemu/commit/8498bb8d2e19f5c280aaac6be772fad5980e7519
  Author: Gerd Hoffmann <address@hidden>
  Date:   2017-06-23 (Fri, 23 Jun 2017)

  Changed paths:
    M hw/input/ps2.c
    M include/hw/input/ps2.h
    M include/qemu/typedefs.h

  Log Message:
  -----------
  ps2: add and use PS2State typedef

Cleanup: Create and use a typedef for PS2State and stop passing void
pointers.  No functional change.

Signed-off-by: Gerd Hoffmann <address@hidden>
Message-id: address@hidden


  Commit: 954ee55bd528a97347f19f815e00f1e375f82f0a
      
https://github.com/qemu/qemu/commit/954ee55bd528a97347f19f815e00f1e375f82f0a
  Author: Gerd Hoffmann <address@hidden>
  Date:   2017-06-23 (Fri, 23 Jun 2017)

  Changed paths:
    M hw/input/ps2.c

  Log Message:
  -----------
  ps2: add ps2_reset_queue

Factor out ps2 queue reset to a separate function.
No functional change.

Signed-off-by: Gerd Hoffmann <address@hidden>
Message-id: address@hidden


  Commit: 6e24ee0c1e4b6c0c9c748acab77ecd113c942a4d
      
https://github.com/qemu/qemu/commit/6e24ee0c1e4b6c0c9c748acab77ecd113c942a4d
  Author: Gerd Hoffmann <address@hidden>
  Date:   2017-06-23 (Fri, 23 Jun 2017)

  Changed paths:
    M hw/input/ps2.c

  Log Message:
  -----------
  ps2: reset queue in ps2_reset_keyboard

When the guest resets the keyboard also clear the queue.  It is highly
unlikely that the guest is still interested in the events stuck in the
queue, and it avoids confusing the guest in case the queue is full and
the ACK can't be queued up.

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1372583
Signed-off-by: Gerd Hoffmann <address@hidden>
Message-id: address@hidden


  Commit: 40b06f523070deb55f87f9bcee4fedb6c69942f9
      
https://github.com/qemu/qemu/commit/40b06f523070deb55f87f9bcee4fedb6c69942f9
  Author: Peter Maydell <address@hidden>
  Date:   2017-06-23 (Fri, 23 Jun 2017)

  Changed paths:
    M hw/input/hid.c
    M hw/input/ps2.c
    M include/hw/input/ps2.h
    M include/qemu/typedefs.h
    M ui/input.c
    M ui/keymaps.c
    M ui/sdl2.c
    M ui/trace-events

  Log Message:
  -----------
  Merge remote-tracking branch 
'remotes/kraxel/tags/ui-and-input-20170623-pull-request' into staging

# gpg: Signature made Fri 23 Jun 2017 11:39:22 BST
# gpg:                using RSA key 0x4CB6D8EED3E87138
# gpg: Good signature from "Gerd Hoffmann (work) <address@hidden>"
# gpg:                 aka "Gerd Hoffmann <address@hidden>"
# gpg:                 aka "Gerd Hoffmann (private) <address@hidden>"
# Primary key fingerprint: A032 8CFF B93A 17A7 9901  FE7D 4CB6 D8EE D3E8 7138

* remotes/kraxel/tags/ui-and-input-20170623-pull-request:
  ps2: reset queue in ps2_reset_keyboard
  ps2: add ps2_reset_queue
  ps2: add and use PS2State typedef
  sdl2: add assert to make coverity happy
  hid: Reset kbd modifiers on reset
  input: Decrement queue count on kbd delay
  keymaps: add tracing

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/4c8c1cc544db...40b06f523070