qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] a2740a: qdev: remove PropertyInfo.qtype field


From: GitHub
Subject: [Qemu-commits] [qemu/qemu] a2740a: qdev: remove PropertyInfo.qtype field
Date: Thu, 22 Jun 2017 05:17:00 -0700

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: a2740ad584839ac84f3cdb2d928de93a0d7f4e72
      
https://github.com/qemu/qemu/commit/a2740ad584839ac84f3cdb2d928de93a0d7f4e72
  Author: Marc-André Lureau <address@hidden>
  Date:   2017-06-19 (Mon, 19 Jun 2017)

  Changed paths:
    M hw/core/qdev-properties.c
    M hw/core/qdev.c
    M include/hw/qdev-core.h
    M include/hw/qdev-properties.h

  Log Message:
  -----------
  qdev: remove PropertyInfo.qtype field

Remove dependency on qapi qtype, replace a field by a few PropertyInfo
callbacks to set the default value type (introduced in commit 4f2d3d7).

Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>


  Commit: 560f19f162529d691619ac69ed032321c7f5f1fb
      
https://github.com/qemu/qemu/commit/560f19f162529d691619ac69ed032321c7f5f1fb
  Author: Marc-André Lureau <address@hidden>
  Date:   2017-06-19 (Mon, 19 Jun 2017)

  Changed paths:
    M qom/object.c

  Log Message:
  -----------
  object: fix potential leak in getters

If the property is not of the requested type, the getters will leak a
QObject.

Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>


  Commit: 7c877c80308a8d0166029494e2e236c1f95336e8
      
https://github.com/qemu/qemu/commit/7c877c80308a8d0166029494e2e236c1f95336e8
  Author: Marc-André Lureau <address@hidden>
  Date:   2017-06-19 (Mon, 19 Jun 2017)

  Changed paths:
    M tests/qapi-schema/qapi-schema-test.json
    M tests/qapi-schema/qapi-schema-test.out
    M tests/test-keyval.c
    M tests/test-qobject-input-visitor.c

  Log Message:
  -----------
  tests: Remove test cases for alternates of 'number' and 'int'

Alternates with both a 'number' and an 'int' branch will become
invalid when the next patch merges of QFloat and QInt into QNum.
More sophisticated alternate code could keep them valid, but since
we have no users outside tests, simply drop the tests.

Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>


  Commit: c1214ad3dcf392ca3d9354c8a811c76f0d4c45ce
      
https://github.com/qemu/qemu/commit/c1214ad3dcf392ca3d9354c8a811c76f0d4c45ce
  Author: Marc-André Lureau <address@hidden>
  Date:   2017-06-19 (Mon, 19 Jun 2017)

  Changed paths:
    M tests/test-qobject-input-visitor.c

  Log Message:
  -----------
  tests: add more int/number ranges checks

Signed-off-by: Marc-André Lureau <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
[test_visitor_in_uint() tightened slightly]
Signed-off-by: Markus Armbruster <address@hidden>


  Commit: 58634047b7deeab36e4b07c4744e44d698975561
      
https://github.com/qemu/qemu/commit/58634047b7deeab36e4b07c4744e44d698975561
  Author: Marc-André Lureau <address@hidden>
  Date:   2017-06-19 (Mon, 19 Jun 2017)

  Changed paths:
    M qapi/qobject-input-visitor.c

  Log Message:
  -----------
  qapi: Clean up qobject_input_type_number() control flow

Use the more common pattern to error out.

Signed-off-by: Marc-André Lureau <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
[Commit message tweaked]
Signed-off-by: Markus Armbruster <address@hidden>


  Commit: 01b2ffcedd94ad7b42bc870e4c6936c87ad03429
      
https://github.com/qemu/qemu/commit/01b2ffcedd94ad7b42bc870e4c6936c87ad03429
  Author: Marc-André Lureau <address@hidden>
  Date:   2017-06-20 (Tue, 20 Jun 2017)

  Changed paths:
    M MAINTAINERS
    M block/blkdebug.c
    M block/nbd.c
    M block/nfs.c
    M block/qapi.c
    M block/quorum.c
    M block/sheepdog.c
    M block/ssh.c
    M block/vvfat.c
    M blockdev.c
    M hw/acpi/pcihp.c
    M hw/i386/acpi-build.c
    M hw/usb/xen-usb.c
    M include/qapi/qmp/qdict.h
    R include/qapi/qmp/qfloat.h
    R include/qapi/qmp/qint.h
    M include/qapi/qmp/qlist.h
    A include/qapi/qmp/qnum.h
    M include/qapi/qmp/types.h
    M include/qapi/qobject-input-visitor.h
    M include/qapi/qobject-output-visitor.h
    M monitor.c
    M qapi/qobject-input-visitor.c
    M qapi/qobject-output-visitor.c
    M qga/commands.c
    M qga/main.c
    M qobject/Makefile.objs
    M qobject/json-parser.c
    M qobject/qdict.c
    R qobject/qfloat.c
    R qobject/qint.c
    M qobject/qjson.c
    A qobject/qnum.c
    M qobject/qobject.c
    M qom/object.c
    M scripts/coccinelle/qobject.cocci
    M scripts/qapi-visit.py
    M scripts/qapi.py
    M target/i386/cpu.c
    M tests/.gitignore
    M tests/Makefile.include
    M tests/check-qdict.c
    R tests/check-qfloat.c
    R tests/check-qint.c
    M tests/check-qjson.c
    M tests/check-qlist.c
    A tests/check-qnum.c
    M tests/qapi-schema/comments.out
    M tests/qapi-schema/doc-good.out
    M tests/qapi-schema/empty.out
    M tests/qapi-schema/event-case.out
    M tests/qapi-schema/ident-with-escape.out
    M tests/qapi-schema/include-relpath.out
    M tests/qapi-schema/include-repetition.out
    M tests/qapi-schema/include-simple.out
    M tests/qapi-schema/indented-expr.out
    M tests/qapi-schema/qapi-schema-test.out
    M tests/test-qmp-commands.c
    M tests/test-qmp-event.c
    M tests/test-qobject-input-visitor.c
    M tests/test-qobject-output-visitor.c
    M tests/test-x86-cpuid-compat.c
    M ui/spice-core.c
    M ui/vnc-enc-tight.c
    M util/qemu-option.c

  Log Message:
  -----------
  qapi: merge QInt and QFloat in QNum

We would like to use a same QObject type to represent numbers, whether
they are int, uint, or floats. Getters will allow some compatibility
between the various types if the number fits other representations.

Add a few more tests while at it.

Signed-off-by: Marc-André Lureau <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
[parse_stats_intervals() simplified a bit, comment in
test_visitor_in_int_overflow() tidied up, suppress bogus warnings]
Signed-off-by: Markus Armbruster <address@hidden>


  Commit: 60390d2dc85ffade8981ca41e02335cb07353a6d
      
https://github.com/qemu/qemu/commit/60390d2dc85ffade8981ca41e02335cb07353a6d
  Author: Marc-André Lureau <address@hidden>
  Date:   2017-06-20 (Tue, 20 Jun 2017)

  Changed paths:
    M include/qapi/visitor-impl.h
    M include/qapi/visitor.h
    M qapi/qapi-clone-visitor.c
    M qapi/qapi-dealloc-visitor.c
    M qapi/qapi-visit-core.c
    M qapi/qobject-input-visitor.c
    M qapi/trace-events
    M scripts/qapi-visit.py
    M tests/test-qobject-input-visitor.c

  Log Message:
  -----------
  qapi: Remove visit_start_alternate() parameter promote_int

Before the previous commit, parameter promote_int = true made
visit_start_alternate() with an input visitor avoid QTYPE_QINT
variants and create QTYPE_QFLOAT variants instead.  This was used
where QTYPE_QINT variants were invalid.

The previous commit fused QTYPE_QINT with QTYPE_QFLOAT, rendering
promote_int useless and unused.

Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>


  Commit: 36aeb6094f04bed036c43c5e0eb675ca78bf72fe
      
https://github.com/qemu/qemu/commit/36aeb6094f04bed036c43c5e0eb675ca78bf72fe
  Author: Marc-André Lureau <address@hidden>
  Date:   2017-06-20 (Tue, 20 Jun 2017)

  Changed paths:
    M tests/check-qdict.c
    M tests/check-qlist.c
    M tests/check-qnum.c
    M tests/check-qstring.c

  Log Message:
  -----------
  tests: remove /{qnum, qlist, dict}/destroy test

The tests aren't really useful, or already covered by other simple tests.

Signed-off-by: Marc-André Lureau <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>


  Commit: 61a8f418b26a2d974e38e4ae55020aca8d402d88
      
https://github.com/qemu/qemu/commit/61a8f418b26a2d974e38e4ae55020aca8d402d88
  Author: Marc-André Lureau <address@hidden>
  Date:   2017-06-20 (Tue, 20 Jun 2017)

  Changed paths:
    M include/qapi/qmp/qnum.h
    M qobject/qnum.c
    M tests/check-qnum.c

  Log Message:
  -----------
  qnum: add uint type

In order to store integer values between INT64_MAX and UINT64_MAX, add
a uint64_t internal representation.

Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>


  Commit: 2bc7cfea095dc0ab7fae17e0a620f93ce042cafa
      
https://github.com/qemu/qemu/commit/2bc7cfea095dc0ab7fae17e0a620f93ce042cafa
  Author: Marc-André Lureau <address@hidden>
  Date:   2017-06-20 (Tue, 20 Jun 2017)

  Changed paths:
    M qobject/json-lexer.c
    M qobject/json-parser.c
    M tests/check-qjson.c

  Log Message:
  -----------
  json: learn to parse uint64 numbers

Switch strtoll() usage to qemu_strtoi64() helper while at it.

Add a few tests for large numbers.

Signed-off-by: Marc-André Lureau <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>


  Commit: 5923f85fb82df7c8c60a89458a5ae856045e5ab1
      
https://github.com/qemu/qemu/commit/5923f85fb82df7c8c60a89458a5ae856045e5ab1
  Author: Marc-André Lureau <address@hidden>
  Date:   2017-06-20 (Tue, 20 Jun 2017)

  Changed paths:
    M hw/i386/acpi-build.c
    M qapi/qobject-input-visitor.c
    M qapi/qobject-output-visitor.c
    M tests/test-qobject-input-visitor.c
    M tests/test-qobject-output-visitor.c

  Log Message:
  -----------
  qapi: update the qobject visitor to use QNUM_U64

Switch to use QNum/uint where appropriate to remove i64 limitation.

The input visitor will cast i64 input to u64 for compatibility
reasons (existing json QMP client already use negative i64 for large
u64, and expect an implicit cast in qemu).

Note: before the patch, uint64_t values above INT64_MAX are sent over
json QMP as negative values, e.g. UINT64_MAX is sent as -1. After the
patch, they are sent unmodified.  Clearly a bug fix, but we have to
consider compatibility issues anyway.  libvirt should cope fine,
because its parsing of unsigned integers accepts negative values
modulo 2^64.  There's hope that other clients will, too.

Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Message-Id: <address@hidden>
[check_native_list() tweaked for consistency with signed case]
Signed-off-by: Markus Armbruster <address@hidden>


  Commit: 3152779cd63ba41331ef41659406f65b03e7911a
      
https://github.com/qemu/qemu/commit/3152779cd63ba41331ef41659406f65b03e7911a
  Author: Marc-André Lureau <address@hidden>
  Date:   2017-06-20 (Tue, 20 Jun 2017)

  Changed paths:
    M include/qom/object.h
    M qom/object.c

  Log Message:
  -----------
  object: add uint property setter/getter

Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>


  Commit: d015c4ea6ff49a164cad68992e529716bc1f5311
      
https://github.com/qemu/qemu/commit/d015c4ea6ff49a164cad68992e529716bc1f5311
  Author: Marc-André Lureau <address@hidden>
  Date:   2017-06-20 (Tue, 20 Jun 2017)

  Changed paths:
    M hw/pci-host/q35.c

  Log Message:
  -----------
  q35: fix get_mmcfg_size to use uint64 visitor

e->size is hwaddr, i.e. uint64_t. We silently truncate.

Signed-off-by: Marc-André Lureau <address@hidden>
Suggested-by: Markus Armbruster <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>


  Commit: 1e507bb0fd0a858c3e310fb62e45b0e01a75013f
      
https://github.com/qemu/qemu/commit/1e507bb0fd0a858c3e310fb62e45b0e01a75013f
  Author: Marc-André Lureau <address@hidden>
  Date:   2017-06-20 (Tue, 20 Jun 2017)

  Changed paths:
    M backends/cryptodev.c
    M hw/pci-host/piix.c
    M hw/pci-host/q35.c
    M hw/ppc/pnv.c
    M net/dump.c
    M net/filter-buffer.c

  Log Message:
  -----------
  object: use more specific property type names

Use the actual unsigned integer type name.

The type name change impacts the following externally visible area:

* vl.c's machine_help_func() puts it in help for -machine NAME,help.

* QMP command qom-list exposes it in ObjectPropertyInfo member @type.

* QMP command device-list-properties exposes it in DevicePropertyInfo
  member @type.

Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>


  Commit: 85bbd1e7a4aea4c6d4d636d300c3f405afa98285
      
https://github.com/qemu/qemu/commit/85bbd1e7a4aea4c6d4d636d300c3f405afa98285
  Author: Marc-André Lureau <address@hidden>
  Date:   2017-06-20 (Tue, 20 Jun 2017)

  Changed paths:
    M hw/block/fdc.c
    M hw/net/e1000e.c
    M include/hw/qdev-properties.h

  Log Message:
  -----------
  qdev: Rename DEFINE_PROP_DEFAULT() to DEFINE_PROP_SIGNED()

The rename prepares for the patch after next's DEFINE_PROP_UNSIGNED().

Signed-off-by: Marc-André Lureau <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
[Commit message tweaked]
Signed-off-by: Markus Armbruster <address@hidden>


  Commit: 76318657a803c542cdee232c8507dec8004e2478
      
https://github.com/qemu/qemu/commit/76318657a803c542cdee232c8507dec8004e2478
  Author: Marc-André Lureau <address@hidden>
  Date:   2017-06-20 (Tue, 20 Jun 2017)

  Changed paths:
    M hw/core/qdev-properties.c
    M include/hw/qdev-core.h
    M include/hw/qdev-properties.h

  Log Message:
  -----------
  qdev: wrap default property value in an union

Wrap the Property default value (an int64_t) in a union, to prepare
for the next patch adding a uint64_t.

Signed-off-by: Marc-André Lureau <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>


  Commit: 3fb2111fc9bb9c73bae81c6696bcf333690147b0
      
https://github.com/qemu/qemu/commit/3fb2111fc9bb9c73bae81c6696bcf333690147b0
  Author: Marc-André Lureau <address@hidden>
  Date:   2017-06-20 (Tue, 20 Jun 2017)

  Changed paths:
    M hw/core/qdev-properties.c
    M include/hw/qdev-core.h
    M include/hw/qdev-properties.h

  Log Message:
  -----------
  qdev: avoid type casts between signed and unsigned

Modify the unsigned type for various properties to use QNUM_U64, to
avoid type casts.

There are a few empty lines added to improve code reading/style.

Signed-off-by: Marc-André Lureau <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
[Change to set_default_value_enum() dropped]
Signed-off-by: Markus Armbruster <address@hidden>


  Commit: d528227d4c30869dce6fa81124d12b39bcb987cf
      
https://github.com/qemu/qemu/commit/d528227d4c30869dce6fa81124d12b39bcb987cf
  Author: Marc-André Lureau <address@hidden>
  Date:   2017-06-20 (Tue, 20 Jun 2017)

  Changed paths:
    M hw/intc/apic_common.c

  Log Message:
  -----------
  apic-common: make "id" property a uint32

The getter and setter of TYPE_APIC_COMMON property "id" are
apic_common_get_id() and apic_common_set_id().

apic_common_get_id() reads either APICCommonState member uint32_t
initial_apic_id or uint8_t id into an int64_t local variable.  It then
passes this variable to visit_type_int().

apic_common_set_id() uses visit_type_int() to read the value into a
local variable, which it then assigns both to initial_apic_id and id.

While the state backing the property is two unsigned members, 8 and 32
bits wide, the actual visitor is 64 bits signed.

Change getter and setter to use visit_type_uint32().  Then everything's
uint32_t, except for @id.

Suggested-by: Markus Armbruster <address@hidden>
Signed-off-by: Marc-André Lureau <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>


  Commit: 446de8b68a33834b9130f5ba182e8cdf8749c759
      
https://github.com/qemu/qemu/commit/446de8b68a33834b9130f5ba182e8cdf8749c759
  Author: Marc-André Lureau <address@hidden>
  Date:   2017-06-20 (Tue, 20 Jun 2017)

  Changed paths:
    M hw/i386/acpi-build.c
    M hw/pci-host/gpex.c
    M hw/pci-host/q35.c
    M hw/pci-host/xilinx-pcie.c

  Log Message:
  -----------
  qdev: Use appropriate getter/setters type

Based on the underlying type of the data accessed, use the appropriate
getters/setters:

* AcpiPmInfo members s3_disabled, s4_disabled are bool, member s4_val is
  an uint8_t

* Property ACPI_PCIHP_IO_PROP is defined with
  object_property_add_uint32_ptr()

* Property PCIE_HOST_MCFG_SIZE is implemented with visit_type_uint64()

* PCIDevice property "addr" is backed by PCIDevice member devfn, which
  is an int32_t

Signed-off-by: Marc-André Lureau <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
[More verbose commit message]
Signed-off-by: Markus Armbruster <address@hidden>


  Commit: 822335eb518b5b565f8938dbe4dba6bda56f6093
      
https://github.com/qemu/qemu/commit/822335eb518b5b565f8938dbe4dba6bda56f6093
  Author: Marc-André Lureau <address@hidden>
  Date:   2017-06-20 (Tue, 20 Jun 2017)

  Changed paths:
    M include/hw/isa/isa.h

  Log Message:
  -----------
  isa: use get_uint() for "io-base"

The property is defined with DEFINE_PROP_UINT32().

Signed-off-by: Marc-André Lureau <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>


  Commit: 9ed442b8ae9c0641c6735e1753ef554c659f10f1
      
https://github.com/qemu/qemu/commit/9ed442b8ae9c0641c6735e1753ef554c659f10f1
  Author: Marc-André Lureau <address@hidden>
  Date:   2017-06-20 (Tue, 20 Jun 2017)

  Changed paths:
    M hw/acpi/memory_hotplug.c
    M hw/acpi/nvdimm.c
    M hw/mem/pc-dimm.c
    M hw/ppc/spapr.c

  Log Message:
  -----------
  pc-dimm: use get_uint() for dimm properties

TYPE_PC_DIMM's property PC_DIMM_ADDR_PROP is defined with
DEFINE_PROP_UINT64().

TYPE_PC_DIMM's property PC_DIMM_NODE_PROP is defined with
DEFINE_PROP_UINT32().

Signed-off-by: Marc-André Lureau <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>


  Commit: b053ef6106dc99c56972fd72a4880571c6fbd669
      
https://github.com/qemu/qemu/commit/b053ef6106dc99c56972fd72a4880571c6fbd669
  Author: Marc-André Lureau <address@hidden>
  Date:   2017-06-20 (Tue, 20 Jun 2017)

  Changed paths:
    M hw/acpi/memory_hotplug.c
    M hw/acpi/nvdimm.c
    M hw/mem/pc-dimm.c

  Log Message:
  -----------
  pc-dimm: make "size" property uint64

This carries the memory_region_size() value without implicit cast.

Signed-off-by: Marc-André Lureau <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>


  Commit: c03d83d55a27f11a4fe87ac7b0085bcbb440d9ac
      
https://github.com/qemu/qemu/commit/c03d83d55a27f11a4fe87ac7b0085bcbb440d9ac
  Author: Marc-André Lureau <address@hidden>
  Date:   2017-06-20 (Tue, 20 Jun 2017)

  Changed paths:
    M hw/acpi/pcihp.c

  Log Message:
  -----------
  pcihp: use get_uint() for "bsel" property

The property is defined with object_property_add_uint32_ptr()

Signed-off-by: Marc-André Lureau <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>


  Commit: 19e9cdf040efdbdbae634931916e38b48aa8baf0
      
https://github.com/qemu/qemu/commit/19e9cdf040efdbdbae634931916e38b48aa8baf0
  Author: Marc-André Lureau <address@hidden>
  Date:   2017-06-20 (Tue, 20 Jun 2017)

  Changed paths:
    M hw/arm/aspeed.c

  Log Message:
  -----------
  aspeed: use {set, get}_uint() for "ram-size" property

This property is an alias for device TYPE_ASPEED_SDMC's property
"ram-size", which is defined with DEFINE_PROP_UINT64().

Signed-off-by: Marc-André Lureau <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>


  Commit: c5c6c47ce32a8069e9f88fdbe9570db3e4509abb
      
https://github.com/qemu/qemu/commit/c5c6c47ce32a8069e9f88fdbe9570db3e4509abb
  Author: Marc-André Lureau <address@hidden>
  Date:   2017-06-20 (Tue, 20 Jun 2017)

  Changed paths:
    M hw/arm/bcm2835_peripherals.c
    M hw/arm/raspi.c

  Log Message:
  -----------
  bcm2835_fb: use {get, set}_uint() for "vcram-size" and "vcram-base"

Both properties are defined with DEFINE_PROP_UINT32().

Signed-off-by: Marc-André Lureau <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>


  Commit: 6d13643a3adf228021292f4de67b5a50fff2392d
      
https://github.com/qemu/qemu/commit/6d13643a3adf228021292f4de67b5a50fff2392d
  Author: Marc-André Lureau <address@hidden>
  Date:   2017-06-20 (Tue, 20 Jun 2017)

  Changed paths:
    M hw/core/platform-bus.c

  Log Message:
  -----------
  platform-bus: use get_uint() for "addr" property

This is TYPE_MEMORY_REGION's property.  Its getter
memory_region_get_addr() uses visit_type_uint64().

Signed-off-by: Marc-André Lureau <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>


  Commit: 35f91e506947720747bab33b88bf78efa1891b9b
      
https://github.com/qemu/qemu/commit/35f91e506947720747bab33b88bf78efa1891b9b
  Author: Marc-André Lureau <address@hidden>
  Date:   2017-06-20 (Tue, 20 Jun 2017)

  Changed paths:
    M hw/i386/acpi-build.c

  Log Message:
  -----------
  acpi: use get_uint() for "acpi-pcihp-io*" properties

Those are defined with object_property_add_uint16_ptr()

Signed-off-by: Marc-André Lureau <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>


  Commit: b81bdbf3c77e04ee2c0cc5d25c1c361bbe60382d
      
https://github.com/qemu/qemu/commit/b81bdbf3c77e04ee2c0cc5d25c1c361bbe60382d
  Author: Marc-André Lureau <address@hidden>
  Date:   2017-06-20 (Tue, 20 Jun 2017)

  Changed paths:
    M hw/i386/acpi-build.c

  Log Message:
  -----------
  acpi: use get_uint() for various acpi properties

PIIX4: piix4_pm_add_propeties() defines these with
object_property_add_uint*_ptr().

Q35: ich9_lpc_add_properties() and ich9_pm_add_properties() define them
similarly, except for ACPI_PM_PROP_GPE0_BLK().  That one's getter
ich9_pm_get_gpe0_blk() uses visit_type_uint32().

Signed-off-by: Marc-André Lureau <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>


  Commit: 605553654f695b03e7d3f59395a4b7f8f1c5cf99
      
https://github.com/qemu/qemu/commit/605553654f695b03e7d3f59395a4b7f8f1c5cf99
  Author: Marc-André Lureau <address@hidden>
  Date:   2017-06-20 (Tue, 20 Jun 2017)

  Changed paths:
    M hw/i386/acpi-build.c

  Log Message:
  -----------
  acpi: use get_uint() for "pci-hole*" properties

Those properties use visit_type_uint*()

Signed-off-by: Marc-André Lureau <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>


  Commit: 1ea1572adfae0f6a774bc2446b4890ac597125eb
      
https://github.com/qemu/qemu/commit/1ea1572adfae0f6a774bc2446b4890ac597125eb
  Author: Marc-André Lureau <address@hidden>
  Date:   2017-06-20 (Tue, 20 Jun 2017)

  Changed paths:
    M hw/i386/pc.c

  Log Message:
  -----------
  pc: use get_uint() for "iobase" property

TYPE_ISA_FDC's property "iobase" is defined with DEFINE_PROP_UINT32().

Signed-off-by: Marc-André Lureau <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>


  Commit: c7b4efb4a0aefc3c0de7500332a4c34f2d84d9b3
      
https://github.com/qemu/qemu/commit/c7b4efb4a0aefc3c0de7500332a4c34f2d84d9b3
  Author: Marc-André Lureau <address@hidden>
  Date:   2017-06-20 (Tue, 20 Jun 2017)

  Changed paths:
    M hw/i386/pc.c

  Log Message:
  -----------
  pc: use get_uint() for "apic-id" property

TYPE_X86_CPU's property "apic-id" is defined with DEFINE_PROP_UINT32().

Signed-off-by: Marc-André Lureau <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>


  Commit: 5d7fb0f254164e883a077186530fc2aa706954a4
      
https://github.com/qemu/qemu/commit/5d7fb0f254164e883a077186530fc2aa706954a4
  Author: Marc-André Lureau <address@hidden>
  Date:   2017-06-20 (Tue, 20 Jun 2017)

  Changed paths:
    M hw/i386/pc.c

  Log Message:
  -----------
  pc: use get_uint() for "hpet-intcap" property

TYPE_HPET's property HPET_INTCAP is defined with DEFINE_PROP_UINT32().

Signed-off-by: Marc-André Lureau <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>


  Commit: 4ccd89d29447dc26ec674fa255d28238e4a859b3
      
https://github.com/qemu/qemu/commit/4ccd89d29447dc26ec674fa255d28238e4a859b3
  Author: Marc-André Lureau <address@hidden>
  Date:   2017-06-20 (Tue, 20 Jun 2017)

  Changed paths:
    M hw/i386/xen/xen-hvm.c

  Log Message:
  -----------
  xen: use get_uint() for "max-ram-below-4g" property

TYPE_PC_MACHINE's property PC_MACHINE_MAX_RAM_BELOW_4G's getter and
setter pc_machine_get_max_ram_below_4g() and
pc_machine_set_max_ram_below_4g() use visit_type_size()

Signed-off-by: Marc-André Lureau <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>


  Commit: 77a7a3676077a109bd032affd12681bfdb2e8783
      
https://github.com/qemu/qemu/commit/77a7a3676077a109bd032affd12681bfdb2e8783
  Author: Marc-André Lureau <address@hidden>
  Date:   2017-06-20 (Tue, 20 Jun 2017)

  Changed paths:
    M hw/intc/arm_gicv3_common.c

  Log Message:
  -----------
  arm: use get_uint() for "mp-affinity" property

TYPE_ARM_CPU's property "mp-affinity" is defined with
DEFINE_PROP_UINT64().

Signed-off-by: Marc-André Lureau <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>


  Commit: 1eb4243434008faefd79ad0ce4970ae4d071ae2f
      
https://github.com/qemu/qemu/commit/1eb4243434008faefd79ad0ce4970ae4d071ae2f
  Author: Marc-André Lureau <address@hidden>
  Date:   2017-06-20 (Tue, 20 Jun 2017)

  Changed paths:
    M hw/misc/auxbus.c

  Log Message:
  -----------
  auxbus: use get_uint() for "addr" property

This is TYPE_MEMORY_REGION's property.  Its getter
memory_region_get_addr() uses visit_type_uint64().

Signed-off-by: Marc-André Lureau <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>


  Commit: 07fe095452c55ff18153552998e0ef16d171c1e3
      
https://github.com/qemu/qemu/commit/07fe095452c55ff18153552998e0ef16d171c1e3
  Author: Marc-André Lureau <address@hidden>
  Date:   2017-06-20 (Tue, 20 Jun 2017)

  Changed paths:
    M hw/misc/pvpanic.c

  Log Message:
  -----------
  pvpanic: use get_uint() for "ioport" property

TYPE_ISA_PVPANIC_DEVICE's property PVPANIC_IOPORT_PROP is defined with
DEFINE_PROP_UINT16().

Signed-off-by: Marc-André Lureau <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>


  Commit: 9848619a3b9c56d5db6b58963a62559ecfa9fd5d
      
https://github.com/qemu/qemu/commit/9848619a3b9c56d5db6b58963a62559ecfa9fd5d
  Author: Marc-André Lureau <address@hidden>
  Date:   2017-06-20 (Tue, 20 Jun 2017)

  Changed paths:
    M hw/ppc/pnv_core.c

  Log Message:
  -----------
  pnv-core: use get_uint() for "core-pir" property

This is an alias of TYPE_PNV_CORE's property "pir", which is defined
with DEFINE_PROP_UINT32()

Signed-off-by: Marc-André Lureau <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>


  Commit: 61d7c14437a82487c7baef7ad1c2c73c9a30f9be
      
https://github.com/qemu/qemu/commit/61d7c14437a82487c7baef7ad1c2c73c9a30f9be
  Author: Marc-André Lureau <address@hidden>
  Date:   2017-06-20 (Tue, 20 Jun 2017)

  Changed paths:
    M numa.c

  Log Message:
  -----------
  numa: use get_uint() for "size" property

"size" is a property of TYPE_MEMORY_BACKEND.
host_memory_backend_get_size() and host_memory_backend_set_size() use
visit_type_size().

Signed-off-by: Marc-André Lureau <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>


  Commit: 709fa704f6b142f9be3a9e33a81e6d8d4c52e2de
      
https://github.com/qemu/qemu/commit/709fa704f6b142f9be3a9e33a81e6d8d4c52e2de
  Author: Marc-André Lureau <address@hidden>
  Date:   2017-06-20 (Tue, 20 Jun 2017)

  Changed paths:
    M target/i386/cpu.c

  Log Message:
  -----------
  i386/cpu: use get_uint() for "min-level"/"min-xlevel" properties

These are properties of TYPE_X86_CPU, defined with DEFINE_PROP_UINT32()

Signed-off-by: Marc-André Lureau <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>


  Commit: ad664c1d4c731c8320fb9008125fa93069a6315f
      
https://github.com/qemu/qemu/commit/ad664c1d4c731c8320fb9008125fa93069a6315f
  Author: Marc-André Lureau <address@hidden>
  Date:   2017-06-20 (Tue, 20 Jun 2017)

  Changed paths:
    M ui/console.c

  Log Message:
  -----------
  console: use get_uint() for "head" property

TYPE_QEMU_CONSOLE property "head" is defined with
object_property_add_uint*_ptr().

Signed-off-by: Marc-André Lureau <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>


  Commit: 269c20b2bbd2aa8531e0cdc741fb166f290d7a2b
      
https://github.com/qemu/qemu/commit/269c20b2bbd2aa8531e0cdc741fb166f290d7a2b
  Author: Marc-André Lureau <address@hidden>
  Date:   2017-06-20 (Tue, 20 Jun 2017)

  Changed paths:
    M tests/check-qdict.c

  Log Message:
  -----------
  tests/qdict: check more get_try_int() cases

Signed-off-by: Marc-André Lureau <address@hidden>
Suggested-by: Markus Armbruster <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>


  Commit: 84e3d0725b06bdf8c6985788caa7776d6b7353ce
      
https://github.com/qemu/qemu/commit/84e3d0725b06bdf8c6985788caa7776d6b7353ce
  Author: Peter Maydell <address@hidden>
  Date:   2017-06-22 (Thu, 22 Jun 2017)

  Changed paths:
    M MAINTAINERS
    M backends/cryptodev.c
    M block/blkdebug.c
    M block/nbd.c
    M block/nfs.c
    M block/qapi.c
    M block/quorum.c
    M block/sheepdog.c
    M block/ssh.c
    M block/vvfat.c
    M blockdev.c
    M hw/acpi/memory_hotplug.c
    M hw/acpi/nvdimm.c
    M hw/acpi/pcihp.c
    M hw/arm/aspeed.c
    M hw/arm/bcm2835_peripherals.c
    M hw/arm/raspi.c
    M hw/block/fdc.c
    M hw/core/platform-bus.c
    M hw/core/qdev-properties.c
    M hw/core/qdev.c
    M hw/i386/acpi-build.c
    M hw/i386/pc.c
    M hw/i386/xen/xen-hvm.c
    M hw/intc/apic_common.c
    M hw/intc/arm_gicv3_common.c
    M hw/mem/pc-dimm.c
    M hw/misc/auxbus.c
    M hw/misc/pvpanic.c
    M hw/net/e1000e.c
    M hw/pci-host/gpex.c
    M hw/pci-host/piix.c
    M hw/pci-host/q35.c
    M hw/pci-host/xilinx-pcie.c
    M hw/ppc/pnv.c
    M hw/ppc/pnv_core.c
    M hw/ppc/spapr.c
    M hw/usb/xen-usb.c
    M include/hw/isa/isa.h
    M include/hw/qdev-core.h
    M include/hw/qdev-properties.h
    M include/qapi/qmp/qdict.h
    R include/qapi/qmp/qfloat.h
    R include/qapi/qmp/qint.h
    M include/qapi/qmp/qlist.h
    A include/qapi/qmp/qnum.h
    M include/qapi/qmp/types.h
    M include/qapi/qobject-input-visitor.h
    M include/qapi/qobject-output-visitor.h
    M include/qapi/visitor-impl.h
    M include/qapi/visitor.h
    M include/qom/object.h
    M monitor.c
    M net/dump.c
    M net/filter-buffer.c
    M numa.c
    M qapi/qapi-clone-visitor.c
    M qapi/qapi-dealloc-visitor.c
    M qapi/qapi-visit-core.c
    M qapi/qobject-input-visitor.c
    M qapi/qobject-output-visitor.c
    M qapi/trace-events
    M qga/commands.c
    M qga/main.c
    M qobject/Makefile.objs
    M qobject/json-lexer.c
    M qobject/json-parser.c
    M qobject/qdict.c
    R qobject/qfloat.c
    R qobject/qint.c
    M qobject/qjson.c
    A qobject/qnum.c
    M qobject/qobject.c
    M qom/object.c
    M scripts/coccinelle/qobject.cocci
    M scripts/qapi-visit.py
    M scripts/qapi.py
    M target/i386/cpu.c
    M tests/.gitignore
    M tests/Makefile.include
    M tests/check-qdict.c
    R tests/check-qfloat.c
    R tests/check-qint.c
    M tests/check-qjson.c
    M tests/check-qlist.c
    A tests/check-qnum.c
    M tests/check-qstring.c
    M tests/qapi-schema/comments.out
    M tests/qapi-schema/doc-good.out
    M tests/qapi-schema/empty.out
    M tests/qapi-schema/event-case.out
    M tests/qapi-schema/ident-with-escape.out
    M tests/qapi-schema/include-relpath.out
    M tests/qapi-schema/include-repetition.out
    M tests/qapi-schema/include-simple.out
    M tests/qapi-schema/indented-expr.out
    M tests/qapi-schema/qapi-schema-test.json
    M tests/qapi-schema/qapi-schema-test.out
    M tests/test-keyval.c
    M tests/test-qmp-commands.c
    M tests/test-qmp-event.c
    M tests/test-qobject-input-visitor.c
    M tests/test-qobject-output-visitor.c
    M tests/test-x86-cpuid-compat.c
    M ui/console.c
    M ui/spice-core.c
    M ui/vnc-enc-tight.c
    M util/qemu-option.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2017-06-09-v2' 
into staging

QAPI patches for 2017-06-09

# gpg: Signature made Tue 20 Jun 2017 13:31:39 BST
# gpg:                using RSA key 0x3870B400EB918653
# gpg: Good signature from "Markus Armbruster <address@hidden>"
# gpg:                 aka "Markus Armbruster <address@hidden>"
# Primary key fingerprint: 354B C8B3 D7EB 2A6B 6867  4E5F 3870 B400 EB91 8653

* remotes/armbru/tags/pull-qapi-2017-06-09-v2: (41 commits)
  tests/qdict: check more get_try_int() cases
  console: use get_uint() for "head" property
  i386/cpu: use get_uint() for "min-level"/"min-xlevel" properties
  numa: use get_uint() for "size" property
  pnv-core: use get_uint() for "core-pir" property
  pvpanic: use get_uint() for "ioport" property
  auxbus: use get_uint() for "addr" property
  arm: use get_uint() for "mp-affinity" property
  xen: use get_uint() for "max-ram-below-4g" property
  pc: use get_uint() for "hpet-intcap" property
  pc: use get_uint() for "apic-id" property
  pc: use get_uint() for "iobase" property
  acpi: use get_uint() for "pci-hole*" properties
  acpi: use get_uint() for various acpi properties
  acpi: use get_uint() for "acpi-pcihp-io*" properties
  platform-bus: use get_uint() for "addr" property
  bcm2835_fb: use {get, set}_uint() for "vcram-size" and "vcram-base"
  aspeed: use {set, get}_uint() for "ram-size" property
  pcihp: use get_uint() for "bsel" property
  pc-dimm: make "size" property uint64
  ...

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/db7a99cdc1d0...84e3d0725b06

reply via email to

[Prev in Thread] Current Thread [Next in Thread]