[Qemu-commits] [qemu/qemu] 01f9cf: qemu-options: explain disk I/O throttling options

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 01f9cfab8bf73653ff6df066155a01ce7892cf7d
      
https://github.com/qemu/qemu/commit/01f9cfab8bf73653ff6df066155a01ce7892cf7d
  Author: Stefan Hajnoczi <address@hidden>
  Date:   2017-04-21 (Fri, 21 Apr 2017)

  Changed paths:
    M qemu-options.hx

  Log Message:
  -----------
  qemu-options: explain disk I/O throttling options

The disk I/O throttling options have been listed for a long time but
never explained on the QEMU man page.

Suggested-by: Nini Gu <address@hidden>
Cc: Alberto Garcia <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>
Reviewed-by: Alberto Garcia <address@hidden>
Reviewed-by: Greg Kurz <address@hidden>
Message-id: address@hidden
Signed-off-by: Stefan Hajnoczi <address@hidden>


  Commit: ab08aec45f67a776ea37cee0bf94a34abb84ad97
      
https://github.com/qemu/qemu/commit/ab08aec45f67a776ea37cee0bf94a34abb84ad97
  Author: Stefan Hajnoczi <address@hidden>
  Date:   2017-04-21 (Fri, 21 Apr 2017)

  Changed paths:
    M tests/test-throttle.c

  Log Message:
  -----------
  throttle: do not use invalid config in test

The (burst) max parameter cannot be smaller than the avg parameter.
There is a test case that uses avg = 56, max = 1 and gets away with it
because no input validation is performed by the test case.

This patch switches to valid test input parameters.

Signed-off-by: Stefan Hajnoczi <address@hidden>
Reviewed-by: Alberto Garcia <address@hidden>
Message-id: address@hidden
Signed-off-by: Stefan Hajnoczi <address@hidden>


  Commit: d72915c60bff51495529449750e051d01b03c62f
      
https://github.com/qemu/qemu/commit/d72915c60bff51495529449750e051d01b03c62f
  Author: Stefan Hajnoczi <address@hidden>
  Date:   2017-04-21 (Fri, 21 Apr 2017)

  Changed paths:
    M tests/test-throttle.c
    M util/throttle.c

  Log Message:
  -----------
  throttle: make throttle_config(throttle_get_config()) symmetric

Throttling has a weird property that throttle_get_config() does not
always return the same throttling settings that were given with
throttle_config().  In other words, the set and get functions aren't
symmetric.

If .max is 0 then the throttling code assigns a default value of .avg /
10 in throttle_config().  This is an implementation detail of the
throttling algorithm.  When throttle_get_config() is called the .max
value returned should still be 0.

Users are exposed to this quirk via "info block" or "query-block"
monitor commands.  This has caused confusion because it looks like a bug
when an unexpected value is reported.

This patch hides the .max value adjustment in throttle_get_config() and
updates test-throttle.c appropriately.

Reported-by: Nini Gu <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>
Reviewed-by: Alberto Garcia <address@hidden>
Message-id: address@hidden
Signed-off-by: Stefan Hajnoczi <address@hidden>


  Commit: 3928d50bf151d2f25fde93432b0ee1d8eddd982d
      
https://github.com/qemu/qemu/commit/3928d50bf151d2f25fde93432b0ee1d8eddd982d
  Author: Lidong Chen <address@hidden>
  Date:   2017-04-21 (Fri, 21 Apr 2017)

  Changed paths:
    M migration/block.c

  Log Message:
  -----------
  migration/block: use blk_pwrite_zeroes for each zero cluster

BLOCK_SIZE is (1 << 20), qcow2 cluster size is 65536 by default,
this may cause the qcow2 file size to be bigger after migration.
This patch checks each cluster, using blk_pwrite_zeroes for each
zero cluster.

[Initialize cluster_size to BLOCK_SIZE to prevent a gcc uninitialized
variable compiler warning.  In reality we always initialize cluster_size
in a conditional but gcc doesn't know that.
--Stefan]

Reviewed-by: Stefan Hajnoczi <address@hidden>
Signed-off-by: Lidong Chen <address@hidden>
Message-id: address@hidden
Signed-off-by: Stefan Hajnoczi <address@hidden>


  Commit: 205f8618beb8ec00f7617b9c737dfd273b1310eb
      
https://github.com/qemu/qemu/commit/205f8618beb8ec00f7617b9c737dfd273b1310eb
  Author: Changlong Xie <address@hidden>
  Date:   2017-04-21 (Fri, 21 Apr 2017)

  Changed paths:
    M MAINTAINERS

  Log Message:
  -----------
  MAINTAINERS: update Wen's email address

So he can get CC'ed on future patches and bugs for this feature

Signed-off-by: Changlong Xie <address@hidden>
Message-id: address@hidden
Signed-off-by: Stefan Hajnoczi <address@hidden>


  Commit: 3ccc0a0163b932fe980dce8d26db4bf98b1900e9
      
https://github.com/qemu/qemu/commit/3ccc0a0163b932fe980dce8d26db4bf98b1900e9
  Author: Zhang Chen <address@hidden>
  Date:   2017-04-21 (Fri, 21 Apr 2017)

  Changed paths:
    M MAINTAINERS

  Log Message:
  -----------
  MAINTAINERS: update my email address

I'm leaving my job at Fujitsu, this email address will stop working
this week. Update it to one that I will have access to later.

Signed-off-by: Xie Changlong <address@hidden>
Message-id: address@hidden
Signed-off-by: Stefan Hajnoczi <address@hidden>


  Commit: 09fc586db3b0917c3f5ad0c56e60920c5061422b
      
https://github.com/qemu/qemu/commit/09fc586db3b0917c3f5ad0c56e60920c5061422b
  Author: Peter Maydell <address@hidden>
  Date:   2017-04-21 (Fri, 21 Apr 2017)

  Changed paths:
    M MAINTAINERS
    M migration/block.c
    M qemu-options.hx
    M tests/test-throttle.c
    M util/throttle.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into 
staging

# gpg: Signature made Fri 21 Apr 2017 10:43:04 BST
# gpg:                using RSA key 0x9CA4ABB381AB73C8
# gpg: Good signature from "Stefan Hajnoczi <address@hidden>"
# gpg:                 aka "Stefan Hajnoczi <address@hidden>"
# Primary key fingerprint: 8695 A8BF D3F9 7CDA AC35  775A 9CA4 ABB3 81AB 73C8

* remotes/stefanha/tags/block-pull-request:
  MAINTAINERS: update my email address
  MAINTAINERS: update Wen's email address
  migration/block: use blk_pwrite_zeroes for each zero cluster
  throttle: make throttle_config(throttle_get_config()) symmetric
  throttle: do not use invalid config in test
  qemu-options: explain disk I/O throttling options

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/b4c963fa82ff...09fc586db3b0