[Qemu-commits] [qemu/qemu] d9123d: tests/libqtest.c: Delete possible stale unix socke...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: d9123d09f711bf1b855de2b5a907d4c85f46d6c3
      
https://github.com/qemu/qemu/commit/d9123d09f711bf1b855de2b5a907d4c85f46d6c3
  Author: Peter Maydell <address@hidden>
  Date:   2017-04-03 (Mon, 03 Apr 2017)

  Changed paths:
    M tests/libqtest.c

  Log Message:
  -----------
  tests/libqtest.c: Delete possible stale unix sockets

Occasionally if a test crashes or is interrupted by the user
at the wrong moment it could leave behind a stale UNIX
socket in /tmp/. This will then cause a subsequent test
run to fail spuriously with
 tests/libqtest.c:70:init_socket: assertion failed (ret != -1): (-1 != -1)
if it happens to reuse the same PID.

Defend against this by deleting any stray stale socket before
trying to open the new ones for this test.

Signed-off-by: Peter Maydell <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Message-id: address@hidden