[Qemu-commits] [qemu/qemu] aa2629: event_notifier: prevent accidental use after close

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: aa262928595d431bfee7914cb7d9d79197f887a2
      
https://github.com/qemu/qemu/commit/aa262928595d431bfee7914cb7d9d79197f887a2
  Author: Halil Pasic <address@hidden>
  Date:   2017-03-29 (Wed, 29 Mar 2017)

  Changed paths:
    M util/event_notifier-posix.c
    M util/event_notifier-win32.c

  Log Message:
  -----------
  event_notifier: prevent accidental use after close

Let's set the handles to the underlying facilities to their extremal
value so no accidental misuse can happen, and to make it obvious that the
notifier is dysfunctional. E.g. if we just close an fd but do not touch
the int holding the fd eventually a read/write could succeed again when
the fd gets reused, and corrupt the file addressed by the fd.

Signed-off-by: Halil Pasic <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>


  Commit: c53598ed18e40a9609573b21f2a361221ca0f806
      
https://github.com/qemu/qemu/commit/c53598ed18e40a9609573b21f2a361221ca0f806
  Author: Alexey Kardashevskiy <address@hidden>
  Date:   2017-03-29 (Wed, 29 Mar 2017)

  Changed paths:
    M hw/pci/pci.c

  Log Message:
  -----------
  pci: Add missing drop of bus master AS reference

The recent introduction of a bus master container added
memory_region_add_subregion() into the PCI device registering path but
missed memory_region_del_subregion() in the unregistering path leaving
a reference to the root memory region of the new container.

This adds missing memory_region_del_subregion().

Fixes: 3716d5902d743 ("pci: introduce a bus master container")
Signed-off-by: Alexey Kardashevskiy <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>
Reviewed-by: Paolo Bonzini <address@hidden>


  Commit: b8adbc657802482e4da1767bf983ebfdf9bfe9fc
      
https://github.com/qemu/qemu/commit/b8adbc657802482e4da1767bf983ebfdf9bfe9fc
  Author: Andrew Baumann <address@hidden>
  Date:   2017-03-29 (Wed, 29 Mar 2017)

  Changed paths:
    M include/hw/virtio/virtio.h

  Log Message:
  -----------
  virtio: fix vring_align() on 64-bit windows

long is 32-bits on 64-bit windows, which caused the top half of the
address to be truncated; this patch changes it to use the
QEMU_ALIGN_UP macro which does not suffer the same problem

Signed-off-by: Andrew Baumann <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>
Reviewed-by: Stefan Weil <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>


  Commit: e68dd68496e89a48415e1f088f13d4dd59fe8560
      
https://github.com/qemu/qemu/commit/e68dd68496e89a48415e1f088f13d4dd59fe8560
  Author: Peter Maydell <address@hidden>
  Date:   2017-03-30 (Thu, 30 Mar 2017)

  Changed paths:
    M hw/pci/pci.c
    M include/hw/virtio/virtio.h
    M util/event_notifier-posix.c
    M util/event_notifier-win32.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging

virtio, pci: fixes

More fixes for 2.9.

Signed-off-by: Michael S. Tsirkin <address@hidden>

# gpg: Signature made Wed 29 Mar 2017 00:35:49 BST
# gpg:                using RSA key 0x281F0DB8D28D5469
# gpg: Good signature from "Michael S. Tsirkin <address@hidden>"
# gpg:                 aka "Michael S. Tsirkin <address@hidden>"
# Primary key fingerprint: 0270 606B 6F3C DF3D 0B17  0970 C350 3912 AFBE 8E67
#      Subkey fingerprint: 5D09 FD08 71C8 F85B 94CA  8A0D 281F 0DB8 D28D 5469

* remotes/mst/tags/for_upstream:
  virtio: fix vring_align() on 64-bit windows
  pci: Add missing drop of bus master AS reference
  event_notifier: prevent accidental use after close

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/fb59dabd4fa7...e68dd68496e8