[Qemu-commits] [qemu/qemu] 8bb93c: ui/console: ensure graphic updates don't race with...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 8bb93c6f99a42c2e0943bc904b283cd622d302c5
      
https://github.com/qemu/qemu/commit/8bb93c6f99a42c2e0943bc904b283cd622d302c5
  Author: Alex Bennée <address@hidden>
  Date:   2017-03-17 (Fri, 17 Mar 2017)

  Changed paths:
    M ui/console.c

  Log Message:
  -----------
  ui/console: ensure graphic updates don't race with TCG vCPUs

Commit 8d04fb55..

  tcg: drop global lock during TCG code execution

..broke the assumption that updates to the GUI couldn't happen at the
same time as TCG vCPUs where running. As a result the TCG vCPU could
still be updating a directly mapped frame-buffer while the display
side was updating. This would cause artefacts to appear when the
update code assumed that memory block hadn't changed.

The simplest solution is to ensure the two things can't happen at the
same time like the old BQL locking scheme. Here we use the solution
introduced for MTTCG and schedule the update as async_safe_work when
we know no vCPUs can be running.

Reported-by: Mark Cave-Ayland <address@hidden>
Signed-off-by: Alex Bennée <address@hidden>
Message-id: address@hidden
Cc: BALATON Zoltan <address@hidden>
Cc: Gerd Hoffmann <address@hidden>
Cc: Paolo Bonzini <address@hidden>
Signed-off-by: Alex Bennée <address@hidden>

[ kraxel: updated comment clarifying the display adapters are buggy
    and this is a temporary workaround ]

Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: f019722cbbb45aea153294fc8921fcc96a4d3fa2
      
https://github.com/qemu/qemu/commit/f019722cbbb45aea153294fc8921fcc96a4d3fa2
  Author: Gerd Hoffmann <address@hidden>
  Date:   2017-03-17 (Fri, 17 Mar 2017)

  Changed paths:
    M hw/display/cirrus_vga_rop.h

  Log Message:
  -----------
  cirrus: fix off-by-one in cirrus_bitblt_rop_bkwd_transp_*_16

The switch from pointers to addresses (commit
026aeffcb4752054830ba203020ed6eb05bcaba8 and
ffaf857778286ca54e3804432a2369a279e73aa7) added
a off-by-one bug to 16bit backward blits.  Fix.

Reported-by: 李强 <address@hidden>
Signed-off-by: Gerd Hoffmann <address@hidden>
Reviewed-by: Li Qiang <address@hidden>
Message-id: address@hidden


  Commit: 7bc4f0846f5e15dad5a54490290241243b5a4416
      
https://github.com/qemu/qemu/commit/7bc4f0846f5e15dad5a54490290241243b5a4416
  Author: Marc-André Lureau <address@hidden>
  Date:   2017-03-20 (Mon, 20 Mar 2017)

  Changed paths:
    M ui/vnc.c

  Log Message:
  -----------
  vnc: fix a qio-channel leak

Spotted by ASAN.

Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Daniel P. Berrange <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: bedf13ecab38bcd479e9db6994ebc3b2c5c7a3ae
      
https://github.com/qemu/qemu/commit/bedf13ecab38bcd479e9db6994ebc3b2c5c7a3ae
  Author: Peter Maydell <address@hidden>
  Date:   2017-03-20 (Mon, 20 Mar 2017)

  Changed paths:
    M hw/display/cirrus_vga_rop.h
    M ui/console.c
    M ui/vnc.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/kraxel/tags/pull-fixes-20170320-1' into 
staging

fixes for 2.9: vnc, cirrus, tcg display updates.

# gpg: Signature made Mon 20 Mar 2017 08:52:34 GMT
# gpg:                using RSA key 0x4CB6D8EED3E87138
# gpg: Good signature from "Gerd Hoffmann (work) <address@hidden>"
# gpg:                 aka "Gerd Hoffmann <address@hidden>"
# gpg:                 aka "Gerd Hoffmann (private) <address@hidden>"
# Primary key fingerprint: A032 8CFF B93A 17A7 9901  FE7D 4CB6 D8EE D3E8 7138

* remotes/kraxel/tags/pull-fixes-20170320-1:
  vnc: fix a qio-channel leak
  cirrus: fix off-by-one in cirrus_bitblt_rop_bkwd_transp_*_16
  ui/console: ensure graphic updates don't race with TCG vCPUs

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/ebedf0f9cd46...bedf13ecab38