[Qemu-commits] [qemu/qemu] 35c7cb: vfio/pci: Report errors from qdev_unplug() via dev...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 35c7cb4caff66fe4c01711243d42de4445cb83e2
      
https://github.com/qemu/qemu/commit/35c7cb4caff66fe4c01711243d42de4445cb83e2
  Author: Alex Williamson <address@hidden>
  Date:   2017-02-22 (Wed, 22 Feb 2017)

  Changed paths:
    M hw/vfio/pci.c

  Log Message:
  -----------
  vfio/pci: Report errors from qdev_unplug() via device request

Currently we ignore this error, report it with error_reportf_err()

Signed-off-by: Alex Williamson <address@hidden>
Reviewed-by: Eric Auger <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>


  Commit: d0d1cd70d10639273e2a23870e7e7d80b2bc4e21
      
https://github.com/qemu/qemu/commit/d0d1cd70d10639273e2a23870e7e7d80b2bc4e21
  Author: Alex Williamson <address@hidden>
  Date:   2017-02-22 (Wed, 22 Feb 2017)

  Changed paths:
    M hw/vfio/pci.c

  Log Message:
  -----------
  vfio/pci: Improve extended capability comments, skip masked caps

Since commit 4bb571d857d9 ("pci/pcie: don't assume cap id 0 is
reserved") removes the internal use of extended capability ID 0, the
comment here becomes invalid.  However, peeling back the onion, the
code is still correct and we still can't seed the capability chain
with ID 0, unless we want to muck with using the version number to
force the header to be non-zero, which is much uglier to deal with.
The comment also now covers some of the subtleties of using cap ID 0,
such as transparently indicating absence of capabilities if none are
added.  This doesn't detract from the correctness of the referenced
commit as vfio in the kernel also uses capability ID zero to mask
capabilties.  In fact, we should skip zero capabilities precisely
because the kernel might also expose such a capability at the head
position and re-introduce the problem.

Signed-off-by: Alex Williamson <address@hidden>
Reviewed-by: Peter Xu <address@hidden>
Tested-by: Peter Xu <address@hidden>
Reported-by: Jintack Lim <address@hidden>
Tested-by: Jintack Lim <address@hidden>


  Commit: c2b2e158cc7b1cb431bd6039824ec13c3184a775
      
https://github.com/qemu/qemu/commit/c2b2e158cc7b1cb431bd6039824ec13c3184a775
  Author: XiongZhang <address@hidden>
  Date:   2017-02-22 (Wed, 22 Feb 2017)

  Changed paths:
    M hw/vfio/pci-quirks.c

  Log Message:
  -----------
  vfio/pci-quirks.c: Disable stolen memory for igd VFIO

Regardless of running in UPT or legacy mode, the guest igd
drivers may attempt to use stolen memory, however only legacy
mode has BIOS support for reserving stolen memmory in the
guest VM. We zero out the stolen memory size in all cases,
then guest igd driver won't use stolen memory.
In legacy mode, user could use x-igd-gms option to specify the
amount of stolen memory which will be pre-allocated and reserved
by bios for igd use.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=99028
    https://bugs.freedesktop.org/show_bug.cgi?id=99025

Signed-off-by: Xiong Zhang <address@hidden>
Tested-by: Terrence Xu <address@hidden>
Signed-off-by: Alex Williamson <address@hidden>


  Commit: 6959e4523e517b8af965af1030d3ac5bec9cd0fb
      
https://github.com/qemu/qemu/commit/6959e4523e517b8af965af1030d3ac5bec9cd0fb
  Author: Peter Maydell <address@hidden>
  Date:   2017-02-24 (Fri, 24 Feb 2017)

  Changed paths:
    M hw/vfio/pci-quirks.c
    M hw/vfio/pci.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/awilliam/tags/vfio-updates-20170223.0' 
into staging

VFIO updates 2017-02-23

 - Report qdev_unplug errors (Alex Williamson)
 - Fix ecap ID 0 handling, improve comment (Alex Williamson)
 - Disable IGD stolen memory in UPT mode too (Xiong Zhang)

# gpg: Signature made Thu 23 Feb 2017 19:04:17 GMT
# gpg:                using RSA key 0x239B9B6E3BB08B22
# gpg: Good signature from "Alex Williamson <address@hidden>"
# gpg:                 aka "Alex Williamson <address@hidden>"
# gpg:                 aka "Alex Williamson <address@hidden>"
# gpg:                 aka "Alex Williamson <address@hidden>"
# Primary key fingerprint: 42F6 C04E 540B D1A9 9E7B  8A90 239B 9B6E 3BB0 8B22

* remotes/awilliam/tags/vfio-updates-20170223.0:
  vfio/pci-quirks.c: Disable stolen memory for igd VFIO
  vfio/pci: Improve extended capability comments, skip masked caps
  vfio/pci: Report errors from qdev_unplug() via device request

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/fe8ee082db50...6959e4523e51