qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 3f35c3: hmp: fix block_set_io_throttle


From: GitHub
Subject: [Qemu-commits] [qemu/qemu] 3f35c3: hmp: fix block_set_io_throttle
Date: Thu, 23 Feb 2017 02:00:11 -0800

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 3f35c3b166c18043596768448e5d91b5d52f8353
      
https://github.com/qemu/qemu/commit/3f35c3b166c18043596768448e5d91b5d52f8353
  Author: Eric Blake <address@hidden>
  Date:   2017-02-21 (Tue, 21 Feb 2017)

  Changed paths:
    M hmp.c

  Log Message:
  -----------
  hmp: fix block_set_io_throttle

Commit 7a9877a made the 'device' parameter to BlockIOThrottle
optional, favoring 'id' instead.  But it forgot to update the
HMP usage to set has_device, which makes all attempts to change
throttling via HMP fail with "Need exactly one of 'device' and 'id'"

CC: address@hidden
Signed-off-by: Eric Blake <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Signed-off-by: Dr. David Alan Gilbert <address@hidden>


  Commit: 5fc00480ab1ce767f1c6c63ae644e960295fed2c
      
https://github.com/qemu/qemu/commit/5fc00480ab1ce767f1c6c63ae644e960295fed2c
  Author: Pavel Hrdina <address@hidden>
  Date:   2017-02-21 (Tue, 21 Feb 2017)

  Changed paths:
    M hmp.c
    M iothread.c
    M qapi-schema.json

  Log Message:
  -----------
  monitor: add poll-* properties into query-iothreads result

IOthreads were recently extended by new properties that can
enable/disable and configure aio polling.  This will also allow
other tools that uses QEMU to probe for existence of those new
properties via query-qmp-schema.

Signed-off-by: Pavel Hrdina <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Signed-off-by: Dr. David Alan Gilbert <address@hidden>


  Commit: 854e67fea6a6f181163a5467fc9ba04de8d181bb
      
https://github.com/qemu/qemu/commit/854e67fea6a6f181163a5467fc9ba04de8d181bb
  Author: Thomas Huth <address@hidden>
  Date:   2017-02-21 (Tue, 21 Feb 2017)

  Changed paths:
    M hmp.c
    M monitor.c
    M target/i386/monitor.c
    M target/ppc/monitor.c
    M target/sh4/monitor.c
    M target/sparc/monitor.c
    M target/xtensa/monitor.c

  Log Message:
  -----------
  monitor: Fix crashes when using HMP commands without CPU

When running certain HMP commands ("info registers", "info cpustats",
"info tlb", "nmi", "memsave" or dumping virtual memory) with the "none"
machine, QEMU crashes with a segmentation fault. This happens because the
"none" machine does not have any CPUs by default, but these HMP commands
did not check for a valid CPU pointer yet. Add such checks now, so we get
an error message about the missing CPU instead.

Signed-off-by: Thomas Huth <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Acked-by: David Gibson <address@hidden>
Signed-off-by: Dr. David Alan Gilbert <address@hidden>


  Commit: e295a154c2a95f114e52ef4b0fb22b801b028bdc
      
https://github.com/qemu/qemu/commit/e295a154c2a95f114e52ef4b0fb22b801b028bdc
  Author: Peter Maydell <address@hidden>
  Date:   2017-02-21 (Tue, 21 Feb 2017)

  Changed paths:
    M hmp.c
    M iothread.c
    M monitor.c
    M qapi-schema.json
    M target/i386/monitor.c
    M target/ppc/monitor.c
    M target/sh4/monitor.c
    M target/sparc/monitor.c
    M target/xtensa/monitor.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/dgilbert/tags/pull-hmp-20170221' into 
staging

HMP pull

Note, I had seen a fail in the vhost-user/flags-mismatch on one
host in one build, but not others with the same patches; and these patches
go nowhere near that, so I think that's a separate vhost-user issue.

# gpg: Signature made Tue 21 Feb 2017 18:49:25 GMT
# gpg:                using RSA key 0x0516331EBC5BFDE7
# gpg: Good signature from "Dr. David Alan Gilbert (RH2) <address@hidden>"
# gpg: WARNING: This key is not certified with a trusted signature!
# gpg:          There is no indication that the signature belongs to the owner.
# Primary key fingerprint: 45F5 C71B 4A0C B7FB 977A  9FA9 0516 331E BC5B FDE7

* remotes/dgilbert/tags/pull-hmp-20170221:
  monitor: Fix crashes when using HMP commands without CPU
  monitor: add poll-* properties into query-iothreads result
  hmp: fix block_set_io_throttle

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/796b288f7be8...e295a154c2a9

reply via email to

[Prev in Thread] Current Thread [Next in Thread]