[Qemu-commits] [qemu/qemu] b4b076: migration: create Migration Incoming State at init...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: b4b076daf324894dd288cbdb67ff1e3c7434df7b
      
https://github.com/qemu/qemu/commit/b4b076daf324894dd288cbdb67ff1e3c7434df7b
  Author: Juan Quintela <address@hidden>
  Date:   2017-02-06 (Mon, 06 Feb 2017)

  Changed paths:
    M include/migration/migration.h
    M migration/migration.c
    M migration/savevm.c

  Log Message:
  -----------
  migration: create Migration Incoming State at init time

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Juan Quintela <address@hidden>


  Commit: bc5c4f21966977c4ff00ae77979b95a2b39142a3
      
https://github.com/qemu/qemu/commit/bc5c4f21966977c4ff00ae77979b95a2b39142a3
  Author: Dr. David Alan Gilbert <address@hidden>
  Date:   2017-02-06 (Mon, 06 Feb 2017)

  Changed paths:
    M hw/core/qdev.c
    M hw/intc/apic_common.c
    M include/migration/vmstate.h
    M migration/savevm.c
    M stubs/vmstate.c

  Log Message:
  -----------
  vmstate_register_with_alias_id: Take an Error **

I'll be adding an error to it in a subsequent patch.

Signed-off-by: Dr. David Alan Gilbert <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Juan Quintela <address@hidden>


  Commit: 581f08bac22bdd5e081ae07f68071a0fc3c5c2c7
      
https://github.com/qemu/qemu/commit/581f08bac22bdd5e081ae07f68071a0fc3c5c2c7
  Author: Dr. David Alan Gilbert <address@hidden>
  Date:   2017-02-06 (Mon, 06 Feb 2017)

  Changed paths:
    M include/migration/vmstate.h
    M migration/savevm.c

  Log Message:
  -----------
  migration: Check for ID length

The qdev id of a device can be huge if it's on the end of a chain
of bridges; in reality such chains shouldn't occur but they can
be made to by chaining PCIe bridges together.

The migration format has a number of 256 character long format
limits; check we don't hit them (we already use pstrcat/cpy but
that just protects us from buffer overruns, we fairly quickly
hit an assert).

Signed-off-by: Dr. David Alan Gilbert <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Juan Quintela <address@hidden>


  Commit: 67980031d234aa90524b83bb80bb5d1601d29076
      
https://github.com/qemu/qemu/commit/67980031d234aa90524b83bb80bb5d1601d29076
  Author: Dr. David Alan Gilbert <address@hidden>
  Date:   2017-02-06 (Mon, 06 Feb 2017)

  Changed paths:
    M hw/core/qdev.c

  Log Message:
  -----------
  vmstate registration: check return values

Check qdev's call to vmstate_register_with_alias_id; that gets
most of the common uses; there's hundreds of calls via vmstate_register
which could get fixed over time.

Signed-off-by: Dr. David Alan Gilbert <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Juan Quintela <address@hidden>


  Commit: 328d4d85282e7d62f89f5b0547a493d9cd07cea0
      
https://github.com/qemu/qemu/commit/328d4d85282e7d62f89f5b0547a493d9cd07cea0
  Author: Dr. David Alan Gilbert <address@hidden>
  Date:   2017-02-06 (Mon, 06 Feb 2017)

  Changed paths:
    M migration/savevm.c

  Log Message:
  -----------
  Postcopy: Reset state to avoid cleanup assert

On a destination host with no userfault support an incoming
postcopy would cause the state to enter ADVISE before
it realised there was no support, and because it was in ADVISE
state it would perform a cleanup at the end.  Since there
was no support the cleanup function should be unreachable,
but ends up being called and asserting.

Reset the state when we realise we have no support, thus the
cleanup doesn't happen.

Signed-off-by: Dr. David Alan Gilbert <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Juan Quintela <address@hidden>


  Commit: ef8d6488d2767fe81bb4bb9bcdc52af5ff718b56
      
https://github.com/qemu/qemu/commit/ef8d6488d2767fe81bb4bb9bcdc52af5ff718b56
  Author: Dr. David Alan Gilbert <address@hidden>
  Date:   2017-02-06 (Mon, 06 Feb 2017)

  Changed paths:
    M migration/migration.c

  Log Message:
  -----------
  postcopy: Recover block devices on early failure

An early postcopy failure can be recovered from as long as we know
we haven't sent the command to run the destination.
We have to undo the bdrv_inactivate_all by calling
bdrv_invalidate_cache_all

Note that I'm not using ms->block_inactive because once we've
sent the postcopy package we dont want anything else to try
and recover the block storage on the source; the destination
might have started writing to it.

Signed-off-by: Dr. David Alan Gilbert <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Juan Quintela <address@hidden>


  Commit: d0dff238a87fa81393ed72754d4dc8b09e50b08b
      
https://github.com/qemu/qemu/commit/d0dff238a87fa81393ed72754d4dc8b09e50b08b
  Author: Peter Maydell <address@hidden>
  Date:   2017-02-07 (Tue, 07 Feb 2017)

  Changed paths:
    M hw/core/qdev.c
    M hw/intc/apic_common.c
    M include/migration/migration.h
    M include/migration/vmstate.h
    M migration/migration.c
    M migration/savevm.c
    M stubs/vmstate.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/juanquintela/tags/migration/20170206' 
into staging

migration/next for 20170206

# gpg: Signature made Mon 06 Feb 2017 16:13:26 GMT
# gpg:                using RSA key 0xF487EF185872D723
# gpg: Good signature from "Juan Quintela <address@hidden>"
# gpg:                 aka "Juan Quintela <address@hidden>"
# Primary key fingerprint: 1899 FF8E DEBF 58CC EE03  4B82 F487 EF18 5872 D723

* remotes/juanquintela/tags/migration/20170206:
  postcopy: Recover block devices on early failure
  Postcopy: Reset state to avoid cleanup assert
  vmstate registration: check return values
  migration: Check for ID length
  vmstate_register_with_alias_id: Take an Error **
  migration: create Migration Incoming State at init time

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/3c457da147e1...d0dff238a87f